Skip to contentSkip to conversation

net-next: sundance: Add netconsole logging support

PATCH In review Denis Kirjanov 3 participants 4 messages Aug 16, 2013 – Aug 17, 2013

Subsystems (3)
Networking Network drivers Sundance network driver
lore
Share & tools
lore

Denis Kirjanov

author
#0 lore raw

PATCH 1/2 net-next: sundance: Add netconsole logging support

Signed-off-by Denis Kirjanov <[email protected]>
---
 drivers/net/ethernet/dlink/sundance.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/net/ethernet/dlink/sundance.c +14 -0
index 50d9c63..2688a84 100644
@@ -469,6 +469,17 @@ static void sundance_reset(struct net_device *dev, unsigned long reset_cmd)
 	}
 }
 
+#ifdef CONFIG_NET_POLL_CONTROLLER
+static void sundance_poll_controller(struct net_device *dev)
+{
+	struct netdev_private *np = netdev_priv(dev);
+
+	disable_irq(np->pci_dev->irq);
+	intr_handler(np->pci_dev->irq, dev);
+	enable_irq(np->pci_dev->irq);
+}
+#endif
+
 static const struct net_device_ops netdev_ops = {
 	.ndo_open		= netdev_open,
 	.ndo_stop		= netdev_close,

@@ -480,6 +491,9 @@ static const struct net_device_ops netdev_ops = {
 	.ndo_change_mtu		= change_mtu,
 	.ndo_set_mac_address 	= sundance_set_mac_addr,
 	.ndo_validate_addr	= eth_validate_addr,
+#ifdef CONFIG_NET_POLL_CONTROLLER
+	.ndo_poll_controller = sundance_poll_controller,
+#endif
 };
 
 static int sundance_probe1(struct pci_dev *pdev,
Signature · 1 line
1.8.0.2
author
#1 lore raw

PATCH 2/2 net-next: sundance: Add myself as an maintainer Signed-off-by: Denis Kirjanov <[email protected]>

---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +6 -0
index 9ee0a8f..1b3fb7c 100644
@@ -7968,6 +7968,12 @@ F:	arch/m68k/sun3*/
 F:	arch/m68k/include/asm/sun3*
 F:	drivers/net/ethernet/i825xx/sun3*
 
+SUNDANCE NETWORK DRIVER
+M:	Denis Kirjanov <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	drivers/net/ethernet/dlink/sundance.c
+
 SUPERH
 M:	Paul Mundt <[email protected]>
 L:	[email protected]
Signature · 1 line
1.8.0.2
#2 lore raw
In reply to Denis Kirjanov

Hello.

On 08/16/2013 09:00 PM, Denis Kirjanov wrote:

I'd rather name the patch "sundance: add netpoll support". "net-next:"
shouldn't be there twice definitely.

Quoted 9 lines
Signed-off-by Denis Kirjanov <[email protected]>
---
  drivers/net/ethernet/dlink/sundance.c | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
drivers/net/ethernet/dlink/sundance.c +0 -0
index 50d9c63..2688a84 100644

[...]

drivers/net/ethernet/dlink/sundance.c static const struct net_device_ops netdev_ops = { · line 495

Quoted 6 lines
drivers/net/ethernet/dlink/sundance.c +2 -0
@@ -480,6 +491,9 @@ static const struct net_device_ops netdev_ops = {
  	.ndo_change_mtu		= change_mtu,
  	.ndo_set_mac_address 	= sundance_set_mac_addr,
  	.ndo_validate_addr	= eth_validate_addr,
+#ifdef CONFIG_NET_POLL_CONTROLLER
+	.ndo_poll_controller = sundance_poll_controller,

Could you align = here with the reset of initializers?

drivers/net/ethernet/dlink/sundance.c static const struct net_device_ops netdev_ops = { · line 496

Quoted 1 line
drivers/net/ethernet/dlink/sundance.c +1 -0
+#endif

WBR, Sergei

maintainer
#3 lore raw
Quoted 6 lines · Sergei Shtylyov

Hello.

On 08/16/2013 09:00 PM, Denis Kirjanov wrote:

I'd rather name the patch "sundance: add netpoll support". "net-next:"
shouldn't be there twice definitely.

Right, it was late at night so somehow I added prefix twice.

Quoted 12 lines
Quoted 11 lines
Signed-off-by Denis Kirjanov <[email protected]>
---
  drivers/net/ethernet/dlink/sundance.c | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
drivers/net/ethernet/dlink/sundance.c +0 -0
index 50d9c63..2688a84 100644

[...]

Quoted 8 lines

drivers/net/ethernet/dlink/sundance.c static const struct net_device_ops netdev_ops = { · line 495

Quoted 6 lines
drivers/net/ethernet/dlink/sundance.c +2 -0
@@ -480,6 +491,9 @@ static const struct net_device_ops netdev_ops = {
  	.ndo_change_mtu		= change_mtu,
  	.ndo_set_mac_address 	= sundance_set_mac_addr,
  	.ndo_validate_addr	= eth_validate_addr,
+#ifdef CONFIG_NET_POLL_CONTROLLER
+	.ndo_poll_controller = sundance_poll_controller,

Could you align = here with the reset of initializers?

I'll respin.

Thanks!

Quoted 9 lines

drivers/net/ethernet/dlink/sundance.c static const struct net_device_ops netdev_ops = { · line 496

Quoted 1 line
drivers/net/ethernet/dlink/sundance.c +1 -0
+#endif

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Regards,
Denis