Skip to contentSkip to conversation

ARM: highbank: fix debug uart virtual address for LPAE

PATCH Superseded Rob Herring 2 participants 3 messages Aug 18, 2013 – Sep 5, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: highbank: fix debug uart virtual address for LPAE

From: Rob Herring <[email protected]>

Section entries are 2MB on LPAE, so the DEBUG_LL virtual address must have the same offset in the 2MB section as the physical address. This fixes async external aborts when DEBUG_LL is enabled on Midway.

---
v2: Rebase on Russell's DEBUG_LL clean-up

 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/Kconfig.debug +1 -1
index 2d57da3..2a88a4d 100644
@@ -1005,7 +1005,7 @@ config DEBUG_UART_VIRT
 	default 0xfee003f8 if FOOTBRIDGE
 	default 0xfee08300 if DEBUG_DAVINCI_TNETV107X_UART1
 	default 0xfee20000 if DEBUG_NSPIRE_CLASSIC_UART || DEBUG_NSPIRE_CX_UART
-	default 0xfee36000 if DEBUG_HIGHBANK_UART
+	default 0xfef36000 if DEBUG_HIGHBANK_UART
 	default 0xfee82340 if ARCH_IOP13XX
 	default 0xfef00000 if ARCH_IXP4XX && !CPU_BIG_ENDIAN
 	default 0xfef00003 if ARCH_IXP4XX && CPU_BIG_ENDIAN
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH v2 1/1 ARM: highbank: fix debug uart virtual address for LPAE

Quoted 9 lines · Rob Herring

From: Rob Herring <[email protected]>

Section entries are 2MB on LPAE, so the DEBUG_LL virtual address must have the same offset in the 2MB section as the physical address. This fixes async external aborts when DEBUG_LL is enabled on Midway.

---
v2: Rebase on Russell's DEBUG_LL clean-up

Do you also want to do a patch for this for v3.11, because if it's wrong in my series, it's wrong in mainline at the moment:

-               ldr     \rv, =0xfee36000
-               ldr     \rp, =0xfff36000
#2 lore raw

PATCH v2 1/1 ARM: highbank: fix debug uart virtual address for LPAE

Quoted 7 lines · Russell King - ARM Linux
Quoted 6 lines · Rob Herring

From: Rob Herring <[email protected]>

Section entries are 2MB on LPAE, so the DEBUG_LL virtual address must have the same offset in the 2MB section as the physical address. This fixes async external aborts when DEBUG_LL is enabled on Midway.

Quoted 6 lines
Quoted 3 lines

---
v2: Rebase on Russell's DEBUG_LL clean-up

Do you also want to do a patch for this for v3.11, because if it's wrong in my series, it's wrong in mainline at the moment:

That would be v1 of my patch. There are other fixes needed for LPAE on Midway in 3.11, so this fix alone is not really needed.

Rob