Kconfig Gtk/Qt interface flavours ported to newest toolkit versions
v3 cover Kconfig Gtk/Qt interface flavours ported to newest toolkit versions
Hi Michal, Yann, all,
I prepared a v3 of the patch set addressing the following comments and suggestions:
Quoted 1 line
The prefix should be "kconfig: bla bla"
Prefix is kconfig now.
Quoted 7 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+/* Most images are taken from the system icon theme + in modern gui toolkits nowadays. + Because we compile with -Wunused-variable, we hide + the following xmp image constants. +*/ +#ifdef IMAGES_EXTENDEDI see no users of this. So why not delete these?
This part of images.c is removed now.
Quoted 2 lines
Please provide the full diffstat for the patch. git format-patch -n will do this for you.
Full diffstat provided. I've used git format-patch --summary --minimal -M. As far as I understand this provides an applicable patch (unlike the -D option) but is still more suitable to review. As discussed some patches are too big for the mailing list so additionally I provide the changes via github in the master branch of [email protected]:davidgraeff/linux.git.
Quoted 3 lines
Each directory should be named after the frontend IMO. So lxdialog dir should be renamed to menuconfig.
I renamed lxdialog to menuconfig. I very much like this suggestion but didn't dare to touch this directory in the first place.
Quoted 10 lines
Review
Quoted 7 lines
+++ b/scripts/kconfig/gconfig/Makefile
[...](quoted diff) +5
-0+ +HOSTLOADLIBES_gconf = `pkg-config --libs gtk+-2.0 gmodule-2.0 libglade-2.0` +HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \ + -Wno-missing-prototypes +This blank line contains unwanted space characters (and they were not in
scripts/kconfig/Makefile).
Removed the line. Sometimes text editors should stop thinking too much :D
Quoted 2 lines
Quoted 1 line
+clean-files +=
zconf.tab.cgconfig/gconf.glade.hgconf
zconf.tab.cshould be dropped here.
Dropped zconf.tab.c from gconfig/Makefiles clean target.
Quoted 7 lines
Quoted 7 lines
scripts/kconfig/Makefile +0
-0@@ -110,6 +100,7 @@ help: @echo ' nconfig - Update current config utilising a ncurses menu based program' @echo ' menuconfig - Update current config utilising a menu based program'
Quoted 8 lines
scripts/kconfig/Makefile help: · line 106
Quoted 5 lines
scripts/kconfig/Makefile +1
-0@echo ' xconfig - Update current config utilising a QT based front-end' + @echo ' qconfig - Update current config utilising a QT based front-end' @echo ' gconfig - Update current config utilising a GTK based front-end' @echo ' oldconfig - Update current config utilising a provided .config as base' @echo ' localmodconfig - Update current config disabling modules not loaded'So you sneaked in a new "qconfig" target.
This belongs in a separate patch - and we already have xconfig so I suggest to drop it.
I've split this change into a separate patch. My suggestion is to add the qconfig target for beeing consistent with the names of the other targets where the first character provides a hint for the used toolkit. And to accommodate the fact that this frontend may also be used on non xserver machines.
Regards,
David
David Graeff (5):
kconfig: Move flavours into their own subdirectories.
kconfig: Add qconfig makefile target additionally to the xconfig
target
kconfig: Update/Port Gtk flavour to use Gtk3
kconfig: Qt interface port to Qt4/Qt5, removed Qt3 Support
kconfig: images.c for gtk/qt gui flavour reoganized
scripts/kconfig/Makefile | 189 +--
scripts/kconfig/gconf.c | 1542 -----------------
scripts/kconfig/gconfig/Makefile | 67 +
scripts/kconfig/gconfig/gconf.c | 758 +++++++++
scripts/kconfig/{ => gconfig}/gconf.glade | 0
scripts/kconfig/gconfig/gconf.h | 80 +
scripts/kconfig/gconfig/gconf.ui | 536 ++++++
scripts/kconfig/gconfig/gconf_treeview_model.c | 706 ++++++++
scripts/kconfig/gconfig/gconf_treeview_model.h | 43 +
scripts/kconfig/gconfig/util.h | 33 +
scripts/kconfig/images.c | 225 +--
.../kconfig/{lxdialog => menuconfig}/.gitignore | 0
.../{lxdialog => menuconfig}/BIG.FAT.WARNING | 0
scripts/kconfig/menuconfig/Makefile | 42 +
.../{lxdialog => menuconfig}/check-lxdialog.sh | 0
.../kconfig/{lxdialog => menuconfig}/checklist.c | 0
scripts/kconfig/{lxdialog => menuconfig}/dialog.h | 0
.../kconfig/{lxdialog => menuconfig}/inputbox.c | 0
scripts/kconfig/{ => menuconfig}/mconf.c | 4 +-
scripts/kconfig/{lxdialog => menuconfig}/menubox.c | 0
scripts/kconfig/{lxdialog => menuconfig}/textbox.c | 0
scripts/kconfig/{lxdialog => menuconfig}/util.c | 0
scripts/kconfig/{lxdialog => menuconfig}/yesno.c | 0
scripts/kconfig/nconfig/Makefile | 26 +
scripts/kconfig/{ => nconfig}/nconf.c | 2 +-
scripts/kconfig/{ => nconfig}/nconf.gui.c | 0
scripts/kconfig/{ => nconfig}/nconf.h | 0
scripts/kconfig/qconf.cc | 1790 --------------------
scripts/kconfig/qconf.h | 337 ----
scripts/kconfig/qconfig/Makefile | 94 +
scripts/kconfig/qconfig/infoViewWidget.cc | 225 +++
scripts/kconfig/qconfig/infoViewWidget.h | 42 +
scripts/kconfig/qconfig/mainwindow.cc | 382 +++++
scripts/kconfig/qconfig/mainwindow.h | 73 +
scripts/kconfig/qconfig/mainwindow.ui | 392 +++++
scripts/kconfig/qconfig/qconf.cc | 77 +
scripts/kconfig/qconfig/qconf.h | 23 +
scripts/kconfig/qconfig/searchfiltermodelproxy.cc | 35 +
scripts/kconfig/qconfig/searchfiltermodelproxy.h | 35 +
scripts/kconfig/qconfig/searchmodel.cc | 57 +
scripts/kconfig/qconfig/searchmodel.h | 28 +
41 files changed, 3783 insertions(+), 4060 deletions(-)
delete mode 100644 scripts/kconfig/gconf.c
create mode 100644 scripts/kconfig/gconfig/Makefile
create mode 100644 scripts/kconfig/gconfig/gconf.c
rename scripts/kconfig/{ => gconfig}/gconf.glade (100%)
create mode 100644 scripts/kconfig/gconfig/gconf.h
create mode 100644 scripts/kconfig/gconfig/gconf.ui
create mode 100644 scripts/kconfig/gconfig/gconf_treeview_model.c
create mode 100644 scripts/kconfig/gconfig/gconf_treeview_model.h
create mode 100644 scripts/kconfig/gconfig/util.h
rename scripts/kconfig/{lxdialog => menuconfig}/.gitignore (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/BIG.FAT.WARNING (100%)
create mode 100644 scripts/kconfig/menuconfig/Makefile
rename scripts/kconfig/{lxdialog => menuconfig}/check-lxdialog.sh (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/checklist.c (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/dialog.h (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/inputbox.c (100%)
rename scripts/kconfig/{ => menuconfig}/mconf.c (99%)
rename scripts/kconfig/{lxdialog => menuconfig}/menubox.c (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/textbox.c (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/util.c (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/yesno.c (100%)
create mode 100644 scripts/kconfig/nconfig/Makefile
rename scripts/kconfig/{ => nconfig}/nconf.c (99%)
rename scripts/kconfig/{ => nconfig}/nconf.gui.c (100%)
rename scripts/kconfig/{ => nconfig}/nconf.h (100%)
delete mode 100644 scripts/kconfig/qconf.cc
delete mode 100644 scripts/kconfig/qconf.h
create mode 100644 scripts/kconfig/qconfig/Makefile
create mode 100644 scripts/kconfig/qconfig/infoViewWidget.cc
create mode 100644 scripts/kconfig/qconfig/infoViewWidget.h
create mode 100644 scripts/kconfig/qconfig/mainwindow.cc
create mode 100644 scripts/kconfig/qconfig/mainwindow.h
create mode 100644 scripts/kconfig/qconfig/mainwindow.ui
create mode 100644 scripts/kconfig/qconfig/qconf.cc
create mode 100644 scripts/kconfig/qconfig/qconf.h
create mode 100644 scripts/kconfig/qconfig/searchfiltermodelproxy.cc
create mode 100644 scripts/kconfig/qconfig/searchfiltermodelproxy.h
create mode 100644 scripts/kconfig/qconfig/searchmodel.cc
create mode 100644 scripts/kconfig/qconfig/searchmodel.hSignature · 1 line
1.8.1.2
PATCH v3 1/5 kconfig: Move flavours into their own subdirectories.
Split out non-generic Makefile targets into new Makefiles. Each flavour has its own specific Makefile now. Rename lxdialog to menuconfig.
create mode 100644 scripts/kconfig/gconfig/Makefile
rename scripts/kconfig/{ => gconfig}/gconf.c (99%)
rename scripts/kconfig/{ => gconfig}/gconf.glade (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/.gitignore (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/BIG.FAT.WARNING (100%)
create mode 100644 scripts/kconfig/menuconfig/Makefile
rename scripts/kconfig/{lxdialog => menuconfig}/check-lxdialog.sh (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/checklist.c (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/dialog.h (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/inputbox.c (100%)
rename scripts/kconfig/{ => menuconfig}/mconf.c (99%)
rename scripts/kconfig/{lxdialog => menuconfig}/menubox.c (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/textbox.c (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/util.c (100%)
rename scripts/kconfig/{lxdialog => menuconfig}/yesno.c (100%)
create mode 100644 scripts/kconfig/nconfig/Makefile
rename scripts/kconfig/{ => nconfig}/nconf.c (99%)
rename scripts/kconfig/{ => nconfig}/nconf.gui.c (100%)
rename scripts/kconfig/{ => nconfig}/nconf.h (100%)
create mode 100644 scripts/kconfig/qconfig/Makefile
rename scripts/kconfig/{ => qconfig}/qconf.cc (99%)
rename scripts/kconfig/{ => qconfig}/qconf.h (100%)scripts/kconfig/Makefile +15 -174
@@ -1,8 +1,10 @@ # =========================================================================== # Kernel configuration targets # These targets are used from top-level makefile +# This specific makefile only contains special targets and targets for +# the line-oriented program. Other interface flavours are included at the end. -PHONY += oldconfig xconfig gconfig menuconfig config silentoldconfig update-po-config \ +PHONY += oldconfig config silentoldconfig update-po-config \ localmodconfig localyesconfig ifdef KBUILD_KCONFIG
@@ -14,21 +16,9 @@ endif # We need this, in case the user has it in its environment unexport CONFIG_ -xconfig: $(obj)/qconf - $< $(Kconfig) - -gconfig: $(obj)/gconf - $< $(Kconfig) - -menuconfig: $(obj)/mconf - $< $(Kconfig) - config: $(obj)/conf $< --oldaskconfig $(Kconfig) -nconfig: $(obj)/nconf - $< $(Kconfig) - oldconfig: $(obj)/conf $< --$@ $(Kconfig)
@@ -53,7 +43,7 @@ localyesconfig localmodconfig: $(obj)/streamline_config.pl $(obj)/conf # Create new linux.pot file # Adjust charset to UTF-8 in .po file to accept UTF-8 in Kconfig files -update-po-config: $(obj)/kxgettext $(obj)/gconf.glade.h +update-po-config: $(obj)/kxgettext $(obj)/gkonfig/gconf.glade.h $(Q)echo " GEN config.pot" $(Q)xgettext --default-domain=linux \ --add-comments --keyword=_ --keyword=N_ \
@@ -110,6 +100,7 @@ help: @echo ' nconfig - Update current config utilising a ncurses menu based program' @echo ' menuconfig - Update current config utilising a menu based program' @echo ' xconfig - Update current config utilising a QT based front-end' + @echo ' qconfig - Update current config utilising a QT based front-end' @echo ' gconfig - Update current config utilising a GTK based front-end' @echo ' oldconfig - Update current config utilising a provided .config as base' @echo ' localmodconfig - Update current config disabling modules not loaded'
@@ -125,81 +116,28 @@ help: @echo ' listnewconfig - List new options' @echo ' olddefconfig - Same as silentoldconfig but sets new symbols to their default value' -# lxdialog stuff -check-lxdialog := $(srctree)/$(src)/lxdialog/check-lxdialog.sh - # Use recursively expanded variables so we do not call gcc unless # we really need to do so. (Do not call gcc as part of make mrproper) HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags) \ -DLOCALE # =========================================================================== -# Shared Makefile for the various kconfig executables: +# Shared Makefile for some of the kconfig executables: # conf: Used for defconfig, oldconfig and related targets -# nconf: Used for the nconfig target. -# Utilizes ncurses -# mconf: Used for the menuconfig target -# Utilizes the lxdialog package -# qconf: Used for the xconfig target -# Based on QT which needs to be installed to compile it -# gconf: Used for the gconfig target -# Based on GTK which needs to be installed to compile it # object files used by all kconfig flavours -lxdialog := lxdialog/checklist.o lxdialog/util.o lxdialog/inputbox.o -lxdialog += lxdialog/textbox.o lxdialog/yesno.o lxdialog/menubox.o - conf-objs := conf.o zconf.tab.o -mconf-objs := mconf.o zconf.tab.o $(lxdialog) -nconf-objs := nconf.o zconf.tab.o nconf.gui.o kxgettext-objs := kxgettext.o zconf.tab.o -qconf-cxxobjs := qconf.o -qconf-objs := zconf.tab.o -gconf-objs := gconf.o zconf.tab.o hostprogs-y := conf -ifeq ($(MAKECMDGOALS),nconfig) - hostprogs-y += nconf -endif - -ifeq ($(MAKECMDGOALS),menuconfig) - hostprogs-y += mconf -endif - ifeq ($(MAKECMDGOALS),update-po-config) hostprogs-y += kxgettext endif -ifeq ($(MAKECMDGOALS),xconfig) - qconf-target := 1 -endif -ifeq ($(MAKECMDGOALS),gconfig) - gconf-target := 1 -endif - - -ifeq ($(qconf-target),1) - hostprogs-y += qconf -endif - -ifeq ($(gconf-target),1) - hostprogs-y += gconf -endif - -clean-files := qconf.moc .tmp_qtcheck .tmp_gtkcheck -clean-files += zconf.tab.c zconf.lex.c zconf.hash.c gconf.glade.h -clean-files += mconf qconf gconf nconf +clean-files := zconf.tab.c zconf.lex.c zconf.hash.c clean-files += config.pot linux.pot -# Check that we have the required ncurses stuff installed for lxdialog (menuconfig) -PHONY += $(obj)/dochecklxdialog -$(addprefix $(obj)/,$(lxdialog)): $(obj)/dochecklxdialog -$(obj)/dochecklxdialog: - $(Q)$(CONFIG_SHELL) $(check-lxdialog) -check $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTLOADLIBES_mconf) - -always := dochecklxdialog - # Add environment specific flags HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(srctree)/$(src)/check.sh $(HOSTCC) $(HOSTCFLAGS))
@@ -210,113 +148,16 @@ HOSTCFLAGS_zconf.tab.o := -I$(src) LEX_PREFIX_zconf := zconf YACC_PREFIX_zconf := zconf -HOSTLOADLIBES_qconf = $(KC_QT_LIBS) -HOSTCXXFLAGS_qconf.o = $(KC_QT_CFLAGS) - -HOSTLOADLIBES_gconf = `pkg-config --libs gtk+-2.0 gmodule-2.0 libglade-2.0` -HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \ - -Wno-missing-prototypes - -HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) - -HOSTLOADLIBES_nconf = $(shell \ - pkg-config --libs menu panel ncurses 2>/dev/null \ - || echo "-lmenu -lpanel -lncurses" ) -$(obj)/qconf.o: $(obj)/.tmp_qtcheck - -ifeq ($(qconf-target),1) -$(obj)/.tmp_qtcheck: $(src)/Makefile --include $(obj)/.tmp_qtcheck - -# QT needs some extra effort... -$(obj)/.tmp_qtcheck: - @set -e; echo " CHECK qt"; dir=""; pkg=""; \ - if ! pkg-config --exists QtCore 2> /dev/null; then \ - echo "* Unable to find the QT4 tool qmake. Trying to use QT3"; \ - pkg-config --exists qt 2> /dev/null && pkg=qt; \ - pkg-config --exists qt-mt 2> /dev/null && pkg=qt-mt; \ - if [ -n "$$pkg" ]; then \ - cflags="\$$(shell pkg-config $$pkg --cflags)"; \ - libs="\$$(shell pkg-config $$pkg --libs)"; \ - moc="\$$(shell pkg-config $$pkg --variable=prefix)/bin/moc"; \ - dir="$$(pkg-config $$pkg --variable=prefix)"; \ - else \ - for d in $$QTDIR /usr/share/qt* /usr/lib/qt*; do \ - if [ -f $$d/include/qconfig.h ]; then dir=$$d; break; fi; \ - done; \ - if [ -z "$$dir" ]; then \ - echo >&2 "*"; \ - echo >&2 "* Unable to find any QT installation. Please make sure that"; \ - echo >&2 "* the QT4 or QT3 development package is correctly installed and"; \ - echo >&2 "* either qmake can be found or install pkg-config or set"; \ - echo >&2 "* the QTDIR environment variable to the correct location."; \ - echo >&2 "*"; \ - false; \ - fi; \ - libpath=$$dir/lib; lib=qt; osdir=""; \ - $(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \ - osdir=x$$($(HOSTCXX) -print-multi-os-directory); \ - test -d $$libpath/$$osdir && libpath=$$libpath/$$osdir; \ - test -f $$libpath/libqt-mt.so && lib=qt-mt; \ - cflags="-I$$dir/include"; \ - libs="-L$$libpath -Wl,-rpath,$$libpath -l$$lib"; \ - moc="$$dir/bin/moc"; \ - fi; \ - if [ ! -x $$dir/bin/moc -a -x /usr/bin/moc ]; then \ - echo "*"; \ - echo "* Unable to find $$dir/bin/moc, using /usr/bin/moc instead."; \ - echo "*"; \ - moc="/usr/bin/moc"; \ - fi; \ - else \ - cflags="\$$(shell pkg-config QtCore QtGui Qt3Support --cflags)"; \ - libs="\$$(shell pkg-config QtCore QtGui Qt3Support --libs)"; \ - moc="\$$(shell pkg-config QtCore --variable=moc_location)"; \ - [ -n "$$moc" ] || moc="\$$(shell pkg-config QtCore --variable=prefix)/bin/moc"; \ - fi; \ - echo "KC_QT_CFLAGS=$$cflags" > $@; \ - echo "KC_QT_LIBS=$$libs" >> $@; \ - echo "KC_QT_MOC=$$moc" >> $@ -endif - -$(obj)/gconf.o: $(obj)/.tmp_gtkcheck - -ifeq ($(gconf-target),1) --include $(obj)/.tmp_gtkcheck - -# GTK needs some extra effort, too... -$(obj)/.tmp_gtkcheck: - @if `pkg-config --exists gtk+-2.0 gmodule-2.0 libglade-2.0`; then \ - if `pkg-config --atleast-version=2.0.0 gtk+-2.0`; then \ - touch $@; \ - else \ - echo >&2 "*"; \ - echo >&2 "* GTK+ is present but version >= 2.0.0 is required."; \ - echo >&2 "*"; \ - false; \ - fi \ - else \ - echo >&2 "*"; \ - echo >&2 "* Unable to find the GTK+ installation. Please make sure that"; \ - echo >&2 "* the GTK+ 2.0 development package is correctly installed..."; \ - echo >&2 "* You need gtk+-2.0, glib-2.0 and libglade-2.0."; \ - echo >&2 "*"; \ - false; \ - fi -endif - $(obj)/zconf.tab.o: $(obj)/zconf.lex.c $(obj)/zconf.hash.c -$(obj)/qconf.o: $(obj)/qconf.moc - -quiet_cmd_moc = MOC $@ - cmd_moc = $(KC_QT_MOC) -i $< -o $@ +# NCurses/Dialog Interface +include $(obj)/menuconfig/Makefile -$(obj)/%.moc: $(src)/%.h $(obj)/.tmp_qtcheck - $(call cmd,moc) +# Qt Interface +include $(obj)/qconfig/Makefile -# Extract gconf menu items for I18N support -$(obj)/gconf.glade.h: $(obj)/gconf.glade - $(Q)intltool-extract --type=gettext/glade --srcdir=$(srctree) \ - $(obj)/gconf.glade +# NCurses Interface +include $(obj)/nconfig/Makefile +# Gtk Interface +include $(obj)/gconfig/Makefile
scripts/kconfig/gconfig/Makefile new file +62 -0
62 lines not on this page · raw message
scripts/kconfig/gconfig/gconf.c renamed from scripts/kconfig/gconf.c +3 -3
@@ -11,8 +11,8 @@#endif #include <stdlib.h> -#include "lkc.h" -#include "images.c" +#include "../lkc.h" +#include "../images.c" #include <glade/glade.h> #include <gtk/gtk.h>
@@ -1486,7 +1486,7 @@ int main(int ac, char *av[])/* Determine GUI path */ env =getenv (SRCTREE );if (env) - glade_file =g_strconcat (env,"/scripts/kconfig/gconf.glade" ,NULL ); + glade_file =g_strconcat (env,"/scripts/kconfig/gconfig/gconf.glade" ,NULL );else if (av[0 ][0 ] =='/' ) glade_file =g_strconcat (av[0 ],".glade" ,NULL );else
scripts/kconfig/gconfig/gconf.glade renamed from scripts/kconfig/gconf.glade +0 -0
scripts/kconfig/menuconfig/.gitignore renamed from scripts/kconfig/lxdialog/.gitignore +0 -0
scripts/kconfig/menuconfig/BIG.FAT.WARNING renamed from scripts/kconfig/lxdialog/BIG.FAT.WARNING +0 -0
scripts/kconfig/menuconfig/Makefile new file +42 -0
42 lines not on this page · raw message
scripts/kconfig/menuconfig/check-lxdialog.sh renamed from scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
scripts/kconfig/menuconfig/checklist.c renamed from scripts/kconfig/lxdialog/checklist.c +0 -0
scripts/kconfig/menuconfig/dialog.h renamed from scripts/kconfig/lxdialog/dialog.h +0 -0
scripts/kconfig/menuconfig/inputbox.c renamed from scripts/kconfig/lxdialog/inputbox.c +0 -0
scripts/kconfig/menuconfig/mconf.c renamed from scripts/kconfig/mconf.c +2 -2
@@ -19,8 +19,8 @@#include <unistd.h> #include <locale.h> -#include "lkc.h" -#include "lxdialog/dialog.h" +#include "../lkc.h" +#include "dialog.h" static const char mconf_readme[] =N_ ( "Overview\n"
scripts/kconfig/menuconfig/menubox.c renamed from scripts/kconfig/lxdialog/menubox.c +0 -0
scripts/kconfig/menuconfig/textbox.c renamed from scripts/kconfig/lxdialog/textbox.c +0 -0
scripts/kconfig/menuconfig/util.c renamed from scripts/kconfig/lxdialog/util.c +0 -0
scripts/kconfig/menuconfig/yesno.c renamed from scripts/kconfig/lxdialog/yesno.c +0 -0
scripts/kconfig/nconfig/Makefile new file +26 -0
@@ -0,0 +1,26 @@ +# =========================================================================== +# Kernel configuration targets +# These targets are used from top-level makefile + +PHONY += nconfig + +nconfig: $(obj)/nconf + $< $(Kconfig) + +# =========================================================================== +# nconf: Used for the nconfig target. +# Utilizes ncurses +# object files used by all kconfig flavours listed above + +nconf-objs := nconfig/nconf.o zconf.tab.o nconfig/nconf.gui.o + +ifeq ($(MAKECMDGOALS),nconfig) + hostprogs-y += nconf +endif + +clean-files += nconf + +HOSTLOADLIBES_nconf = $(shell \ + pkg-config --libs menu panel ncurses 2>/dev/null \ + || echo "-lmenu -lpanel -lncurses" ) +
scripts/kconfig/nconfig/nconf.c renamed from scripts/kconfig/nconf.c +1 -1
@@ -9,7 +9,7 @@#include <string.h> #include <stdlib.h> -#include "lkc.h" +#include "../lkc.h" #include "nconf.h" #include <ctype.h>
scripts/kconfig/nconfig/nconf.gui.c renamed from scripts/kconfig/nconf.gui.c +0 -0
scripts/kconfig/nconfig/nconf.h renamed from scripts/kconfig/nconf.h +0 -0
scripts/kconfig/qconfig/Makefile new file +104 -0
104 lines not on this page · raw message
scripts/kconfig/qconfig/qconf.cc renamed from scripts/kconfig/qconf.cc +2 -2
@@ -43,11 +43,11 @@ #include <stdlib.h> -#include "lkc.h" +#include "../lkc.h" #include "qconf.h" #include "qconf.moc" -#include "images.c" +#include "../images.c" #ifdef _ # undef _
scripts/kconfig/qconfig/qconf.h renamed from scripts/kconfig/qconf.h +0 -0
Signature · 1 line
1.8.1.2
PATCH v3 2/5 kconfig: Add qconfig makefile target additionally to the xconfig target
In reply to David GraeffBecause we no longer only target the xserver with the qt frontend of kconfig and due to the name beeing inconsistent with the other makefile targets an additional qconfig target is added.
scripts/kconfig/qconfig/Makefile +4 -1
@@ -2,11 +2,14 @@ # Kernel configuration targets # These targets are used from kconfig top-level makefile -PHONY += xconfig +PHONY += xconfig qconfig xconfig: $(obj)/qconf $< $(Kconfig) +qconfig: $(obj)/qconf + $< $(Kconfig) + # =========================================================================== # qconf: Used for the xconfig/qconfig target # Based on Qt4+ which needs to be installed to compile it
Signature · 1 line
1.8.1.2
PATCH v3 5/5 kconfig: images.c for gtk/qt gui flavour reoganized
In reply to David GraeffChange order of xpm image constants to build up groups. Make those groups optional via ifdefs.
Remove not used constants.
scripts/kconfig/images.c +11 -214
@@ -3,94 +3,7 @@* Released under the terms of the GNU GPL v2.0. */ -static const char *xpm_load[] = { -"22 22 5 1" , -". c None" , -"# c #000000" , -"c c #838100" , -"a c #ffff00" , -"b c #ffffff" , -"......................" , -"......................" , -"......................" , -"............####....#." , -"...........#....##.##." , -"..................###." , -".................####." , -".####...........#####." , -"#abab##########......." , -"#babababababab#......." , -"#ababababababa#......." , -"#babababababab#......." , -"#ababab###############" , -"#babab##cccccccccccc##" , -"#abab##cccccccccccc##." , -"#bab##cccccccccccc##.." , -"#ab##cccccccccccc##..." , -"#b##cccccccccccc##...." , -"###cccccccccccc##....." , -"##cccccccccccc##......" , -"###############......." , -"......................" }; - -static const char *xpm_save[] = { -"22 22 5 1" , -". c None" , -"# c #000000" , -"a c #838100" , -"b c #c5c2c5" , -"c c #cdb6d5" , -"......................" , -".####################." , -".#aa#bbbbbbbbbbbb#bb#." , -".#aa#bbbbbbbbbbbb#bb#." , -".#aa#bbbbbbbbbcbb####." , -".#aa#bbbccbbbbbbb#aa#." , -".#aa#bbbccbbbbbbb#aa#." , -".#aa#bbbbbbbbbbbb#aa#." , -".#aa#bbbbbbbbbbbb#aa#." , -".#aa#bbbbbbbbbbbb#aa#." , -".#aa#bbbbbbbbbbbb#aa#." , -".#aaa############aaa#." , -".#aaaaaaaaaaaaaaaaaa#." , -".#aaaaaaaaaaaaaaaaaa#." , -".#aaa#############aa#." , -".#aaa#########bbb#aa#." , -".#aaa#########bbb#aa#." , -".#aaa#########bbb#aa#." , -".#aaa#########bbb#aa#." , -".#aaa#########bbb#aa#." , -"..##################.." , -"......................" }; - -static const char *xpm_back[] = { -"22 22 3 1" , -". c None" , -"# c #000083" , -"a c #838183" , -"......................" , -"......................" , -"......................" , -"......................" , -"......................" , -"...........######a...." , -"..#......##########..." , -"..##...####......##a.." , -"..###.###.........##.." , -"..######..........##.." , -"..#####...........##.." , -"..######..........##.." , -"..#######.........##.." , -"..########.......##a.." , -"...............a###..." , -"...............###...." , -"......................" , -"......................" , -"......................" , -"......................" , -"......................" , -"......................" }; - +#ifdef IMAGES_TOOLBAR static const char *xpm_tree_view[] = {"22 22 2 1" , ". c None",
@@ -171,90 +84,24 @@ static const char *xpm_split_view[] = {"......#......#........" ,"......................" , "......................"}; +#endif -static const char *xpm_symbol_no[] = { +#ifdef IMAGES_TREEVIEW +static const char *xpm_void[] = {"12 12 2 1" ," c white" ,". c black" ," " , -" .......... " , -" . . " , -" . . " , -" . . " , -" . . " , -" . . " , -" . . " , -" . . " , -" . . " , -" .......... " , -" " }; - -static const char *xpm_symbol_mod[] = { -"12 12 2 1" , -" c white" , -". c black" ," " , -" .......... " , -" . . " , -" . . " , -" . .. . " , -" . .... . " , -" . .... . " , -" . .. . " , -" . . " , -" . . " , -" .......... " , -" " }; - -static const char *xpm_symbol_yes[] = { -"12 12 2 1" , -" c white" , -". c black" ," " , -" .......... " , -" . . " , -" . . " , -" . . . " , -" . .. . " , -" . . .. . " , -" . .... . " , -" . .. . " , -" . . " , -" .......... " , -" " }; - -static const char *xpm_choice_no[] = { -"12 12 2 1" , -" c white" , -". c black" ," " , -" .... " , -" .. .. " , -" . . " , -" . . " , -" . . " , -" . . " , -" . . " , -" . . " , -" .. .. " , -" .... " , -" " }; - -static const char *xpm_choice_yes[] = { -"12 12 2 1" , -" c white" , -". c black" ," " , -" .... " , -" .. .. " , -" . . " , -" . .. . " , -" . .... . " , -" . .... . " , -" . .. . " , -" . . " , -" .. .. " , -" .... " , +" " , +" " , +" " , +" " , +" " , +" " ," " }; static const char *xpm_menu[] = {
@@ -273,54 +120,4 @@ static const char *xpm_menu[] = {" . . " ," .......... " , " "}; - -static const char *xpm_menu_inv[] = { -"12 12 2 1" , -" c white" , -". c black" , -" " , -" .......... " , -" .......... " , -" .. ...... " , -" .. .... " , -" .. .. " , -" .. .. " , -" .. .... " , -" .. ...... " , -" .......... " , -" .......... " , -" " }; - -static const char *xpm_menuback[] = { -"12 12 2 1" , -" c white" , -". c black" , -" " , -" .......... " , -" . . " , -" . .. . " , -" . .... . " , -" . ...... . " , -" . ...... . " , -" . .... . " , -" . .. . " , -" . . " , -" .......... " , -" " }; - -static const char *xpm_void[] = { -"12 12 2 1" , -" c white" , -". c black" , -" " , -" " , -" " , -" " , -" " , -" " , -" " , -" " , -" " , -" " , -" " , -" " }; +#endif
Signature · 1 line
1.8.1.2
David, All,
On 2013-08-19 16:29 +0200, David Graeff spake thusly:
Quoted 7 lines
David Graeff (5):
kconfig: Move flavours into their own subdirectories.
kconfig: Add qconfig makefile target additionally to the xconfig
target
kconfig: Update/Port Gtk flavour to use Gtk3
kconfig: Qt interface port to Qt4/Qt5, removed Qt3 Support
kconfig:images.cfor gtk/qt gui flavour reoganized
Are you still interested in this series? If so, could you please rebase it on top of the current tree, so it is easier to apply?
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'