Skip to contentSkip to conversation

perf trace: Make command line arguments consistent with perf-record

PATCH In review David Ahern 2 participants 4 messages Aug 19, 2013 – Aug 20, 2013 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf trace: Make command line arguments consistent with perf-record

Common arguments like thread id, CPU list, mmap pages, etc should be consistent across perf commands.

---
 tools/perf/builtin-trace.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
tools/perf/builtin-trace.c +6 -6
index da7ae01..55f1287 100644
@@ -637,17 +637,17 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)
 	const struct option trace_options[] = {
 	OPT_STRING('p', "pid", &trace.opts.target.pid, "pid",
 		    "trace events on existing process id"),
-	OPT_STRING(0, "tid", &trace.opts.target.tid, "tid",
+	OPT_STRING('t', "tid", &trace.opts.target.tid, "tid",
 		    "trace events on existing thread id"),
-	OPT_BOOLEAN(0, "all-cpus", &trace.opts.target.system_wide,
+	OPT_BOOLEAN('a', "all-cpus", &trace.opts.target.system_wide,
 		    "system-wide collection from all CPUs"),
-	OPT_STRING(0, "cpu", &trace.opts.target.cpu_list, "cpu",
+	OPT_STRING('C', "cpu", &trace.opts.target.cpu_list, "cpu",
 		    "list of cpus to monitor"),
-	OPT_BOOLEAN(0, "no-inherit", &trace.opts.no_inherit,
+	OPT_BOOLEAN('i', "no-inherit", &trace.opts.no_inherit,
 		    "child tasks do not inherit counters"),
-	OPT_UINTEGER(0, "mmap-pages", &trace.opts.mmap_pages,
+	OPT_UINTEGER('m', "mmap-pages", &trace.opts.mmap_pages,
 		     "number of mmap data pages"),
-	OPT_STRING(0, "uid", &trace.opts.target.uid_str, "user",
+	OPT_STRING('u', "uid", &trace.opts.target.uid_str, "user",
 		   "user to profile"),
 	OPT_CALLBACK(0, "duration", &trace, "float",
 		     "show only events with duration > N.M ms",
Signature · 1 line
1.7.10.1
#1 lore raw

Em Mon, Aug 19, 2013 at 11:04:30AM -0600, David Ahern escreveu:

Quoted 2 lines

Common arguments like thread id, CPU list, mmap pages, etc should be consistent across perf commands.

Ok, at some point I'll add a 'perf strace' alias that will resume trying to map the 'strace' single letter options.

Can you check if this clashes with the -o patch I added today?

- Arnaldo

Quoted 35 lines
---
 tools/perf/builtin-trace.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
tools/perf/builtin-trace.c +6 -6
index da7ae01..55f1287 100644
@@ -637,17 +637,17 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)
 	const struct option trace_options[] = {
 	OPT_STRING('p', "pid", &trace.opts.target.pid, "pid",
 		    "trace events on existing process id"),
-	OPT_STRING(0, "tid", &trace.opts.target.tid, "tid",
+	OPT_STRING('t', "tid", &trace.opts.target.tid, "tid",
 		    "trace events on existing thread id"),
-	OPT_BOOLEAN(0, "all-cpus", &trace.opts.target.system_wide,
+	OPT_BOOLEAN('a', "all-cpus", &trace.opts.target.system_wide,
 		    "system-wide collection from all CPUs"),
-	OPT_STRING(0, "cpu", &trace.opts.target.cpu_list, "cpu",
+	OPT_STRING('C', "cpu", &trace.opts.target.cpu_list, "cpu",
 		    "list of cpus to monitor"),
-	OPT_BOOLEAN(0, "no-inherit", &trace.opts.no_inherit,
+	OPT_BOOLEAN('i', "no-inherit", &trace.opts.no_inherit,
 		    "child tasks do not inherit counters"),
-	OPT_UINTEGER(0, "mmap-pages", &trace.opts.mmap_pages,
+	OPT_UINTEGER('m', "mmap-pages", &trace.opts.mmap_pages,
 		     "number of mmap data pages"),
-	OPT_STRING(0, "uid", &trace.opts.target.uid_str, "user",
+	OPT_STRING('u', "uid", &trace.opts.target.uid_str, "user",
 		   "user to profile"),
 	OPT_CALLBACK(0, "duration", &trace, "float",
 		     "show only events with duration > N.M ms",
Signature · 1 line
1.7.10.1
#2 lore raw
Quoted 8 lines · Arnaldo Carvalho de Melo

Em Mon, Aug 19, 2013 at 11:04:30AM -0600, David Ahern escreveu:

Quoted 2 lines

Common arguments like thread id, CPU list, mmap pages, etc should be consistent across perf commands.

Ok, at some point I'll add a 'perf strace' alias that will resume trying to map the 'strace' single letter options.

Can you check if this clashes with the -o patch I added today?

I just did remote update again and I do not see a -o patch in any of the branches.

David

#3 lore raw

Em Tue, Aug 20, 2013 at 08:19:30AM -0600, David Ahern escreveu:

Quoted 5 lines · Arnaldo Carvalho de Melo
Quoted 3 lines

Em Mon, Aug 19, 2013 at 11:04:30AM -0600, David Ahern escreveu:

Quoted 2 lines

Common arguments like thread id, CPU list, mmap pages, etc should be consistent across perf commands.

Quoted 7 lines
Quoted 4 lines

Ok, at some point I'll add a 'perf strace' alias that will resume trying to map the 'strace' single letter options.

Can you check if this clashes with the -o patch I added today?

I just did remote update again and I do not see a -o patch in any of the branches.

Sorry, I thought I pushed it, did it now.

- Arnaldo