Skip to contentSkip to conversation

arm64: wire in generic parport.h

PATCH In review Mark Salter 2 participants 4 messages Aug 18, 2013 – Aug 20, 2013 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: wire in generic parport.h

The arm64 port doesn't provide a parport.h which causes a build failure with some configurations:

drivers/parport/parport_pc.c:67:25: fatal error: asm/parport.h: No such file or directory
#include <asm/parport.h>

This patch wires in the generic parport.h for arm64.

---
 arch/arm64/include/asm/Kbuild | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/include/asm/Kbuild +1 -0
index 79a642d..487b0a2 100644
@@ -25,6 +25,7 @@ generic-y += local64.h
 generic-y += mman.h
 generic-y += msgbuf.h
 generic-y += mutex.h
+generic-y += parport.h                                                                                         
 generic-y += pci.h
 generic-y += percpu.h
 generic-y += poll.h
Signature · 1 line
1.8.1.4
#1 lore raw
Quoted 7 lines · Mark Salter

The arm64 port doesn't provide a parport.h which causes a build failure with some configurations:

drivers/parport/parport_pc.c:67:25: fatal error: asm/parport.h: No such file or directory
#include <asm/parport.h>

This patch wires in the generic parport.h for arm64.

Can arm64 have a PC-style parport?

If not, you're better off disabling it in drivers/parport/Kconfig.

You will receive bonus points for introducing ARCH_MAY_HAVE_PC_PARPORT, cfr. ARCH_MAY_HAVE_PC_FDC.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
Quoted 10 lines · Geert Uytterhoeven
Quoted 7 lines · Mark Salter

The arm64 port doesn't provide a parport.h which causes a build failure with some configurations:

drivers/parport/parport_pc.c:67:25: fatal error: asm/parport.h: No such file or directory
#include <asm/parport.h>

This patch wires in the generic parport.h for arm64.

Can arm64 have a PC-style parport?

Good question. I'm not sure, but really doubt it.

Quoted 6 lines

If not, you're better off disabling it in drivers/parport/Kconfig.

You will receive bonus points for introducing ARCH_MAY_HAVE_PC_PARPORT, cfr. ARCH_MAY_HAVE_PC_FDC.

Yes, good point. I'll work up a new patch. I can use some bonus points.

--Mark

#3 lore raw
In reply to Geert Uytterhoeven
Quoted 7 lines · Geert Uytterhoeven
Quoted 6 lines · Mark Salter

The arm64 port doesn't provide a parport.h which causes a build failure with some configurations:

drivers/parport/parport_pc.c:67:25: fatal error: asm/parport.h: No such file or directory
#include <asm/parport.h>

Quoted 8 lines
Quoted 1 line

This patch wires in the generic parport.h for arm64.

Can arm64 have a PC-style parport?

If not, you're better off disabling it in drivers/parport/Kconfig.

You will receive bonus points for introducing ARCH_MAY_HAVE_PC_PARPORT, cfr. ARCH_MAY_HAVE_PC_FDC.

Okay, I have two versions of the patch. One which follows the PC_FDC patch and adds something like this to arch/<somearch>/Kconfig:

config ARCH_MAY_HAVE_PC_PARPORT
def_bool y

The other version adds:

config ARCH_MAY_HAVE_PC_PARPORT
bool

to arch/Kconfig (or maybe that should be in drivers/parport/Kconfig) so that the various arches just need to select it.

Is there any preference for one over the other?

--Mark