Skip to contentSkip to conversation

Why are BSD-licensed LZ4 symbols GPL exported?

PATCH In review Richard Yao 6 participants 9 messages Aug 16, 2013 – Aug 20, 2013

lore
Share & tools
lore
#0 lore raw

Why are the LZ4 symbols being GPL-exported when the LZ4 code is BSD-licensed and no substantial changes appear to have been made when it was merged?

Also, why is the module license GPL when the code itself is clearly under a BSD license?

#1 lore raw

PATCH 1/1 Correct the LZ4 license

The LZ4 code is listed as using the "BSD 2-Clause License".

---
 lib/lz4/lz4_compress.c   |    4 ++--
 lib/lz4/lz4_decompress.c |    6 +++---
 lib/lz4/lz4hc_compress.c |    4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)
lib/lz4/lz4_compress.c +2 -2
index fd94058..28321d8 100644
@@ -437,7 +437,7 @@ int lz4_compress(const unsigned char *src, size_t src_len,
 exit:
 	return ret;
 }
-EXPORT_SYMBOL_GPL(lz4_compress);
+EXPORT_SYMBOL(lz4_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 compressor");
lib/lz4/lz4_decompress.c +3 -3
index d3414ea..411be80 100644
@@ -299,7 +299,7 @@ exit_0:
 	return ret;
 }
 #ifndef STATIC
-EXPORT_SYMBOL_GPL(lz4_decompress);
+EXPORT_SYMBOL(lz4_decompress);
 #endif
 
 int lz4_decompress_unknownoutputsize(const char *src, size_t src_len,
@@ -319,8 +319,8 @@ exit_0:
 	return ret;
 }
 #ifndef STATIC
-EXPORT_SYMBOL_GPL(lz4_decompress_unknownoutputsize);
+EXPORT_SYMBOL(lz4_decompress_unknownoutputsize);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 Decompressor");
 #endif
lib/lz4/lz4hc_compress.c +2 -2
index eb1a74f..f344f76 100644
@@ -533,7 +533,7 @@ int lz4hc_compress(const unsigned char *src, size_t src_len,
 exit:
 	return ret;
 }
-EXPORT_SYMBOL_GPL(lz4hc_compress);
+EXPORT_SYMBOL(lz4hc_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4HC compressor");
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH] Correct the LZ4 license

Quoted 52 lines · Richard Laager

The LZ4 code is listed as using the "BSD 2-Clause License".

---
 lib/lz4/lz4_compress.c   |    4 ++--
 lib/lz4/lz4_decompress.c |    6 +++---
 lib/lz4/lz4hc_compress.c |    4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)
lib/lz4/lz4_compress.c +2 -2
index fd94058..28321d8 100644
@@ -437,7 +437,7 @@ int lz4_compress(const unsigned char *src, size_t src_len,
 exit:
 	return ret;
 }
-EXPORT_SYMBOL_GPL(lz4_compress);
+EXPORT_SYMBOL(lz4_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 compressor");
lib/lz4/lz4_decompress.c +3 -3
index d3414ea..411be80 100644
@@ -299,7 +299,7 @@ exit_0:
 	return ret;
 }
 #ifndef STATIC
-EXPORT_SYMBOL_GPL(lz4_decompress);
+EXPORT_SYMBOL(lz4_decompress);
 #endif
 
 int lz4_decompress_unknownoutputsize(const char *src, size_t src_len,
@@ -319,8 +319,8 @@ exit_0:
 	return ret;
 }
 #ifndef STATIC
-EXPORT_SYMBOL_GPL(lz4_decompress_unknownoutputsize);
+EXPORT_SYMBOL(lz4_decompress_unknownoutputsize);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 Decompressor");
 #endif
lib/lz4/lz4hc_compress.c +0 -0
index eb1a74f..f344f76 100644

lib/lz4/lz4hc_compress.c int lz4hc_compress(const unsigned char *src, size_t src_len, · line 539

Quoted 9 lines
lib/lz4/lz4hc_compress.c +2 -2
@@ -533,7 +533,7 @@ int lz4hc_compress(const unsigned char *src, size_t src_len,
 exit:
 	return ret;
 }
-EXPORT_SYMBOL_GPL(lz4hc_compress);
+EXPORT_SYMBOL(lz4hc_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4HC compressor");

Thanks,
Kyungsik

#3 lore raw
In reply to Richard Yao
Quoted 3 lines · Richard Yao

Why are the LZ4 symbols being GPL-exported when the LZ4 code is BSD-licensed and no substantial changes appear to have been made when it was merged?

EXPORT_SYMBOL_GPL is intended an indication that using a symbol is likely to result in you producing a derived work of the kernel, and the kernel as a whole is under the GPL. It has nothing to do with additional licenses that individual pieces of code may be available under.

Signature · 1 line
Matthew Garrett | [email protected]
#4 lore raw
Quoted 9 lines · Matthew Garrett
Quoted 3 lines · Richard Yao

Why are the LZ4 symbols being GPL-exported when the LZ4 code is BSD-licensed and no substantial changes appear to have been made when it was merged?

EXPORT_SYMBOL_GPL is intended an indication that using a symbol is likely to result in you producing a derived work of the kernel, and the kernel as a whole is under the GPL. It has nothing to do with additional licenses that individual pieces of code may be available under.

Maybe not.

http://www.ifross.org/en/artikel/ongoing-dispute-over-value-exportsymbolgpl-function

#5 lore raw
Quoted 9 lines · Joe Perches
Quoted 3 lines · Matthew Garrett
Quoted 2 lines · Richard Yao

Why are the LZ4 symbols being GPL-exported when the LZ4 code is BSD-licensed and no substantial changes appear to have been made

when it

Quoted 4 lines
Quoted 1 line

was merged?

EXPORT_SYMBOL_GPL is intended an indication that using a symbol is likely to result in you producing a derived work of the kernel, and

Quoted 8 lines

the

Quoted 1 line

kernel as a whole is under the GPL. It has nothing to do with

additional

Quoted 1 line

licenses that individual pieces of code may be available under.

Maybe not.

http://www.ifross.org/en/artikel/ongoing-dispute-over-value-exportsymbolgpl-function

Kernel developers: "We're making symbols that we, as the creators of this project, don't think you can use without the result being a derived work".

Lawyers: "we're prepared to argue over the definitions of 'that', 'as', 'of', 'this', 'use', and 'the', as long as we're paid by the hour."

This random speculation outside of a courtroom actually capable of setting precedent strikes you as relevant for what reason?

Rob

#6 lore raw
Quoted 18 lines · Rob Landley
Quoted 9 lines · Joe Perches
Quoted 3 lines · Matthew Garrett
Quoted 2 lines · Richard Yao

Why are the LZ4 symbols being GPL-exported when the LZ4 code is BSD-licensed and no substantial changes appear to have been made

when it

Quoted 4 lines
Quoted 1 line

was merged?

EXPORT_SYMBOL_GPL is intended an indication that using a symbol is likely to result in you producing a derived work of the kernel, and

Quoted 7 lines

the

Quoted 1 line

kernel as a whole is under the GPL. It has nothing to do with

additional

Quoted 1 line

licenses that individual pieces of code may be available under.

Maybe not.
http://www.ifross.org/en/artikel/ongoing-dispute-over-value-exportsymbolgpl-function

Quoted 6 lines

Kernel developers: "We're making symbols that we, as the creators of this project, don't think you can use without the result being a derived work".

Lawyers: "we're prepared to argue over the definitions of 'that', 'as', 'of', 'this', 'use', and 'the', as long as we're paid by the hour."

Law is certainly a, umm, useful occupation.

Quoted 2 lines

This random speculation outside of a courtroom actually capable of setting precedent strikes you as relevant for what reason?

Because your declarative statement that EXPORT_SYMBOL_GPL is "intended [as] an indication that using [the] symbol is likely to result..." is incomplete.

There are competing histories as to what EXPORT_SYMBOL_GPL was intended to do.

#7 lore raw
Quoted 1 line · Joe Perches

Because your

Sorry, not your's but Matthew's.

I do think the MODULE_LICENSE should be "Dual BSD/GPL" instead of merely "GPL" if for no other reason than politeness to the original developer and the license at the top of the files.

* LZ4 - Fast LZ compression algorithm
* Copyright (C) 2011-2012, Yann Collet.
* BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php)

---
 lib/lz4/lz4_compress.c   | 2 +-
 lib/lz4/lz4_decompress.c | 2 +-
 lib/lz4/lz4hc_compress.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
lib/lz4/lz4_compress.c +1 -1
index fd94058..a4001ee 100644
@@ -439,5 +439,5 @@ exit:
 }
 EXPORT_SYMBOL_GPL(lz4_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 compressor");
lib/lz4/lz4_decompress.c +1 -1
index d3414ea..c45e685 100644
@@ -321,6 +321,6 @@ exit_0:
 #ifndef STATIC
 EXPORT_SYMBOL_GPL(lz4_decompress_unknownoutputsize);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 Decompressor");
 #endif
lib/lz4/lz4hc_compress.c +1 -1
index eb1a74f..59f26e6 100644
@@ -535,5 +535,5 @@ exit:
 }
 EXPORT_SYMBOL_GPL(lz4hc_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4HC compressor");