PHY framework
Subsystems (12)
v11 cover PHY framework
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to drivers/phy to increase code re-use and to increase code maintainability.
Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
You can find this patch series @git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git testing
I'll create a new branch *next* once this patch series is finalized. All the PHY driver development that depends on PHY framework can be based on this branch.
Did USB enumeration testing in panda and beagle after applying [1]
[1] -> https://lkml.org/lkml/2013/7/26/88
Changes from v10:
* fixed a mistake in devm_of_phy_provider_register macro which was carried over from earlier version.
* used ida_simple_get for obtaining the id.
Changes from v9:
* Fixed Greg's concern on having *find PHY by string* and changed it to Tomasz pseudo code.
* move omap-usb2 phy and twl4030-usb phy to drivers/phy
* made all the dependent drivers select GENERIC_PHY instead of having depends on
* Made PHY core to assign the id's (so changed the phy_create API).
* Adapted twl4030-usb to the new design.
Changes from v8:
* Added phy_set_drvdata and phy_get_drvdata in phy.h.
* Changed phy_create API not to take void *priv. private data should now be set using phy_set_drvdata now.
Changes from v7:
* Fixed Documentation
* Added to_phy, of_phy_provider_register and devm_of_phy_provider_register
* modified runtime_pm usage in phy_init, phy_exit, phy_power_on and phy_power_off. Now phy_power_on will enable the clocks and phy_power_off will disable the clocks.
* pm_runtime_no_callbacks() is added so that pm_runtime_get_sync doesn't fail
* modified other patches to adhere to the changes in the PHY framework
* removed usb: phy: twl4030: twl4030 shouldn't be subsys_initcall as it will be merged separately.
* reference counting has been added to protect phy ops when the PHY is shared by multiple consumers.
Changes from v6
* corrected few typos in Documentation
* Changed PHY Subsystem to *bool* in Kconfig (to avoid compilation errors when PHY Subsystem is kept as module and the dependent modules are built-in)
* Added if pm_runtime_enabled check before runtime pm calls.
Changes from v5:
* removed the new sysfs entries as it dint have any new information other than what is already there in /sys/devices/...
* removed a bunch of APIs added to get the PHY and now only phy_get and devm_phy_get are used.
* Added new APIs to register/unregister the PHY provider. This is needed for dt boot case.
* Enabled pm runtime and incorporated the comments given by Alan Stern in a different patch series by Gautam.
* Removed the *phy_bind* API. Now the phy binding information should be passed using the platform data to the controller devices.
* Fixed a few typos.
Changes from v4:
* removed of_phy_get_with_args/devm_of_phy_get_with_args. Now the *phy providers* should use their custom implementation of of_xlate or use of_phy_xlate to get *phy instance* from *phy providers*.
* Added of_phy_xlate to be used by *phy providers* if it provides only one PHY.
* changed phy_core from having subsys_initcall to module_init.
* other minor fixes.
Changes from v3:
* Changed the return value of PHY APIs to ENOSYS
* Added APIs of_phy_get_with_args/devm_of_phy_get_with_args to support getting PHYs if the same IP implements multiple PHYs.
* modified phy_bind API so that the binding information can now be _updated_. In effect of this removed the binding information added in board files and added only in usb-musb.c. If a particular board uses a different phy binding, it can update it in board file after usb_musb_init().
* Added Documentation/devicetree/bindings/phy/phy-bindings.txt for dt binding information.
Changes from v2:
* removed phy_descriptor structure completely so changed the APIs which were taking phy_descriptor as parameters
* Added 2 more APIs *of_phy_get_byname* and *devm_of_phy_get_byname* to be used by PHY user drivers which has *phy* and *phy-names* binding in the dt data
* Fixed a few typos
* Removed phy_list and we now use class_dev_iter_init, class_dev_iter_next and class_dev_iter_exit for traversing through the phy list. (Note we still need phy_bind list and phy_bind_mutex).
* Changed the sysfs entry name from *bind* to *phy_bind*.
Changes from v1:
* Added Documentation for the PHY framework
* Added few more APIs mostly w.r.t devres
* Modified omap-usb2 and twl4030 to make use of the new framework
Kishon Vijay Abraham I (8):
drivers: phy: add generic PHY framework
usb: phy: omap-usb2: use the new generic PHY framework
usb: phy: twl4030: use the new generic PHY framework
arm: omap3: twl: add phy consumer data in twl4030_usb_data
ARM: dts: omap: update usb_otg_hs data
usb: musb: omap2430: use the new generic PHY framework
usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2
usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops
.../devicetree/bindings/phy/phy-bindings.txt | 66 ++
Documentation/devicetree/bindings/usb/omap-usb.txt | 5 +
Documentation/devicetree/bindings/usb/usb-phy.txt | 6 +
Documentation/phy.txt | 166 +++++
MAINTAINERS | 8 +
arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +
arch/arm/boot/dts/omap3-evm.dts | 2 +
arch/arm/boot/dts/omap3-overo.dtsi | 2 +
arch/arm/boot/dts/omap4.dtsi | 3 +
arch/arm/boot/dts/twl4030.dtsi | 1 +
arch/arm/mach-omap2/twl-common.c | 11 +
drivers/Kconfig | 2 +
drivers/Makefile | 2 +
drivers/phy/Kconfig | 41 ++
drivers/phy/Makefile | 7 +
drivers/phy/phy-core.c | 698 ++++++++++++++++++++
drivers/{usb => }/phy/phy-omap-usb2.c | 60 +-
drivers/{usb => }/phy/phy-twl4030-usb.c | 69 +-
drivers/usb/musb/Kconfig | 1 +
drivers/usb/musb/musb_core.h | 2 +
drivers/usb/musb/omap2430.c | 26 +-
drivers/usb/phy/Kconfig | 19 -
drivers/usb/phy/Makefile | 2 -
include/linux/i2c/twl.h | 2 +
include/linux/phy/phy.h | 270 ++++++++
25 files changed, 1397 insertions(+), 76 deletions(-)
create mode 100644 Documentation/devicetree/bindings/phy/phy-bindings.txt
create mode 100644 Documentation/phy.txt
create mode 100644 drivers/phy/Kconfig
create mode 100644 drivers/phy/Makefile
create mode 100644 drivers/phy/phy-core.c
rename drivers/{usb => }/phy/phy-omap-usb2.c (88%)
rename drivers/{usb => }/phy/phy-twl4030-usb.c (94%)
create mode 100644 include/linux/phy/phy.hSignature · 1 line
1.7.10.4
PATCH v11 1/8 drivers: phy: add generic PHY framework
The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also register *PHY provider* with the framework.
PHY drivers should create the PHY by passing id and ops like init, exit, power_on and power_off. This framework is also pm runtime enabled.
The documentation for the generic PHY framework is added in Documentation/phy.txt and the documentation for dt binding can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt
--- .../devicetree/bindings/phy/phy-bindings.txt | 66 ++ Documentation/phy.txt | 166 +++++ MAINTAINERS | 8 + drivers/Kconfig | 2 + drivers/Makefile | 2 + drivers/phy/Kconfig | 18 + drivers/phy/Makefile | 5 + drivers/phy/phy-core.c | 698 ++++++++++++++++++++ include/linux/phy/phy.h | 270 ++++++++ 9 files changed, 1235 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/phy-bindings.txt create mode 100644 Documentation/phy.txt create mode 100644 drivers/phy/Kconfig create mode 100644 drivers/phy/Makefile create mode 100644 drivers/phy/phy-core.c create mode 100644 include/linux/phy/phy.h
Documentation/devicetree/bindings/phy/phy-bindings.txt new file +66 -0
@@ -0,0 +1,66 @@ +This document explains only the device tree data binding. For general +information about PHY subsystem refer to Documentation/phy.txt + +PHY device node +=============== + +Required Properties: +#phy-cells: Number of cells in a PHY specifier; The meaning of all those + cells is defined by the binding for the phy node. The PHY + provider can use the values in cells to find the appropriate + PHY. + +For example: + +phys: phy { + compatible = "xxx"; + reg = <...>; + . + . + #phy-cells = <1>; + . + . +}; + +That node describes an IP block (PHY provider) that implements 2 different PHYs. +In order to differentiate between these 2 PHYs, an additonal specifier should be +given while trying to get a reference to it. + +PHY user node +============= + +Required Properties: +phys : the phandle for the PHY device (used by the PHY subsystem) +phy-names : the names of the PHY corresponding to the PHYs present in the + *phys* phandle + +Example 1: +usb1: usb_otg_ss at xxx { + compatible = "xxx"; + reg = <xxx>; + . + . + phys = <&usb2_phy>, <&usb3_phy>; + phy-names = "usb2phy", "usb3phy"; + . + . +}; + +This node represents a controller that uses two PHYs, one for usb2 and one for +usb3. + +Example 2: +usb2: usb_otg_ss at xxx { + compatible = "xxx"; + reg = <xxx>; + . + . + phys = <&phys 1>; + phy-names = "usbphy"; + . + . +}; + +This node represents a controller that uses one of the PHYs of the PHY provider +device defined previously. Note that the phy handle has an additional specifier +"1" to differentiate between the two PHYs.
Documentation/phy.txt new file +166 -0
166 lines not on this page · raw message
MAINTAINERS +8 -0
@@ -3599,6 +3599,14 @@ S: Maintained F: include/asm-generic F: include/uapi/asm-generic +GENERIC PHY FRAMEWORK +M: Kishon Vijay Abraham I <[email protected]> +L: linux-kernel at vger.kernel.org +T: git git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git +S: Supported +F: drivers/phy/ +F: include/linux/phy/ + GENERIC UIO DRIVER FOR PCI DEVICES M: "Michael S. Tsirkin" <[email protected]> L: kvm at vger.kernel.org
drivers/Kconfig +2 -0
@@ -166,4 +166,6 @@ source "drivers/reset/Kconfig" source "drivers/fmc/Kconfig" +source "drivers/phy/Kconfig" + endmenu
drivers/Makefile +2 -0
@@ -8,6 +8,8 @@ obj-y += irqchip/ obj-y += bus/ +obj-$(CONFIG_GENERIC_PHY) += phy/ + # GPIO must come after pinctrl as gpios may need to mux pins etc obj-y += pinctrl/ obj-y += gpio/
drivers/phy/Kconfig new file +18 -0
@@ -0,0 +1,18 @@ +# +# PHY +# + +menu "PHY Subsystem" + +config GENERIC_PHY + tristate "PHY Core" + help + Generic PHY support. + + This framework is designed to provide a generic interface for PHY + devices present in the kernel. This layer will have the generic + API by which phy drivers can create PHY using the phy framework and + phy users can obtain reference to the PHY. All the users of this + framework should select this config. + +endmenu
drivers/phy/Makefile new file +5 -0
@@ -0,0 +1,5 @@ +# +# Makefile for the phy drivers. +# + +obj-$(CONFIG_GENERIC_PHY) += phy-core.o
drivers/phy/phy-core.c new file +698 -0
698 lines not on this page · raw message
include/linux/phy/phy.h new file +270 -0
270 lines not on this page · raw message
Signature · 1 line
1.7.10.4
PATCH v11 2/8 usb: phy: omap-usb2: use the new generic PHY framework
In reply to Kishon Vijay Abraham IUsed the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively. The omap-usb2 driver is also moved to driver/phy.
However using the old USB PHY library cannot be completely removed because OTG is intertwined with PHY and moving to the new framework will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library.
---
drivers/phy/Kconfig | 12 +++++++++
drivers/phy/Makefile | 1 +
drivers/{usb => }/phy/phy-omap-usb2.c | 45 ++++++++++++++++++++++++++++++---
drivers/usb/phy/Kconfig | 10 --------
drivers/usb/phy/Makefile | 1 -
5 files changed, 54 insertions(+), 15 deletions(-)
rename drivers/{usb => }/phy/phy-omap-usb2.c (88%)drivers/phy/Kconfig +12 -0
@@ -15,4 +15,16 @@ config GENERIC_PHY phy users can obtain reference to the PHY. All the users of this framework should select this config. +config OMAP_USB2 + tristate "OMAP USB2 PHY Driver" + depends on ARCH_OMAP2PLUS + select GENERIC_PHY + select USB_PHY + select OMAP_CONTROL_USB + help + Enable this to support the transceiver that is part of SOC. This + driver takes care of all the PHY functionality apart from comparator. + The USB OTG controller communicates with the comparator using this + driver. + endmenu
drivers/phy/Makefile +1 -0
@@ -3,3 +3,4 @@ # obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_OMAP_USB2) += phy-omap-usb2.o
drivers/phy/phy-omap-usb2.c renamed from drivers/usb/phy/phy-omap-usb2.c +41 -4
79 lines not on this page · raw message
drivers/usb/phy/Kconfig +0 -10
@@ -72,16 +72,6 @@ config OMAP_CONTROL_USB power on the USB2 PHY is present in OMAP4 and OMAP5. OMAP5 has an additional register to power on USB3 PHY. -config OMAP_USB2 - tristate "OMAP USB2 PHY Driver" - depends on ARCH_OMAP2PLUS - select OMAP_CONTROL_USB - help - Enable this to support the transceiver that is part of SOC. This - driver takes care of all the PHY functionality apart from comparator. - The USB OTG controller communicates with the comparator using this - driver. - config OMAP_USB3 tristate "OMAP USB3 PHY Driver" select OMAP_CONTROL_USB
drivers/usb/phy/Makefile +0 -1
@@ -16,7 +16,6 @@ obj-$(CONFIG_ISP1301_OMAP) += phy-isp1301-omap.o obj-$(CONFIG_MV_U3D_PHY) += phy-mv-u3d-usb.o obj-$(CONFIG_NOP_USB_XCEIV) += phy-nop.o obj-$(CONFIG_OMAP_CONTROL_USB) += phy-omap-control.o -obj-$(CONFIG_OMAP_USB2) += phy-omap-usb2.o obj-$(CONFIG_OMAP_USB3) += phy-omap-usb3.o obj-$(CONFIG_SAMSUNG_USBPHY) += phy-samsung-usb.o obj-$(CONFIG_SAMSUNG_USB2PHY) += phy-samsung-usb2.o
Signature · 1 line
1.7.10.4
Greg KH
maintainerRe: [PATCH v11 2/8] usb: phy: omap-usb2: use the new generic PHY framework
Quoted 12 lines · Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. Now the power off and power on are done in
omap_usb_power_offandomap_usb_power_onrespectively. The omap-usb2 driver is also moved to driver/phy.However using the old USB PHY library cannot be completely removed because OTG is intertwined with PHY and moving to the new framework will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library.
Signed-off-by Kishon Vijay Abraham I <[email protected]>Reviewed-by Sylwester Nawrocki <[email protected]>Acked-by Felipe Balbi <[email protected]>
Quoted 8 lines
---
drivers/phy/Kconfig | 12 +++++++++
drivers/phy/Makefile | 1 +
drivers/{usb => }/phy/phy-omap-usb2.c | 45 ++++++++++++++++++++++++++++++---
drivers/usb/phy/Kconfig | 10 --------
drivers/usb/phy/Makefile | 1 -
5 files changed, 54 insertions(+), 15 deletions(-)
rename drivers/{usb => }/phy/phy-omap-usb2.c (88%)I tried to apply this to my USB branch, but it fails.
Kishon, you were going to refresh this patch series, right? Please do, because as-is, I can't take it.
thanks,
greg k-h
Re: [PATCH v11 2/8] usb: phy: omap-usb2: use the new generic PHY framework
Hi Greg,
Quoted 22 lines · Greg KH
Quoted 12 lines · Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. Now the power off and power on are done in
omap_usb_power_offandomap_usb_power_onrespectively. The omap-usb2 driver is also moved to driver/phy.However using the old USB PHY library cannot be completely removed because OTG is intertwined with PHY and moving to the new framework will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library.
Signed-off-by Kishon Vijay Abraham I <[email protected]>Reviewed-by Sylwester Nawrocki <[email protected]>Acked-by Felipe Balbi <[email protected]>Quoted 8 lines
--- drivers/phy/Kconfig | 12 +++++++++ drivers/phy/Makefile | 1 + drivers/{usb => }/phy/phy-omap-usb2.c | 45 ++++++++++++++++++++++++++++++--- drivers/usb/phy/Kconfig | 10 -------- drivers/usb/phy/Makefile | 1 - 5 files changed, 54 insertions(+), 15 deletions(-) rename drivers/{usb => }/phy/phy-omap-usb2.c (88%)
Quoted 4 lines
I tried to apply this to my USB branch, but it fails.
Kishon, you were going to refresh this patch series, right? Please do, because as-is, I can't take it.
Just sent.
Thanks
Kishon
PATCH v11 3/8 usb: phy: twl4030: use the new generic PHY framework
In reply to Kishon Vijay Abraham IUsed the generic PHY framework API to create the PHY. For powering on and powering off the PHY, power_on and power_off ops are used. Once the MUSB OMAP glue is adapted to the new framework, the suspend and resume ops of usb phy library will be removed. Also twl4030-usb driver is moved to drivers/phy/.
However using the old usb phy library cannot be completely removed because otg is intertwined with phy and moving to the new framework completely will break otg. Once we have a separate otg state machine, we can get rid of the usb phy library.
---
drivers/phy/Kconfig | 11 ++++++
drivers/phy/Makefile | 1 +
drivers/{usb => }/phy/phy-twl4030-usb.c | 56 +++++++++++++++++++++++++++++--
drivers/usb/phy/Kconfig | 9 -----
drivers/usb/phy/Makefile | 1 -
include/linux/i2c/twl.h | 2 ++
6 files changed, 67 insertions(+), 13 deletions(-)
rename drivers/{usb => }/phy/phy-twl4030-usb.c (95%)drivers/phy/Kconfig +11 -0
@@ -27,4 +27,15 @@ config OMAP_USB2 The USB OTG controller communicates with the comparator using this driver. +config TWL4030_USB + tristate "TWL4030 USB Transceiver Driver" + depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS + select GENERIC_PHY + select USB_PHY + help + Enable this to support the USB OTG transceiver on TWL4030 + family chips (including the TWL5030 and TPS659x0 devices). + This transceiver supports high and full speed devices plus, + in host mode, low speed. + endmenu
drivers/phy/Makefile +1 -0
@@ -4,3 +4,4 @@ obj-$(CONFIG_GENERIC_PHY) += phy-core.o obj-$(CONFIG_OMAP_USB2) += phy-omap-usb2.o +obj-$(CONFIG_TWL4030_USB) += phy-twl4030-usb.o
drivers/phy/phy-twl4030-usb.c renamed from drivers/usb/phy/phy-twl4030-usb.c +53 -3
112 lines not on this page · raw message
drivers/usb/phy/Kconfig +0 -9
@@ -102,15 +102,6 @@ config SAMSUNG_USB3PHY Enable this to support Samsung USB 3.0 (Super Speed) phy controller for samsung SoCs. -config TWL4030_USB - tristate "TWL4030 USB Transceiver Driver" - depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS - help - Enable this to support the USB OTG transceiver on TWL4030 - family chips (including the TWL5030 and TPS659x0 devices). - This transceiver supports high and full speed devices plus, - in host mode, low speed. - config TWL6030_USB tristate "TWL6030 USB Transceiver Driver" depends on TWL4030_CORE && OMAP_USB2 && USB_MUSB_OMAP2PLUS
drivers/usb/phy/Makefile +0 -1
@@ -20,7 +20,6 @@ obj-$(CONFIG_OMAP_USB3) += phy-omap-usb3.o obj-$(CONFIG_SAMSUNG_USBPHY) += phy-samsung-usb.o obj-$(CONFIG_SAMSUNG_USB2PHY) += phy-samsung-usb2.o obj-$(CONFIG_SAMSUNG_USB3PHY) += phy-samsung-usb3.o -obj-$(CONFIG_TWL4030_USB) += phy-twl4030-usb.o obj-$(CONFIG_TWL6030_USB) += phy-twl6030-usb.o obj-$(CONFIG_USB_EHCI_TEGRA) += phy-tegra-usb.o obj-$(CONFIG_USB_GPIO_VBUS) += phy-gpio-vbus-usb.o
include/linux/i2c/twl.h +2 -0
@@ -26,6 +26,7 @@#define __TWL_H_#include <linux/types.h> +#include <linux/phy/phy.h> #include <linux/input/matrix_keypad.h> /*
@@ -615,6 +616,7 @@ enum twl4030_usb_mode {struct twl4030_usb_data {enum twl4030_usb_mode usb_mode;unsigned long features; +struct phy_init_data *init_data;int (*phy_init)(struct device *dev);int (*phy_exit)(struct device *dev);
Signature · 1 line
1.7.10.4
PATCH v11 4/8 arm: omap3: twl: add phy consumer data in twl4030_usb_data
In reply to Kishon Vijay Abraham IThe PHY framework uses the phy consumer data populated in platform data in the case of non-dt boot to return the reference to the PHY when the controller (PHY consumer) requests for it. So populated the phy consumer data in the platform data of twl usb.
--- arch/arm/mach-omap2/twl-common.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/arm/mach-omap2/twl-common.c +11 -0
@@ -24,6 +24,7 @@#include <linux/i2c/twl.h> #include <linux/gpio.h> #include <linux/string.h> +#include <linux/phy/phy.h> #include <linux/regulator/machine.h> #include <linux/regulator/fixed.h>
@@ -90,8 +91,18 @@ void __init omap_pmic_late_init(void) }#if defined(CONFIG_ARCH_OMAP3 ) +struct phy_consumer consumers[] = { +PHY_CONSUMER ("musb-hdrc.0" ,"usb" ), +}; + +struct phy_init_data init_data = { + .consumers = consumers, + .num_consumers =ARRAY_SIZE (consumers), +}; +static struct twl4030_usb_data omap3_usb_pdata = { .usb_mode =T2_USB_MODE_ULPI , + .init_data = &init_data, }; static int omap3_batt_table[] = {
Signature · 1 line
1.7.10.4
PATCH v11 5/8 ARM: dts: omap: update usb_otg_hs data
In reply to Kishon Vijay Abraham IUpdated the usb_otg_hs dt data to include the *phy* and *phy-names* binding in order for the driver to use the new generic PHY framework. Also updated the Documentation to include the binding information. The PHY binding information can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt
--- Documentation/devicetree/bindings/usb/omap-usb.txt | 5 +++++ Documentation/devicetree/bindings/usb/usb-phy.txt | 6 ++++++ arch/arm/boot/dts/omap3-beagle-xm.dts | 2 ++ arch/arm/boot/dts/omap3-evm.dts | 2 ++ arch/arm/boot/dts/omap3-overo.dtsi | 2 ++ arch/arm/boot/dts/omap4.dtsi | 3 +++ arch/arm/boot/dts/twl4030.dtsi | 1 + 7 files changed, 21 insertions(+)
Documentation/devicetree/bindings/usb/omap-usb.txt +5 -0
@@ -19,6 +19,9 @@ OMAP MUSB GLUE - power : Should be "50". This signifies the controller can supply up to 100mA when operating in host mode. - usb-phy : the phandle for the PHY device + - phys : the phandle for the PHY device (used by generic PHY framework) + - phy-names : the names of the PHY corresponding to the PHYs present in the + *phy* phandle. Optional properties: - ctrl-module : phandle of the control module this glue uses to write to
@@ -33,6 +36,8 @@ usb_otg_hs: usb_otg_hs at 4a0ab000 { num-eps = <16>; ram-bits = <12>; ctrl-module = <&omap_control_usb>; + phys = <&usb2_phy>; + phy-names = "usb2-phy"; }; Board specific device node entry
Documentation/devicetree/bindings/usb/usb-phy.txt +6 -0
@@ -5,6 +5,8 @@ OMAP USB2 PHY Required properties: - compatible: Should be "ti,omap-usb2" - reg : Address and length of the register set for the device. + - #phy-cells: determine the number of cells that should be given in the + phandle while referencing this phy. Optional properties: - ctrl-module : phandle of the control module used by PHY driver to power on
@@ -16,6 +18,7 @@ usb2phy at 4a0ad080 { compatible = "ti,omap-usb2"; reg = <0x4a0ad080 0x58>; ctrl-module = <&omap_control_usb>; + #phy-cells = <0>; }; OMAP USB3 PHY
@@ -25,6 +28,8 @@ Required properties: - reg : Address and length of the register set for the device. - reg-names: The names of the register addresses corresponding to the registers filled in "reg". + - #phy-cells: determine the number of cells that should be given in the + phandle while referencing this phy. Optional properties: - ctrl-module : phandle of the control module used by PHY driver to power on
@@ -39,4 +44,5 @@ usb3phy at 4a084400 { <0x4a084c00 0x40>; reg-names = "phy_rx", "phy_tx", "pll_ctrl"; ctrl-module = <&omap_control_usb>; + #phy-cells = <0>; };
arch/arm/boot/dts/omap3-beagle-xm.dts +2 -0
@@ -144,6 +144,8 @@ &usb_otg_hs { interface-type = <0>; usb-phy = <&usb2_phy>; + phys = <&usb2_phy>; + phy-names = "usb2-phy"; mode = <3>; power = <50>; };
arch/arm/boot/dts/omap3-evm.dts +2 -0
@@ -70,6 +70,8 @@ &usb_otg_hs { interface-type = <0>; usb-phy = <&usb2_phy>; + phys = <&usb2_phy>; + phy-names = "usb2-phy"; mode = <3>; power = <50>; };
arch/arm/boot/dts/omap3-overo.dtsi +2 -0
@@ -76,6 +76,8 @@ &usb_otg_hs { interface-type = <0>; usb-phy = <&usb2_phy>; + phys = <&usb2_phy>; + phy-names = "usb2-phy"; mode = <3>; power = <50>; };
arch/arm/boot/dts/omap4.dtsi +3 -0
@@ -520,6 +520,7 @@ compatible = "ti,omap-usb2"; reg = <0x4a0ad080 0x58>; ctrl-module = <&omap_control_usb>; + #phy-cells = <0>; }; };
@@ -658,6 +659,8 @@ interrupt-names = "mc", "dma"; ti,hwmods = "usb_otg_hs"; usb-phy = <&usb2_phy>; + phys = <&usb2_phy>; + phy-names = "usb2-phy"; multipoint = <1>; num-eps = <16>; ram-bits = <12>;
arch/arm/boot/dts/twl4030.dtsi +1 -0
@@ -86,6 +86,7 @@ usb1v8-supply = <&vusb1v8>; usb3v1-supply = <&vusb3v1>; usb_mode = <1>; + #phy-cells = <0>; }; twl_pwm: pwm {
Signature · 1 line
1.7.10.4
PATCH v11 6/8 usb: musb: omap2430: use the new generic PHY framework
In reply to Kishon Vijay Abraham IUse the generic PHY framework API to get the PHY. The usb_phy_set_resume and usb_phy_set_suspend is replaced with power_on and power_off to align with the new PHY framework.
musb->xceiv can't be removed as of now because musb core uses xceiv.state and xceiv.otg. Once there is a separate state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework.
--- drivers/usb/musb/Kconfig | 1 + drivers/usb/musb/musb_core.h | 2 ++ drivers/usb/musb/omap2430.c | 26 ++++++++++++++++++++------ 3 files changed, 23 insertions(+), 6 deletions(-)
drivers/usb/musb/Kconfig +1 -0
@@ -76,6 +76,7 @@ config USB_MUSB_TUSB6010 config USB_MUSB_OMAP2PLUS tristate "OMAP2430 and onwards" depends on ARCH_OMAP2PLUS + select GENERIC_PHY config USB_MUSB_AM35X tristate "AM35x"
drivers/usb/musb/musb_core.h +2 -0
@@ -46,6 +46,7 @@#include <linux/usb.h> #include <linux/usb/otg.h> #include <linux/usb/musb.h> +#include <linux/phy/phy.h> struct musb ;struct musb_hw_ep ;
@@ -346,6 +347,7 @@ struct musb {u16 int_tx;struct usb_phy *xceiv; +struct phy *phy;int nIrq; unsigned irq_wake:1;
drivers/usb/musb/omap2430.c +20 -6
@@ -348,11 +348,21 @@ static int omap2430_musb_init(struct musb *musb)* up through ULPI. TWL4030-family PMICs include one, * which needs a driver, drivers aren't always needed. */ -if (dev->parent->of_node) +if (dev->parent->of_node) { + musb->phy =devm_phy_get (dev->parent,"usb2-phy" ); + +/* We can't totally remove musb->xceiv as of now because +* musb core uses xceiv.state and xceiv.otg. Once we have +* a separate state machine to handle otg, these can be moved +* out of xceiv and then we can start using the generic PHY +* framework +*/ musb->xceiv =devm_usb_get_phy_by_phandle (dev->parent,"usb-phy" ,0 ); -else + }else { musb->xceiv =devm_usb_get_phy_dev (dev,0 ); + musb->phy =devm_phy_get (dev,"usb" ); + }if (IS_ERR (musb->xceiv)) { status =PTR_ERR (musb->xceiv);
@@ -364,6 +374,10 @@ static int omap2430_musb_init(struct musb *musb)return -EPROBE_DEFER ; } +if (IS_ERR (musb->phy)) { +pr_err ("HS USB OTG: no PHY configured\n" ); +return PTR_ERR (musb->phy); + } musb->isr = omap2430_musb_interrupt; status =pm_runtime_get_sync (dev);
@@ -397,7 +411,7 @@ static int omap2430_musb_init(struct musb *musb)if (glue->status !=OMAP_MUSB_UNKNOWN )omap_musb_set_mailbox (glue); -usb_phy_init (musb->xceiv); +phy_init (musb->phy);pm_runtime_put_noidle (musb->controller);return 0 ;
@@ -460,6 +474,7 @@ static int omap2430_musb_exit(struct musb *musb)del_timer_sync (&musb_idle_timer);omap2430_low_level_exit (musb); +phy_exit (musb->phy);return 0 ; }
@@ -638,7 +653,7 @@ static int omap2430_runtime_suspend(struct device *dev) OTG_INTERFSEL);omap2430_low_level_exit (musb); -usb_phy_set_suspend (musb->xceiv,1 ); +phy_power_off (musb->phy); }return 0 ;
@@ -653,8 +668,7 @@ static int omap2430_runtime_resume(struct device *dev)omap2430_low_level_init (musb);musb_writel (musb->mregs,OTG_INTERFSEL , musb->context.otg_interfsel); - -usb_phy_set_suspend (musb->xceiv,0 ); +phy_power_on (musb->phy); }return 0 ;
Signature · 1 line
1.7.10.4
PATCH v11 7/8 usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2
In reply to Kishon Vijay Abraham INow that omap-usb2 is adapted to the new generic PHY framework, *set_suspend* ops can be removed from omap-usb2 driver.
--- drivers/phy/phy-omap-usb2.c | 25 ------------------------- 1 file changed, 25 deletions(-)
drivers/phy/phy-omap-usb2.c +0 -25
@@ -97,29 +97,6 @@ static int omap_usb_set_peripheral(struct usb_otg *otg,return 0 ; } -static int omap_usb2_suspend (struct usb_phy *x,int suspend) -{ -u32 ret; -struct omap_usb *phy =phy_to_omapusb (x); - -if (suspend && !phy->is_suspended) { -omap_control_usb_phy_power (phy->control_dev,0 ); -pm_runtime_put_sync (phy->dev); - phy->is_suspended =1 ; - }else if (!suspend && phy->is_suspended) { - ret =pm_runtime_get_sync (phy->dev); -if (ret <0 ) { -dev_err (phy->dev,"get_sync failed with err %d\n" , - ret); -return ret; - } -omap_control_usb_phy_power (phy->control_dev,1 ); - phy->is_suspended =0 ; - } - -return 0 ; -} -static int omap_usb_power_off (struct phy *x) {struct omap_usb *phy =phy_get_drvdata (x);
@@ -167,7 +144,6 @@ static int omap_usb2_probe(struct platform_device *pdev) phy->phy.dev = phy->dev; phy->phy.label ="omap-usb2" ; - phy->phy.set_suspend = omap_usb2_suspend; phy->phy.otg = otg; phy->phy.type =USB_PHY_TYPE_USB2 ;
@@ -182,7 +158,6 @@ static int omap_usb2_probe(struct platform_device *pdev)return -ENODEV ; } - phy->is_suspended =1 ;omap_control_usb_phy_power (phy->control_dev,0 ); otg->set_host = omap_usb_set_host;
Signature · 1 line
1.7.10.4
PATCH v11 8/8 usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops
In reply to Kishon Vijay Abraham INow that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver.
--- drivers/phy/phy-twl4030-usb.c | 57 ++++++++++------------------------------- 1 file changed, 13 insertions(+), 44 deletions(-)
drivers/phy/phy-twl4030-usb.c +13 -44
@@ -422,25 +422,20 @@ static void twl4030_phy_power(struct twl4030_usb *twl, int on) } } -static void twl4030_phy_suspend (struct twl4030_usb *twl,int controller_off) +static int twl4030_phy_power_off (struct phy *phy) { +struct twl4030_usb *twl =phy_get_drvdata (phy); +if (twl->asleep) -return ; +return 0 ;twl4030_phy_power (twl,0 ); twl->asleep =1 ;dev_dbg (twl->dev,"%s\n" , __func__); -} - -static int twl4030_phy_power_off (struct phy *phy) -{ -struct twl4030_usb *twl =phy_get_drvdata (phy); - -twl4030_phy_suspend (twl,0 );return 0 ; } -static void __twl4030_phy_resume (struct twl4030_usb *twl) +static void __twl4030_phy_power_on (struct twl4030_usb *twl) {twl4030_phy_power (twl,1 );twl4030_i2c_access (twl,1 );
@@ -449,11 +444,13 @@ static void __twl4030_phy_resume(struct twl4030_usb *twl)twl4030_i2c_access (twl,0 ); } -static void twl4030_phy_resume (struct twl4030_usb *twl) +static int twl4030_phy_power_on (struct phy *phy) { +struct twl4030_usb *twl =phy_get_drvdata (phy); +if (!twl->asleep) -return ; -__twl4030_phy_resume (twl); +return 0 ; +__twl4030_phy_power_on (twl); twl->asleep =0 ;dev_dbg (twl->dev,"%s\n" , __func__);
@@ -466,13 +463,6 @@ static void twl4030_phy_resume(struct twl4030_usb *twl)cancel_delayed_work (&twl->id_workaround_work);schedule_delayed_work (&twl->id_workaround_work,HZ ); } -} - -static int twl4030_phy_power_on (struct phy *phy) -{ -struct twl4030_usb *twl =phy_get_drvdata (phy); - -twl4030_phy_resume (twl);return 0 ; }
@@ -604,9 +594,9 @@ static void twl4030_id_workaround_work(struct work_struct *work) } } -static int twl4030_usb_phy_init (struct usb_phy *phy) +static int twl4030_phy_init (struct phy *phy) { -struct twl4030_usb *twl =phy_to_twl (phy); +struct twl4030_usb *twl =phy_get_drvdata (phy);enum omap_musb_vbus_id_status status;/*
@@ -621,32 +611,13 @@ static int twl4030_usb_phy_init(struct usb_phy *phy)if (status ==OMAP_MUSB_ID_GROUND || status ==OMAP_MUSB_VBUS_VALID ) {omap_musb_mailbox (twl->linkstat); -twl4030_phy_resume (twl); +twl4030_phy_power_on (phy); }sysfs_notify (&twl->dev->kobj,NULL ,"vbus" );return 0 ; } -static int twl4030_phy_init (struct phy *phy) -{ -struct twl4030_usb *twl =phy_get_drvdata (phy); - -return twl4030_usb_phy_init (&twl->phy); -} - -static int twl4030_set_suspend (struct usb_phy *x,int suspend) -{ -struct twl4030_usb *twl =phy_to_twl (x); - -if (suspend) -twl4030_phy_suspend (twl,1 ); -else -twl4030_phy_resume (twl); - -return 0 ; -} -static int twl4030_set_peripheral (struct usb_otg *otg,struct usb_gadget *gadget) {
@@ -719,8 +690,6 @@ static int twl4030_usb_probe(struct platform_device *pdev) twl->phy.label ="twl4030" ; twl->phy.otg = otg; twl->phy.type =USB_PHY_TYPE_USB2 ; - twl->phy.set_suspend = twl4030_set_suspend; - twl->phy.init = twl4030_usb_phy_init; otg->phy = &twl->phy; otg->set_host = twl4030_set_host;
Signature · 1 line
1.7.10.4
Hi Greg,
Quoted 15 lines · Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to
drivers/phyto increase code re-use and to increase code maintainability.Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
Quoted 6 lines
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
You can find this patch series @
git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.gittesting
Looks like there are not further comments on this series. Can you take this in your misc tree?
Thanks
Kishon
Hi,
Quoted 20 lines · Kishon Vijay Abraham I
Quoted 19 lines · Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to
drivers/phyto increase code re-use and to increase code maintainability.Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
Quoted 5 lines
Quoted 2 lines
You can find this patch series @
git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.gittestingLooks like there are not further comments on this series. Can you take this in your misc tree?
Do you want me to queue these for you ? There are quite a few users for this framework already and I know of at least 2 others which will show up for v3.13.
Let me know.
cheers
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130827/4ffdfd07/attachment-0001.sig>
Hi,
Quoted 26 lines · Felipe Balbi
Hi,
Quoted 23 lines · Kishon Vijay Abraham I
Quoted 21 lines · Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to
drivers/phyto increase code re-use and to increase code maintainability.Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
You can find this patch series @
git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.gittesting
Quoted 6 lines
Quoted 2 lines
Looks like there are not further comments on this series. Can you take this in your misc tree?
Do you want me to queue these for you ? There are quite a few users for this framework already and I know of at least 2 others which will show up for v3.13.
yeah sure. That would be better I think.
Thanks
Kishon
Hi Greg,
Quoted 26 lines · Felipe Balbi
Hi,
Quoted 23 lines · Kishon Vijay Abraham I
Quoted 21 lines · Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to
drivers/phyto increase code re-use and to increase code maintainability.Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
You can find this patch series @
git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.gittesting
Quoted 6 lines
Quoted 2 lines
Looks like there are not further comments on this series. Can you take this in your misc tree?
Do you want me to queue these for you ? There are quite a few users for this framework already and I know of at least 2 others which will show up for v3.13.
Can you queue this patch series? There are quite a few users already for this framework.
Thanks
Kishon
Greg KH
maintainerQuoted 32 lines · Kishon Vijay Abraham I
Hi Greg,
Quoted 29 lines · Felipe Balbi
Hi,
Quoted 25 lines · Kishon Vijay Abraham I
Quoted 15 lines · Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to
drivers/phyto increase code re-use and to increase code maintainability.Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
Quoted 6 lines
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
You can find this patch series @
git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.gittestingLooks like there are not further comments on this series. Can you take this in your misc tree?
Quoted 6 lines
Quoted 3 lines
Do you want me to queue these for you ? There are quite a few users for this framework already and I know of at least 2 others which will show up for v3.13.
Can you queue this patch series? There are quite a few users already for this framework.
It will have to wait for 3.13 as the merge window for new features has been closed for a week or so. Sorry, I'll queue this up after 3.12-rc1 is out.
greg k-h
Quoted 37 lines · Greg KH
Quoted 36 lines · Kishon Vijay Abraham I
Hi Greg,
Quoted 32 lines · Felipe Balbi
Hi,
Quoted 20 lines · Kishon Vijay Abraham I
Quoted 19 lines · Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to
drivers/phyto increase code re-use and to increase code maintainability.Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
Quoted 5 lines
Quoted 2 lines
You can find this patch series @
git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.gittestingLooks like there are not further comments on this series. Can you take this in your misc tree?
Do you want me to queue these for you ? There are quite a few users for this framework already and I know of at least 2 others which will show up for v3.13.
Quoted 6 lines
Quoted 2 lines
Can you queue this patch series? There are quite a few users already for this framework.
It will have to wait for 3.13 as the merge window for new features has been closed for a week or so. Sorry, I'll queue this up after 3.12-rc1 is out.
Alright, thanks.
-Kishon
Quoted 38 lines · Kishon Vijay Abraham I
Quoted 37 lines · Greg KH
Quoted 36 lines · Kishon Vijay Abraham I
Hi Greg,
Quoted 32 lines · Felipe Balbi
Hi,
Quoted 20 lines · Kishon Vijay Abraham I
Quoted 19 lines · Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to
drivers/phyto increase code re-use and to increase code maintainability.Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
Quoted 5 lines
Quoted 2 lines
You can find this patch series @
git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.gittestingLooks like there are not further comments on this series. Can you take this in your misc tree?
Do you want me to queue these for you ? There are quite a few users for this framework already and I know of at least 2 others which will show up for v3.13.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Can you queue this patch series? There are quite a few users already for this framework.
It will have to wait for 3.13 as the merge window for new features has been closed for a week or so. Sorry, I'll queue this up after 3.12-rc1 is out.
Alright, thanks.
Just a gentle ping on this one...
cheers
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130917/3deed190/attachment.sig>
Hi Greg,
Quoted 42 lines · Felipe Balbi
Quoted 41 lines · Kishon Vijay Abraham I
Quoted 40 lines · Greg KH
Quoted 38 lines · Kishon Vijay Abraham I
Hi Greg,
Quoted 26 lines · Felipe Balbi
Hi,
Quoted 23 lines · Kishon Vijay Abraham I
Quoted 21 lines · Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to
drivers/phyto increase code re-use and to increase code maintainability.Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
You can find this patch series @
git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.gittestingQuoted 6 lines
Quoted 2 lines
Looks like there are not further comments on this series. Can you take this in your misc tree?
Do you want me to queue these for you ? There are quite a few users for this framework already and I know of at least 2 others which will show up for v3.13.
Can you queue this patch series? There are quite a few users already for this framework.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
It will have to wait for 3.13 as the merge window for new features has been closed for a week or so. Sorry, I'll queue this up after 3.12-rc1 is out.
Alright, thanks.
Just a gentle ping on this one...
Let me know if you want me to rebase this patch series on the latest mainline HEAD.
Thanks
Kishon
Greg KH
maintainerQuoted 49 lines · Kishon Vijay Abraham I
Hi Greg,
Quoted 46 lines · Felipe Balbi
Quoted 45 lines · Kishon Vijay Abraham I
Quoted 43 lines · Greg KH
Quoted 32 lines · Kishon Vijay Abraham I
Hi Greg,
Quoted 29 lines · Felipe Balbi
Hi,
Quoted 25 lines · Kishon Vijay Abraham I
Quoted 15 lines · Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).
The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to
drivers/phyto increase code re-use and to increase code maintainability.Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.
Quoted 6 lines
If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.
You can find this patch series @
git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.gittestingLooks like there are not further comments on this series. Can you take this in your misc tree?
Quoted 6 lines
Quoted 3 lines
Do you want me to queue these for you ? There are quite a few users for this framework already and I know of at least 2 others which will show up for v3.13.
Can you queue this patch series? There are quite a few users already for this framework.
It will have to wait for 3.13 as the merge window for new features has been closed for a week or so. Sorry, I'll queue this up after 3.12-rc1 is out.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Alright, thanks.
Just a gentle ping on this one...
Let me know if you want me to rebase this patch series on the latest mainline HEAD.
Yes please.