Skip to contentSkip to conversation

hso: Earlier catch of error condition

PATCH Applied Daniel Gimpelevich 3 participants 3 messages Aug 21, 2013 – Aug 22, 2013

Subsystems (4)
Networking Network drivers USB networking drivers Hso 3G modem driver
lore
Share & tools
lore

Daniel Gimpelevich

author
#0 lore raw

PATCH 1/2 hso: Earlier catch of error condition

There is no need to get an interface specification if we know it's the wrong one.

Signed-off-by Daniel Gimpelevich <[email protected]>
---
 drivers/net/usb/hso.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/net/usb/hso.c +5 -4
index cba1d46..5fb36ed 100644
@@ -2886,6 +2886,11 @@ static int hso_probe(struct usb_interface *interface,
 	struct hso_shared_int *shared_int;
 	struct hso_device *tmp_dev = NULL;
 
+	if (interface->cur_altsetting->desc.bInterfaceClass != 0xFF) {
+		dev_err(&interface->dev, "Not our interface\n");
+		return -ENODEV;
+	}
+
 	if_num = interface->altsetting->desc.bInterfaceNumber;
 
 	/* Get the interface/port specification from either driver_info or from

@@ -2895,10 +2900,6 @@ static int hso_probe(struct usb_interface *interface,
 	else
 		port_spec = hso_get_config_data(interface);
 
-	if (interface->cur_altsetting->desc.bInterfaceClass != 0xFF) {
-		dev_err(&interface->dev, "Not our interface\n");
-		return -ENODEV;
-	}
 	/* Check if we need to switch to alt interfaces prior to port
 	 * configuration */
 	if (interface->num_altsetting > 1)
Signature · 1 line
1.7.9.5