Skip to contentSkip to conversation

acpi-dma, doc: append managed function to the list

PATCH Applied Andy Shevchenko 3 participants 4 messages Aug 21, 2013 – Aug 25, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 acpi-dma, doc: append managed function to the list

ACPI DMA provides managed function to register the slave DMA controller in the internal container. This patch anounces that function in the corresponding documentation file.

---
 Documentation/driver-model/devres.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/driver-model/devres.txt +3 -0
index fb57d85..fcb34a5 100644
@@ -299,3 +299,6 @@ PWM
 PHY
   devm_usb_get_phy()
   devm_usb_put_phy()
+
+SLAVE DMA ENGINE
+  devm_acpi_dma_controller_register()
Signature · 1 line
1.8.4.rc2
#1 lore raw

PATCH 2/2 acpi-dma: remove ugly conversion

In case of big endian CPU we have to convert either all fields in the structure or leave this job to ACPICA. The second choice seems the best.

So, let's remove the ugly conversion that is not fully comprehensive anyway.

---
 drivers/dma/acpi-dma.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/dma/acpi-dma.c +1 -3
index ba7f932..e69b03c 100644
@@ -43,7 +43,6 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp,
 	struct list_head resource_list;
 	struct resource_list_entry *rentry;
 	resource_size_t mem = 0, irq = 0;
-	u32 vendor_id;
 	int ret;
 
 	if (grp->shared_info_length != sizeof(struct acpi_csrt_shared_info))
@@ -73,9 +72,8 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp,
 	if (si->mmio_base_low != mem || si->gsi_interrupt != irq)
 		return 0;
 
-	vendor_id = le32_to_cpu((__force __le32)grp->vendor_id);
 	dev_dbg(&adev->dev, "matches with %.4s%04X (rev %u)\n",
-		(char *)&vendor_id, grp->device_id, grp->revision);
+		(char *)&grp->vendor_id, grp->device_id, grp->revision);
 
 	/* Check if the request line range is available */
 	if (si->base_request_line == 0 && si->num_handshake_signals == 0)
Signature · 1 line
1.8.4.rc2
Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] acpi-dma: remove ugly conversion

Quoted 7 lines · Andy Shevchenko

In case of big endian CPU we have to convert either all fields in the structure or leave this job to ACPICA. The second choice seems the best.

So, let's remove the ugly conversion that is not fully comprehensive anyway.

Applied
#3 lore raw
In reply to Andy Shevchenko
Quoted 3 lines · Andy Shevchenko

ACPI DMA provides managed function to register the slave DMA controller in the internal container. This patch anounces that function in the corresponding documentation file.

Applied, thanks

~Vinod