Skip to contentSkip to conversation

drivers/infiniband: fix too big NAPI weights

PATCH New Michal Schmidt 1 participant 3 messages Aug 21, 2013 1 message not in the archive InfiniBand

lore
Share & tools
lore

Michal Schmidt

author
#0 lore raw

cover drivers/infiniband: fix too big NAPI weights

Some drivers request too big NAPI weights and would trigger the error message in netif_napi_add() added in commit 82dc3c63. Let's fix them.

Michal Schmidt (2):
IB/nes: lower NAPI weight
IB/ipoib: lower NAPI weight

 drivers/infiniband/hw/nes/nes_nic.c       | 2 +-
 drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 6 lines
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1377103822-1752-1-git-send-email-mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org

author
#2 lore raw

PATCH 1/2 IB/nes: lower NAPI weight

Since commit 82dc3c63 netif_napi_add() produces an error message if a NAPI poll weight greater than 64 is requested.

Use the standard NAPI weight.

Signed-off-by Michal Schmidt <[email protected]>
CC Faisal Latif <[email protected]>
CC Roland Dreier <[email protected]>
CC Sean Hefty <[email protected]>
CC Hal Rosenstock <[email protected]>
---
 drivers/infiniband/hw/nes/nes_nic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/nes/nes_nic.c +1 -1
index 49eb511..0eb34a9 100644
@@ -1679,7 +1679,7 @@ struct net_device *nes_netdev_init(struct nes_device *nesdev,
 	netdev->type = ARPHRD_ETHER;
 	netdev->netdev_ops = &nes_netdev_ops;
 	netdev->ethtool_ops = &nes_ethtool_ops;
-	netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);
+	netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, NAPI_POLL_WEIGHT);
 	nes_debug(NES_DBG_INIT, "Enabling VLAN Insert/Delete.\n");
 
 	/* Fill in the port structure */
Signature · 6 lines
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#3 lore raw

PATCH 2/2 IB/ipoib: lower NAPI weight

In reply to a message not in the archive

Since commit 82dc3c63 netif_napi_add() produces an error message if a NAPI poll weight greater than 64 is requested.

Use the standard NAPI weight.

Signed-off-by Michal Schmidt <[email protected]>
CC Roland Dreier <[email protected]>
CC Sean Hefty <[email protected]>
CC Hal Rosenstock <[email protected]>
CC Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/ulp/ipoib/ipoib_main.c +1 -1
index 82cec1a..57fb116 100644
@@ -1350,7 +1350,7 @@ void ipoib_setup(struct net_device *dev)
 
 	ipoib_set_ethtool_ops(dev);
 
-	netif_napi_add(dev, &priv->napi, ipoib_poll, 100);
+	netif_napi_add(dev, &priv->napi, ipoib_poll, NAPI_POLL_WEIGHT);
 
 	dev->watchdog_timeo	 = HZ;
Signature · 6 lines
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html