checkpatch.pl: false warning about "-p0 patch"
Hello,
I have received what appears to be a false warning from checkpatch.pl when checking a patch named 'b':
$ scripts/checkpatch.pl b
WARNING: patch prefix 'b' exists, appears to be a -p0 patchtotal: 0 errors, 1 warnings, 16 lines checked
b has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
It appears that I can trigger this warning with any arbitrary commit. The following bash script gives me at least one warning for everything in Linus' tree:
for i in {0..100}
do
git format-patch -1 HEAD~$i --stdout > b
scripts/checkpatch.pl b
doneI have also seen this warning on patches with other names, but I'm not reproducing that right now.
Brian
Quoted 1 line · Brian Norris
Hello,
Hello.
Quoted 17 lines
I have received what appears to be a false warning from checkpatch.pl when checking a patch named 'b':
$ scripts/checkpatch.pl b WARNING: patch prefix 'b' exists, appears to be a -p0 patchtotal: 0 errors, 1 warnings, 16 lines checked
b has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in
MAINTAINERS.It appears that I can trigger this warning with any arbitrary commit. The following bash script gives me at least one warning for everything in Linus' tree:
Quoted 8 lines
for i in {0..100} do git format-patch -1 HEAD~$i --stdout > b scripts/checkpatch.pl b doneI have also seen this warning on patches with other names, but I'm not reproducing that right now.
checkpatch can use stdin as well as files/patches.
Try this instead of creating a temporary file:
for i in {0..100}
do
git format-patch -1 --stdout HEAD~$1 | ./scripts/checkpatch.pl -
done
Quoted 31 lines · Joe Perches
Quoted 1 line · Brian Norris
Hello,
Hello.
Quoted 17 lines
I have received what appears to be a false warning from checkpatch.pl when checking a patch named 'b':
$ scripts/checkpatch.pl b WARNING: patch prefix 'b' exists, appears to be a -p0 patchtotal: 0 errors, 1 warnings, 16 lines checked
b has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in
MAINTAINERS.It appears that I can trigger this warning with any arbitrary commit. The following bash script gives me at least one warning for everything in Linus' tree:
Quoted 8 lines
for i in {0..100} do git format-patch -1 HEAD~$i --stdout > b scripts/checkpatch.pl b doneI have also seen this warning on patches with other names, but I'm not reproducing that right now.
Quoted 8 lines
checkpatch can use stdin as well as files/patches.
Try this instead of creating a temporary file:
for i in {0..100}
dogit format-patch -1 --stdout HEAD~$1 | ./scripts/checkpatch.pl -done
Thanks for the tip. This for-loop was just a litmus test to show that checkpatch.pl is indeed failing simply because of the filename of 'b'. So I would consider that a checkpatch.pl bug.
But now, I realized the problem is simply with the existence of a file named 'b'. That is, checkpatch will give a warning for this:
touch b
git format-patch -1 --stdout | scripts/checkpatch.pl -
WARNING: patch prefix 'b' exists, appears to be a -p0 patch
WARNING: patch prefix 'b' exists, appears to be a -p0 patch
WARNING: patch prefix 'b' exists, appears to be a -p0 patch
...
Is that expected?
Brian
Quoted 6 lines · Brian Norris
I realized the problem is simply with the existence of a file named 'b'. That is, checkpatch will give a warning for this:
touch b
git format-patch -1 --stdout |scripts/checkpatch.pl-
WARNING: patch prefix 'b' exists, appears to be a -p0 patch
Is that expected?
Yes. Basically, don't have a file (or a directory) named a or b in the kernel root directory.
if (!$file && $tree && $p1_prefix ne '' &&
-e "$root/$p1_prefix") {
WARN("PATCH_PREFIX",
"patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
}