Skip to contentSkip to conversation

staging: rtl8187se: Remove pt_regs * irq handler parameter

PATCH Superseded navin patidar 2 participants 2 messages Aug 23, 2013 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8187se: Remove pt_regs * irq handler parameter

struct pt_regs pointer is no longer passed as a irq handler argument.

---
 drivers/staging/rtl8187se/r8180_core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8187se/r8180_core.c +2 -2
index ca69155..d722bed 100644
@@ -197,7 +197,7 @@ inline void force_pci_posting(struct net_device *dev)
 	mb();
 }
 
-irqreturn_t rtl8180_interrupt(int irq, void *netdev, struct pt_regs *regs);
+static irqreturn_t rtl8180_interrupt(int irq, void *netdev);
 void set_nic_rxring(struct net_device *dev);
 void set_nic_txring(struct net_device *dev);
 static struct net_device_stats *rtl8180_stats(struct net_device *dev);
@@ -3537,7 +3537,7 @@ void rtl8180_tx_isr(struct net_device *dev, int pri, short error)
 	spin_unlock_irqrestore(&priv->tx_lock, flag);
 }
 
-irqreturn_t rtl8180_interrupt(int irq, void *netdev, struct pt_regs *regs)
+irqreturn_t rtl8180_interrupt(int irq, void *netdev)
 {
 	struct net_device *dev = (struct net_device *) netdev;
 	struct r8180_priv *priv = (struct r8180_priv *)ieee80211_priv(dev);
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 3 lines · navin patidar

struct pt_regs pointer is no longer passed as a irq handler argument.

Good eye.

Could you also remove the cast to (void *) so the compiler can catch this in the future?

- if (request_irq(dev->irq, (void *)rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {
+ if (request_irq(dev->irq, rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {

regrds,
dan carpenter