Skip to contentSkip to conversation

Drivers: hv: vmbus: Do not attempt to negoatiate a new version prematurely

PATCH New K. Y. Srinivasan 1 participant 1 message Aug 28, 2013 Hyper-V/Azure core and drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Drivers: hv: vmbus: Do not attempt to negoatiate a new version prematurely

The current code would attempt to negotiate a different protocol version if the current negotiation timed out. This triggers an assert in the host (on debug builds). Avoid this by negotiating a newer version only if the host properly rejects the current version being negotiated.

---
 drivers/hv/connection.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/hv/connection.c +4 -1
index ec3b8cd..8f4743a 100644
@@ -195,7 +195,10 @@ int vmbus_connect(void)
 
 	do {
 		ret = vmbus_negotiate_version(msginfo, version);
-		if (ret == 0)
+		if (ret)
+			goto cleanup;
+
+		if (vmbus_connection.conn_state == CONNECTED)
 			break;
 
 		version = vmbus_get_next_version(version);
Signature · 1 line
1.7.4.1