Skip to contentSkip to conversation

samsung-laptop: fix config build error

PATCH Applied Randy Dunlap 2 participants 2 messages Aug 22, 2013 – Sep 3, 2013 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 samsung-laptop: fix config build error

From: Randy Dunlap <[email protected]>

Fix build failure when ACPI_VIDEO=m and SAMSUNG_LAPTOP=y. The patch prevents that specific config combination.

drivers/built-in.o: In function `samsung_init':
samsung-laptop.c:(.init.text+0x128ff): undefined reference to `acpi_video_unregister'

build testing:
ACPI_VIDEO=m, SAMSUNG_LAPTOP=m: OK
ACPI_VIDEO=y, SAMSUNG_LAPTOP=m: OK
ACPI_VIDEO=y, SAMSUNG_LAPTOP=y: OK
ACPI=n, SAMSUNG_LAPTOP=y: OK
ACPI=n, SAMSUNG_LAPTOP=m: OK

---
 drivers/platform/x86/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/Kconfig +1 -0
@@ -732,6 +732,7 @@ config SAMSUNG_LAPTOP
 	tristate "Samsung Laptop driver"
 	depends on X86
 	depends on RFKILL || RFKILL = n
+	depends on ACPI_VIDEO || ACPI_VIDEO = n
 	depends on BACKLIGHT_CLASS_DEVICE
 	select LEDS_CLASS
 	select NEW_LEDS
#1 lore raw
Quoted 4 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build failure when ACPI_VIDEO=m and SAMSUNG_LAPTOP=y. The patch prevents that specific config combination.

Applied, thanks.

Signature · 1 line
Matthew Garrett <[email protected]>