Bluetooth: Use GFP_KERNEL when cloning SKB in a workqueue
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/1 Bluetooth: Use GFP_KERNEL when cloning SKB in a workqueue
There is no need to use GFP_ATOMIC with skb_clone() when the code is executed in a workqueue.
Signed-off-by Marcel Holtmann <[email protected]>
--- net/bluetooth/hci_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/hci_core.c +1 -1
@@ -3537,7 +3537,7 @@ static void hci_cmd_work(struct work_struct *work)kfree_skb (hdev->sent_cmd); - hdev->sent_cmd =skb_clone (skb,GFP_ATOMIC ); + hdev->sent_cmd =skb_clone (skb,GFP_KERNEL );if (hdev->sent_cmd) {atomic_dec (&hdev->cmd_cnt);hci_send_frame (skb);
Signature · 1 line
1.8.3.1
Hi Marcel,
Quoted 7 lines · Marcel Holtmann
There is no need to use
GFP_ATOMICwithskb_clone()when the code is executed in a workqueue.Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/hci_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by Johan Hedberg <[email protected]>
Johan
Hi Marcel,
2013-09-03 Marcel Holtmann <[email protected]>:
Quoted 7 lines
There is no need to use
GFP_ATOMICwithskb_clone()when the code is executed in a workqueue.Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/hci_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch has been applied to bluetooth-next. Thanks.
Gustavo