Nested VMX: fix bugs during reading VMX MSRs.
cover Nested VMX: fix bugs during reading VMX MSRs.
From: Yang Zhang <[email protected]>
The following patches fix the issues which existing in current vmx msr reading logic.
Yang Zhang (3):
Nested VMX: Check VMX capability before read VMX related MSRs. Nested VMX: Clear bit 31 of IA32_VMX_BASIC MSR Nested VMX: Fix IA32_VMX_CR4_FIXED1 msr emulation
xen/arch/x86/hvm/vmx/vvmx.c | 54 ++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 51 insertions(+), 3 deletions(-)
PATCH 1/3 Nested VMX: Check VMX capability before read VMX related MSRs.
From: Yang Zhang <[email protected]>
VMX MSRs only available when the CPU support the VMX feature. In addition, VMX_TRUE* MSRs only available when bitt 55 of VMX_BASIC MSR is set.
--- xen/arch/x86/hvm/vmx/vvmx.c | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-)
xen/arch/x86/hvm/vmx/vvmx.c +18 -0
@@ -1820,6 +1820,24 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content)if ( !nestedhvm_enabled (v->domain) )return 0 ; +/* +* VMX capablitys MSRs available only when guest +* support VMX. +*/ +hvm_cpuid (0x1 , &eax, &ebx, &ecx, &edx); +if ( !(ecx &cpufeat_mask (X86_FEATURE_VMXE )) ) +return 0 ; + +/* +* Those MSRs available only when bit 55 of +* MSR_IA32_VMX_BASIC is set. +*/ +rdmsrl (MSR_IA32_VMX_BASIC , data); +if ( msr >=MSR_IA32_VMX_TRUE_PINBASED_CTLS && + msr <=MSR_IA32_VMX_TRUE_ENTRY_CTLS && + !(data &VMX_BASIC_DEFAULT1_ZERO ) ) +return 0 ; +rdmsrl (msr, host_data);/*
Signature · 1 line
1.7.1
Re: [PATCH 1/3] Nested VMX: Check VMX capability before read VMX related MSRs.
Quoted 14 lines
Quoted 1 line
Quoted 1 line · Yang Zhang
xen/arch/x86/hvm/vmx/vvmx.c +6
-0@@ -1820,6 +1820,24 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content)if ( !nestedhvm_enabled (v->domain) )return 0 ; +/* +* VMX capablitys MSRs available only when guest +* support VMX. +*/ +hvm_cpuid (0x1 , &eax, &ebx, &ecx, &edx); +if ( !(ecx &cpufeat_mask (X86_FEATURE_VMXE )) )
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 · line 1839
Quoted 10 lines
xen/arch/x86/hvm/vmx/vvmx.c +10
-0+return 0 ; + +/* +* Those MSRs available only when bit 55 of +* MSR_IA32_VMX_BASIC is set. +*/ +rdmsrl (MSR_IA32_VMX_BASIC , data); +if ( msr >=MSR_IA32_VMX_TRUE_PINBASED_CTLS && + msr <=MSR_IA32_VMX_TRUE_ENTRY_CTLS && + !(data &VMX_BASIC_DEFAULT1_ZERO ) )
Indentation.
Jan
Quoted 5 lines
xen/arch/x86/hvm/vmx/vvmx.c +2
-0+return 0 ; +rdmsrl (msr, host_data);/*
Re: [PATCH 1/3] Nested VMX: Check VMX capability before read VMX related MSRs.
In reply to Yang ZhangQuoted 4 lines · Yang Zhang
From: Yang Zhang <[email protected]>
VMX MSRs only available when the CPU support the VMX feature. In addition, VMX_TRUE* MSRs only available when bitt 55 of
VMX_BASICMSR is set.
As you already have to respin the patch, "bit" rather than "bitt"
~Andrew
Quoted 35 lines
Signed-off-by Yang Zhang <[email protected]>--- xen/arch/x86/hvm/vmx/vvmx.c | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-)xen/arch/x86/hvm/vmx/vvmx.c +18
-0@@ -1820,6 +1820,24 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content)if ( !nestedhvm_enabled (v->domain) )return 0 ; +/* +* VMX capablitys MSRs available only when guest +* support VMX. +*/ +hvm_cpuid (0x1 , &eax, &ebx, &ecx, &edx); +if ( !(ecx &cpufeat_mask (X86_FEATURE_VMXE )) ) +return 0 ; + +/* +* Those MSRs available only when bit 55 of +* MSR_IA32_VMX_BASIC is set. +*/ +rdmsrl (MSR_IA32_VMX_BASIC , data); +if ( msr >=MSR_IA32_VMX_TRUE_PINBASED_CTLS && + msr <=MSR_IA32_VMX_TRUE_ENTRY_CTLS && + !(data &VMX_BASIC_DEFAULT1_ZERO ) ) +return 0 ; +rdmsrl (msr, host_data);/*
PATCH 2/3 Nested VMX: Clear bit 31 of IA32_VMX_BASIC MSR
In reply to Yang ZhangFrom: Yang Zhang <[email protected]>
The bit 31 of revision_id will set to 1 if vmcs shadowing enabled. And according intel SDM, the bit 31 of IA32_VMX_BASIC MSR is always 0. So we cannot set low 32 bit of IA32_VMX_BASIC to revision_id directly. Must clear the bit 31 to 0.
--- xen/arch/x86/hvm/vmx/vvmx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
xen/arch/x86/hvm/vmx/vvmx.c +1 -1
@@ -1846,7 +1846,7 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content)switch (msr) {case MSR_IA32_VMX_BASIC : data = (host_data & (~0ul <<32 )) | - ((v->arch.hvm_vmx.vmcs)->vmcs_revision_id); + ((v->arch.hvm_vmx.vmcs)->vmcs_revision_id & ~(1ul <<31 ));break ;case MSR_IA32_VMX_PINBASED_CTLS :case MSR_IA32_VMX_TRUE_PINBASED_CTLS :
Signature · 1 line
1.7.1
Re: [PATCH 2/3] Nested VMX: Clear bit 31 of IA32_VMX_BASIC MSR
Quoted 17 lines · Yang Zhang
From: Yang Zhang <[email protected]>
The bit 31 of
revision_idwill set to 1 if vmcs shadowing enabled. And according intel SDM, the bit 31 ofIA32_VMX_BASICMSR is always 0. So we cannot set low 32 bit ofIA32_VMX_BASICtorevision_iddirectly. Must clear the bit 31 to 0.Signed-off-by Yang Zhang <[email protected]>--- xen/arch/x86/hvm/vmx/vvmx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)xen/arch/x86/hvm/vmx/vvmx.c +0
-0
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1849
Quoted 5 lines
xen/arch/x86/hvm/vmx/vvmx.c +1
-1@@ -1846,7 +1846,7 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content)switch (msr) {case MSR_IA32_VMX_BASIC : data = (host_data & (~0ul <<32 )) | - ((v->arch.hvm_vmx.vmcs)->vmcs_revision_id); + ((v->arch.hvm_vmx.vmcs)->vmcs_revision_id & ~(1ul <<31 ));
What are the chances of vmcs_revision_id extending beyond 32 bits?
The SDM states that the bottom 31 bits of IA32_VMX_BASIC shall be the bottom 31 bits of the revision id, so
(v->arch.hvm_vmx.vmcs->vmcs_revision_id & 0x7fffffff);
would seem more obvious. Also, the brackets were superfluous.
~Andrew
Quoted 3 lines
xen/arch/x86/hvm/vmx/vvmx.c +0
-0break ;case MSR_IA32_VMX_PINBASED_CTLS :case MSR_IA32_VMX_TRUE_PINBASED_CTLS :
Re: [PATCH 2/3] Nested VMX: Clear bit 31 of IA32_VMX_BASIC MSR
Andrew Cooper wrote on 2013-09-05:
Quoted 25 lines · Yang Zhang
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr,
Quoted 16 lines
From: Yang Zhang <[email protected]>
The bit 31 of
revision_idwill set to 1 if vmcs shadowing enabled. And according intel SDM, the bit 31 ofIA32_VMX_BASICMSR is always
0. So we cannot set low 32 bit ofIA32_VMX_BASICtorevision_iddirectly. Must clear the bit 31 to 0.Signed-off-by Yang Zhang <[email protected]>--- xen/arch/x86/hvm/vmx/vvmx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/xen/arch/x86/hvm/vmx/vvmx.cindex 2e0b7f7..8571002 100644xen/arch/x86/hvm/vmx/vvmx.c +0
-0@@ -1846,7 +1846,7 @@ int nvmx_msr_read_intercept(unsigned int msr,u64
*msr_content)xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content)
Quoted 6 lines
xen/arch/x86/hvm/vmx/vvmx.c +2
-1switch (msr) {case MSR_IA32_VMX_BASIC : data = (host_data & (~0ul <<32 )) | - ((v->arch.hvm_vmx.vmcs)->vmcs_revision_id); + ((v->arch.hvm_vmx.vmcs)->vmcs_revision_id & ~(1ul << +31 ));
Quoted 8 lines
What are the chances of
vmcs_revision_idextending beyond 32 bits?The SDM states that the bottom 31 bits of
IA32_VMX_BASICshall be the bottom 31 bits of the revision id, so(
v->arch.hvm_vmx.vmcs->vmcs_revision_id&0x7fffffff);would seem more obvious. Also, the brackets were superfluous.
Right!
Quoted 6 lines
~Andrew
Quoted 3 lines
xen/arch/x86/hvm/vmx/vvmx.c +0
-0break ;case MSR_IA32_VMX_PINBASED_CTLS :case MSR_IA32_VMX_TRUE_PINBASED_CTLS :
Best regards,
Yang
PATCH 3/3 Nested VMX: Fix IA32_VMX_CR4_FIXED1 msr emulation
In reply to Yang ZhangFrom: Yang Zhang <[email protected]>
Currently, it use hardcode value for IA32_VMX_CR4_FIXED1. This is wrong. We should check guest's cpuid to know which bits are writeable in CR4 by guest and allow the guest to set the corresponding bit only when guest has the feature.
--- xen/arch/x86/hvm/vmx/vvmx.c | 34 ++++++++++++++++++++++++++++++++-- 1 files changed, 32 insertions(+), 2 deletions(-)
xen/arch/x86/hvm/vmx/vvmx.c +32 -2
@@ -1815,6 +1815,7 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) {struct vcpu *v = current;u64 data =0 , host_data =0 ; +unsigned int eax, ebx, ecx, edx;int r =1 ;if ( !nestedhvm_enabled (v->domain) )
@@ -1943,8 +1944,37 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) data =X86_CR4_VMXE ;break ;case MSR_IA32_VMX_CR4_FIXED1 : -/* allow 0-settings except SMXE */ - data =0x267ff & ~X86_CR4_SMXE ; + data |= (edx &cpufeat_mask (X86_FEATURE_VME ) ? + (X86_CR4_VME |X86_CR4_PVI ) :0 ) | + (edx &cpufeat_mask (X86_FEATURE_TSC ) ?X86_CR4_TSD :0 ) | + (edx &cpufeat_mask (X86_FEATURE_DE ) ?X86_CR4_DE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_PSE ) ?X86_CR4_PSE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_PAE ) ?X86_CR4_PAE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_MCE ) ?X86_CR4_MCE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_PGE ) ?X86_CR4_PGE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_FXSR ) ?X86_CR4_OSFXSR :0 ) | + (edx &cpufeat_mask (X86_FEATURE_XMM ) ?X86_CR4_OSXMMEXCPT :0 ) | + (ecx &cpufeat_mask (X86_FEATURE_VMXE ) ?X86_CR4_VMXE :0 ) | + (ecx &cpufeat_mask (X86_FEATURE_SMXE ) ?X86_CR4_SMXE :0 ) | + (ecx &cpufeat_mask (X86_FEATURE_PCID ) ?X86_CR4_PCIDE :0 ) | + (ecx &cpufeat_mask (X86_FEATURE_XSAVE ) ?X86_CR4_OSXSAVE :0 ); + +hvm_cpuid (0x0 , &eax, &ebx, &ecx, &edx); +if ( eax >=0xa ) + { +unsigned int temp_eax; + +hvm_cpuid (0xa , &temp_eax, &ebx, &ecx, &edx); +/* Check whether guest has the perf monitor feature. */ +if ( (temp_eax &0xff ) && (temp_eax &0xff00 ) ) + data |=X86_CR4_PCE ; + }else if ( eax >=0x7 ) + { +hvm_cpuid (0x7 , &eax, &ebx, &ecx, &edx); + data |= (ebx &cpufeat_mask (X86_FEATURE_SMEP ) ?X86_CR4_SMEP :0 ) | + (ebx &cpufeat_mask (X86_FEATURE_FSGSBASE ) ? +X86_CR4_FSGSBASE :0 ); + }break ;case MSR_IA32_VMX_MISC :/* Do not support CR3-target feature now */
Signature · 1 line
1.7.1
Re: [PATCH 3/3] Nested VMX: Fix IA32_VMX_CR4_FIXED1 msr emulation
Quoted 12 lines
Quoted 1 line
Quoted 1 line · Yang Zhang
xen/arch/x86/hvm/vmx/vvmx.c +1
-0@@ -1815,6 +1815,7 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) {struct vcpu *v = current;u64 data =0 , host_data =0 ; +unsigned int eax, ebx, ecx, edx;int r =1 ;if ( !nestedhvm_enabled (v->domain) )
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1947
Quoted 6 lines
xen/arch/x86/hvm/vmx/vvmx.c +1
-2@@ -1943,8 +1944,37 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) data =X86_CR4_VMXE ;break ;case MSR_IA32_VMX_CR4_FIXED1 : -/* allow 0-settings except SMXE */ - data =0x267ff & ~X86_CR4_SMXE ; + data |= (edx & cpufeat_mask(X86_FEATURE_VME) ?
Did you perhaps send a stale patch? I can't see how this would even have compiled: edx is uninitialized at this point afaict.
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1960
Quoted 13 lines
xen/arch/x86/hvm/vmx/vvmx.c +13
-0+ (X86_CR4_VME | X86_CR4_PVI) : 0) | + (edx &cpufeat_mask (X86_FEATURE_TSC ) ?X86_CR4_TSD :0 ) | + (edx &cpufeat_mask (X86_FEATURE_DE ) ?X86_CR4_DE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_PSE ) ?X86_CR4_PSE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_PAE ) ?X86_CR4_PAE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_MCE ) ?X86_CR4_MCE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_PGE ) ?X86_CR4_PGE :0 ) | + (edx &cpufeat_mask (X86_FEATURE_FXSR ) ?X86_CR4_OSFXSR :0 ) | + (edx &cpufeat_mask (X86_FEATURE_XMM ) ?X86_CR4_OSXMMEXCPT :0 ) | + (ecx &cpufeat_mask (X86_FEATURE_VMXE ) ?X86_CR4_VMXE :0 ) | + (ecx &cpufeat_mask (X86_FEATURE_SMXE ) ?X86_CR4_SMXE :0 ) | + (ecx &cpufeat_mask (X86_FEATURE_PCID ) ?X86_CR4_PCIDE :0 ) | + (ecx &cpufeat_mask (X86_FEATURE_XSAVE ) ?X86_CR4_OSXSAVE :0 );
I think this would be more legible if you used a series of "if() data |=". Or at least suitably pad the lines so the similar parts align nicely.
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1965
Quoted 5 lines
xen/arch/x86/hvm/vmx/vvmx.c +5
-0+ +hvm_cpuid (0x0 , &eax, &ebx, &ecx, &edx); +if ( eax >=0xa ) + { +unsigned int temp_eax;
Why is this needed? You don't need eax anymore below.
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1971
Quoted 6 lines
xen/arch/x86/hvm/vmx/vvmx.c +6
-0+ +hvm_cpuid (0xa , &temp_eax, &ebx, &ecx, &edx); +/* Check whether guest has the perf monitor feature. */ +if ( (temp_eax &0xff ) && (temp_eax &0xff00 ) ) + data |=X86_CR4_PCE ; + }else if ( eax >=0x7 )
Coding style. Also, is this really "else if"? If not, _that_ would explain the (apparent; can be avoided nevertheless) need for temp_eax above...
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1976
Quoted 5 lines
xen/arch/x86/hvm/vmx/vvmx.c +5
-0+ { +hvm_cpuid (0x7 , &eax, &ebx, &ecx, &edx); + data |= (ebx &cpufeat_mask (X86_FEATURE_SMEP ) ?X86_CR4_SMEP :0 ) | + (ebx &cpufeat_mask (X86_FEATURE_FSGSBASE ) ? +X86_CR4_FSGSBASE :0 );
Same as above. I'd also like to see SMAP added here right away, even if for now hvm_cpuid() [hopefully] always returns the respective bit clear.
Jan
Re: [PATCH 3/3] Nested VMX: Fix IA32_VMX_CR4_FIXED1 msr emulation
Jan Beulich wrote on 2013-09-05:
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line · Yang Zhang
xen/arch/x86/hvm/vmx/vvmx.c +0
-0@@ -1815,6 +1815,7 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) {struct vcpu *v = current;u64 data =0 , host_data =0 ; + unsigned int eax, ebx, ecx, edx; int r = 1;
Quoted 11 lines
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1947
Quoted 8 lines
xen/arch/x86/hvm/vmx/vvmx.c +1
-2if ( !nestedhvm_enabled(v->domain) ) @@ -1943,8 +1944,37 @@ intnvmx_msr_read_intercept (unsigned int msr,u64 *msr_content) data =X86_CR4_VMXE ;break ;case MSR_IA32_VMX_CR4_FIXED1 : -/* allow 0-settings except SMXE */ - data =0x267ff & ~X86_CR4_SMXE ; + data |= (edx & cpufeat_mask(X86_FEATURE_VME) ?Did you perhaps send a stale patch? I can't see how this would even have
compiled: edx is uninitialized at this point afaict.
It is already filled. See the first patch.
Quoted 18 lines
Quoted 10 lines
+ (
X86_CR4_VME|X86_CR4_PVI) :
0) | + (edx &cpufeat_mask(X86_FEATURE_TSC)?X86_CR4_TSD: 0) | + (edx &cpufeat_mask(X86_FEATURE_DE)
?X86_CR4_DE: 0) | + (edx &cpufeat_mask(X86_FEATURE_PSE)?X86_CR4_PSE: 0) | + (edx &cpufeat_mask(X86_FEATURE_PAE)?X86_CR4_PAE: 0) | +
(edx &cpufeat_mask(X86_FEATURE_MCE)?X86_CR4_MCE: 0) | +(edx & cpufeat_mask(X86_FEATURE_PGE) ? X86_CR4_PGE : 0) | + (edx & cpufeat_mask(X86_FEATURE_FXSR) ? X86_CR4_OSFXSR : 0) |Quoted 7 lines
+ (edx &
cpufeat_mask(X86_FEATURE_XMM)?X86_CR4_OSXMMEXCPT: 0) | + (ecx &cpufeat_mask(X86_FEATURE_VMXE)?X86_CR4_VMXE: 0) | + (ecx &cpufeat_mask(X86_FEATURE_SMXE)?X86_CR4_SMXE: 0) | +(ecx & cpufeat_mask(X86_FEATURE_PCID) ? X86_CR4_PCIDE : 0) | + (ecx & cpufeat_mask(X86_FEATURE_XSAVE) ? + X86_CR4_OSXSAVE :0);
Quoted 2 lines
I think this would be more legible if you used a series of "
if()data |=". Or at least suitably pad the lines so the similar parts align nicely.
if() should be better. Since the line will exceed the 80 characters if using pad.
Quoted 8 lines
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1965
Quoted 6 lines
xen/arch/x86/hvm/vmx/vvmx.c +5
-0+ +hvm_cpuid (0x0 , &eax, &ebx, &ecx, &edx); +if ( eax >=0xa ) + { +unsigned int temp_eax;Why is this needed? You don't need eax anymore below.
Good point!
Quoted 10 lines
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1971
Quoted 7 lines
xen/arch/x86/hvm/vmx/vvmx.c +6
-0+ +hvm_cpuid (0xa , &temp_eax, &ebx, &ecx, &edx); +/* Check whether guest has the perf monitor feature. */ +if ( (temp_eax &0xff ) && (temp_eax &0xff00 ) ) + data |=X86_CR4_PCE ; + }else if ( eax >=0x7 )Coding style. Also, is this really "else if"? If not, _that_ would explain the (apparent; can be avoided nevertheless) need for
temp_eaxabove...
The different coding style between upstream Linux and Xen really defeats me. :(
Quoted 9 lines
Quoted 4 lines
+ { +
hvm_cpuid(0x7, &eax, &ebx, &ecx, &edx); +data |= (ebx & cpufeat_mask(X86_FEATURE_SMEP) ? X86_CR4_SMEP : 0)| + (ebx &
cpufeat_mask(X86_FEATURE_FSGSBASE)? +
X86_CR4_FSGSBASE: 0);Same as above. I'd also like to see SMAP added here right away, even if for now
hvm_cpuid()[hopefully] always returns the respective bit clear.
Sure.
Quoted 2 lines
Jan
Best regards,
Yang
Re: [PATCH 3/3] Nested VMX: Fix IA32_VMX_CR4_FIXED1 msr emulation
Quoted 8 lines
Quoted 1 line
Quoted 1 line · Yang Z
Jan Beulich wrote on 2013-09-05:
Quoted 6 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line · Yang Zhang
case MSR_IA32_VMX_CR4_FIXED1:xen/arch/x86/hvm/vmx/vvmx.c +1
-2-/* allow 0-settings except SMXE */ - data =0x267ff & ~X86_CR4_SMXE ; + data |= (edx & cpufeat_mask(X86_FEATURE_VME) ?
Quoted 4 lines
Quoted 2 lines
Did you perhaps send a stale patch? I can't see how this would even have
compiled: edx is uninitialized at this point afaict.It is already filled. See the first patch.
Then the first patch fails to declare all four variables, and hence won't build. It just caught my eye that you declare the variables here and don't initialize them between declaration and use.
Jan
Re: [PATCH 3/3] Nested VMX: Fix IA32_VMX_CR4_FIXED1 msr emulation
Jan Beulich wrote on 2013-09-05:
Quoted 12 lines
Quoted 12 lines
Quoted 1 line
Quoted 1 line · Yang Z
Jan Beulich wrote on 2013-09-05:
Quoted 9 lines
xen/arch/x86/hvm/vmx/vvmx.c int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content) · line 1947
Quoted 5 lines
Quoted 1 line
Quoted 1 line · Yang Zhang
case MSR_IA32_VMX_CR4_FIXED1:xen/arch/x86/hvm/vmx/vvmx.c +1
-2-/* allow 0-settings except SMXE */ - data =0x267ff & ~X86_CR4_SMXE ; + data |= (edx & cpufeat_mask(X86_FEATURE_VME) ?Did you perhaps send a stale patch? I can't see how this would even have
compiled: edx is uninitialized at this point afaict.
Quoted 5 lines
Quoted 1 line
It is already filled. See the first patch.
Then the first patch fails to declare all four variables, and hence won't build. It just caught my eye that you declare the variables here and don't initialize them between declaration and use.
You are right. I adjust the order of patches but forget tweaking the code accordingly.
Best regards,
Yang