tcg/optimize: fixes and improvements
v2 cover tcg/optimize: fixes and improvements
This patchset first fixes known-zero bits optimization so that it works in more than a few cases, and does some further optimizations for 32-bit ops and unsigned loads.
v1 -> v2:
- swapped patches 1 & 2
- Cc:ed qemu-stable for patch 1
- improved description of patch 2
Aurelien Jarno (4):
tcg/optimize: fix known-zero bits for right shift ops tcg/optimize: fix known-zero bits optimization tcg/optimize: improve known-zero bits for 32-bit ops tcg/optimize: add known-zero bits compute for load ops
tcg/optimize.c | 48 +++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 43 insertions(+), 5 deletions(-)
Signature · 1 line
1.7.10.4
PATCH v2 1/4 tcg/optimize: fix known-zero bits for right shift ops
32-bit versions of sar and shr ops should not propagate known-zero bits from the unused 32 high bits. For sar it could even lead to wrong code being generated.
--- tcg/optimize.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
tcg/optimize.c +17 -4
@@ -730,16 +730,29 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, mask = temps[args[1 ]].mask & mask;break ; - CASE_OP_32_64(sar): +case INDEX_op_sar_i32: +if (temps[args[2 ]].state ==TCG_TEMP_CONST ) { + mask = ((int32_t )temps[args[1 ]].mask + >> temps[args[2 ]].val); + } +break ; +case INDEX_op_sar_i64:if (temps[args[2 ]].state ==TCG_TEMP_CONST ) { - mask = ((tcg_target_long )temps[args[1 ]].mask + mask = ((int64_t )temps[args[1 ]].mask >> temps[args[2 ]].val); }break ; - CASE_OP_32_64(shr): +case INDEX_op_shr_i32:if (temps[args[2 ]].state ==TCG_TEMP_CONST ) { - mask = temps[args[1 ]].mask >> temps[args[2 ]].val; + mask = ((uint32_t )temps[args[1 ]].mask + >> temps[args[2 ]].val); + } +break ; +case INDEX_op_shr_i64: +if (temps[args[2 ]].state ==TCG_TEMP_CONST ) { + mask = ((uint64_t )temps[args[1 ]].mask + >> temps[args[2 ]].val); }break ;
Signature · 1 line
1.7.10.4
Re: [Qemu-devel] [PATCH v2 1/4] tcg/optimize: fix known-zero bits for right shift ops
Quoted 11 lines · Aurelien Jarno
32-bit versions of sar and shr ops should not propagate known-zero bits from the unused 32 high bits. For sar it could even lead to wrong code being generated.
Cc Richard Henderson <[email protected]>Cc Paolo Bonzini <[email protected]>Signed-off-by Aurelien Jarno <[email protected]>--- tcg/optimize.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
r~
Re: [Qemu-devel] [PATCH v2 1/4] tcg/optimize: fix known-zero bits for right shift ops
In reply to Aurelien JarnoQuoting Aurelien Jarno (2013-09-09 12:27:47)
Quoted 11 lines
32-bit versions of sar and shr ops should not propagate known-zero bits from the unused 32 high bits. For sar it could even lead to wrong code being generated.
Cc Richard Henderson <[email protected]>Cc Paolo Bonzini <[email protected]>Signed-off-by Aurelien Jarno <[email protected]>--- tcg/optimize.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
Ping, looking to pull this in for 1.7.1
Quoted 41 lines
tcg/optimize.c +17
-4@@ -730,16 +730,29 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, mask = temps[args[1 ]].mask & mask;break ; - CASE_OP_32_64(sar): +case INDEX_op_sar_i32: +if (temps[args[2 ]].state ==TCG_TEMP_CONST ) { + mask = ((int32_t )temps[args[1 ]].mask + >> temps[args[2 ]].val); + } +break ; +case INDEX_op_sar_i64:if (temps[args[2 ]].state ==TCG_TEMP_CONST ) { - mask = ((tcg_target_long )temps[args[1 ]].mask + mask = ((int64_t )temps[args[1 ]].mask >> temps[args[2 ]].val); }break ; - CASE_OP_32_64(shr): +case INDEX_op_shr_i32:if (temps[args[2 ]].state ==TCG_TEMP_CONST ) { - mask = temps[args[1 ]].mask >> temps[args[2 ]].val; + mask = ((uint32_t )temps[args[1 ]].mask + >> temps[args[2 ]].val); + } +break ; +case INDEX_op_shr_i64: +if (temps[args[2 ]].state ==TCG_TEMP_CONST ) { + mask = ((uint64_t )temps[args[1 ]].mask + >> temps[args[2 ]].val); }break ;Signature · 1 line
1.7.10.4
PATCH v2 2/4 tcg/optimize: fix known-zero bits optimization
In reply to Aurelien JarnoKnown-zero bits optimization is a great idea that helps to generate more optimized code. However the current implementation only works in very few cases as the computed mask is not saved.
Fix this to make it really working.
--- tcg/optimize.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
tcg/optimize.c +7 -1
@@ -695,7 +695,8 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr,break ; } -/* Simplify using known-zero bits */ +/* Simplify using known-zero bits. Currently only ops with a single +output argument is supported. */ mask =-1 ; affected =-1 ;switch (op) {
@@ -1157,6 +1158,11 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, }else {for (i =0 ; i < def->nb_oargs; i++) {reset_temp (args[i]); +/* Save the corresponding known-zero bits mask for the +first output argument (only one supported so far). */ +if (i ==0 ) { + temps[args[i]].mask = mask; + } } }for (i =0 ; i < def->nb_args; i++) {
Signature · 1 line
1.7.10.4
Re: [Qemu-devel] [PATCH v2 2/4] tcg/optimize: fix known-zero bits optimization
Quoted 4 lines · Aurelien Jarno
Known-zero bits optimization is a great idea that helps to generate more optimized code. However the current implementation only works in very few cases as the computed mask is not saved.
Quoted 8 lines
Fix this to make it really working.
Cc Richard Henderson <[email protected]>Cc Paolo Bonzini <[email protected]>Signed-off-by Aurelien Jarno <[email protected]>--- tcg/optimize.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
r~
PATCH v2 3/4 tcg/optimize: improve known-zero bits for 32-bit ops
In reply to Aurelien JarnoThe shl_i32 op might set some bits of the unused 32 high bits of the mask. Fix that by clearing the unused 32 high bits for all 32-bit ops except load/store which operate on tl values.
--- tcg/optimize.c | 6 ++++++ 1 file changed, 6 insertions(+)
tcg/optimize.c +6 -0
@@ -791,6 +791,12 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr,break ; } +/* 32-bit ops (non 64-bit ops and non load/store ops) generate 32-bit +results */ +if (!(tcg_op_defs[op].flags & (TCG_OPF_CALL_CLOBBER |TCG_OPF_64BIT ))) { + mask &=0xffffffffu ; + } +if (mask ==0 ) {assert (def->nb_oargs ==1 ); s->gen_opc_buf[op_index] =op_to_movi (op);
Signature · 1 line
1.7.10.4
Re: [Qemu-devel] [PATCH v2 3/4] tcg/optimize: improve known-zero bits for 32-bit ops
Quoted 10 lines · Aurelien Jarno
The
shl_i32op might set some bits of the unused 32 high bits of the mask. Fix that by clearing the unused 32 high bits for all 32-bit ops except load/store which operate on tl values.Cc Richard Henderson <[email protected]>Cc Paolo Bonzini <[email protected]>Signed-off-by Aurelien Jarno <[email protected]>--- tcg/optimize.c | 6 ++++++ 1 file changed, 6 insertions(+)
r~
PATCH v2 4/4 tcg/optimize: add known-zero bits compute for load ops
In reply to Aurelien Jarno--- tcg/optimize.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
tcg/optimize.c +13 -0
@@ -787,6 +787,19 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, mask = temps[args[3 ]].mask | temps[args[4 ]].mask;break ; + CASE_OP_32_64(ld8u): +case INDEX_op_qemu_ld8u: + mask =0xff ; +break ; + CASE_OP_32_64(ld16u): +case INDEX_op_qemu_ld16u: + mask =0xffff ; +break ; +case INDEX_op_ld32u_i64: +case INDEX_op_qemu_ld32u: + mask =0xffffffffu ; +break ; +default :break ; }
Signature · 1 line
1.7.10.4
Re: [Qemu-devel] [PATCH v2 4/4] tcg/optimize: add known-zero bits compute for load ops
tcg/optimize.c static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, · line 802
Quoted 13 lines · Aurelien Jarno
tcg/optimize.c +13
-0+ CASE_OP_32_64(ld8u): +case INDEX_op_qemu_ld8u: + mask =0xff ; +break ; + CASE_OP_32_64(ld16u): +case INDEX_op_qemu_ld16u: + mask =0xffff ; +break ; +case INDEX_op_ld32u_i64: +case INDEX_op_qemu_ld32u: + mask =0xffffffffu ; +break ; +
This could stand to be updated for the new INDEX_op_qemu_ld_{i32,i64} opcodes, where you have to look at args[last] to find out the width and sign.
But this is still an improvement for the old opcodes.
r~
Il 09/09/2013 19:27, Aurelien Jarno ha scritto:
Quoted 9 lines
This patchset first fixes known-zero bits optimization so that it works in more than a few cases, and does some further optimizations for 32-bit ops and unsigned loads.
v1 -> v2:
- swapped patches 1 & 2
- Cc:ed qemu-stable for patch 1
- improved description of patch 2
Quoted 9 lines
Aurelien Jarno (4):
tcg/optimize: fix known-zero bits for right shift ops tcg/optimize: fix known-zero bits optimization tcg/optimize: improve known-zero bits for 32-bit ops tcg/optimize: add known-zero bits compute for load opstcg/optimize.c | 48 +++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 43 insertions(+), 5 deletions(-)
Ping?
Paolo