workqueue: remove redundant timer_stats_timer_set_start_info() call
PATCH 1/1 workqueue: remove redundant timer_stats_timer_set_start_info() call
From: Li Bin <[email protected]>
There is a redundant call for timer_stats_timer_set_start_info(), because it is the responsibility of the 'timer add' function:
add_timer_on()
|- timer_stats_timer_set_start_info()
add_timer()
|- mod_timer()
|- __mod_timer() |- timer_stats_timer_set_start_info()
So the calling here is redundant, remove it.
--- kernel/workqueue.c | 2 -- 1 file changed, 2 deletions(-)
kernel/workqueue.c +0 -2
@@ -1462,8 +1462,6 @@ static void __queue_delayed_work(int cpu, struct workqueue_struct *wq,return ; } -timer_stats_timer_set_start_info (&dwork->timer); - dwork->wq = wq; dwork->cpu = cpu; timer->expires = jiffies + delay;
Signature · 1 line
1.8.2.1
Tejun Heo
maintainerQuoted 8 lines · Libin
From: Li Bin <[email protected]>
There is a redundant call for
timer_stats_timer_set_start_info(), because it is the responsibility of the 'timer add' function:
add_timer_on()
|-timer_stats_timer_set_start_info()
Quoted 6 lines
add_timer()
|-mod_timer()|- __mod_timer() |- timer_stats_timer_set_start_info()So the calling here is redundant, remove it.
I think it's intentional to record the caller's address so that timers from delayed_work items can be distinguished.
Thanks.
Signature · 1 line
tejun
Quoted 14 lines · Tejun Heo
Quoted 13 lines · Libin
From: Li Bin <[email protected]>
There is a redundant call for
timer_stats_timer_set_start_info(), because it is the responsibility of the 'timer add' function:
add_timer_on()
|-timer_stats_timer_set_start_info()
add_timer()
|-mod_timer()|- __mod_timer() |- timer_stats_timer_set_start_info()
Quoted 5 lines
Quoted 1 line
So the calling here is redundant, remove it.
I think it's intentional to record the caller's address so that timers from
delayed_workitems can be distinguished.
Indeed the case, thank you tejun.
Libin
Quoted 2 lines
Thanks.