Skip to contentSkip to conversation

ARM: dts: igep00x0: Add pinmux configuration for MCBSP2.

PATCH In review Enric Balletbo i Serra 2 participants 4 messages Sep 10, 2013 – Sep 19, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: igep00x0: Add pinmux configuration for MCBSP2.

Add pinmux configuration for MCBSP2 connected to the TDM interface. With this configuration the Headset modules works as expected.

---
 arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/omap3-igep.dtsi +14 -0
index bc48b11..2326d11 100644
@@ -48,6 +48,15 @@
 		>;
 	};
 
+	mcbsp2_pins: pinmux_mcbsp2_pins {
+		pinctrl-single,pins = <
+			0x10c (PIN_INPUT | MUX_MODE0)		/* mcbsp2_fsx.mcbsp2_fsx */
+			0x10e (PIN_INPUT | MUX_MODE0)		/* mcbsp2_clkx.mcbsp2_clkx */
+			0x110 (PIN_INPUT | MUX_MODE0)		/* mcbsp2_dr.mcbsp2.dr */
+			0x112 (PIN_OUTPUT | MUX_MODE0)		/* mcbsp2_dx.mcbsp2_dx */
+		>;
+	};
+
 	mmc1_pins: pinmux_mmc1_pins {
 		pinctrl-single,pins = <
 			0x114 (PIN_INPUT_PULLUP | MUX_MODE0)	/* sdmmc1_clk.sdmmc1_clk */
@@ -93,6 +102,11 @@
 	clock-frequency = <400000>;
 };
 
+&mcbsp2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mcbsp2_pins>;
+};
+
 &mmc1 {
       pinctrl-names = "default";
       pinctrl-0 = <&mmc1_pins>;
Signature · 1 line
1.8.1.2
#1 lore raw

2013/9/10 Enric Balletbo i Serra <[email protected]>:

Quoted 42 lines

Add pinmux configuration for MCBSP2 connected to the TDM interface. With this configuration the Headset modules works as expected.

---
 arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/omap3-igep.dtsi +14 -1
index bc48b11..2326d11 100644
@@ -48,6 +48,15 @@
                >;
        };
 
+       mcbsp2_pins: pinmux_mcbsp2_pins {
+               pinctrl-single,pins = <
+                       0x10c (PIN_INPUT | MUX_MODE0)           /* mcbsp2_fsx.mcbsp2_fsx */
+                       0x10e (PIN_INPUT | MUX_MODE0)           /* mcbsp2_clkx.mcbsp2_clkx */
+                       0x110 (PIN_INPUT | MUX_MODE0)           /* mcbsp2_dr.mcbsp2.dr */
+                       0x112 (PIN_OUTPUT | MUX_MODE0)          /* mcbsp2_dx.mcbsp2_dx */
+               >;
+       };
+
        mmc1_pins: pinmux_mmc1_pins {
                pinctrl-single,pins = <
                        0x114 (PIN_INPUT_PULLUP | MUX_MODE0)    /* sdmmc1_clk.sdmmc1_clk */
@@ -93,6 +102,11 @@
        clock-frequency = <400000>;
 };
 
+&mcbsp2 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&mcbsp2_pins>;
+};
+
 &mmc1 {
       pinctrl-names = "default";
       pinctrl-0 = <&mmc1_pins>;
--
Quoted 2 lines

1.8.1.2

Hi Benoit,

I sent this patch some time ago to be merged as a fix for 3.11, but seems was not merged. Would be possible include this patch in these series ?

Best regards,
Enric

#2 lore raw

Hi Enric,

Quoted 48 lines · Enric Balletbo Serra

2013/9/10 Enric Balletbo i Serra <[email protected]>:

Quoted 42 lines

Add pinmux configuration for MCBSP2 connected to the TDM interface. With this configuration the Headset modules works as expected.

---
  arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
arch/arm/boot/dts/omap3-igep.dtsi +14 -1
index bc48b11..2326d11 100644
@@ -48,6 +48,15 @@
                 >;
         };
 
+       mcbsp2_pins: pinmux_mcbsp2_pins {
+               pinctrl-single,pins = <
+                       0x10c (PIN_INPUT | MUX_MODE0)           /* mcbsp2_fsx.mcbsp2_fsx */
+                       0x10e (PIN_INPUT | MUX_MODE0)           /* mcbsp2_clkx.mcbsp2_clkx */
+                       0x110 (PIN_INPUT | MUX_MODE0)           /* mcbsp2_dr.mcbsp2.dr */
+                       0x112 (PIN_OUTPUT | MUX_MODE0)          /* mcbsp2_dx.mcbsp2_dx */
+               >;
+       };
+
         mmc1_pins: pinmux_mmc1_pins {
                 pinctrl-single,pins = <
                         0x114 (PIN_INPUT_PULLUP | MUX_MODE0)    /* sdmmc1_clk.sdmmc1_clk */
@@ -93,6 +102,11 @@
         clock-frequency = <400000>;
  };
 
+&mcbsp2 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&mcbsp2_pins>;
+};
+
  &mmc1 {
        pinctrl-names = "default";
        pinctrl-0 = <&mmc1_pins>;
--
Quoted 2 lines

1.8.1.2

Hi Benoit,

Quoted 3 lines

I sent this patch some time ago to be merged as a fix for 3.11, but seems was not merged. Would be possible include this patch in these series ?

I'm really sorry I missed that one :-(
I'm applying it right now, and will update my pull request.

Thanks,
Benoit

#3 lore raw

Hi Benoit,

2013/9/18 Benoit Cousson <[email protected]>:

Quoted 65 lines

Hi Enric,

Quoted 56 lines · Enric Balletbo Serra

2013/9/10 Enric Balletbo i Serra <[email protected]>:

Quoted 49 lines

Add pinmux configuration for MCBSP2 connected to the TDM interface. With this configuration the Headset modules works as expected.

---
  arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
arch/arm/boot/dts/omap3-igep.dtsi +3 -0
index bc48b11..2326d11 100644
@@ -48,6 +48,15 @@
                 >;
         };
 
+       mcbsp2_pins: pinmux_mcbsp2_pins {
+               pinctrl-single,pins = <
+                       0x10c (PIN_INPUT | MUX_MODE0)           /*

mcbsp2_fsx.mcbsp2_fsx */
+ 0x10e (PIN_INPUT | MUX_MODE0) /*
mcbsp2_clkx.mcbsp2_clkx */
+ 0x110 (PIN_INPUT | MUX_MODE0) /*
mcbsp2_dr.mcbsp2.dr */
+ 0x112 (PIN_OUTPUT | MUX_MODE0) /*
mcbsp2_dx.mcbsp2_dx */

arch/arm/boot/dts/omap3-igep.dtsi +3 -0
+               >;
+       };
+
         mmc1_pins: pinmux_mmc1_pins {
                 pinctrl-single,pins = <
                         0x114 (PIN_INPUT_PULLUP | MUX_MODE0)    /*

sdmmc1_clk.sdmmc1_clk */

arch/arm/boot/dts/omap3-igep.dtsi +5 -1
@@ -93,6 +102,11 @@
         clock-frequency = <400000>;
  };
 
+&mcbsp2 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&mcbsp2_pins>;
+};
+
  &mmc1 {
        pinctrl-names = "default";
        pinctrl-0 = <&mmc1_pins>;
--
Quoted 2 lines

1.8.1.2

Hi Benoit,

Quoted 3 lines

I sent this patch some time ago to be merged as a fix for 3.11, but seems was not merged. Would be possible include this patch in these series ?

Quoted 6 lines

I'm really sorry I missed that one :-(
I'm applying it right now, and will update my pull request.

Thanks,
Benoit

Many thanks.

Best regards,
Enric