fbdev/ps3fb: fix section mismatch warning for ps3fb_probe
Subsystems (3)
PATCH 3/3 fbdev/ps3fb: fix section mismatch warning for ps3fb_probe
While cross-building for PPC64 I've got
WARNING: drivers/video/built-in.o(.text+0x9f9ca): Section mismatch in reference from the function .ps3fb_probe() to th e variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix. This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
WARNING: drivers/video/built-in.o(.text+0x9f9d2): Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix. This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
WARNING: drivers/built-in.o(.text+0xe222a): Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix. This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
WARNING: drivers/built-in.o(.text+0xe2232): Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix. This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
WARNING: vmlinux.o(.text+0x561d4a): Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix. This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
Mismatch was introduced with 48c68c4f "Drivers: video: remove __dev* attributes."
Remove __init data annotation from ps3fb_fix.
--- drivers/video/ps3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/ps3fb.c +1 -1
@@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl }; -static struct fb_fix_screeninfo ps3fb_fix__initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id =DEVICE_NAME , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_TRUECOLOR ,
Signature · 1 line
1.7.10.4
drivers/video/ps3fb.c static struct fb_ops ps3fb_ops = { · line 958
Quoted 13 lines · Vladimir Murzin
drivers/video/ps3fb.c +1
-1@@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl }; -static struct fb_fix_screeninfo ps3fb_fix__initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id =DEVICE_NAME , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_TRUECOLOR ,
Fixed before by Geoff, but never applied:
http://marc.info/?l=linux-fbdev&m6914132618389&w=3
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 9 lines · Geert Uytterhoeven
Quoted 8 lines · Vladimir Murzin
drivers/video/ps3fb.c +0
-0@@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl };
Quoted 8 lines
drivers/video/ps3fb.c static struct fb_ops ps3fb_ops = { · line 958
Quoted 5 lines
drivers/video/ps3fb.c +1
-1-static struct fb_fix_screeninfo ps3fb_fix__initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id =DEVICE_NAME , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_TRUECOLOR ,Fixed before by Geoff, but never applied:
http://marc.info/?l=linux-fbdev&m6914132618389&w=3
Great! Hope some day it will ;)
Sorry for the noise
Vladimir
Quoted 11 lines
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds