Skip to contentSkip to conversation

mei: Don't dev_err() on suspend

PATCH In review Adam Jackson 3 participants 4 messages Sep 10, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mei: Don't dev_err() on suspend

Suspend isn't an error condition, and I'm sick of seeing this (and only this) on the console when I suspend with quiet boot enabled.

---
 drivers/misc/mei/pci-me.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/mei/pci-me.c +1 -1
index 1b3844e..c718f1d 100644
@@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
 	if (!dev)
 		return -ENODEV;
 
-	dev_err(&pdev->dev, "suspend\n");
+	dev_info(&pdev->dev, "suspend\n");
 
 	mei_stop(dev);
 
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 2 lines · Adam Jackson

Suspend isn't an error condition, and I'm sick of seeing this (and only this) on the console when I suspend with quiet boot enabled.

[]

drivers/misc/mei/pci-me.c

Quoted 1 line
drivers/misc/mei/pci-me.c +0 -0

[]

drivers/misc/mei/pci-me.c static int mei_me_pci_suspend(struct device *device) · line 265

Quoted 6 lines
drivers/misc/mei/pci-me.c +1 -1
@@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
 	if (!dev)
 		return -ENODEV;
 
-	dev_err(&pdev->dev, "suspend\n");
+	dev_info(&pdev->dev, "suspend\n");

dev_dbg instead?

#2 lore raw

I

Quoted 13 lines

-----Original Message-----
From: Joe Perches [mailto:[email protected]]
Sent: Tuesday, September 10, 2013 19:06
To: Adam Jackson
Cc: [email protected]; Winkler, Tomas
Subject: Re: [PATCH] mei: Don't dev_err() on suspend

Quoted 2 lines · Adam Jackson

Suspend isn't an error condition, and I'm sick of seeing this (and only this) on the console when I suspend with quiet boot enabled.

[]

drivers/misc/mei/pci-me.c

Quoted 1 line
drivers/misc/mei/pci-me.c +0 -0

[]

Quoted 8 lines

drivers/misc/mei/pci-me.c static int mei_me_pci_suspend(struct device *device) · line 265

Quoted 6 lines
drivers/misc/mei/pci-me.c +1 -1
@@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
 	if (!dev)
 		return -ENODEV;
 
-	dev_err(&pdev->dev, "suspend\n");
+	dev_info(&pdev->dev, "suspend\n");

dev_dbg instead?

Yes, but I believe we fixed that long ago were do you see this? Thanks
Tomas

#3 lore raw
Quoted 11 lines · Tomas

From: Joe Perches [mailto:[email protected]]

Quoted 10 lines · Adam Jackson
Quoted 2 lines

Suspend isn't an error condition, and I'm sick of seeing this (and only this) on the console when I suspend with quiet boot enabled.

[]

drivers/misc/mei/pci-me.c

Quoted 1 line
drivers/misc/mei/pci-me.c +0 -0

[]

Quoted 4 lines
drivers/misc/mei/pci-me.c +0 -0
@@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
 	if (!dev)
 		return -ENODEV;
 
Quoted 6 lines
Quoted 4 lines

drivers/misc/mei/pci-me.c static int mei_me_pci_suspend(struct device *device) · line 265

Quoted 2 lines
drivers/misc/mei/pci-me.c +1 -1
-	dev_err(&pdev->dev, "suspend\n");
+	dev_info(&pdev->dev, "suspend\n");

dev_dbg instead?

Yes, but I believe we fixed that long ago were do you see this?

drivers/misc/mei/pci-me.c of both linus and -next