mxs_spi: unbreak driver
Subsystems (6)
PATCH 1/4 mxs_spi: unbreak driver
since the switch to common clock, SPI driver reports :
MXS: Timeout resetting block via register 0x80014000 mxs_spi mxs_spi2: MXS SPI: Timeout waiting for start
The reason is that the clock is not enabled anywhere in the driver.
Signed-off-by Eric Bénard <[email protected]>
--- drivers/spi/mxs_spi.c | 1 + 1 file changed, 1 insertion(+)
drivers/spi/mxs_spi.c +1 -0
@@ -270,6 +270,7 @@ static int mxs_spi_probe(struct device_d *dev) mxs->clk =clk_get (dev,NULL );if (IS_ERR (mxs->clk))return PTR_ERR (mxs->clk); +clk_enable (mxs->clk);spi_register_master (master);
Signature · 7 lines
1.8.3.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
PATCH 2/4 nand_mxs: fix on i.MX28
when the bootmode is different than NAND (USB for example), the GPMI clock is not enabled thus we can't probe a NAND flash.
Tested on an i.MX28
Signed-off-by Eric Bénard <[email protected]>
--- drivers/mtd/nand/nand_mxs.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/nand/nand_mxs.c +1 -0
@@ -1259,6 +1259,7 @@ static int mxs_nand_probe(struct device_d *dev) nand_info->dma_channel_base =0 ; }else { nand_info->dma_channel_base =MXS_DMA_CHANNEL_AHB_APBH_GPMI0 ; +clk_enable (nand_info->clk); } err =mxs_nand_alloc_buffers (nand_info);
Signature · 7 lines
1.8.3.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
PATCH 3/4 video/stm: don't fail when the pixel clock is properly set
In reply to Eric Bénardthe check is wrong as when the clock rate is correctly set the function will return 0.
Signed-off-by Eric Bénard <[email protected]>
--- drivers/video/stm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/stm.c +1 -1
@@ -331,7 +331,7 @@ static int stmfb_activate_var(struct fb_info *fb_info)/** @todo ensure HCLK is active at this point of time! */ size =clk_set_rate (fbi->clk,PICOS2KHZ (mode->pixclock) *1000 ); -if (size ==0 ) { +if (size !=0 ) {dev_dbg (fbi->hw_dev,"Unable to set a valid pixel clock\n" );return -EINVAL ; }
Signature · 7 lines
1.8.3.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
PATCH 4/4 video/stm: enable clock to get the display working
In reply to Eric Bénardelse the clock is not enabled :
ref_pix (rate 270000000, disabled)
lcdif_sel (rate 270000000, disabled)
lcdif_div (rate 33750000, disabled)
lcdif (rate 33750000, disabled)
lcdif_comp (rate 33750000, disabled)tested on i.MX28EVK.
Signed-off-by Eric Bénard <[email protected]>
--- drivers/video/stm.c | 1 + 1 file changed, 1 insertion(+)
drivers/video/stm.c +1 -0
@@ -496,6 +496,7 @@ static int stmfb_probe(struct device_d *hw_dev) fbi.clk =clk_get (hw_dev,NULL );if (IS_ERR (fbi.clk))return PTR_ERR (fbi.clk); +clk_enable (fbi.clk);/* add runtime video info */ fbi.info.mode_list = pdata->mode_list;
Signature · 7 lines
1.8.3.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox