Skip to contentSkip to conversation

powerpc: Export cpu_to_chip_id() to fix build error

PATCH In review Guenter Roeck 3 participants 3 messages Sep 10, 2013 – Sep 11, 2013 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Export cpu_to_chip_id() to fix build error

powerpc allmodconfig build fails with:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

The problem was introduced with commit 15863ff3b (powerpc: Make chip-id information available to userspace).

Export the missing symbol.

Cc Vasant Hegde <[email protected]>
Cc Shivaprasad G Bhat <[email protected]>
---
 arch/powerpc/kernel/smp.c |    1 +
 1 file changed, 1 insertion(+)
arch/powerpc/kernel/smp.c +1 -0
index 442d8e2..8e59abc 100644
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
 	of_node_put(np);
 	return of_get_ibm_chip_id(np);
 }
+EXPORT_SYMBOL(cpu_to_chip_id);
 
 /* Helper routines for cpu to core mapping */
 int cpu_core_index_of_thread(int cpu)
Signature · 1 line
1.7.9.7
#1 lore raw
Quoted 6 lines · Guenter Roeck

powerpc allmodconfig build fails with:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

The problem was introduced with commit 15863ff3b (powerpc: Make chip-id information available to userspace).

Thanks, I'll send that to Linus asap.

Ben.

Quoted 21 lines

Export the missing symbol.

Cc Vasant Hegde <[email protected]>
Cc Shivaprasad G Bhat <[email protected]>
---
 arch/powerpc/kernel/smp.c |    1 +
 1 file changed, 1 insertion(+)
arch/powerpc/kernel/smp.c +1 -0
index 442d8e2..8e59abc 100644
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
 	of_node_put(np);
 	return of_get_ibm_chip_id(np);
 }
+EXPORT_SYMBOL(cpu_to_chip_id);
 
 /* Helper routines for cpu to core mapping */
 int cpu_core_index_of_thread(int cpu)
#2 lore raw
Quoted 10 lines · Benjamin Herrenschmidt
Quoted 6 lines · Guenter Roeck

powerpc allmodconfig build fails with:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

The problem was introduced with commit 15863ff3b (powerpc: Make chip-id information available to userspace).

Thanks, I'll send that to Linus asap.

Verified on today's Linus tree. This issue is fixed.

Thanks a lot.

-Vasant

Quoted 30 lines

Ben.

Quoted 14 lines

Export the missing symbol.

Cc Vasant Hegde <[email protected]>
Cc Shivaprasad G Bhat <[email protected]>
---
  arch/powerpc/kernel/smp.c |    1 +
  1 file changed, 1 insertion(+)
arch/powerpc/kernel/smp.c +0 -0
index 442d8e2..8e59abc 100644

arch/powerpc/kernel/smp.c int cpu_to_chip_id(int cpu) · line 617

Quoted 7 lines
arch/powerpc/kernel/smp.c +1 -0
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
  	of_node_put(np);
  	return of_get_ibm_chip_id(np);
  }
+EXPORT_SYMBOL(cpu_to_chip_id);
 
  /* Helper routines for cpu to core mapping */
  int cpu_core_index_of_thread(int cpu)

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev