Skip to contentSkip to conversation

bug[#43]: kgdboe: netpoll: Should handle ETH_P_ARP other than ETH_P_IP in netpoll_neigh_reply

PATCH In review Sonic Zhang 2 participants 2 messages Sep 11, 2013 – Sep 12, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bug[#43]: kgdboe: netpoll: Should handle ETH_P_ARP other than ETH_P_IP in netpoll_neigh_reply

From: Sonic Zhang <[email protected]>

The received ARP request type in the Ethernet packet head is ETH_P_ARP other than ETH_P_IP.

---
 net/core/netpoll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/netpoll.c +1 -1
index 2c637e9..c3c7b27 100644
@@ -550,7 +550,7 @@ static void netpoll_neigh_reply(struct sk_buff *skb, struct netpoll_info *npinfo
 		return;
 
 	proto = ntohs(eth_hdr(skb)->h_proto);
-	if (proto == ETH_P_IP) {
+	if (proto == ETH_P_ARP) {
 		struct arphdr *arp;
 		unsigned char *arp_ptr;
 		/* No arp on this interface */
Signature · 1 line
1.8.2.3
maintainer
#1 lore raw

From: Sonic Zhang <[email protected]>
Date: Wed, 11 Sep 2013 11:31:53 +0800

Quoted 5 lines

From: Sonic Zhang <[email protected]>

The received ARP request type in the Ethernet packet head is ETH_P_ARP other than ETH_P_IP.

This bug was introduced by commit b7394d2429c198b1da3d46ac39192e891029ec0f ("netpoll: prepare for ipv6")

I'll apply this, thank you.