Skip to contentSkip to conversation

powerpc/p1010rdb-pb: add support for p1010rdb-pb board

PATCH New Shengzhou Liu 2 participants 5 messages Aug 13, 2013 – Sep 12, 2013 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/p1010rdb-pb: add support for p1010rdb-pb board

Add support for freescale P1010RDB-PB board.

---
 board/freescale/p1010rdb/law.c      |    2 -
 board/freescale/p1010rdb/p1010rdb.c |  302 ++++++++++++++++++++++++++++++++---
 board/freescale/p1010rdb/tlb.c      |    4 -
 boards.cfg                          |   21 +++
 include/configs/P1010RDB.h          |  111 ++++++++++---
 5 files changed, 383 insertions(+), 57 deletions(-)
board/freescale/p1010rdb/law.c +0 -2
index 0045127..ed41a05 100644
@@ -9,11 +9,9 @@
 #include <asm/mmu.h>
 
 struct law_entry law_table[] = {
-#ifndef CONFIG_SDCARD
 	SET_LAW(CONFIG_SYS_FLASH_BASE_PHYS, LAW_SIZE_32M, LAW_TRGT_IF_IFC),
 	SET_LAW(CONFIG_SYS_CPLD_BASE_PHYS, LAW_SIZE_128K, LAW_TRGT_IF_IFC),
 	SET_LAW(CONFIG_SYS_NAND_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_IFC),
-#endif
 };
 
 int num_law_entries = ARRAY_SIZE(law_table);
board/freescale/p1010rdb/p1010rdb.c +276 -26

409 lines not on this page · raw message

board/freescale/p1010rdb/tlb.c +0 -4
index 77a8043..a7af0f6 100644
@@ -42,7 +42,6 @@ struct fsl_e_tlb_entry tlb_table[] = {
 			0, 1, BOOKE_PAGESZ_1M, 1),
 
 #ifndef CONFIG_SPL_BUILD
-#ifndef CONFIG_SDCARD
 	SET_TLB_ENTRY(1, CONFIG_SYS_FLASH_BASE, CONFIG_SYS_FLASH_BASE_PHYS,
 			MAS3_SX|MAS3_SR, MAS2_W|MAS2_G,
 			0, 2, BOOKE_PAGESZ_16M, 1),
@@ -51,7 +50,6 @@ struct fsl_e_tlb_entry tlb_table[] = {
 			CONFIG_SYS_FLASH_BASE_PHYS + 0x1000000,
 			MAS3_SX|MAS3_SR, MAS2_W|MAS2_G,
 			0, 3, BOOKE_PAGESZ_16M, 1),
-#endif
 
 #ifdef CONFIG_PCI
 	/* *I*G* - PCI */
@@ -66,7 +64,6 @@ struct fsl_e_tlb_entry tlb_table[] = {
 #endif
 #endif
 
-#ifndef CONFIG_SDCARD
 	/* *I*G - Board CPLD  */
 	SET_TLB_ENTRY(1, CONFIG_SYS_CPLD_BASE, CONFIG_SYS_CPLD_BASE_PHYS,
 			MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
@@ -75,7 +72,6 @@ struct fsl_e_tlb_entry tlb_table[] = {
 	SET_TLB_ENTRY(1, CONFIG_SYS_NAND_BASE, CONFIG_SYS_NAND_BASE_PHYS,
 			MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
 			0, 7, BOOKE_PAGESZ_1M, 1),
-#endif
 
 #if defined(CONFIG_SYS_RAMBOOT) || defined(CONFIG_SPL)
 	SET_TLB_ENTRY(1, CONFIG_SYS_DDR_SDRAM_BASE, CONFIG_SYS_DDR_SDRAM_BASE,
boards.cfg +21 -0
index 944ed4c..5bb6548 100644
@@ -789,6 +789,27 @@ P1010RDB_NOR_SECBOOT         powerpc     mpc85xx     p1010rdb            freesca
 P1010RDB_SDCARD              powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB,SDCARD
 P1010RDB_SPIFLASH            powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB,SPIFLASH
 P1010RDB_SPIFLASH_SECBOOT    powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB,SPIFLASH,SECURE_BOOT
+P1010RDB-PB_36BIT_NAND       powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,36BIT,NAND
+P1010RDB-PB_36BIT_NAND_SECBOOT powerpc   mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,36BIT,NAND_SECBOOT,SECURE_BOOT
+P1010RDB-PB_36BIT_NOR        powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,
+36BIT
+P1010RDB-PB_36BIT_NOR_SECBOOT powerpc    mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,
+36BIT,SECURE_BOOT
+P1010RDB-PB_36BIT_SDCARD     powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,
+36BIT,SDCARD
+P1010RDB-PB_36BIT_SPIFLASH   powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,
+36BIT,SPIFLASH
+P1010RDB-PB_36BIT_SPIFLASH_SECBOOT powerpc mpc85xx   p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,
+36BIT,SPIFLASH,SECURE_BOOT
+P1010RDB-PB_NAND             powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,
+NAND
+P1010RDB-PB_NAND_SECBOOT     powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,NAND_SECBOOT,SECURE_BOOT
+P1010RDB-PB_NOR              powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB
+P1010RDB-PB_NOR_SECBOOT      powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,SECURE_BOOT
+P1010RDB-PB_SDCARD           powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,SDCARD
+P1010RDB-PB_SPIFLASH         powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,
+SPIFLASH
+P1010RDB-PB_SPIFLASH_SECBOOT powerpc     mpc85xx     p1010rdb            freescale      -           P1010RDB:P1010RDB_PB,SPIFLASH,SECURE_BOOT
 P1011RDB                     powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P1011RDB
 P1011RDB_36BIT               powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P1011RDB,36BIT
 P1011RDB_36BIT_SDCARD        powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P1011RDB,36BIT,SDCARD
include/configs/P1010RDB.h +86 -25

204 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 powerpc/p1010rdb-pb: add support for p1010rdb-pb board

Quoted 16 lines · Shengzhou Liu

Add support for freescale P1010RDB-PB board.

---
 board/freescale/p1010rdb/law.c      |    2 -
 board/freescale/p1010rdb/p1010rdb.c |  302 ++++++++++++++++++++++++++++++++---
 board/freescale/p1010rdb/tlb.c      |    4 -
 boards.cfg                          |   21 +++
 include/configs/P1010RDB.h          |  111 ++++++++++---
 5 files changed, 383 insertions(+), 57 deletions(-)
board/freescale/p1010rdb/law.c +0 -0
index 0045127..ed41a05 100644

board/freescale/p1010rdb/law.c line 15

Quoted 9 lines
board/freescale/p1010rdb/law.c +0 -2
@@ -9,11 +9,9 @@
 #include <asm/mmu.h>
 
 struct law_entry law_table[] = {
-#ifndef CONFIG_SDCARD
 	SET_LAW(CONFIG_SYS_FLASH_BASE_PHYS, LAW_SIZE_32M, LAW_TRGT_IF_IFC),
 	SET_LAW(CONFIG_SYS_CPLD_BASE_PHYS, LAW_SIZE_128K, LAW_TRGT_IF_IFC),
 	SET_LAW(CONFIG_SYS_NAND_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_IFC),
-#endif
 };

If this is applicable to the current board as well (is that P1010RDB-PA?), then it isn't related to adding PB support and thus belongs in a separate patch.

board/freescale/p1010rdb/law.c line 16

Quoted 1 line
board/freescale/p1010rdb/law.c +1 -0
+uint pin_mux;

This is too generic for a global variable. Does it even need to be global?

Quoted 8 lines
board/freescale/p1010rdb/law.c +0 -1
-#ifndef CONFIG_SDCARD
 struct cpld_data {
board/freescale/p1010rdb/law.c +1 -0
 	u8 cpld_ver; /* cpld revision */
+#if defined(CONFIG_P1010RDB)
 	u8 pcba_ver; /* pcb revision number */
 	u8 twindie_ddr3;
 	u8 res1[6];

board/freescale/p1010rdb/law.c struct cpld_data { · line 75

Quoted 7 lines
board/freescale/p1010rdb/law.c +3 -0
@@ -51,18 +69,16 @@ struct cpld_data {
 	u8 por1; /* POR Options */
 	u8 por2; /* POR Options */
 	u8 por3; /* POR Options */
+#elif defined(CONFIG_P1010RDB_PB)
+	u8 rom_loc;
+#endif
 };

CONFIG_P1010RDB should be defined if CONFIG_P1010RDB_PB is defined. Define a new CONFIG_P1010RDB_PA (if that's the appropriate name) for things that are specifically for the older revision.

board/freescale/p1010rdb/law.c struct cpld_data { · line 62

Quoted 9 lines
board/freescale/p1010rdb/law.c +1 -4
+#if defined(CONFIG_P1010RDB) && defined(DEBUG)
 void cpld_show(void)
 {
 	struct cpld_data *cpld_data = (void *)(CONFIG_SYS_CPLD_BASE);
 
-	printf("CPLD: V%x.%x PCBA: V%x.0\n",
-		in_8(&cpld_data->cpld_ver) & 0xF0,
-		in_8(&cpld_data->cpld_ver) & 0x0F,
-		in_8(&cpld_data->pcba_ver) & 0x0F);

Why are you removing this? Where is cpld_show() called?

board/freescale/p1010rdb/law.c void fdt_del_sdhc(void *blob) · line 457

Quoted 13 lines
board/freescale/p1010rdb/law.c +9 -0
@@ -246,6 +446,16 @@ void fdt_del_sdhc(void *blob)
 	}
 }
 
+void fdt_del_ifc(void *blob)
+{
+	int nodeoff = 0;
+
+	while ((nodeoff = fdt_node_offset_by_compatible(blob, 0,
+		"fsl,ifc")) >= 0) {
+		fdt_del_node(blob, nodeoff);
+	}
+}

Is this PB-specific? If no, why is it in this patch? If not, why isn't the caller guarded by the PB ifdef?

Quoted 9 lines
board/freescale/p1010rdb/law.c +9 -0
+static int pin_mux_cmd(cmd_tbl_t *cmdtp, int flag, int argc,
+					char * const argv[])
+{
+	if (argc < 2)
+		return CMD_RET_USAGE;
+	if (strcmp(argv[1], "ifc") == 0)
+		config_board_mux(MUX_TYPE_IFC);
+	else if (strcmp(argv[1], "sdhc") == 0)
+		config_board_mux(MUX_TYPE_SDHC);

board/freescale/p1010rdb/law.c void fdt_del_sdhc(void *blob)

Quoted 10 lines
board/freescale/p1010rdb/law.c +10 -0
+	else
+		return CMD_RET_USAGE;
+	return 0;
+}
+
+U_BOOT_CMD(
+	mux, 2, 0, pin_mux_cmd,
+	"configure multiplexing pin for IFC/SDHC bus in runtime",
+	"bus_type (e.g. mux sdhc)"
+);

Are you sure this is a good idea? What happens to the drivers using said hardware at the time? Granted they should be idle when not running a command that actively uses them, but still... Usually we use hwconfig for this sort of thing.

Quoted 22 lines
board/freescale/p1010rdb/law.c +5 -7
@@ -203,25 +207,24 @@ extern unsigned long get_sdram_size(void);
 #define CONFIG_SYS_DDR_INIT_ADDR	0x00000000
 #define CONFIG_SYS_DDR_INIT_EXT_ADDR	0x00000000
 #define CONFIG_SYS_DDR_MODE_CONTROL	0x00000000
-
 #define CONFIG_SYS_DDR_ZQ_CONTROL	0x89080600
 #define CONFIG_SYS_DDR_SR_CNTR		0x00000000
 #define CONFIG_SYS_DDR_RCW_1		0x00000000
 #define CONFIG_SYS_DDR_RCW_2		0x00000000
-#define CONFIG_SYS_DDR_CONTROL		0x470C0000	/* Type = DDR3  */
-#define CONFIG_SYS_DDR_CONTROL_2	0x04401010
+#define CONFIG_SYS_DDR_CONTROL		0xc70c0008	/* Type = DDR3  */
+#define CONFIG_SYS_DDR_CONTROL_2	0x24401000
 #define CONFIG_SYS_DDR_TIMING_4		0x00000001
-#define CONFIG_SYS_DDR_TIMING_5		0x03402400
+#define CONFIG_SYS_DDR_TIMING_5		0x02401400
 
-#define CONFIG_SYS_DDR_TIMING_3_800	0x00020000
-#define CONFIG_SYS_DDR_TIMING_0_800	0x00330004
-#define CONFIG_SYS_DDR_TIMING_1_800	0x6f6B4644
+#define CONFIG_SYS_DDR_TIMING_3_800	0x00030000
+#define CONFIG_SYS_DDR_TIMING_0_800	0x00110104

board/freescale/p1010rdb/law.c extern unsigned long get_sdram_size(void); · line 227

Quoted 10 lines
board/freescale/p1010rdb/law.c +4 -3
+#define CONFIG_SYS_DDR_TIMING_1_800	0x6f6b8644
 #define CONFIG_SYS_DDR_TIMING_2_800	0x0FA888CF
 #define CONFIG_SYS_DDR_CLK_CTRL_800	0x03000000
-#define CONFIG_SYS_DDR_MODE_1_800	0x40461520
-#define CONFIG_SYS_DDR_MODE_2_800	0x8000c000
+#define CONFIG_SYS_DDR_MODE_1_800	0x00441420
+#define CONFIG_SYS_DDR_MODE_2_800	0x00000000
 #define CONFIG_SYS_DDR_INTERVAL_800	0x0C300100
-#define CONFIG_SYS_DDR_WRLVL_CONTROL_800	0x8655A608
+#define CONFIG_SYS_DDR_WRLVL_CONTROL_800 0x8675f608

Shouldn't this be ifdeffed by the board revision?

Quoted 11 lines
board/freescale/p1010rdb/law.c +11 -0
+#if defined(CONFIG_P1010RDB)
+#define CONFIG_BOOTMODE \
+	"boot_bank0=i2c dev 0; i2c mw 18 1 f1; i2c mw 18 3 f0; \
+mw.b ffb00011 0; mw.b ffb00009 0; reset\0 \
+	boot_bank1=i2c dev 0; i2c mw 18 1 f1; i2c mw 18 3 f0; \
+mw.b ffb00011 0; mw.b ffb00009 1; reset\0 \
+	boot_nand=i2c dev 0; i2c mw 18 1 f9; i2c mw 18 3 f0; \
+mw.b ffb00011 0; mw.b ffb00017 1; reset\0"
+#elif defined(CONFIG_P1010RDB_PB)
+#define CONFIG_BOOTMODE \
+	"boot_bank0=i2c dev 0; i2c mw 18 1 fe; i2c mw 18 3 0; i2c mw 19 1 2; \

board/freescale/p1010rdb/law.c extern unsigned long get_sdram_size(void);

Quoted 10 lines
board/freescale/p1010rdb/law.c +10 -0
+i2c mw 19 3 e1; reset\0 \
+	boot_bank1=i2c dev 0; i2c mw 18 1 fe; i2c mw 18 3 0; i2c mw 19 1 12; \
+i2c mw 19 3 e1; reset\0 \
+	boot_nand=i2c dev 0; i2c mw 18 1 fc; i2c mw 18 3 0; i2c mw 19 1 8; \
+i2c mw 19 3 f7; reset\0 \
+	boot_spi=i2c dev 0; i2c mw 18 1 fa; i2c mw 18 3 0; i2c mw 19 1 0; \
+i2c mw 19 3 f7; reset\0 \
+	boot_sd=i2c dev 0; i2c mw 18 1 f8; i2c mw 18 3 0; i2c mw 19 1 4; \
+i2c mw 19 3 f3; reset\0"
+#endif

Don't put newlines in strings. Do it like this:

#define CONFIG_BOOTMODE \
	"bootb_bank0=i2c dev 0; i2c mw 18 1 fe; i2c mw 18 3 0; " \
	"i2c mw 19 1 2; i2c mw 19 3 e1; reset\0" \
	...

-Scott

A message that is not in the archive (sent off-list or not yet received): 3F453DDFF675A64A89321A1F35281021A8DA99@039-SN1MPN1-004.039d.mgd.msft.net

#3 lore raw

PATCH 1/1 powerpc/p1010rdb-pb: add support for p1010rdb-pb board

Quoted 18 lines · On Thu, 2013-08-29 at 06:10 -0500, Liu Shengzhou-B36685 wrote:
Quoted 8 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, August 14, 2013 8:35 AM
To: Liu Shengzhou-B36685
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] powerpc/p1010rdb-pb: add support for p1010rdb-pb board

Quoted 10 lines

board/freescale/p1010rdb/law.c

Quoted 6 lines

struct law_entry law_table[] = {

board/freescale/p1010rdb/law.c +0 -2
-#ifndef CONFIG_SDCARD
 	SET_LAW(CONFIG_SYS_FLASH_BASE_PHYS, LAW_SIZE_32M, LAW_TRGT_IF_IFC),
 	SET_LAW(CONFIG_SYS_CPLD_BASE_PHYS, LAW_SIZE_128K, LAW_TRGT_IF_IFC),
 	SET_LAW(CONFIG_SYS_NAND_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_IFC),
-#endif  };

If this is applicable to the current board as well (is that P1010RDB-PA?), then it isn't related to adding PB support and thus belongs in a separate patch.

Quoted 1 line

As P1010RDB-PA will no longer be supported officially,

Why? Don't confuse Freescale supporting the board with U-Boot supporting the board.

Quoted 2 lines

but we still keep previous code for P1010RDB-PA. will add some description for P1010RDB-PA in commit message.

I don't see how this answers my question.

Quoted 4 lines
Quoted 2 lines
Quoted 1 line

+uint pin_mux;

This is too generic for a global variable. Does it even need to be global?

Will rename to "static uint sd_ifc_mux", need to be global for invoking in several different functions.

If it's static, it's not global.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
board/freescale/p1010rdb/p1010rdb.c +1 -0
+#if defined(CONFIG_P1010RDB) && defined(DEBUG)
 void cpld_show(void)
 {
 	struct cpld_data *cpld_data = (void *)(CONFIG_SYS_CPLD_BASE);
Quoted 8 lines
Quoted 7 lines

board/freescale/p1010rdb/p1010rdb.c struct cpld_data { · line 63

Quoted 4 lines
board/freescale/p1010rdb/p1010rdb.c +0 -4
-	printf("CPLD: V%x.%x PCBA: V%x.0\n",
-		in_8(&cpld_data->cpld_ver) & 0xF0,
-		in_8(&cpld_data->cpld_ver) & 0x0F,
-		in_8(&cpld_data->pcba_ver) & 0x0F);

Why are you removing this? Where is cpld_show() called?

previous code for debug, actually no longer needed, will remove cpld_show().

Make such cleanup a separate patch.

Quoted 17 lines
Quoted 4 lines
Quoted 4 lines
(quoted diff) +0 -0
@@ -246,6 +446,16 @@ void fdt_del_sdhc(void *blob)
 	}
 }
 
Quoted 13 lines

board/freescale/p1010rdb/p1010rdb.c void fdt_del_sdhc(void *blob) · line 457

Quoted 9 lines
board/freescale/p1010rdb/p1010rdb.c +9 -0
+void fdt_del_ifc(void *blob)
+{
+	int nodeoff = 0;
+
+	while ((nodeoff = fdt_node_offset_by_compatible(blob, 0,
+		"fsl,ifc")) >= 0) {
+		fdt_del_node(blob, nodeoff);
+	}
+}

Is this PB-specific? If no, why is it in this patch? If not, why isn't the caller guarded by the PB ifdef?

Quoted 1 line

for both PA and PB, this patch also tune for PA(though PA no longer be supported officially).

Why is it in this patch?

Quoted 11 lines
Quoted 10 lines

board/freescale/p1010rdb/p1010rdb.c int misc_init_r(void) · line 594

Quoted 6 lines
board/freescale/p1010rdb/p1010rdb.c +6 -0
+
+U_BOOT_CMD(
+	mux, 2, 0, pin_mux_cmd,
+	"configure multiplexing pin for IFC/SDHC bus in runtime",
+	"bus_type (e.g. mux sdhc)"
+);

Are you sure this is a good idea? What happens to the drivers using said hardware at the time? Granted they should be idle when not running a command that actively uses them, but still... Usually we use hwconfig for this sort of thing.

Quoted 4 lines

The patch supports two ways simultaneously:
1) mux command: for temporary use case in runtime for accessing IFC and SDHC without reboot, this way is very useful in practice and in some test cases.
2) hwconfig: for long-term use case.

This should be a separate patch from basic board support.

Quoted 11 lines
Quoted 8 lines

include/configs/P1010RDB.h extern unsigned long get_sdram_size(void); · line 227

Quoted 6 lines
include/configs/P1010RDB.h +3 -2
-#define CONFIG_SYS_DDR_MODE_2_800	0x8000c000
+#define CONFIG_SYS_DDR_MODE_1_800	0x00441420
+#define CONFIG_SYS_DDR_MODE_2_800	0x00000000
 #define CONFIG_SYS_DDR_INTERVAL_800	0x0C300100
-#define CONFIG_SYS_DDR_WRLVL_CONTROL_800	0x8655A608
+#define CONFIG_SYS_DDR_WRLVL_CONTROL_800 0x8675f608

Shouldn't this be ifdeffed by the board revision?

No, this is for both PA and PB. old parameters were not the optimal, will add some description for P1010RDB-PA in commit message.

Separate patch.

-Scott

A message that is not in the archive (sent off-list or not yet received): 3F453DDFF675A64A89321A1F35281021ABA019@039-SN1MPN1-004.039d.mgd.msft.net

#5 lore raw

PATCH 1/1 powerpc/p1010rdb-pb: add support for p1010rdb-pb board

Quoted 29 lines · On Wed, 2013-09-11 at 00:58 -0500, Liu Shengzhou-B36685 wrote:

Scott, please review new version http://patchwork.ozlabs.org/patch/273539/

Quoted 26 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 04, 2013 11:57 PM
To: Liu Shengzhou-B36685
Cc: Wood Scott-B07421; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] powerpc/p1010rdb-pb: add support for p1010rdb-pb board

Quoted 17 lines · On Thu, 2013-08-29 at 06:10 -0500, Liu Shengzhou-B36685 wrote:
Quoted 17 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, August 14, 2013 8:35 AM
To: Liu Shengzhou-B36685
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] powerpc/p1010rdb-pb: add support for p1010rdb-pb board

Quoted 6 lines

struct law_entry law_table[] = {

board/freescale/p1010rdb/law.c +0 -1
-#ifndef CONFIG_SDCARD
 	SET_LAW(CONFIG_SYS_FLASH_BASE_PHYS, LAW_SIZE_32M, LAW_TRGT_IF_IFC),
 	SET_LAW(CONFIG_SYS_CPLD_BASE_PHYS, LAW_SIZE_128K, LAW_TRGT_IF_IFC),
 	SET_LAW(CONFIG_SYS_NAND_BASE_PHYS, LAW_SIZE_1M,

LAW_TRGT_IF_IFC), -#endif };

If this is applicable to the current board as well (is that P1010RDB-PA?), then it isn't related to adding PB support and thus belongs

Quoted 7 lines
Quoted 5 lines

in a separate patch.

Quoted 2 lines
Quoted 1 line

As P1010RDB-PA will no longer be supported officially,

Why? Don't confuse Freescale supporting the board with U-Boot supporting the board.

Ever PMO team said to remove the code/document of old P1010RDB-PA.

I don't know who PMO is, but they don't dictate what a community project such as U-Boot does. If there is a good argument to make for dropping PA (such as talking about how limited the distribution of the boards has been so far, though I was not under the impression that it was particularly limited), then make that argument. Otherwise, we're keeping PA support and it's irrelevant that some people in Freescale don't care about it any more (except for York, of course).

Quoted 1 line

But I prefer to adhere to reserve code support for old board.

Then what's up with statements like, "we will no longer product and maintain old board, the change can be regarded as for new board"?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

but we still keep previous code for P1010RDB-PA. will add some description for P1010RDB-PA in commit message.

I don't see how this answers my question.

I meant new version of this patch would be updated with subject and commit description to cover all the changes of both new and old boards instead of separating patch.

No, please keep PB support separate from anything intended to change how PA works.

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line

+uint pin_mux;

This is too generic for a global variable. Does it even need to be global?

Will rename to "static uint sd_ifc_mux", need to be global for invoking in

several different functions.

If it's static, it's not global.

Use 'static' to limits it as global just in the scope of this module.

My point is that the term "global" usually means program-wide rather than file-scope, especially when talking about namespacing.

Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines

board/freescale/p1010rdb/p1010rdb.c struct cpld_data { · line 63

Quoted 9 lines
board/freescale/p1010rdb/p1010rdb.c +1 -4
+#if defined(CONFIG_P1010RDB) && defined(DEBUG)
 void cpld_show(void)
 {
 	struct cpld_data *cpld_data = (void *)(CONFIG_SYS_CPLD_BASE);
 
-	printf("CPLD: V%x.%x PCBA: V%x.0\n",
-		in_8(&cpld_data->cpld_ver) & 0xF0,
-		in_8(&cpld_data->cpld_ver) & 0x0F,
-		in_8(&cpld_data->pcba_ver) & 0x0F);

Why are you removing this? Where is cpld_show() called?

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

previous code for debug, actually no longer needed, will remove cpld_show().

Make such cleanup a separate patch.

new version of this patch has covered all the changes. I don't think it's really necessary as a separate patch.

I disagree and will not review it in this state (the point is to make it easier to review -- both now and during future code archaeology). If York is happy with it like this, then that's between the two of you...

Quoted 13 lines
Quoted 13 lines
Quoted 9 lines
Quoted 9 lines

board/freescale/p1010rdb/p1010rdb.c int misc_init_r(void) · line 594

Quoted 5 lines
board/freescale/p1010rdb/p1010rdb.c +5 -0
+U_BOOT_CMD(
+	mux, 2, 0, pin_mux_cmd,
+	"configure multiplexing pin for IFC/SDHC bus in runtime",
+	"bus_type (e.g. mux sdhc)"
+);

Are you sure this is a good idea? What happens to the drivers using said hardware at the time? Granted they should be idle when not running a command that actively uses them, but still... Usually we use

hwconfig for this sort of thing.

Quoted 3 lines

The patch supports two ways simultaneously:
1) mux command: for temporary use case in runtime for accessing IFC and SDHC

Quoted 7 lines
Quoted 5 lines

without reboot,

Quoted 2 lines

this way is very useful in practice and in some test cases.
2) hwconfig: for long-term use case.

This should be a separate patch from basic board support.

Yes, better as a separate patch, but it's not really necessary to split it, we will no longer product and maintain old board, the change can be regarded as for new board.

Huh? I don't see what this has to do with PA versus PB at all. It's not even really about p1010rdb at all. It's a new feature for controlling p1010 pin muxing.

-Scott

#6 lore raw

PATCH 1/1 powerpc/p1010rdb-pb: add support for p1010rdb-pb board

Quoted 11 lines · Scott Wood
Quoted 10 lines · On Wed, 2013-09-11 at 00:58 -0500, Liu Shengzhou-B36685 wrote:

Scott, please review new version http://patchwork.ozlabs.org/patch/273539/

Quoted 7 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 04, 2013 11:57 PM
To: Liu Shengzhou-B36685
Cc: Wood Scott-B07421; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] powerpc/p1010rdb-pb: add support for p1010rdb-pb board

Sorry about the HTML -- the mouse pointer was in the wrong place when scrolling, and it toggled the option instead of scrolling the message. :-P

-Scott