regulator: palmas: Remove wrong comment for the equation calculating num_voltages
Subsystems (2)
PATCH 1/1 regulator: palmas: Remove wrong comment for the equation calculating num_voltages
Current equation on the comment is wrong.
For linear mapping starting from 0, the equation is (maxV-minV)/stepV + 1. Since the linear mapping for PALMAS is not all starting from 0, the equation on the comment is not useful and misleading. Thus remove it.
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/palmas-regulator.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/regulator/palmas-regulator.c +0 -6
@@ -201,12 +201,6 @@ static unsigned int palmas_smps_ramp_delay[4] = {0, 10000, 5000, 2500};#define SMPS_CTRL_MODE_ECO 0x02#define SMPS_CTRL_MODE_PWM 0x03 -/* These values are derived from the data sheet. And are the number of steps -* where there is a voltage change, the ranges at beginning and end of register -* max/min values where there are no change are ommitted. -* -* So they are basically (maxV-minV)/stepV -*/ #define PALMAS_SMPS_NUM_VOLTAGES 122#define PALMAS_SMPS10_NUM_VOLTAGES 2#define PALMAS_LDO_NUM_VOLTAGES 50
Signature · 1 line
1.8.1.2
Quoted 4 lines · Axel Lin
Current equation on the comment is wrong.
For linear mapping starting from 0, the equation is (maxV-minV)/stepV + 1. Since the linear mapping for PALMAS is not all starting from 0, the equation on the comment is not useful and misleading. Thus remove it.
Applied, thanks.