Skip to contentSkip to conversation

ISDN, hfcpci Fix uninitialized warning

PATCH New Prarit Bhargava 1 participant 1 message Sep 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ISDN, hfcpci Fix uninitialized warning

Fix uninitialized warning. Use same fix as
drivers/media/pci/cx18/cx18-alsa-main.c

CC [M] drivers/isdn/hardware/mISDN/hfcpci.o drivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’:
drivers/isdn/hardware/mISDN/hfcpci.c:2298:2: error: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result [-Werror=unused-result]
(void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
^

---
 drivers/isdn/hardware/mISDN/hfcpci.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/isdn/hardware/mISDN/hfcpci.c +5 -1
index 7f910c7..2373b44 100644
@@ -2295,8 +2295,12 @@ _hfcpci_softirq(struct device *dev, void *arg)
 static void
 hfcpci_softirq(void *arg)
 {
-	(void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
+	int ret;
+
+	ret = driver_for_each_device(&hfc_driver.driver, NULL, arg,
 				      _hfcpci_softirq);
+	if (unlikely(ret))
+		pr_warn("hfcpci_softirq: driver softirq failed\n");
 
 	/* if next event would be in the past ... */
 	if ((s32)(hfc_jiffies + tics - jiffies) <= 0)
Signature · 1 line
1.7.9.3