atm: nicstar: fix regression made by previous patch
Subsystems (3)
PATCH 1/1 atm: nicstar: fix regression made by previous patch
The commit 8390f814 "atm: nicstar: re-use native mac_pton() helper" did a usefull thing. However, mac_pton() returns 1 in the case of the successfully parsed input. This patch fixes a typo.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/atm/nicstar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/atm/nicstar.c +1 -1
@@ -778,7 +778,7 @@ static int ns_init_card(int i, struct pci_dev *pcidev)return error; } -if (mac[i] ==NULL ||mac_pton (mac[i], card->atmdev->esi)) { +if (mac[i] ==NULL || !mac_pton (mac[i], card->atmdev->esi)) {nicstar_read_eprom (card->membase,NICSTAR_EPROM_MAC_ADDR_OFFSET , card->atmdev->esi,6 ); if (memcmp(card->atmdev->esi, "\x00\x00\x00\x00\x00\x00", 6) ==
Signature · 1 line
1.8.4.rc3
From: Andy Shevchenko <[email protected]>
Date: Fri, 13 Sep 2013 18:00:58 +0300
Quoted 5 lines
The commit
8390f814"atm: nicstar: re-use nativemac_pton()helper" did a usefull thing. However,mac_pton()returns 1 in the case of the successfully parsed input. This patch fixes a typo.Signed-off-by Andy Shevchenko <[email protected]>
Applied.