hwmon: (mc13783-adc) Increase size of name string
Guenter Roeck
maintainerPATCH 4/12 hwmon: (mc13783-adc) Increase size of name string
smatch complains about
mc13783_adc_probe() error: snprintf() chops off the last chars of 'id->name': 20 +vs 10
Use PLATFORM_NAME_SIZE instead of '10' as size when declaring the name variable.
--- drivers/hwmon/mc13783-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/mc13783-adc.c +1 -1
@@ -37,7 +37,7 @@struct mc13783_adc_priv {struct mc13xxx *mc13xxx;struct device *hwmon_dev; -char name[10 ]; +char name[PLATFORM_NAME_SIZE ]; }; static ssize_t mc13783_adc_show_name(struct device *dev, struct device_attribute
Signature · 7 lines
1.7.9.7 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 9 lines · Guenter Roeck
smatch complains about
mc13783_adc_probe()error:snprintf()chops off the last chars of 'id->name': 20 +vs 10Use
PLATFORM_NAME_SIZEinstead of '10' as size when declaring the name variable.Signed-off-by Guenter Roeck <[email protected]>
Note that Dan Carpenter had been sending the same patch 19 months ago:
http://lists.lm-sensors.org/pipermail/lm-sensors/2012-February/035178.html
I wasn't sure what to do with it and finally forgot about it, sorry.
Quoted 9 lines
--- drivers/hwmon/mc13783-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hwmon/mc13783-adc.c +0
-0
drivers/hwmon/mc13783-adc.c line 43
Quoted 8 lines
drivers/hwmon/mc13783-adc.c +1
-1@@ -37,7 +37,7 @@struct mc13783_adc_priv {struct mc13xxx *mc13xxx;struct device *hwmon_dev; -char name[10 ]; +char name[PLATFORM_NAME_SIZE ]; }; static ssize_t mc13783_adc_show_name(struct device *dev, struct device_attribute
I admit I find it a bit sad to allocate more memory than we need just to make a static analyzer happy. Static analyzers are supposed to help developers improve their code, not make it less efficient.
That being said, I tried to rewrite the code in a way which was more obviously correct (to a static analyzer), but what I came up with was not very appealing.
So if everybody is OK with the simple buffer size fix above, then so am I.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Guenter Roeck
maintainerQuoted 39 lines · Jean Delvare
Quoted 9 lines · Guenter Roeck
smatch complains about
mc13783_adc_probe()error:snprintf()chops off the last chars of 'id->name': 20 +vs 10Use
PLATFORM_NAME_SIZEinstead of '10' as size when declaring the name variable.Signed-off-by Guenter Roeck <[email protected]>Note that Dan Carpenter had been sending the same patch 19 months ago:
http://lists.lm-sensors.org/pipermail/lm-sensors/2012-February/035178.html
I wasn't sure what to do with it and finally forgot about it, sorry.
Quoted 9 lines
--- drivers/hwmon/mc13783-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hwmon/mc13783-adc.c +0
-0drivers/hwmon/mc13783-adc.c line 43
Quoted 8 lines
drivers/hwmon/mc13783-adc.c +1
-1@@ -37,7 +37,7 @@struct mc13783_adc_priv {struct mc13xxx *mc13xxx;struct device *hwmon_dev; -char name[10 ]; +char name[PLATFORM_NAME_SIZE ]; }; static ssize_t mc13783_adc_show_name(struct device *dev, struct device_attributeI admit I find it a bit sad to allocate more memory than we need just to make a static analyzer happy. Static analyzers are supposed to help developers improve their code, not make it less efficient.
Quoted 4 lines
That being said, I tried to rewrite the code in a way which was more obviously correct (to a static analyzer), but what I came up with was not very appealing.
For me there is always a trade-off. In this case, using an arbitrary size of 10 adds at least some risk. Anyone ever messing with the variable might inadvertently introduce a bug. So I thought it was worth changing it to use a well defined constant instead.
There are other cases where static analyzers create noise - for example, smatch complains about ignored return values in detect functions which are replaced with -ENODEV. But on the other side it caught a number of inconsistencies and at least one real bug, so I am perfectly happy with the false positives.
Overall my approach is that I try to make static analyzers happy if it doesn't create undue pain, simply because I think that they are valuable tools to have around, and I don't want real problems to disappear in the noise.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors