hwmon: (acpi_power_meter) Don't crash the kernel unnecessarily
Guenter Roeck
maintainerPATCH 8/12 hwmon: (acpi_power_meter) Don't crash the kernel unnecessarily
acpi_power_meter crashes the kernel if it detects an unexpected event or an internal implementation error. While the detected conditions suggest that there is a bug in the code, the condition is not fatal. Replace BUG() with WARN().
Signed-off-by Guenter Roeck <[email protected]>
--- drivers/hwmon/acpi_power_meter.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/hwmon/acpi_power_meter.c +8 -3
@@ -381,8 +381,10 @@ static ssize_t show_str(struct device *dev, val = resource->oem_info;break ;default : -BUG (); +WARN (1 ,"Implementation error: unexpected attribute index %d\n" , + attr->index); val ="" ; +break ; }return sprintf (buf,"%s\n" , val);
@@ -436,7 +438,9 @@ static ssize_t show_val(struct device *dev, val = resource->trip[attr->index -7 ] *1000 ;break ;default : -BUG (); +WARN (1 ,"Implementation error: unexpected attribute index %d\n" , + attr->index); +break ; }return sprintf (buf,"%llu\n" , val);
@@ -855,7 +859,8 @@ static void acpi_power_meter_notify(struct acpi_device *device, u32 event)dev_info (&device->dev,"Capping in progress.\n" );break ;default : -BUG (); +WARN (1 ,"Unexpected event %d\n" , event); +break ; }mutex_unlock (&resource->lock);
Signature · 7 lines
1.7.9.7 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors