Skip to contentSkip to conversation

python-crc16: new package

PATCH Superseded Michael Rommel 2 participants 3 messages Sep 14, 2013 – Sep 17, 2013

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 python-crc16: new package

A python library that calculates CRC checksums of the CCITT/XModem variant.

---
Changes v1 -> v2
* corrected a typo in the filename for the .mk file

 package/Config.in                    |    1 +
 package/python-crc16/Config.in       |   11 +++++++++++
 package/python-crc16/python-crc16.mk |   34 ++++++++++++++++++++++++++++++++++
 3 files changed, 46 insertions(+)
 create mode 100644 package/python-crc16/Config.in
 create mode 100644 package/python-crc16/python-crc16.mk
package/Config.in +1 -0
index 2884bfb..ccd5e11 100644
@@ -385,6 +385,7 @@ source "package/python/Config.in"
 if BR2_PACKAGE_PYTHON
 menu "external python modules"
 source "package/python-bottle/Config.in"
+source "package/python-crc16/Config.in"
 source "package/python-dpkt/Config.in"
 source "package/python-id3/Config.in"
 source "package/python-mad/Config.in"
package/python-crc16/Config.in new file +11 -0
new file mode 100644
index 0000000..d5c62e9
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_PYTHON_CRC16
+	bool "python-crc16"
+	depends on BR2_PACKAGE_PYTHON
+	help
+	  This library calculates only CRC16 (16-bit codes) and the
+	  only supported variant at the moment is CRC-CCITT (XModem).
+	  CRC is a way of detecting accidental changes in data storage
+	  or transmission. There are many variants of CRC and CRC16,
+	  in particular.
+
+	  http://pycrc16.googlecode.com/files/crc16-0.1.1.tar.gz
package/python-crc16/python-crc16.mk new file +34 -0
new file mode 100644
index 0000000..0119ab8
@@ -0,0 +1,34 @@
+################################################################################
+#
+# python-crc16
+#
+################################################################################
+
+PYTHON_CRC16_VERSION = 0.1.1
+PYTHON_CRC16_SOURCE = crc16-$(PYTHON_CRC16_VERSION).tar.gz
+PYTHON_CRC16_SITE = http://pycrc16.googlecode.com/files/
+PYTHON_CRC16_LICENSE = LGPLv3+
+PYTHON_CRC16_LICENSE_FILES = COPYING.txt
+PYTHON_CRC16_DEPENDENCIES = python host-python
+
+PYTHON_CRC16_PARAMS = CC="$(TARGET_CC)" \
+		CFLAGS="$(TARGET_CFLAGS)" \
+		LDSHARED="$(TARGET_CC) -shared" \
+		CROSS_COMPILING=yes \
+		_python_sysroot=$(STAGING_DIR) \
+		_python_srcdir=$(PYTHON_DIR) \
+		_python_prefix=/usr \
+		_python_exec_prefix=/usr
+
+define PYTHON_CRC16_BUILD_CMDS
+	(cd $(@D); $(PYTHON_CRC16_PARAMS) \
+		$(HOST_DIR)/usr/bin/python setup.py build)
+endef
+
+define PYTHON_CRC16_INSTALL_TARGET_CMDS
+	(cd $(@D); $(PYTHON_CRC16_PARAMS) \
+		$(HOST_DIR)/usr/bin/python setup.py install \
+		--prefix=$(TARGET_DIR)/usr)
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 python-crc16: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Michael" == Michael Rommel <[email protected]> writes:

Michael> A python library that calculates CRC checksums of the CCITT/XModem Michael> variant.

Michael> Signed-off-by: Michael Rommel <[email protected]> Michael> ---
Michael> Changes v1 -> v2
Michael> * corrected a typo in the filename for the .mk file

 Michael>  package/Config.in                    |    1 +
 Michael>  package/python-crc16/Config.in       |   11 +++++++++++
 Michael>  package/python-crc16/python-crc16.mk |   34 ++++++++++++++++++++++++++++++++++
 Michael>  3 files changed, 46 insertions(+)
 Michael>  create mode 100644 package/python-crc16/Config.in
 Michael>  create mode 100644 package/python-crc16/python-crc16.mk

Michael> diff --git a/package/Config.in b/package/Config.in Michael> index 2884bfb..ccd5e11 100644
Michael> --- a/package/Config.in
Michael> +++ b/package/Config.in
Michael> @@ -385,6 +385,7 @@ source "package/python/Config.in"

 Michael>  if BR2_PACKAGE_PYTHON
 Michael>  menu "external python modules"
 Michael>  source "package/python-bottle/Config.in"
 Michael> +source "package/python-crc16/Config.in"
 Michael>  source "package/python-dpkt/Config.in"
 Michael>  source "package/python-id3/Config.in"
 Michael>  source "package/python-mad/Config.in"
 Michael> diff --git a/package/python-crc16/Config.in b/package/python-crc16/Config.in
 Michael> new file mode 100644
 Michael> index 0000000..d5c62e9
 Michael> --- /dev/null
 Michael> +++ b/package/python-crc16/Config.in
 Michael> @@ -0,0 +1,11 @@
 Michael> +config BR2_PACKAGE_PYTHON_CRC16
 Michael> +	bool "python-crc16"
 Michael> +	depends on BR2_PACKAGE_PYTHON
 Michael> +	help
 Michael> +	  This library calculates only CRC16 (16-bit codes) and the
 Michael> +	  only supported variant at the moment is CRC-CCITT (XModem).
 Michael> +	  CRC is a way of detecting accidental changes in data storage
 Michael> +	  or transmission. There are many variants of CRC and CRC16,
 Michael> +	  in particular.

Michael> +
Michael> + http://pycrc16.googlecode.com/files/crc16-0.1.1.tar.gz

The URL should just be the homepage, so without /files/..

I was just about to commit it, but it doesn't build here (qemu_arm_versatile_defconfig + default external codesourcery toolchain):

building 'crc16._crc16' extension
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
/home/peko/source/buildroot/output/host/usr/bin/arm-none-linux-gnueabi-gcc -DNDEBUG -g -O3 -Wall -Wstrict-prototypes -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -pipe -Os -fPIC -I/home/peko/source/buildroot/output/build/python-2.7.3/Include -I/home/peko/source/buildroot/output/build/python-2.7.3 -c src/_crc16module.c -o build/temp.linux-x86_64-2.7/src/_crc16module.o /home/peko/source/buildroot/output/host/usr/bin/arm-none-linux-gnueabi-gcc -shared -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -pipe -Os build/temp.linux-x86_64-2.7/src/_crc16module.o -L/usr/lib -lpython2.7 -o build/lib.linux-x86_64-2.7/crc16/_crc16.so /home/peko/source/buildroot/output/host/opt/ext-toolchain/bin/../lib/gcc/arm-none-linux-gnueabi/4.7.3/../../../../arm-none-linux-gnueabi/bin/ld: warning: library search path "/usr/lib" is unsafe for cross-compilation
/usr/lib/libpython2.7.so: file not recognized: File format not recognized
collect2: error: ld returned 1 exit status

It seems like it tries to build it natively instead of for the target. Any ideas?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v2 1/1 python-crc16: new package

Hi Peter,

I found the culprit. LDFLAGS was missing. I'll test that tomorrow again, also with python-pyzmq to make sure it works in arm/powerpc/i586.

Thanks,

Michael.

Signature · 1 line
Michael Rommel, Erlangen, Germany
Quoted 62 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Michael" == Michael Rommel <[email protected]> writes:

Michael> A python library that calculates CRC checksums of the CCITT/XModem Michael> variant.

Michael> Signed-off-by: Michael Rommel <[email protected]> Michael> ---
Michael> Changes v1 -> v2
Michael> * corrected a typo in the filename for the .mk file

Michael>  package/Config.in                    |    1 +
Michael>  package/python-crc16/Config.in       |   11 +++++++++++
Michael>  package/python-crc16/python-crc16.mk |   34 ++++++++++++++++++++++++++++++++++
Michael>  3 files changed, 46 insertions(+)
Michael>  create mode 100644 package/python-crc16/Config.in
Michael>  create mode 100644 package/python-crc16/python-crc16.mk

Michael> diff --git a/package/Config.in b/package/Config.in Michael> index 2884bfb..ccd5e11 100644
Michael> --- a/package/Config.in
Michael> +++ b/package/Config.in
Michael> @@ -385,6 +385,7 @@ source "package/python/Config.in"

Michael>  if BR2_PACKAGE_PYTHON
Michael>  menu "external python modules"
Michael>  source "package/python-bottle/Config.in"
Michael> +source "package/python-crc16/Config.in"
Michael>  source "package/python-dpkt/Config.in"
Michael>  source "package/python-id3/Config.in"
Michael>  source "package/python-mad/Config.in"

Michael> diff --git a/package/python-crc16/Config.in b/package/python-crc16/Config.in Michael> new file mode 100644
Michael> index 0000000..d5c62e9
Michael> --- /dev/null
Michael> +++ b/package/python-crc16/Config.in
Michael> @@ -0,0 +1,11 @@
Michael> +config BR2_PACKAGE_PYTHON_CRC16
Michael> + bool "python-crc16"
Michael> + depends on BR2_PACKAGE_PYTHON
Michael> + help

Michael> +	  This library calculates only CRC16 (16-bit codes) and the
Michael> +	  only supported variant at the moment is CRC-CCITT (XModem).
Michael> +	  CRC is a way of detecting accidental changes in data storage
Michael> +	  or transmission. There are many variants of CRC and CRC16,
Michael> +	  in particular.

Michael> +
Michael> + http://pycrc16.googlecode.com/files/crc16-0.1.1.tar.gz

The URL should just be the homepage, so without /files/..

I was just about to commit it, but it doesn't build here (qemu_arm_versatile_defconfig + default external codesourcery toolchain):

building 'crc16._crc16' extension
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
/home/peko/source/buildroot/output/host/usr/bin/arm-none-linux-gnueabi-gcc -DNDEBUG -g -O3 -Wall -Wstrict-prototypes -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -pipe -Os -fPIC -I/home/peko/source/buildroot/output/build/python-2.7.3/Include -I/home/peko/source/buildroot/output/build/python-2.7.3 -c src/_crc16module.c -o build/temp.linux-x86_64-2.7/src/_crc16module.o /home/peko/source/buildroot/output/host/usr/bin/arm-none-linux-gnueabi-gcc -shared -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -pipe -Os build/temp.linux-x86_64-2.7/src/_crc16module.o -L/usr/lib -lpython2.7 -o build/lib.linux-x86_64-2.7/crc16/_crc16.so /home/peko/source/buildroot/output/host/opt/ext-toolchain/bin/../lib/gcc/arm-none-linux-gnueabi/4.7.3/../../../../arm-none-linux-gnueabi/bin/ld: warning: library search path "/usr/lib" is unsafe for cross-compilation
/usr/lib/libpython2.7.so: file not recognized: File format not recognized
collect2: error: ld returned 1 exit status

Quoted 5 lines

It seems like it tries to build it natively instead of for the target. Any ideas?

Signature · 1 line
Bye, Peter Korsgaard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130918/51f838d9/attachment-0001.html>