adjust the error labels to make it clear
PATCH 1/1 adjust the error labels to make it clear
From: zhongbaisong <[email protected]>
Signed-off-by zhongbaisong <[email protected]>
--- fs/sysfs/mount.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
fs/sysfs/mount.c +3 -3
@@ -182,12 +182,12 @@ int __init sysfs_init(void) } }else goto out_err; -out: -return err; + out_err:kmem_cache_destroy (sysfs_dir_cachep); sysfs_dir_cachep =NULL ; - goto out; +out: +return err; }#undef sysfs_get
Signature · 1 line
1.7.0.4
Greg KH
maintainerQuoted 3 lines · baisong zhong
From: zhongbaisong <[email protected]>
Signed-off-by zhongbaisong <[email protected]>
I need a changelog description in here, as to why you are making this change, your Subject: is not descriptive at all. What is being made "clear"?
Quoted 11 lines
--- fs/sysfs/mount.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)fs/sysfs/mount.c +0
-0@@ -182,12 +182,12 @@ int __init sysfs_init(void) } }else
fs/sysfs/mount.c int __init sysfs_init(void) · line 190
Quoted 10 lines
fs/sysfs/mount.c +3
-3goto out_err; -out: -return err; + out_err:kmem_cache_destroy (sysfs_dir_cachep); sysfs_dir_cachep =NULL ; - goto out; +out: +return err;
You tested this patch right? Are you sure? Really really sure?
greg "I don't think you tested this" k-h