ARM: tegra: use dt-binding header for key code
Subsystems (2)
PATCH 1/1 ARM: tegra: use dt-binding header for key code
In place of hardcoding the key code in DTS file and comment the key code as side notes, use the key code macro defines in the dt-bindings/input/input.h directly.
---
Reposting this patch as it was sent earlier when merge window was closed.
arch/arm/boot/dts/tegra114-dalmore.dts | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
arch/arm/boot/dts/tegra114-dalmore.dts +5 -4
@@ -1,5 +1,6 @@ /dts-v1/; +#include <dt-bindings/input/input.h> #include "tegra114.dtsi" / {
@@ -1081,26 +1082,26 @@ home { label = "Home"; gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>; - linux,code = <102>; /* KEY_HOME */ + linux,code = <KEY_HOME>; }; power { label = "Power"; gpios = <&gpio TEGRA_GPIO(Q, 0) GPIO_ACTIVE_LOW>; - linux,code = <116>; /* KEY_POWER */ + linux,code = <KEY_POWER>; gpio-key,wakeup; }; volume_down { label = "Volume Down"; gpios = <&gpio TEGRA_GPIO(R, 1) GPIO_ACTIVE_LOW>; - linux,code = <114>; /* KEY_VOLUMEDOWN */ + linux,code = <KEY_VOLUMEDOWN>; }; volume_up { label = "Volume Up"; gpios = <&gpio TEGRA_GPIO(R, 2) GPIO_ACTIVE_LOW>; - linux,code = <115>; /* KEY_VOLUMEUP */ + linux,code = <KEY_VOLUMEUP>; }; };
Signature · 1 line
1.7.1.1
Quoted 3 lines · Laxman Dewangan
In place of hardcoding the key code in DTS file and comment the key code as side notes, use the key code macro defines in the
dt-bindings/input/input.hdirectly.
I can apply this, but aren't there many other Tegra DT files that need conversion too?
Quoted 6 lines · Stephen Warren
Quoted 3 lines · Laxman Dewangan
In place of hardcoding the key code in DTS file and comment the key code as side notes, use the key code macro defines in the
dt-bindings/input/input.hdirectly.I can apply this, but aren't there many other Tegra DT files that need conversion too?
Yes, I am planning to this in next few days. I will post different patches for different boards. If it is fine to you, it can be applied this patch.
Stephen Warren
AppliedQuoted 3 lines · Laxman Dewangan
In place of hardcoding the key code in DTS file and comment the key code as side notes, use the key code macro defines in the
dt-bindings/input/input.hdirectly.
Applied to Tegra's for-3.13/dt branch.