drm/i915: register backlight device also when backlight class is a module
Subsystems (2)
PATCH 1/1 drm/i915: register backlight device also when backlight class is a module
Ville and I were wondering why his laptop was missing the intel_backlight sysfs interface. Turns out we never register it when CONFIG_BACKLIGHT_CLASS_DEVICE=m. This has been broken ever since the i915 native backlight interface was added.
--- drivers/gpu/drm/i915/intel_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -1
@@ -659,7 +659,7 @@ intel_panel_detect(struct drm_device *dev) } } -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE +#if IS_ENABLED (CONFIG_BACKLIGHT_CLASS_DEVICE )static int intel_panel_update_status (struct backlight_device *bd) {struct drm_device *dev =bl_get_data (bd);
Signature · 1 line
1.7.9.5
Quoted 8 lines · Jani Nikula
Ville and I were wondering why his laptop was missing the
intel_backlightsysfs interface. Turns out we never register it whenCONFIG_BACKLIGHT_CLASS_DEVICE=m. This has been broken ever since the i915 native backlight interface was added.CC Ville Syrjälä <[email protected]>Signed-off-by Jani Nikula <[email protected]>
FWIW, a quick git grep -e "#if.*def.*CONFIG" drivers/gpu/drm/i915/ did not return anything else of this kind.
Signature · 1 line
Damien
Quoted 24 lines
--- drivers/gpu/drm/i915/intel_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_panel.c +1
-1@@ -659,7 +659,7 @@ intel_panel_detect(struct drm_device *dev) } } -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE +#if IS_ENABLED (CONFIG_BACKLIGHT_CLASS_DEVICE )static int intel_panel_update_status (struct backlight_device *bd) {struct drm_device *dev =bl_get_data (bd);Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 7 lines · Damien Lespiau
Quoted 6 lines · Jani Nikula
Ville and I were wondering why his laptop was missing the
intel_backlightsysfs interface. Turns out we never register it whenCONFIG_BACKLIGHT_CLASS_DEVICE=m. This has been broken ever since the i915 native backlight interface was added.
I've dropped the cc: stable - since distor don't yell at us I don't think it harms anyone ;-)
Quoted 7 lines
Quoted 2 lines
CC Ville Syrjälä <[email protected]>Signed-off-by Jani Nikula <[email protected]>FWIW, a quick git grep -e "#if.*def.*CONFIG"
drivers/gpu/drm/i915/did not return anything else of this kind.Reviewed-by Damien Lespiau <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch