Skip to contentSkip to conversation

Don't destroy the netdev until the vif is shut down

PATCH In review Paul Durrant 4 participants 17 messages Sep 17, 2013 – Sep 20, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 Don't destroy the netdev until the vif is shut down

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>

---
v2:
- Modify netback_remove() - bug only seemed to manifest with linux guest

v3:
- Move __module_get() and module_put() calls

v4:
- Clear tx_irq in xenvif_disconnect() to make sure that a subsequent call to xenvif_connect() doesn't get nop-ed.

 drivers/net/xen-netback/common.h    |    1 +
 drivers/net/xen-netback/interface.c |   26 ++++++++++----------------
 drivers/net/xen-netback/xenbus.c    |   17 ++++++++++++-----
 3 files changed, 23 insertions(+), 21 deletions(-)
drivers/net/xen-netback/common.h +1 -0
index a197743..5715318 100644
@@ -184,6 +184,7 @@ int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
 		   unsigned long rx_ring_ref, unsigned int tx_evtchn,
 		   unsigned int rx_evtchn);
 void xenvif_disconnect(struct xenvif *vif);
+void xenvif_free(struct xenvif *vif);
 
 int xenvif_xenbus_init(void);
 void xenvif_xenbus_fini(void);
drivers/net/xen-netback/interface.c +10 -16
index 625c6f4..0465e0f 100644
@@ -353,6 +353,9 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
 	}
 
 	netdev_dbg(dev, "Successfully created xenvif\n");
+
+	__module_get(THIS_MODULE);
+
 	return vif;
 }
 
@@ -366,8 +369,6 @@ int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
 	if (vif->tx_irq)
 		return 0;
 
-	__module_get(THIS_MODULE);
-
 	err = xenvif_map_frontend_rings(vif, tx_ring_ref, rx_ring_ref);
 	if (err < 0)
 		goto err;
@@ -452,12 +453,6 @@ void xenvif_carrier_off(struct xenvif *vif)
 
 void xenvif_disconnect(struct xenvif *vif)
 {
-	/* Disconnect funtion might get called by generic framework
-	 * even before vif connects, so we need to check if we really
-	 * need to do a module_put.
-	 */
-	int need_module_put = 0;
-
 	if (netif_carrier_ok(vif->dev))
 		xenvif_carrier_off(vif);
 
@@ -468,23 +463,22 @@ void xenvif_disconnect(struct xenvif *vif)
 			unbind_from_irqhandler(vif->tx_irq, vif);
 			unbind_from_irqhandler(vif->rx_irq, vif);
 		}
-		/* vif->irq is valid, we had a module_get in
-		 * xenvif_connect.
-		 */
-		need_module_put = 1;
+		vif->tx_irq = 0;
 	}
 
 	if (vif->task)
 		kthread_stop(vif->task);
 
+	xenvif_unmap_frontend_rings(vif);
+}
+
+void xenvif_free(struct xenvif *vif)
+{
 	netif_napi_del(&vif->napi);
 
 	unregister_netdev(vif->dev);
 
-	xenvif_unmap_frontend_rings(vif);
-
 	free_netdev(vif->dev);
 
-	if (need_module_put)
-		module_put(THIS_MODULE);
+	module_put(THIS_MODULE);
 }
drivers/net/xen-netback/xenbus.c +12 -5
index 1fe48fe3..a53782e 100644
@@ -42,7 +42,7 @@ static int netback_remove(struct xenbus_device *dev)
 	if (be->vif) {
 		kobject_uevent(&dev->dev.kobj, KOBJ_OFFLINE);
 		xenbus_rm(XBT_NIL, dev->nodename, "hotplug-status");
-		xenvif_disconnect(be->vif);
+		xenvif_free(be->vif);
 		be->vif = NULL;
 	}
 	kfree(be);
@@ -213,9 +213,18 @@ static void disconnect_backend(struct xenbus_device *dev)
 {
 	struct backend_info *be = dev_get_drvdata(&dev->dev);
 
+	if (be->vif)
+		xenvif_disconnect(be->vif);
+}
+
+static void destroy_backend(struct xenbus_device *dev)
+{
+	struct backend_info *be = dev_get_drvdata(&dev->dev);
+
 	if (be->vif) {
+		kobject_uevent(&dev->dev.kobj, KOBJ_OFFLINE);
 		xenbus_rm(XBT_NIL, dev->nodename, "hotplug-status");
-		xenvif_disconnect(be->vif);
+		xenvif_free(be->vif);
 		be->vif = NULL;
 	}
 }
@@ -246,14 +255,11 @@ static void frontend_changed(struct xenbus_device *dev,
 	case XenbusStateConnected:
 		if (dev->state == XenbusStateConnected)
 			break;
-		backend_create_xenvif(be);
 		if (be->vif)
 			connect(be);
 		break;
 
 	case XenbusStateClosing:
-		if (be->vif)
-			kobject_uevent(&dev->dev.kobj, KOBJ_OFFLINE);
 		disconnect_backend(dev);
 		xenbus_switch_state(dev, XenbusStateClosing);
 		break;
@@ -262,6 +268,7 @@ static void frontend_changed(struct xenbus_device *dev,
 		xenbus_switch_state(dev, XenbusStateClosed);
 		if (xenbus_dev_is_online(dev))
 			break;
+		destroy_backend(dev);
 		/* fall through if not online */
 	case XenbusStateUnknown:
 		device_unregister(&dev->dev);
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw

From: Paul Durrant <[email protected]>
Date: Tue, 17 Sep 2013 17:46:08 +0100

Quoted 6 lines

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

Quoted 7 lines

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Can a xen driver expert please review and give an Acked-by:?

Thanks.

maintainer
#2 lore raw
In reply to Paul Durrant

From: Paul Durrant <[email protected]>
Date: Tue, 17 Sep 2013 17:46:08 +0100

Quoted 6 lines

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

Quoted 7 lines

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Can a xen driver expert please review and give an Acked-by:?

Thanks.

Acked-by on v4 1/1
#3 lore raw
In reply to Paul Durrant
Quoted 12 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Quoted 4 lines
Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>

Thanks!
Wei.

Acked-by on v4 1/1
#4 lore raw
In reply to Paul Durrant
Quoted 12 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Quoted 4 lines
Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>

Thanks!
Wei.

#5 lore raw
Quoted 13 lines · Wei Liu
Quoted 12 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Quoted 6 lines
Quoted 4 lines
Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>

yeah, looks good, thanks.

Paul, did you test this with non-Windows frontends too? and do things like vif hot(un)plug still work?

Ian.

#6 lore raw
In reply to Wei Liu
Quoted 13 lines · Wei Liu
Quoted 12 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Quoted 6 lines
Quoted 4 lines
Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>

yeah, looks good, thanks.

Paul, did you test this with non-Windows frontends too? and do things like vif hot(un)plug still work?

Ian.

#7 lore raw
Quoted 28 lines

-----Original Message-----
From: Ian Campbell [mailto:[email protected]]
Sent: 18 September 2013 16:58
To: Wei Liu
Cc: Paul Durrant; [email protected]; [email protected]; David Vrabel
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

Quoted 18 lines · Wei Liu
Quoted 16 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>
Quoted 7 lines
Quoted 1 line

yeah, looks good, thanks.

Paul, did you test this with non-Windows frontends too? and do things like vif hot(un)plug still work?

Ian,

I tested with a debian (wheezy) PV guest but I didn't test unplug. I cycled a windows frontend several times (which is how I spotted the tx_irq thing), and shutdown and brought up both the debian and windows guests several times. I can test unplug too if you'd like.

Paul

#8 lore raw
In reply to Ian Campbell
Quoted 28 lines

-----Original Message-----
From: Ian Campbell [mailto:[email protected]]
Sent: 18 September 2013 16:58
To: Wei Liu
Cc: Paul Durrant; [email protected]; [email protected]; David Vrabel
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

Quoted 18 lines · Wei Liu
Quoted 16 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>
Quoted 7 lines
Quoted 1 line

yeah, looks good, thanks.

Paul, did you test this with non-Windows frontends too? and do things like vif hot(un)plug still work?

Ian,

I tested with a debian (wheezy) PV guest but I didn't test unplug. I cycled a windows frontend several times (which is how I spotted the tx_irq thing), and shutdown and brought up both the debian and windows guests several times. I can test unplug too if you'd like.

Paul

#9 lore raw
Quoted 36 lines · Paul Durrant
Quoted 28 lines

-----Original Message-----
From: Ian Campbell [mailto:[email protected]]
Sent: 18 September 2013 16:58
To: Wei Liu
Cc: Paul Durrant; [email protected]; [email protected]; David Vrabel
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

Quoted 18 lines · Wei Liu
Quoted 16 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>
Quoted 7 lines
Quoted 1 line

yeah, looks good, thanks.

Paul, did you test this with non-Windows frontends too? and do things like vif hot(un)plug still work?

Quoted 6 lines

Ian,

I tested with a debian (wheezy) PV guest but I didn't test unplug. I cycled a windows frontend several times (which is how I spotted the tx_irq thing), and shutdown and brought up both the debian and windows guests several times. I can test unplug too if you'd like.

I don't think it needs to be a blocker for accepting this patch but it would be good to try it, it's the sort of area which historically gets broken by this sort of change.

Ian.

Quoted 2 lines

Paul

#10 lore raw
In reply to Paul Durrant
Quoted 36 lines · Paul Durrant
Quoted 28 lines

-----Original Message-----
From: Ian Campbell [mailto:[email protected]]
Sent: 18 September 2013 16:58
To: Wei Liu
Cc: Paul Durrant; [email protected]; [email protected]; David Vrabel
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

Quoted 18 lines · Wei Liu
Quoted 16 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>
Quoted 7 lines
Quoted 1 line

yeah, looks good, thanks.

Paul, did you test this with non-Windows frontends too? and do things like vif hot(un)plug still work?

Quoted 6 lines

Ian,

I tested with a debian (wheezy) PV guest but I didn't test unplug. I cycled a windows frontend several times (which is how I spotted the tx_irq thing), and shutdown and brought up both the debian and windows guests several times. I can test unplug too if you'd like.

I don't think it needs to be a blocker for accepting this patch but it would be good to try it, it's the sort of area which historically gets broken by this sort of change.

Ian.

Quoted 2 lines

Paul

#11 lore raw
Quoted 48 lines

-----Original Message-----
From: Ian Campbell [mailto:[email protected]]
Sent: 18 September 2013 17:25
To: Paul Durrant
Cc: Wei Liu; [email protected]; [email protected]; David Vrabel
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

Quoted 5 lines · Paul Durrant
Quoted 5 lines

-----Original Message-----
From: Ian Campbell [mailto:[email protected]]
Sent: 18 September 2013 16:58
To: Wei Liu
Cc: Paul Durrant; [email protected]; [email protected];

David

Quoted 33 lines
Quoted 23 lines

Vrabel
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

Quoted 18 lines · Wei Liu
Quoted 16 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>
Quoted 7 lines
Quoted 1 line

yeah, looks good, thanks.

Paul, did you test this with non-Windows frontends too? and do things like vif hot(un)plug still work?

Ian,

Quoted 9 lines
Quoted 4 lines

I tested with a debian (wheezy) PV guest but I didn't test unplug. I cycled a windows frontend several times (which is how I spotted the tx_irq thing), and shutdown and brought up both the debian and windows guests several times. I can test unplug too if you'd like.

I don't think it needs to be a blocker for accepting this patch but it would be good to try it, it's the sort of area which historically gets broken by this sort of change.

FWIW I just checked network-detach with a windows frontend and it worked ok.

Paul

#12 lore raw
In reply to Ian Campbell
Quoted 48 lines

-----Original Message-----
From: Ian Campbell [mailto:[email protected]]
Sent: 18 September 2013 17:25
To: Paul Durrant
Cc: Wei Liu; [email protected]; [email protected]; David Vrabel
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

Quoted 5 lines · Paul Durrant
Quoted 5 lines

-----Original Message-----
From: Ian Campbell [mailto:[email protected]]
Sent: 18 September 2013 16:58
To: Wei Liu
Cc: Paul Durrant; [email protected]; [email protected];

David

Quoted 33 lines
Quoted 23 lines

Vrabel
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

Quoted 18 lines · Wei Liu
Quoted 16 lines · Paul Durrant

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Cc David Vrabel <[email protected]>
Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>
Quoted 7 lines
Quoted 1 line

yeah, looks good, thanks.

Paul, did you test this with non-Windows frontends too? and do things like vif hot(un)plug still work?

Ian,

Quoted 9 lines
Quoted 4 lines

I tested with a debian (wheezy) PV guest but I didn't test unplug. I cycled a windows frontend several times (which is how I spotted the tx_irq thing), and shutdown and brought up both the debian and windows guests several times. I can test unplug too if you'd like.

I don't think it needs to be a blocker for accepting this patch but it would be good to try it, it's the sort of area which historically gets broken by this sort of change.

FWIW I just checked network-detach with a windows frontend and it worked ok.

Paul

maintainer
#13 lore raw
In reply to Paul Durrant

From: Paul Durrant <[email protected]>
Date: Tue, 17 Sep 2013 17:46:08 +0100

Quoted 6 lines

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

Quoted 7 lines

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

I think all of the testing requests have been satisfied so I have applied this.

But _please_ write a more proper subject line in future patch submissions. You have to provide a subsystem prefix in the subject line, here I added "xen-netback: ", otherwise someone skimming the shortlog has no idea what area of code this change touches.

Thanks.

maintainer
#14 lore raw
In reply to Paul Durrant

From: Paul Durrant <[email protected]>
Date: Tue, 17 Sep 2013 17:46:08 +0100

Quoted 6 lines

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

Quoted 7 lines

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

I think all of the testing requests have been satisfied so I have applied this.

But _please_ write a more proper subject line in future patch submissions. You have to provide a subsystem prefix in the subject line, here I added "xen-netback: ", otherwise someone skimming the shortlog has no idea what area of code this change touches.

Thanks.

#15 lore raw
Quoted 26 lines

-----Original Message-----
From: David Miller [mailto:[email protected]]
Sent: 19 September 2013 19:05
To: Paul Durrant
Cc: [email protected]; [email protected]; David Vrabel; Wei Liu; Ian Campbell
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

From: Paul Durrant <[email protected]>
Date: Tue, 17 Sep 2013 17:46:08 +0100

Quoted 6 lines

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

Quoted 7 lines

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Quoted 9 lines

I think all of the testing requests have been satisfied so I have applied this.

But _please_ write a more proper subject line in future patch submissions. You have to provide a subsystem prefix in the subject line, here I added "xen-netback: ", otherwise someone skimming the shortlog has no idea what area of code this change touches.

Ok. Will do. Thanks,

Paul

#16 lore raw
In reply to David Miller
Quoted 26 lines

-----Original Message-----
From: David Miller [mailto:[email protected]]
Sent: 19 September 2013 19:05
To: Paul Durrant
Cc: [email protected]; [email protected]; David Vrabel; Wei Liu; Ian Campbell
Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

From: Paul Durrant <[email protected]>
Date: Tue, 17 Sep 2013 17:46:08 +0100

Quoted 6 lines

Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait.

Quoted 7 lines

With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required.

Quoted 9 lines

I think all of the testing requests have been satisfied so I have applied this.

But _please_ write a more proper subject line in future patch submissions. You have to provide a subsystem prefix in the subject line, here I added "xen-netback: ", otherwise someone skimming the shortlog has no idea what area of code this change touches.

Ok. Will do. Thanks,

Paul