Skip to contentSkip to conversation

regulator: wm8350: correct the max_uV of LDO

PATCH Applied Laxman Dewangan 2 participants 2 messages Sep 19, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: wm8350: correct the max_uV of LDO

As per datasheet, voltage range for LDOs are as follows:

	0000 = 0.9V
		...(50mV steps)
	01111 = 1.65V
	10000 = 1.8V
		... (100mV stepns)
	11111 = 3.3V

So, there is no selector for 1.65V to 1.8V. Correcting the range for max_uV for selector between 0 to 15.

---
When trying to understand the usage of linear_range, found the above issue in code. I do not have hardware to validate but though that let's send this for review. Probably this is real bug.

 drivers/regulator/wm8350-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/wm8350-regulator.c +1 -1
index a438e93..017e869 100644
@@ -543,7 +543,7 @@ static int wm8350_dcdc_set_suspend_mode(struct regulator_dev *rdev,
 }
 
 static const struct regulator_linear_range wm8350_ldo_ranges[] = {
-	{ .min_uV =  900000, .max_uV = 1750000, .min_sel =  0, .max_sel = 15,
+	{ .min_uV =  900000, .max_uV = 1650000, .min_sel =  0, .max_sel = 15,
 	  .uV_step =  50000 },
 	{ .min_uV = 1800000, .max_uV = 3300000, .min_sel = 16, .max_sel = 31,
 	  .uV_step = 100000 },
Signature · 1 line
1.7.1.1
maintainer Applied
#1 lore raw
Quoted 1 line · Laxman Dewangan

As per datasheet, voltage range for LDOs are as follows:

Applied, thanks.