kexec-tools: add support for Xen 4.4
v5 cover kexec-tools: add support for Xen 4.4
The series adds support for the new hypercall ABI which should be provided by Xen 4.4. Images are loaded into Xen directly with no kernel involvement.
Please do not apply until the hypervisor side patches are applied to Xen.
Patch 1 makes libxc 4.4 mandatory for Xen support.
Patch 2-3 remove uses of /proc/iomem in favour of libxc.
Patch 4 adds the support for loading, unloading, and exec'ing an image in Xen.
This series explicitly drops support for older version of libxc/Xen as supporting kexec on these hypervisors requires kernel support that will never be available upstream.
Changes in v5:
- Dropped the purgatory patch.
Changes in v4:
- KEXEC_ARCH_DEFAULT => EM_386
- add segment in the crash case for the backup src.
Changes in v3 (not posted):
- Rebased
Changes in v2:
- Patch from Don Sultz: use libxc for vmcoreinfo.
- Use xc_get_max_cpus() to get number of PCPUs.
- Enable unload and exec of images.
David
PATCH v5 1/4 kexec/xen: require libxc from Xen 4.4
From: David Vrabel <[email protected]>
libxc from Xen 4.4 added xc_kexec_load() which will be required to load images into Xen in the future.
Remove all the #ifdef'ery for older versions of libxc.
--- configure.ac | 5 +- kexec/arch/i386/crashdump-x86.c | 110 ------------------------------------ kexec/arch/i386/kexec-x86-common.c | 103 --------------------------------- kexec/crashdump-xen.c | 12 ---- 4 files changed, 1 insertions(+), 229 deletions(-)
configure.ac +1 -4
@@ -161,11 +161,8 @@ fi dnl find Xen control stack libraries if test "$with_xen" = yes ; then AC_CHECK_HEADER(xenctrl.h, - AC_CHECK_LIB(xenctrl, xc_version, , + AC_CHECK_LIB(xenctrl, xc_kexec_load, , AC_MSG_NOTICE([Xen support disabled]))) - if test "$ac_cv_lib_xenctrl_xc_version" = yes ; then - AC_CHECK_FUNCS(xc_get_machine_memory_map) - fi fi dnl ---Sanity checks
kexec/arch/i386/crashdump-x86.c +0 -110
143 lines not on this page · raw message
kexec/arch/i386/kexec-x86-common.c +0 -103
135 lines not on this page · raw message
kexec/crashdump-xen.c +0 -12
@@ -131,30 +131,18 @@ unsigned long xen_architecture(struct crash_elf_info *elf_info)#ifdef HAVE_LIBXENCTRL int rc;xen_capabilities_info_t capabilities; -#ifdef XENCTRL_HAS_XC_INTERFACE xc_interface *xc; -#else -int xc; -#endif if (!xen_present ()) goto out;memset (capabilities,'0' ,XEN_CAPABILITIES_INFO_LEN ); -#ifdef XENCTRL_HAS_XC_INTERFACE xc =xc_interface_open (NULL ,NULL ,0 );if ( !xc ) {fprintf (stderr,"failed to open xen control interface.\n" ); goto out; } -#else - xc =xc_interface_open (); -if ( xc ==-1 ) { -fprintf (stderr,"failed to open xen control interface.\n" ); - goto out; - } -#endif rc =xc_version (xc, XENVER_capabilities, &capabilities[0 ]);if ( rc ==-1 ) {
Signature · 1 line
1.7.2.5
PATCH v5 2/4 kexec/xen: use libxc to get location of crash notes
In reply to David VrabelFrom: David Vrabel <[email protected]>
Use xc_kexec_get_range(KEXEC_RANGE_MA_CPU) instead of parsing /proc/iomem (which is only populated by non-upstream ("classic") Xen kernels).
--- kexec/crashdump-xen.c | 67 +++++++++++++++++++++++++++++------------------- 1 files changed, 40 insertions(+), 27 deletions(-)
kexec/crashdump-xen.c +40 -27
@@ -163,42 +163,55 @@ unsigned long xen_architecture(struct crash_elf_info *elf_info)return machine; } -static int xen_crash_note_callback (void *UNUSED (data ),int nr, -char *UNUSED (str ), -unsigned long base, -unsigned long length) -{ -struct crash_note_info *note = xen_phys_notes + nr; - - note->base = base; - note->length = length; - -return 0 ; -} - +#ifdef HAVE_LIBXENCTRL int xen_get_nr_phys_cpus (void ) { -char *match ="Crash note\n" ; -int cpus, n; +xc_interface *xc; +int max_cpus; +int cpu;if (xen_phys_cpus)return xen_phys_cpus; -if ((cpus =kexec_iomem_for_each_line (match,NULL ,NULL ))) { - n =sizeof (struct crash_note_info ) * cpus; - xen_phys_notes =malloc (n); -if (!xen_phys_notes) { -fprintf (stderr,"failed to allocate xen_phys_notes.\n" ); -return -1 ; - } -memset (xen_phys_notes,0 , n); -kexec_iomem_for_each_line (match, - xen_crash_note_callback,NULL ); - xen_phys_cpus = cpus; + xc =xc_interface_open (NULL ,NULL ,0 ); +if (!xc) { +fprintf (stderr,"failed to open xen control interface.\n" ); +return -1 ; + } + + max_cpus =xc_get_max_cpus (xc); +if (max_cpus <=0 ) +return -1 ; + + xen_phys_notes =calloc (max_cpus,sizeof (*xen_phys_notes)); +if (xen_phys_notes ==NULL ) +return -1 ; + +for (cpu =0 ; cpu < max_cpus; cpu++) { +uint64_t size, start; +int ret; + + ret =xc_kexec_get_range (xc,KEXEC_RANGE_MA_CPU , cpu, &size, &start); +if (ret <0 ) +break ; + + xen_phys_notes[cpu].base = start; + xen_phys_notes[cpu].length = size; } -return cpus; +xc_interface_close (xc); + + xen_phys_cpus = cpu; + +return cpu; } +#else +int xen_get_nr_phys_cpus (void ) +{ +return -1 ; +} +#endif +int xen_get_note (int cpu,uint64_t *addr,uint64_t *len) {
Signature · 1 line
1.7.2.5
PATCH v5 3/4 kexec/xen: switch to use xc_kexec_get_range for get_xen_vmcoreinfo.
In reply to David VrabelFrom: Don Slutz <[email protected]>
--- kexec/crashdump-xen.c | 25 +++++++++++++++++++++++++ kexec/crashdump.c | 5 ----- 2 files changed, 25 insertions(+), 5 deletions(-)
kexec/crashdump-xen.c +25 -0
@@ -164,6 +164,26 @@ unsigned long xen_architecture(struct crash_elf_info *elf_info) }#ifdef HAVE_LIBXENCTRL +int get_xen_vmcoreinfo (uint64_t *addr,uint64_t *len) +{ +xc_interface *xc; +int ret =0 ; + + xc =xc_interface_open (NULL ,NULL ,0 ); +if (!xc) { +fprintf (stderr,"failed to open xen control interface.\n" ); +return -1 ; + } + + ret =xc_kexec_get_range (xc,KEXEC_RANGE_MA_VMCOREINFO ,0 , len, addr); + +xc_interface_close (xc); + +if (ret <0 ) +return -1 ; +return 0 ; +} +int xen_get_nr_phys_cpus (void ) {xc_interface *xc;
@@ -206,6 +226,11 @@ int xen_get_nr_phys_cpus(void) return cpu; }#else +int get_xen_vmcoreinfo (uint64_t *addr,uint64_t *len) +{ +return -1 ; +} +int xen_get_nr_phys_cpus (void ) {return -1 ;
kexec/crashdump.c +0 -5
@@ -157,8 +157,3 @@ int get_kernel_vmcoreinfo(uint64_t *addr, uint64_t *len) {return get_vmcoreinfo ("/sys/kernel/vmcoreinfo" , addr, len); } - -int get_xen_vmcoreinfo (uint64_t *addr,uint64_t *len) -{ -return get_vmcoreinfo ("/sys/hypervisor/vmcoreinfo" , addr, len); -}
Signature · 1 line
1.7.2.5
PATCH v5 4/4 kexec/xen: directly load images images into Xen
In reply to David VrabelFrom: David Vrabel <[email protected]>
Xen 4.4 has an improvided kexec hypercall ABI that allows images to be loaded and executed without any kernel involvement. Use the API provided by libxc to load images when running in a Xen guest.
Support for loading images via the kexec_load syscall in non-upstream ("classic") Xen kernels is no longer supported.
--- kexec/Makefile | 1 + kexec/arch/i386/crashdump-x86.c | 20 +++++- kexec/crashdump-xen.c | 34 ++++++++++ kexec/crashdump.h | 3 +- kexec/kexec-xen.c | 134 +++++++++++++++++++++++++++++++++++++++ kexec/kexec.c | 24 ++++++-- kexec/kexec.h | 5 ++ 7 files changed, 213 insertions(+), 8 deletions(-) create mode 100644 kexec/kexec-xen.c
kexec/Makefile +1 -0
@@ -25,6 +25,7 @@ KEXEC_SRCS_base += kexec/phys_arch.c KEXEC_SRCS_base += kexec/kernel_version.c KEXEC_SRCS_base += kexec/lzma.c KEXEC_SRCS_base += kexec/zlib.c +KEXEC_SRCS_base += kexec/kexec-xen.c KEXEC_GENERATED_SRCS += $(PURGATORY_HEX_C)
kexec/arch/i386/crashdump-x86.c +18 -2
@@ -990,8 +990,24 @@ static int crashkernel_mem_callback(void *UNUSED(data), int nr,int is_crashkernel_mem_reserved (void ) { - crash_reserved_mem_nr =kexec_iomem_for_each_line ("Crash kernel\n" , - crashkernel_mem_callback,NULL ); +int ret; + +if (xen_present ()) { +uint64_t start, end; + + ret =xen_get_crashkernel_region (&start, &end); +if (ret <0 ) +return 0 ; + + crash_reserved_mem[0 ].start = start; + crash_reserved_mem[0 ].end = end; + crash_reserved_mem[0 ].type =RANGE_RAM ; + crash_reserved_mem_nr =1 ; + }else { + ret =kexec_iomem_for_each_line ("Crash kernel\n" , + crashkernel_mem_callback,NULL ); + crash_reserved_mem_nr = ret; + }return !!crash_reserved_mem_nr; }
kexec/crashdump-xen.c +34 -0
@@ -252,3 +252,37 @@ int xen_get_note(int cpu, uint64_t *addr, uint64_t *len)return 0 ; } + +#ifdef HAVE_LIBXENCTRL +int xen_get_crashkernel_region (uint64_t *start,uint64_t *end) +{ +uint64_t size; +xc_interface *xc; +int rc =-1 ; + + xc =xc_interface_open (NULL ,NULL ,0 ); +if (!xc) { +fprintf (stderr,"failed to open xen control interface.\n" ); + goto out; + } + + rc =xc_kexec_get_range (xc,KEXEC_RANGE_MA_CRASH ,0 , &size, start); +if (rc <0 ) { +fprintf (stderr,"failed to get crash region from hypervisor.\n" ); + goto out_close; + } + + *end = *start + size -1 ; + +out_close: +xc_interface_close (xc); + +out: +return rc; +} +#else +int xen_get_crashkernel_region (uint64_t *start,uint64_t *end) +{ +return -1 ; +} +#endif
kexec/crashdump.h +2 -1
@@ -1,6 +1,7 @@#ifndef CRASHDUMP_H #define CRASHDUMP_H +int get_crashkernel_region (uint64_t *start,uint64_t *end);extern int get_crash_notes_per_cpu (int cpu,uint64_t *addr,uint64_t *len);extern int get_kernel_vmcoreinfo (uint64_t *addr,uint64_t *len);extern int get_xen_vmcoreinfo (uint64_t *addr,uint64_t *len);
@@ -56,9 +57,9 @@ unsigned long crash_architecture(struct crash_elf_info *elf_info);unsigned long phys_to_virt (struct crash_elf_info *elf_info,unsigned long paddr); -int xen_present (void );unsigned long xen_architecture (struct crash_elf_info *elf_info);int xen_get_nr_phys_cpus (void );int xen_get_note (int cpu,uint64_t *addr,uint64_t *len); +int xen_get_crashkernel_region (uint64_t *start,uint64_t *end);#endif /* CRASHDUMP_H */
kexec/kexec-xen.c new file +134 -0
134 lines not on this page · raw message
kexec/kexec.c +19 -5
@@ -764,8 +764,12 @@ static int my_load(const char *type, int fileind, int argc, char **argv,if (kexec_debug)print_segments (stderr, &info); - result =kexec_load ( - info.entry, info.nr_segments, info.segment, info.kexec_flags); +if (xen_present ()) + result =xen_kexec_load (&info); +else + result =kexec_load (info.entry, + info.nr_segments, info.segment, + info.kexec_flags);if (result !=0 ) {/* The load failed, print some debugging information */ fprintf(stderr, "kexec_load failed: %s\n",
@@ -789,10 +793,13 @@ static int k_unload (unsigned long kexec_flags) } kexec_flags |= native_arch; - result =kexec_load (NULL ,0 ,NULL , kexec_flags); +if (xen_present ()) + result =xen_kexec_unload (kexec_flags); +else + result =kexec_load (NULL ,0 ,NULL , kexec_flags);if (result !=0 ) {/* The unload failed, print some debugging information */ -fprintf (stderr,"kexec_load (0 segments) failed: %s\n" , +fprintf (stderr,"kexec unload failed: %s\n" ,strerror (errno)); }return result;
@@ -823,7 +830,10 @@ static int my_shutdown(void)*/ static int my_exec (void ) { -reboot (LINUX_REBOOT_CMD_KEXEC ); +if (xen_present ()) +xen_kexec_exec (); +else +reboot (LINUX_REBOOT_CMD_KEXEC );/* I have failed if I make it here */ fprintf (stderr,"kexec failed: %s\n" ,strerror (errno));
@@ -928,6 +938,10 @@ static int kexec_loaded(void)char *p;char line[3 ]; +/* No way to tell if an image is loaded under Xen, assume it is. */ +if (xen_present ()) +return 1 ; + fp =fopen ("/sys/kernel/kexec_loaded" ,"r" );if (fp ==NULL )return -1 ;
kexec/kexec.h +5 -0
@@ -289,4 +289,9 @@ const char * proc_iomem(void);char *concat_cmdline (const char *base,const char *append); +int xen_present (void ); +int xen_kexec_load (struct kexec_info *info); +int xen_kexec_unload (uint64_t kexec_flags); +void xen_kexec_exec (void ); +#endif /* KEXEC_H */
Signature · 1 line
1.7.2.5
Re: [PATCH 4/4] kexec/xen: directly load images images into Xen
Quoted 10 lines · David Vrabel
From: David Vrabel <[email protected]>
Xen 4.4 has an improvided kexec hypercall ABI that allows images to be loaded and executed without any kernel involvement. Use the API provided by libxc to load images when running in a Xen guest.
Support for loading images via the
kexec_loadsyscall in non-upstream ("classic") Xen kernels is no longer supported.Signed-off-by David Vrabel <[email protected]>
[...]
Quoted 90 lines
kexec/kexec-xen.c new file +84
-0@@ -0,0 +1,134 @@ +#define _GNU_SOURCE +#include <stdio.h> +#include <string.h> +#include <stdlib.h> +#include <elf.h> +#include "kexec.h" +#include "kexec-syscall.h" +#include "crashdump.h" + +#include "config.h" + +#ifdef HAVE_LIBXENCTRL +#include <xenctrl.h> + +#include "crashdump.h" + +int xen_kexec_load (struct kexec_info *info) +{ +uint32_t nr_segments = info->nr_segments; +struct kexec_segment *segments = info->segment; +xc_interface *xch; +xc_hypercall_buffer_array_t *array =NULL ; +uint8_t type; +uint8_t arch; +xen_kexec_segment_t *xen_segs; +int s; +int ret =-1 ; + + xch =xc_interface_open (NULL ,NULL ,0 ); +if (!xch) +return -1 ; + + xen_segs =calloc (nr_segments +1 ,sizeof (*xen_segs)); +if (!xen_segs) + goto out; + + array =xc_hypercall_buffer_array_create (xch, nr_segments); +if (array ==NULL ) + goto out; + +for (s =0 ; s < nr_segments; s++) { +DECLARE_HYPERCALL_BUFFER (void, seg_buf); + + seg_buf =xc_hypercall_buffer_array_alloc (xch, array, s, + seg_buf, segments[s].bufsz); +if (seg_buf ==NULL ) + goto out; +memcpy (seg_buf, segments[s].buf, segments[s].bufsz); + +set_xen_guest_handle (xen_segs[s].buf.h, seg_buf); + xen_segs[s].buf_size = segments[s].bufsz; + xen_segs[s].dest_maddr = (uint64_t )segments[s].mem; + xen_segs[s].dest_size = segments[s].memsz; + } + +if (info->kexec_flags &KEXEC_ON_CRASH ) { +set_xen_guest_handle (xen_segs[s].buf.h,HYPERCALL_BUFFER_NULL ); + xen_segs[s].buf_size =0 ; + xen_segs[s].dest_maddr = info->backup_src_start; + xen_segs[s].dest_size = info->backup_src_size; + nr_segments++; + } + + type = (info->kexec_flags &KEXEC_ON_CRASH ) ?KEXEC_TYPE_CRASH + :KEXEC_TYPE_DEFAULT ; + + arch = (info->kexec_flags &KEXEC_ARCH_MASK ) >>16 ; +#if defined(_i386__) || defined(__x86_64__) +if (!arch) + arch =EM_386 ; +#endif + + ret =xc_kexec_load (xch, type, arch, (uint64_t )info->entry, + nr_segments, xen_segs); + +out: +xc_hypercall_buffer_array_destroy (xch, array); +free (xen_segs); +xc_interface_close (xch); + +return ret; +} + +int xen_kexec_unload (uint64_t kexec_flags)
kexec/kexec-xen.c line 94
Quoted 10 lines
kexec/kexec-xen.c new file +10
-0+{ +xc_interface *xch; +uint8_t type; +int ret; + + xch =xc_interface_open (NULL ,NULL ,0 ); +if (!xch) +return -1 ; + + type = kexec_flags &KEXEC_TYPE_CRASH ;
Why? Could not we unload normal kexec images?
Quoted 87 lines
kexec/kexec-xen.c new file +39
-0+ ret =xc_kexec_unload (xch, type); + +xc_interface_close (xch); + + return ret; +} + +void xen_kexec_exec (void ) +{ +xc_interface *xch; + + xch =xc_interface_open (NULL ,NULL ,0 ); +if (!xch) +return ; + +xc_kexec_exec (xch,KEXEC_TYPE_DEFAULT ); + +xc_interface_close (xch); +} + +#else /* ! HAVE_LIBXENCTRL */ + +int xen_kexec_load (uint64_t entry, +uint32_t nr_segments,struct kexec_segment *segments, +uint64_t kexec_flags) +{ +return -1 ; +} + +int xen_kexec_unload (uin64_t kexec_flags); +{ +return -1 ; +} + +void xen_kexec_exec (void ) +{ +} + +#endif kexec/kexec.c +15
-5@@ -764,8 +764,12 @@ static int my_load(const char *type, int fileind, int argc, char **argv,if (kexec_debug)print_segments (stderr, &info); - result =kexec_load ( - info.entry, info.nr_segments, info.segment, info.kexec_flags); +if (xen_present ()) + result =xen_kexec_load (&info); +else + result =kexec_load (info.entry, + info.nr_segments, info.segment, + info.kexec_flags);if (result !=0 ) {/* The load failed, print some debugging information */ fprintf(stderr, "kexec_load failed: %s\n",@@ -789,10 +793,13 @@ static int k_unload (unsigned long kexec_flags) } kexec_flags |= native_arch; - result =kexec_load (NULL ,0 ,NULL , kexec_flags); +if (xen_present ()) + result =xen_kexec_unload (kexec_flags); +else + result =kexec_load (NULL ,0 ,NULL , kexec_flags);if (result !=0 ) {/* The unload failed, print some debugging information */ -fprintf (stderr,"kexec_load (0 segments) failed: %s\n" , +fprintf (stderr,"kexec unload failed: %s\n" ,strerror (errno)); }return result;@@ -823,7 +830,10 @@ static int my_shutdown(void)*/ static int my_exec (void ) { -reboot (LINUX_REBOOT_CMD_KEXEC ); +if (xen_present ()) +xen_kexec_exec (); +else +reboot (LINUX_REBOOT_CMD_KEXEC );/* I have failed if I make it here */ fprintf (stderr,"kexec failed: %s\n" ,strerror (errno));
kexec/kexec.c static int kexec_loaded(void) · line 944
Quoted 7 lines
kexec/kexec.c +4
-0@@ -928,6 +938,10 @@ static int kexec_loaded(void)char *p;char line[3 ]; +/* No way to tell if an image is loaded under Xen, assume it is. */ +if (xen_present ()) +return 1 ; +
Why? I think that we should have relevant machanism to do that.
Please take into account Konrad's comments too
(http://lists.xenproject.org/archives/html/xen-devel/2013-09/msg02364.html).
Daniel
Re: [PATCH 4/4] kexec/xen: directly load images images into Xen
Quoted 7 lines · Daniel Kiper
kexec/kexec-xen.c new file +5
-0+ xch =xc_interface_open (NULL ,NULL ,0 ); +if (!xch) +return -1 ; + + type = kexec_flags &KEXEC_TYPE_CRASH ;Why? Could not we unload normal kexec images?
type is 0 for normal images and 1 for crash images. This line does not prevent unloading of normal images in the slightest.
Quoted 30 lines
Quoted 21 lines
kexec/kexec-xen.c new file +11
-1+ ret =xc_kexec_unload (xch, type); + +xc_interface_close (xch); + +return ret; +} +@@ -823,7 +830,10 @@ static int my_shutdown(void)*/ static int my_exec (void ) { -reboot (LINUX_REBOOT_CMD_KEXEC ); +if (xen_present ()) +xen_kexec_exec (); +else +reboot (LINUX_REBOOT_CMD_KEXEC );/* I have failed if I make it here */ fprintf (stderr,"kexec failed: %s\n" ,strerror (errno));kexec/kexec-xen.c static int kexec_loaded(void) · line 944
Quoted 7 lines
kexec/kexec-xen.c new file +4
-0@@ -928,6 +938,10 @@ static int kexec_loaded(void)char *p;char line[3 ]; +/* No way to tell if an image is loaded under Xen, assume it is. */ +if (xen_present ()) +return 1 ; +Why? I think that we should have relevant machanism to do that.
Quoted 4 lines
Please take into account Konrad's comments too
(http://lists.xenproject.org/archives/html/xen-devel/2013-09/msg02364.html).Daniel
Here I would agree. As we are redefining all the hypercalls, a KEXEC_loaded_status hypercall (or equiv) would certainly not go amis.
~Andrew
Re: [PATCH 4/4] kexec/xen: directly load images images into Xen
Quoted 11 lines · Andrew Cooper
Quoted 7 lines · Daniel Kiper
kexec/kexec-xen.c new file +5
-0+ xch =xc_interface_open (NULL ,NULL ,0 ); +if (!xch) +return -1 ; + + type = kexec_flags &KEXEC_TYPE_CRASH ;Why? Could not we unload normal kexec images?
type is 0 for normal images and 1 for crash images. This line does not prevent unloading of normal images in the slightest.
My fault. It is & not |. But it should be like in xen_kexec_load():
type = (kexec_flags & KEXEC_ON_CRASH) ? KEXEC_TYPE_CRASH : KEXEC_TYPE_DEFAULT;
or even
type = kexec_flags & ~KEXEC_ARCH_MASK;
Daniel
Re: [PATCH 4/4] kexec/xen: directly load images images into Xen
In reply to Daniel KiperQuoted 16 lines · Daniel Kiper
Quoted 10 lines · David Vrabel
From: David Vrabel <[email protected]>
Xen 4.4 has an improvided kexec hypercall ABI that allows images to be loaded and executed without any kernel involvement. Use the API provided by libxc to load images when running in a Xen guest.
Support for loading images via the
kexec_loadsyscall in non-upstream ("classic") Xen kernels is no longer supported.Signed-off-by David Vrabel <[email protected]>[...]
Quoted 2 lines
kexec/kexec-xen.c new file +0
-0
[...]
Quoted 5 lines
Quoted 5 lines
kexec/kexec-xen.c new file +5
-0+int xen_kexec_unload (uint64_t kexec_flags) +{ +xc_interface *xch; +uint8_t type; +int ret;
Quoted 8 lines
kexec/kexec-xen.c line 94
Quoted 6 lines
kexec/kexec-xen.c new file +6
-0+ + xch =xc_interface_open (NULL ,NULL ,0 ); +if (!xch) +return -1 ; + + type = kexec_flags &KEXEC_TYPE_CRASH ;Why? Could not we unload normal kexec images?
This is correct but could be
type = kexec_flags & KEXEC_TYPE_CRASH ? KEXEC_TYPE_CRASH
: KEXEC_TYPE_DEFAULT
for clarity.
Quoted 10 lines
kexec/kexec-xen.c static int kexec_loaded(void) · line 944
Quoted 8 lines
kexec/kexec-xen.c new file +4
-0@@ -928,6 +938,10 @@ static int kexec_loaded(void)char *p;char line[3 ]; +/* No way to tell if an image is loaded under Xen, assume it is. */ +if (xen_present ()) +return 1 ; +Why? I think that we should have relevant machanism to do that.
Because it's not needed. There's no point in checking if an image a loaded before trying to exec it because you can just try the exec and have that fail.
I'm not going to add a sub-op for this just because one particular tool mistakenly thinks it needs to check in advance.
David
Re: [PATCH 4/4] kexec/xen: directly load images images into Xen
Quoted 32 lines · David Vrabel
Quoted 16 lines · Daniel Kiper
Quoted 10 lines · David Vrabel
From: David Vrabel <[email protected]>
Xen 4.4 has an improvided kexec hypercall ABI that allows images to be loaded and executed without any kernel involvement. Use the API provided by libxc to load images when running in a Xen guest.
Support for loading images via the
kexec_loadsyscall in non-upstream ("classic") Xen kernels is no longer supported.Signed-off-by David Vrabel <[email protected]>[...]
Quoted 2 lines
kexec/kexec-xen.c new file +0
-0[...]
Quoted 5 lines
Quoted 5 lines
kexec/kexec-xen.c new file +5
-0+int xen_kexec_unload (uint64_t kexec_flags) +{ +xc_interface *xch; +uint8_t type; +int ret;Quoted 8 lines
kexec/kexec-xen.c line 94
Quoted 6 lines
kexec/kexec-xen.c new file +6
-0+ + xch =xc_interface_open (NULL ,NULL ,0 ); +if (!xch) +return -1 ; + + type = kexec_flags &KEXEC_TYPE_CRASH ;Why? Could not we unload normal kexec images?
Quoted 6 lines
This is correct but could be
type =
kexec_flags&KEXEC_TYPE_CRASH?KEXEC_TYPE_CRASH
:KEXEC_TYPE_DEFAULTfor clarity.
OK, thanks.
Quoted 11 lines
Quoted 10 lines
kexec/kexec-xen.c static int kexec_loaded(void) · line 944
Quoted 8 lines
kexec/kexec-xen.c new file +4
-0@@ -928,6 +938,10 @@ static int kexec_loaded(void)char *p;char line[3 ]; +/* No way to tell if an image is loaded under Xen, assume it is. */ +if (xen_present ()) +return 1 ; +Why? I think that we should have relevant machanism to do that.
Quoted 3 lines
Because it's not needed. There's no point in checking if an image a loaded before trying to exec it because you can just try the exec and have that fail.
OK, it makes sens.
Quoted 2 lines
I'm not going to add a sub-op for this just because one particular tool mistakenly thinks it needs to check in advance.
However, I think that it is worth to have mechanism to discover which image is loaded. Even here it does not make sens. It could be useful for others.
Daniel