Skip to contentSkip to conversation

drivers: edac: octeon: fix lack of opstate_init

PATCH In review Daniel Walker 2 participants 2 messages Sep 20, 2013 – Sep 24, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drivers: edac: octeon: fix lack of opstate_init

If the opstate_init() isn't called the driver won't start properly.

I just added it in what appears to be an appropriate place.

---
 drivers/edac/octeon_edac-lmc.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/edac/octeon_edac-lmc.c +2 -0
index 93412d6..4881ad0 100644
@@ -92,6 +92,8 @@ static int octeon_lmc_edac_probe(struct platform_device *pdev)
 	struct edac_mc_layer layers[1];
 	int mc = pdev->id;
 
+	opstate_init();
+
 	layers[0].type = EDAC_MC_LAYER_CHANNEL;
 	layers[0].size = 1;
 	layers[0].is_virt_csrow = false;
Signature · 1 line
1.8.1.2
Acked-by on v1 1/2
#1 lore raw
Quoted 5 lines · Daniel Walker

If the opstate_init() isn't called the driver won't start properly.

I just added it in what appears to be an appropriate place.

Makes sense. Unfortunately :-)

EDAC folks - I can funnel this patch through my tree or leave that to you, whatever you prefer. Same for Daniel's other patch.

Ralf