usb: gadget: mv_u3d_core: fix memory leaks
PATCH 1/1 usb: gadget: mv_u3d_core: fix memory leaks
When trb_hw is NULL, trb should be free'd before return.
Signed-off-by Valentin Ilie <[email protected]>
--- drivers/usb/gadget/mv_u3d_core.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/usb/gadget/mv_u3d_core.c +2 -0
@@ -310,6 +310,7 @@ static struct mv_u3d_trb *mv_u3d_build_trb_one(struct mv_u3d_req *req,*/ trb_hw =dma_pool_alloc (u3d->trb_pool,GFP_ATOMIC , dma);if (!trb_hw) { +kfree (trb);dev_err (u3d->dev,"%s, dma_pool_alloc fail\n" , __func__);return NULL ;
@@ -454,6 +455,7 @@ static int mv_u3d_req_to_trb(struct mv_u3d_req *req) trb_hw =kcalloc (trb_num,sizeof (*trb_hw),GFP_ATOMIC );if (!trb_hw) { +kfree (trb);dev_err (u3d->dev,"%s, trb_hw alloc fail\n" , __func__);return -ENOMEM ;
Signature · 1 line
1.7.9.5
Quoted 28 lines · Valentin Ilie
When
trb_hwis NULL, trb should be free'd before return.Signed-off-by Valentin Ilie <[email protected]>--- drivers/usb/gadget/mv_u3d_core.c | 2 ++ 1 file changed, 2 insertions(+)drivers/usb/gadget/mv_u3d_core.c +2
-1@@ -310,6 +310,7 @@ static struct mv_u3d_trb *mv_u3d_build_trb_one(struct mv_u3d_req *req,*/ trb_hw =dma_pool_alloc (u3d->trb_pool,GFP_ATOMIC , dma);if (!trb_hw) { +kfree (trb);dev_err (u3d->dev,"%s, dma_pool_alloc fail\n" , __func__);return NULL ;@@ -454,6 +455,7 @@ static int mv_u3d_req_to_trb(struct mv_u3d_req *req) trb_hw =kcalloc (trb_num,sizeof (*trb_hw),GFP_ATOMIC );if (!trb_hw) { +kfree (trb);dev_err (u3d->dev,"%s, trb_hw alloc fail\n" , __func__);return -ENOMEM ; --
Quoted 2 lines
1.7.9.5
Can anyone look into this?
Thank you
Signature · 2 lines
Valentin Ilie +(40) 746 188 558