Skip to contentSkip to conversation

drivers: net: vmxnet3 : vmxnet3_drv.c: removed checkaptch warning related to msleep()

PATCH In review Avinash kumar 2 participants 2 messages Sep 22, 2013 – Sep 28, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 drivers: net: vmxnet3 : vmxnet3_drv.c: removed checkaptch warning related to msleep()

replaced msleep(1) by usleep_range(1000,1500). Documentation/timers/timers_howto.txt suggests use of usleep_range() in place of msleep() where desired delay is of range 1-20 ms.

---
 drivers/net/vmxnet3/vmxnet3_drv.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/vmxnet3/vmxnet3_drv.c +2 -2
index 7e2788c..34fd6b6 100644
@@ -2608,7 +2608,7 @@ vmxnet3_close(struct net_device *netdev)
 	 * completion.
 	 */
 	while (test_and_set_bit(VMXNET3_STATE_BIT_RESETTING, &adapter->state))
-		msleep(1);
+		usleep_range(1000, 1500);
 
 	vmxnet3_quiesce_dev(adapter);
 
@@ -2656,7 +2656,7 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu)
 	 * completion.
 	 */
 	while (test_and_set_bit(VMXNET3_STATE_BIT_RESETTING, &adapter->state))
-		msleep(1);
+		usleep_range(1000, 1500);
 
 	if (netif_running(netdev)) {
 		vmxnet3_quiesce_dev(adapter);
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw

I see only patch #2 and #3.

Sort out why only 2 of the 3 patches were posted, and resend them all.

Thank you.