ASoC: fsl: fsl_ssi: Fix simultaneous capture and playback
Subsystems (3)
Fabio Estevam
reviewerPATCH 1/1 ASoC: fsl: fsl_ssi: Fix simultaneous capture and playback
From: Fabio Estevam <[email protected]>
When doing simultaneous capture and playback on a mx6 board we get the following error:
$ arecord -f cd | aplay -f cd imx-sgtl5000 sound.13: set sample size in capture stream first fsl-ssi-dai 2028000.ssi: ASoC: can't open interface 2028000.ssi: -11 ALSA lib pcm_dmix.c:1018:(snd_pcm_dmix_ open) unable to open slave aplay: main:660: audio open error: Device or resource busy Recording WAVE 'stdin' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo
The 'arecord -f cd | aplay -f cd' always trigger cause the
'if (!first_runtime->sample_bits)' block to be true which returns an error.
Adjust the logic inside fsl_ssi_startup(), so that we do not always hit the error when playing 'arecord | aplay' line for the first time.
Reported-by Chris Clepper <[email protected]>
Suggested-by Nicolin Chen <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
--- sound/soc/fsl/fsl_ssi.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)
sound/soc/fsl/fsl_ssi.c +4 -11
@@ -469,19 +469,12 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream,* parameters, then the second stream may be * constrained to the wrong sample rate or size. */ -if (!first_runtime->sample_bits) { -dev_err (substream->pcm->card->dev, -"set sample size in %s stream first\n" , - substream->stream == -SNDRV_PCM_STREAM_PLAYBACK - ?"capture" :"playback" ); -return -EAGAIN ; - } - -snd_pcm_hw_constraint_minmax (substream->runtime, -SNDRV_PCM_HW_PARAM_SAMPLE_BITS , +if (first_runtime->sample_bits) { +snd_pcm_hw_constraint_minmax (substream->runtime, +SNDRV_PCM_HW_PARAM_SAMPLE_BITS , first_runtime->sample_bits, first_runtime->sample_bits); + } } ssi_private->second_stream = substream;
Signature · 1 line
1.8.1.2
Quoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
When doing simultaneous capture and playback on a mx6 board we get the following error:
Applied, thanks.