oom: avoid killing init if it assume the oom killed thread's mm
Subsystems (2)
PATCH 1/1 oom: avoid killing init if it assume the oom killed thread's mm
After selecting a task to kill, the oom killer iterates all processes and kills all other user threads that share the same mm_struct in different thread groups.
But in some extreme cases, the selected task happens to be a vfork child of init process sharing the same mm_struct with it, which causes kernel panic on init getting killed. This panic is observed in a busybox shell that busybox itself is init, with a kthread keeps consuming memories.
--- mm/oom_kill.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-)
mm/oom_kill.c +8 -8
@@ -479,17 +479,17 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,task_unlock (victim);/* -* Kill all user processes sharing victim->mm in other thread groups, if -* any. They don't get access to memory reserves, though, to avoid -* depletion of all memory. This prevents mm->mmap_sem livelock when an -* oom killed thread cannot exit because it requires the semaphore and -* its contended by another thread trying to allocate memory itself. -* That thread will now get access to memory reserves since it has a -* pending fatal signal. +* Kill all user processes except init sharing victim->mm in other +* thread groups, if any. They don't get access to memory reserves, +* though, to avoid depletion of all memory. This prevents mm->mmap_sem +* livelock when an oom killed thread cannot exit because it requires +* the semaphore and its contended by another thread trying to allocate +* memory itself. That thread will now get access to memory reserves +* since it has a pending fatal signal. */ for_each_process (p)if (p->mm == mm && !same_thread_group (p, victim) && - !(p->flags &PF_KTHREAD )) { + !(p->flags &PF_KTHREAD ) && !is_global_init (p)) {if (p->signal->oom_score_adj ==OOM_SCORE_ADJ_MIN )continue ;
Signature · 7 lines
1.7.0.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
David Rientjes
reviewerQuoted 9 lines · Ming Liu
After selecting a task to kill, the oom killer iterates all processes and kills all other user threads that share the same
mm_structin different thread groups.But in some extreme cases, the selected task happens to be a vfork child of init process sharing the same
mm_structwith it, which causes kernel panic on init getting killed. This panic is observed in a busybox shell that busybox itself is init, with a kthread keeps consuming memories.
We shouldn't be selecting a process where mm == init_mm in the first place, so this wouldn't fix the issue entirely.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 6 lines · David Rientjes
Quoted 4 lines · Ming Liu
After selecting a task to kill, the oom killer iterates all processes and kills all other user threads that share the same
mm_structin different thread groups.
Quoted 7 lines
Quoted 5 lines
But in some extreme cases, the selected task happens to be a vfork child of init process sharing the same
mm_structwith it, which causes kernel panic on init getting killed. This panic is observed in a busybox shell that busybox itself is init, with a kthread keeps consuming memories.We shouldn't be selecting a process where mm ==
init_mmin the first place, so this wouldn't fix the issue entirely.
But if we add a control point for "mm == init_mm" in the first place(ie. in oom_unkillable_task), that would forbid the processes sharing mm with init to be selected, is that reasonable? Actually my fix is just to protect init process to be killed for its vfork child being selected and I think it's the only place where there is the risk. If my understanding is wrong, pls correct me.
Thanks,
Ming Liu
Quoted 2 lines
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
David Rientjes
reviewerQuoted 10 lines · Ming Liu
Quoted 2 lines
We shouldn't be selecting a process where mm ==
init_mmin the first place, so this wouldn't fix the issue entirely.But if we add a control point for "mm ==
init_mm" in the first place(ie. inoom_unkillable_task), that would forbid the processes sharing mm with init to be selected, is that reasonable? Actually my fix is just to protect init process to be killed for its vfork child being selected and I think it's the only place where there is the risk. If my understanding is wrong, pls correct me.
We never want to select a process where task->mm == init_mm because if we kill it we won't free any memory, regardless of vfork(). The goal of the oom killer is solely to free memory, so it always tries to avoid needless killing.
Quoted 11 lines · David Rientjes
Quoted 9 lines · Ming Liu
Quoted 2 lines
We shouldn't be selecting a process where mm ==
init_mmin the first place, so this wouldn't fix the issue entirely.But if we add a control point for "mm ==
init_mm" in the first place(ie. inoom_unkillable_task), that would forbid the processes sharing mm with init to be selected, is that reasonable? Actually my fix is just to protect init process to be killed for its vfork child being selected and I think it's the only place where there is the risk. If my understanding is wrong, pls correct me.
Quoted 4 lines
We never want to select a process where
task->mm==init_mmbecause if we kill it we won't free any memory, regardless ofvfork(). The goal of the oom killer is solely to free memory, so it always tries to avoid needless killing.
Yes, that make sense, I will send the V1 patch.
the best,
thank you
Quoted 2 lines
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>