Skip to contentSkip to conversation

drm/radeon: add missing hdmi callbacks for rv6xx

PATCH In review Alex Deucher 2 participants 2 messages Sep 23, 2013 – Sep 24, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon: add missing hdmi callbacks for rv6xx

When dpm was merged, I added a new asic struct for rv6xx, but it never got properly updated when the hdmi callbacks were added due to the two patch sets being developed in parallel.

Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=69729

---
 drivers/gpu/drm/radeon/radeon_asic.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/radeon/radeon_asic.c +2 -0
index 5003385..8f7e045 100644
@@ -1004,6 +1004,8 @@ static struct radeon_asic rv6xx_asic = {
 		.wait_for_vblank = &avivo_wait_for_vblank,
 		.set_backlight_level = &atombios_set_backlight_level,
 		.get_backlight_level = &atombios_get_backlight_level,
+		.hdmi_enable = &r600_hdmi_enable,
+		.hdmi_setmode = &r600_hdmi_setmode,
 	},
 	.copy = {
 		.blit = &r600_copy_cpdma,
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw

Am 23.09.2013 21:50, schrieb Alex Deucher:

Quoted 10 lines

When dpm was merged, I added a new asic struct for rv6xx, but it never got properly updated when the hdmi callbacks were added due to the two patch sets being developed in parallel.

Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=69729

Ah, yes of course. Noted this while looking into the DPM patches as well, but totally forgotten about it.

Quoted 17 lines
---
  drivers/gpu/drm/radeon/radeon_asic.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/gpu/drm/radeon/radeon_asic.c +2 -0
index 5003385..8f7e045 100644
@@ -1004,6 +1004,8 @@ static struct radeon_asic rv6xx_asic = {
  		.wait_for_vblank = &avivo_wait_for_vblank,
  		.set_backlight_level = &atombios_set_backlight_level,
  		.get_backlight_level = &atombios_get_backlight_level,
+		.hdmi_enable = &r600_hdmi_enable,
+		.hdmi_setmode = &r600_hdmi_setmode,
  	},
  	.copy = {
  		.blit = &r600_copy_cpdma,