thermal: exynos: Fixes for v3.12
Subsystems (4)
cover thermal: exynos: Fixes for v3.12
This patch series is divided into two parts:
1. Device tree node definition and enabelement for TMU at Exynos4412 (Trats2)
2. Exynos thermal subsystem regressions for v3.12-rc1. Several commits were necessary to properly fix regression for TMU test MUX address setting after reset.
Test HW:
- Exynos4412 - TRATS2 board (Linux v3.12-rc1)
Lukasz Majewski (6):
thermal: exynos: fix: Return from exynos_report_trigger() when
therm_dev is NULL
thermal: exynos: Provide separate TMU data for Exynos4412
thermal: exynos: Provide initial setting for TMU's test MUX address
at Exynos4412
thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
ARM: dts: exynos4x12: Device tree node definition for TMU on
Exynos4x12ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
arch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ arch/arm/boot/dts/exynos4x12.dtsi | 10 +++++++++ drivers/thermal/samsung/exynos_thermal_common.c | 2 +- drivers/thermal/samsung/exynos_tmu.c | 12 +++++++---- drivers/thermal/samsung/exynos_tmu.h | 3 ++- drivers/thermal/samsung/exynos_tmu_data.c | 26 +++++++++++++++++------ drivers/thermal/samsung/exynos_tmu_data.h | 13 +++++++++++- 7 files changed, 58 insertions(+), 13 deletions(-)
Signature · 1 line
1.7.10.4
PATCH 1/6 thermal: exynos: fix: Return from exynos_report_trigger() when therm_dev is NULL
The commit 4de0bdaa9677d11406c9becb70c60887c957e1f0 ("thermal: exynos: Add support for instance based register/unregister") broke check for presence of therm_dev at global thermal zone in exynos_report_trigger().
The resulting wrong test prevents thermal_zone_device_update() call, which calls handlers for situation when trip points are passed.
Such behavior prevents thermal driver from proper reaction (when TMU interrupt is raised) in a situation when overheating is detected at TMU hardware. This patch fixes it.
--- drivers/thermal/samsung/exynos_thermal_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/samsung/exynos_thermal_common.c +1 -1
@@ -310,7 +310,7 @@ void exynos_report_trigger(struct thermal_sensor_conf *conf) } th_zone = conf->pzone_data; -if (th_zone->therm_dev) +if (!th_zone->therm_dev)return ;if (th_zone->bind == false) {
Signature · 1 line
1.7.10.4
Re: [PATCH 1/6] thermal: exynos: fix: Return from exynos_report_trigger() when therm_dev is NULL
Quoted 23 lines · Lukasz Majewski
The commit
4de0bdaa9677d11406c9becb70c60887c957e1f0("thermal: exynos: Add support for instance based register/unregister") broke check for presence oftherm_devat global thermal zone inexynos_report_trigger().The resulting wrong test prevents
thermal_zone_device_update()call, which calls handlers for situation when trip points are passed.
Such behavior prevents thermal driver from proper reaction (when TMU interrupt is raised) in a situation when overheating is detected at TMU hardware. This patch fixes it.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_thermal_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/samsung/exynos_thermal_common.c +0
-0
drivers/thermal/samsung/exynos_thermal_common.c void exynos_report_trigger(struct thermal_sensor_conf *conf) · line 314
Quoted 6 lines
drivers/thermal/samsung/exynos_thermal_common.c +1
-1@@ -310,7 +310,7 @@ void exynos_report_trigger(struct thermal_sensor_conf *conf) } th_zone = conf->pzone_data; -if (th_zone->therm_dev) +if (!th_zone->therm_dev)return ;
Changes looks fine.
Thanks,
Amit Daniel
Quoted 9 lines
drivers/thermal/samsung/exynos_thermal_common.c +0
-1if (th_zone->bind == false) { --1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 38 lines · Lukasz Majewski
The commit
4de0bdaa9677d11406c9becb70c60887c957e1f0("thermal: exynos: Add support for instance based register/unregister") broke check for presence oftherm_devat global thermal zone inexynos_report_trigger().The resulting wrong test prevents
thermal_zone_device_update()call, which calls handlers for situation when trip points are passed.
Such behavior prevents thermal driver from proper reaction (when TMU interrupt is raised) in a situation when overheating is detected at TMU hardware. This patch fixes it.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_thermal_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/samsung/exynos_thermal_common.c +1
-2@@ -310,7 +310,7 @@ void exynos_report_trigger(struct thermal_sensor_conf *conf) } th_zone = conf->pzone_data; -if (th_zone->therm_dev) +if (!th_zone->therm_dev)return ;if (th_zone->bind == false) { --1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] thermal: exynos: fix: Return from exynos_report_trigger() when therm_dev is NULL
In reply to Lukasz MajewskiQuoted 23 lines · Lukasz Majewski
The commit
4de0bdaa9677d11406c9becb70c60887c957e1f0("thermal: exynos: Add support for instance based register/unregister") broke check for presence oftherm_devat global thermal zone inexynos_report_trigger().The resulting wrong test prevents
thermal_zone_device_update()call, which calls handlers for situation when trip points are passed.
Such behavior prevents thermal driver from proper reaction (when TMU interrupt is raised) in a situation when overheating is detected at TMU hardware. This patch fixes it.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_thermal_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/samsung/exynos_thermal_common.c +0
-0
drivers/thermal/samsung/exynos_thermal_common.c void exynos_report_trigger(struct thermal_sensor_conf *conf) · line 313
Quoted 5 lines
drivers/thermal/samsung/exynos_thermal_common.c +1
-1@@ -310,7 +310,7 @@ void exynos_report_trigger(struct thermal_sensor_conf *conf) } th_zone = conf->pzone_data; -if (th_zone->therm_dev) +if (!th_zone->therm_dev)
Fine with this fix, as it really looks obvious. But after reading the code a bit, I am considering if we can remove the above check at all.
Reading the driver code piece at drivers/thermal/samsung/exynos_tmu.c, by checking how exynos_register_thermal gets called, and how error is handled, I assume we do not need to check for th_zone->therm_dev.
To me looks like the driver only allows th_zone's exist only with valid therm_dev, isn't it? Except for the probe sequence, maybe, at run time there is a time window that we have valid th_zone with invalid therm_dev. However, reading the probe, still, the irq gets initialized only in very end, so the work queue don't get queue till then at least.
So, my question before acking is, shall we remove this check altogether?
Quoted 4 lines
drivers/thermal/samsung/exynos_thermal_common.c +0
-0return ;if (th_zone->bind == false) {
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Re: [PATCH 1/6] thermal: exynos: fix: Return from exynos_report_trigger() when therm_dev is NULL
Hi Eduardo,
Thanks for reply.
Quoted 26 lines · Lukasz Majewski
Quoted 25 lines
The commit
4de0bdaa9677d11406c9becb70c60887c957e1f0("thermal: exynos: Add support for instance based register/unregister") broke check for presence oftherm_devat global thermal zone inexynos_report_trigger().The resulting wrong test prevents
thermal_zone_device_update()call, which calls handlers for situation when trip points are passed. Such behavior prevents thermal driver from proper reaction (when TMU interrupt is raised) in a situation when overheating is detected at TMU hardware. This patch fixes it.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_thermal_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_thermal_common.cindex f10a6ad..55a912a 100644 ---a/drivers/thermal/samsung/exynos_thermal_common.c+++b/drivers/thermal/samsung/exynos_thermal_common.c@@ -310,7 +310,7 @@ voidexynos_report_trigger(struct thermal_sensor_conf *conf)}
Quoted 6 lines
drivers/thermal/samsung/exynos_thermal_common.c void exynos_report_trigger(struct thermal_sensor_conf *conf) · line 313
Quoted 3 lines
drivers/thermal/samsung/exynos_thermal_common.c +1
-1th_zone = conf->pzone_data; -if (th_zone->therm_dev) +if (!th_zone->therm_dev)Fine with this fix, as it really looks obvious. But after reading the code a bit, I am considering if we can remove the above check at all.
I have just preserved the old behaviour for -rcX fix.
Quoted 4 lines
Reading the driver code piece at
drivers/thermal/samsung/exynos_tmu.c, by checking howexynos_register_thermalgets called, and how error is handled, I assume we do not need to check forth_zone->therm_dev.
It looks like we don't need this check (we will not register the thermal zone if therm dev is not correct).
Quoted 10 lines
To me looks like the driver only allows th_zone's exist only with valid
therm_dev, isn't it? Except for the probe sequence, maybe, at run time there is a time window that we have validth_zonewith invalidtherm_dev. However, reading the probe, still, the irq gets initialized only in very end, so the work queue don't get queue till then at least.So, my question before acking is, shall we remove this check altogether?
I think that it is up to you to decide how we proceed.
Shall this patch go into v3.12-rcX since it is "obvious" (and documents what and when was broken) or would you require to prepare "new" patch with removal of this check?
Quoted 8 lines
Quoted 6 lines
drivers/thermal/samsung/exynos_thermal_common.c +0
-0return ;if (th_zone->bind == false) {
Signature · 9 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/6 thermal: exynos: Provide separate TMU data for Exynos4412
In reply to Lukasz MajewskiUp till now Exynos5250 and Exynos4412 had the same definitions for TMU data. Following commit changes that, by introducing separate exynos4412_default_tmu_data structure.
Since Exynos4412 was chronologically first, the corresponding name for TMU registers and default data was renamed.
Additionally, new SOC_ARCH_EXYNOS4412 type has been defined.
--- drivers/thermal/samsung/exynos_tmu.c | 7 ++++--- drivers/thermal/samsung/exynos_tmu.h | 1 + drivers/thermal/samsung/exynos_tmu_data.c | 26 ++++++++++++++++++++------ drivers/thermal/samsung/exynos_tmu_data.h | 9 ++++++++- 4 files changed, 33 insertions(+), 10 deletions(-)
drivers/thermal/samsung/exynos_tmu.c +4 -3
@@ -488,7 +488,7 @@ static const struct of_device_id exynos_tmu_match[] = { }, { .compatible = "samsung,exynos4412-tmu", - .data = (void *)EXYNOS5250_TMU_DRV_DATA, + .data = (void *)EXYNOS4412_TMU_DRV_DATA, }, { .compatible = "samsung,exynos5250-tmu",
@@ -630,8 +630,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)return ret;if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || - pdata->type ==SOC_ARCH_EXYNOS5440 ) + pdata->type ==SOC_ARCH_EXYNOS4210 || + pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else { ret = -EINVAL ;
drivers/thermal/samsung/exynos_tmu.h +1 -0
@@ -41,6 +41,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 , +SOC_ARCH_EXYNOS4412 ,SOC_ARCH_EXYNOS ,SOC_ARCH_EXYNOS5440 , };
drivers/thermal/samsung/exynos_tmu_data.c +20 -6
@@ -90,8 +90,8 @@ struct exynos_tmu_init_data const exynos4210_default_tmu_data = { };#endif -#if defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 ) -static const struct exynos_tmu_registers exynos5250_tmu_registers = { +#if defined(CONFIG_SOC_EXYNOS4412 ) || defined(CONFIG_SOC_EXYNOS5250 ) +static const struct exynos_tmu_registers exynos4412_tmu_registers = { .triminfo_data =EXYNOS_TMU_REG_TRIMINFO , .triminfo_25_shift =EXYNOS_TRIMINFO_25_SHIFT , .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,
@@ -128,7 +128,7 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .emul_time_mask = EXYNOS_EMUL_TIME_MASK, }; -#define EXYNOS5250_TMU_DATA \ +#define EXYNOS4412_TMU_DATA \ .threshold_falling = 10, \ .trigger_levels[0] = 85, \ .trigger_levels[1] = 103, \
@@ -162,15 +162,29 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .temp_level = 103, \ }, \ .freq_tab_count = 2, \ - .type = SOC_ARCH_EXYNOS, \ - .registers = &exynos5250_tmu_registers, \ + .registers = &exynos4412_tmu_registers, \ .features = (TMU_SUPPORT_EMULATION |TMU_SUPPORT_TRIM_RELOAD | \TMU_SUPPORT_FALLING_TRIP |TMU_SUPPORT_READY_STATUS | \ TMU_SUPPORT_EMUL_TIME) +#endif +#if defined(CONFIG_SOC_EXYNOS4412 ) +struct exynos_tmu_init_data const exynos4412_default_tmu_data = { + .tmu_data = { + {EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS4412 , + }, + }, + .tmu_count =1 , +}; +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { - {EXYNOS5250_TMU_DATA }, + {EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS , + }, }, .tmu_count =1 , };
drivers/thermal/samsung/exynos_tmu_data.h +8 -1
@@ -138,7 +138,14 @@ extern struct exynos_tmu_init_data const exynos4210_default_tmu_data;#define EXYNOS4210_TMU_DRV_DATA (NULL)#endif -#if (defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 )) +#if defined(CONFIG_SOC_EXYNOS4412 ) +extern struct exynos_tmu_init_data const exynos4412_default_tmu_data; +#define EXYNOS4412_TMU_DRV_DATA (&exynos4412_default_tmu_data) +#else +#define EXYNOS4412_TMU_DRV_DATA (NULL) +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )extern struct exynos_tmu_init_data const exynos5250_default_tmu_data;#define EXYNOS5250_TMU_DRV_DATA (&exynos5250_default_tmu_data)#else
Signature · 1 line
1.7.10.4
Re: [PATCH 2/6] thermal: exynos: Provide separate TMU data for Exynos4412
Quoted 4 lines · Lukasz Majewski
Up till now Exynos5250 and Exynos4412 had the same definitions for TMU data. Following commit changes that, by introducing separate
exynos4412_default_tmu_datastructure.
Quoted 8 lines
Since Exynos4412 was chronologically first, the corresponding name for TMU registers and default data was renamed.
Additionally, new
SOC_ARCH_EXYNOS4412type has been defined.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>
Thanks,
Amit Daniel
Quoted 128 lines
--- drivers/thermal/samsung/exynos_tmu.c | 7 ++++--- drivers/thermal/samsung/exynos_tmu.h | 1 + drivers/thermal/samsung/exynos_tmu_data.c | 26 ++++++++++++++++++++------ drivers/thermal/samsung/exynos_tmu_data.h | 9 ++++++++- 4 files changed, 33 insertions(+), 10 deletions(-)drivers/thermal/samsung/exynos_tmu.c +4
-3@@ -488,7 +488,7 @@ static const struct of_device_id exynos_tmu_match[] = { }, { .compatible = "samsung,exynos4412-tmu", - .data = (void *)EXYNOS5250_TMU_DRV_DATA, + .data = (void *)EXYNOS4412_TMU_DRV_DATA, }, { .compatible = "samsung,exynos5250-tmu",@@ -630,8 +630,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)return ret;if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || - pdata->type ==SOC_ARCH_EXYNOS5440 ) + pdata->type ==SOC_ARCH_EXYNOS4210 || + pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else { ret = -EINVAL ;drivers/thermal/samsung/exynos_tmu.h +1
-0@@ -41,6 +41,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 , +SOC_ARCH_EXYNOS4412 ,SOC_ARCH_EXYNOS ,SOC_ARCH_EXYNOS5440 , };drivers/thermal/samsung/exynos_tmu_data.c +20
-6@@ -90,8 +90,8 @@ struct exynos_tmu_init_data const exynos4210_default_tmu_data = { };#endif -#if defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 ) -static const struct exynos_tmu_registers exynos5250_tmu_registers = { +#if defined(CONFIG_SOC_EXYNOS4412 ) || defined(CONFIG_SOC_EXYNOS5250 ) +static const struct exynos_tmu_registers exynos4412_tmu_registers = { .triminfo_data =EXYNOS_TMU_REG_TRIMINFO , .triminfo_25_shift =EXYNOS_TRIMINFO_25_SHIFT , .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,@@ -128,7 +128,7 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .emul_time_mask = EXYNOS_EMUL_TIME_MASK, }; -#define EXYNOS5250_TMU_DATA \ +#define EXYNOS4412_TMU_DATA \ .threshold_falling = 10, \ .trigger_levels[0] = 85, \ .trigger_levels[1] = 103, \@@ -162,15 +162,29 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .temp_level = 103, \ }, \ .freq_tab_count = 2, \ - .type = SOC_ARCH_EXYNOS, \ - .registers = &exynos5250_tmu_registers, \ + .registers = &exynos4412_tmu_registers, \ .features = (TMU_SUPPORT_EMULATION |TMU_SUPPORT_TRIM_RELOAD | \TMU_SUPPORT_FALLING_TRIP |TMU_SUPPORT_READY_STATUS | \ TMU_SUPPORT_EMUL_TIME) +#endif +#if defined(CONFIG_SOC_EXYNOS4412 ) +struct exynos_tmu_init_data const exynos4412_default_tmu_data = { + .tmu_data = { + {EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS4412 , + }, + }, + .tmu_count =1 , +}; +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { - {EXYNOS5250_TMU_DATA }, + {EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS , + }, }, .tmu_count =1 , };drivers/thermal/samsung/exynos_tmu_data.h +8
-2@@ -138,7 +138,14 @@ extern struct exynos_tmu_init_data const exynos4210_default_tmu_data;#define EXYNOS4210_TMU_DRV_DATA (NULL)#endif -#if (defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 )) +#if defined(CONFIG_SOC_EXYNOS4412 ) +extern struct exynos_tmu_init_data const exynos4412_default_tmu_data; +#define EXYNOS4412_TMU_DRV_DATA (&exynos4412_default_tmu_data) +#else +#define EXYNOS4412_TMU_DRV_DATA (NULL) +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )extern struct exynos_tmu_init_data const exynos5250_default_tmu_data;#define EXYNOS5250_TMU_DRV_DATA (&exynos5250_default_tmu_data)#else --1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 140 lines · Lukasz Majewski
Up till now Exynos5250 and Exynos4412 had the same definitions for TMU data. Following commit changes that, by introducing separate
exynos4412_default_tmu_datastructure.Since Exynos4412 was chronologically first, the corresponding name for TMU registers and default data was renamed.
Additionally, new
SOC_ARCH_EXYNOS4412type has been defined.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 7 ++++--- drivers/thermal/samsung/exynos_tmu.h | 1 + drivers/thermal/samsung/exynos_tmu_data.c | 26 ++++++++++++++++++++------ drivers/thermal/samsung/exynos_tmu_data.h | 9 ++++++++- 4 files changed, 33 insertions(+), 10 deletions(-)drivers/thermal/samsung/exynos_tmu.c +4
-3@@ -488,7 +488,7 @@ static const struct of_device_id exynos_tmu_match[] = { }, { .compatible = "samsung,exynos4412-tmu", - .data = (void *)EXYNOS5250_TMU_DRV_DATA, + .data = (void *)EXYNOS4412_TMU_DRV_DATA, }, { .compatible = "samsung,exynos5250-tmu",@@ -630,8 +630,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)return ret;if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || - pdata->type ==SOC_ARCH_EXYNOS5440 ) + pdata->type ==SOC_ARCH_EXYNOS4210 || + pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else { ret = -EINVAL ;drivers/thermal/samsung/exynos_tmu.h +1
-0@@ -41,6 +41,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 , +SOC_ARCH_EXYNOS4412 ,SOC_ARCH_EXYNOS ,SOC_ARCH_EXYNOS5440 , };drivers/thermal/samsung/exynos_tmu_data.c +20
-6@@ -90,8 +90,8 @@ struct exynos_tmu_init_data const exynos4210_default_tmu_data = { };#endif -#if defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 ) -static const struct exynos_tmu_registers exynos5250_tmu_registers = { +#if defined(CONFIG_SOC_EXYNOS4412 ) || defined(CONFIG_SOC_EXYNOS5250 ) +static const struct exynos_tmu_registers exynos4412_tmu_registers = { .triminfo_data =EXYNOS_TMU_REG_TRIMINFO , .triminfo_25_shift =EXYNOS_TRIMINFO_25_SHIFT , .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,@@ -128,7 +128,7 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .emul_time_mask = EXYNOS_EMUL_TIME_MASK, }; -#define EXYNOS5250_TMU_DATA \ +#define EXYNOS4412_TMU_DATA \ .threshold_falling = 10, \ .trigger_levels[0] = 85, \ .trigger_levels[1] = 103, \@@ -162,15 +162,29 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .temp_level = 103, \ }, \ .freq_tab_count = 2, \ - .type = SOC_ARCH_EXYNOS, \ - .registers = &exynos5250_tmu_registers, \ + .registers = &exynos4412_tmu_registers, \ .features = (TMU_SUPPORT_EMULATION |TMU_SUPPORT_TRIM_RELOAD | \TMU_SUPPORT_FALLING_TRIP |TMU_SUPPORT_READY_STATUS | \ TMU_SUPPORT_EMUL_TIME) +#endif +#if defined(CONFIG_SOC_EXYNOS4412 ) +struct exynos_tmu_init_data const exynos4412_default_tmu_data = { + .tmu_data = { + {EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS4412 , + }, + }, + .tmu_count =1 , +}; +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { - {EXYNOS5250_TMU_DATA }, + {EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS , + }, }, .tmu_count =1 , };drivers/thermal/samsung/exynos_tmu_data.h +8
-2@@ -138,7 +138,14 @@ extern struct exynos_tmu_init_data const exynos4210_default_tmu_data;#define EXYNOS4210_TMU_DRV_DATA (NULL)#endif -#if (defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 )) +#if defined(CONFIG_SOC_EXYNOS4412 ) +extern struct exynos_tmu_init_data const exynos4412_default_tmu_data; +#define EXYNOS4412_TMU_DRV_DATA (&exynos4412_default_tmu_data) +#else +#define EXYNOS4412_TMU_DRV_DATA (NULL) +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )extern struct exynos_tmu_init_data const exynos5250_default_tmu_data;#define EXYNOS5250_TMU_DRV_DATA (&exynos5250_default_tmu_data)#else --1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/6] thermal: exynos: Provide separate TMU data for Exynos4412
In reply to Lukasz MajewskiLukasz,
Just minor comments.
Quoted 8 lines · Lukasz Majewski
Up till now Exynos5250 and Exynos4412 had the same definitions for TMU data. Following commit changes that, by introducing separate
exynos4412_default_tmu_datastructure.Since Exynos4412 was chronologically first, the corresponding name for TMU registers and default data was renamed.
Additionally, new
SOC_ARCH_EXYNOS4412type has been defined.
It is not clear the objective of the patch itself. Was it just to make the code more readable or are you fixing something?
Quoted 41 lines
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 7 ++++--- drivers/thermal/samsung/exynos_tmu.h | 1 + drivers/thermal/samsung/exynos_tmu_data.c | 26 ++++++++++++++++++++------ drivers/thermal/samsung/exynos_tmu_data.h | 9 ++++++++- 4 files changed, 33 insertions(+), 10 deletions(-)drivers/thermal/samsung/exynos_tmu.c +4
-3@@ -488,7 +488,7 @@ static const struct of_device_id exynos_tmu_match[] = { }, { .compatible = "samsung,exynos4412-tmu", - .data = (void *)EXYNOS5250_TMU_DRV_DATA, + .data = (void *)EXYNOS4412_TMU_DRV_DATA, }, { .compatible = "samsung,exynos5250-tmu",@@ -630,8 +630,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)return ret;if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || - pdata->type ==SOC_ARCH_EXYNOS5440 ) + pdata->type ==SOC_ARCH_EXYNOS4210 || + pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else { ret = -EINVAL ;drivers/thermal/samsung/exynos_tmu.h +0
-0
drivers/thermal/samsung/exynos_tmu.h enum calibration_mode { · line 47
Quoted 7 lines
drivers/thermal/samsung/exynos_tmu.h +1
-0@@ -41,6 +41,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 , +SOC_ARCH_EXYNOS4412 ,SOC_ARCH_EXYNOS ,SOC_ARCH_EXYNOS5440 , };
I believe the above enum needs some documentation. SOC_ARCH_EXYNOS seams to be a bit confusing.
Quoted 44 lines
drivers/thermal/samsung/exynos_tmu_data.c +13
-5@@ -90,8 +90,8 @@ struct exynos_tmu_init_data const exynos4210_default_tmu_data = { };#endif -#if defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 ) -static const struct exynos_tmu_registers exynos5250_tmu_registers = { +#if defined(CONFIG_SOC_EXYNOS4412 ) || defined(CONFIG_SOC_EXYNOS5250 ) +static const struct exynos_tmu_registers exynos4412_tmu_registers = { .triminfo_data =EXYNOS_TMU_REG_TRIMINFO , .triminfo_25_shift =EXYNOS_TRIMINFO_25_SHIFT , .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,@@ -128,7 +128,7 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .emul_time_mask = EXYNOS_EMUL_TIME_MASK, }; -#define EXYNOS5250_TMU_DATA \ +#define EXYNOS4412_TMU_DATA \ .threshold_falling = 10, \ .trigger_levels[0] = 85, \ .trigger_levels[1] = 103, \@@ -162,15 +162,29 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .temp_level = 103, \ }, \ .freq_tab_count = 2, \ - .type = SOC_ARCH_EXYNOS, \ - .registers = &exynos5250_tmu_registers, \ + .registers = &exynos4412_tmu_registers, \ .features = (TMU_SUPPORT_EMULATION |TMU_SUPPORT_TRIM_RELOAD | \TMU_SUPPORT_FALLING_TRIP |TMU_SUPPORT_READY_STATUS | \ TMU_SUPPORT_EMUL_TIME) +#endif +#if defined(CONFIG_SOC_EXYNOS4412 ) +struct exynos_tmu_init_data const exynos4412_default_tmu_data = { + .tmu_data = { + {EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS4412 , + }, + }, + .tmu_count = 1,
drivers/thermal/samsung/exynos_tmu_data.c static const struct exynos_tmu_registers exynos5250_tmu_registers = { · line 187
Quoted 10 lines
drivers/thermal/samsung/exynos_tmu_data.c +7
-1+}; +#endif + +#if defined(CONFIG_SOC_EXYNOS5250) struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { - {EXYNOS5250_TMU_DATA }, + { EXYNOS4412_TMU_DATA, + .type = SOC_ARCH_EXYNOS, + },
Please add a comment on this initialization, specially because we start to mix macros with inline initialization. Starts to be hard to follow.
Besides, I believe
+ {
+ EXYNOS4412_TMU_DATA,
+ .type = SOC_ARCH_EXYNOS,
+ },
is a much more common style.
Quoted 24 lines
drivers/thermal/samsung/exynos_tmu_data.c +0
-0}, .tmu_count = 1, };drivers/thermal/samsung/exynos_tmu_data.h +8
-1@@ -138,7 +138,14 @@ extern struct exynos_tmu_init_data const exynos4210_default_tmu_data;#define EXYNOS4210_TMU_DRV_DATA (NULL)#endif -#if (defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 )) +#if defined(CONFIG_SOC_EXYNOS4412 ) +extern struct exynos_tmu_init_data const exynos4412_default_tmu_data; +#define EXYNOS4412_TMU_DRV_DATA (&exynos4412_default_tmu_data) +#else +#define EXYNOS4412_TMU_DRV_DATA (NULL) +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )extern struct exynos_tmu_init_data const exynos5250_default_tmu_data;#define EXYNOS5250_TMU_DRV_DATA (&exynos5250_default_tmu_data)#else
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Re: [PATCH 2/6] thermal: exynos: Provide separate TMU data for Exynos4412
Hi Eduardo,
Quoted 9 lines
Lukasz,
Just minor comments.
Quoted 4 lines · Lukasz Majewski
Up till now Exynos5250 and Exynos4412 had the same definitions for TMU data. Following commit changes that, by introducing separate
exynos4412_default_tmu_datastructure.
Quoted 7 lines
Quoted 4 lines
Since Exynos4412 was chronologically first, the corresponding name for TMU registers and default data was renamed.
Additionally, new
SOC_ARCH_EXYNOS4412type has been defined.It is not clear the objective of the patch itself. Was it just to make the code more readable or are you fixing something?
I'm fixing thermal on EXYNOS4412 device (trats2). The problem here is to do it properly, since on the current code EXYNOS4412 and EXYNOS5250 uses the same configuration data.
To fix this problem, I had to split them. Also chronologically the THERMAL IP first appeared on EXYNOS4412, not EXYNOS5250.
Quoted 44 lines
Quoted 44 lines
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 7 ++++--- drivers/thermal/samsung/exynos_tmu.h | 1 + drivers/thermal/samsung/exynos_tmu_data.c | 26++++++++++++++++++++------
drivers/thermal/samsung/exynos_tmu_data.h| 9 ++++++++- 4 files
changed, 33 insertions(+), 10 deletions(-)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex b43afda..a858cc4 100644drivers/thermal/samsung/exynos_tmu.c +4
-3@@ -488,7 +488,7 @@ static const struct of_device_id exynos_tmu_match[] = { }, { .compatible = "samsung,exynos4412-tmu", - .data = (void *)EXYNOS5250_TMU_DRV_DATA, + .data = (void *)EXYNOS4412_TMU_DRV_DATA, }, { .compatible = "samsung,exynos5250-tmu",@@ -630,8 +630,9 @@ static int exynos_tmu_probe(struct platform_device *pdev) return ret;if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || - pdata->type ==SOC_ARCH_EXYNOS5440 ) + pdata->type ==SOC_ARCH_EXYNOS4210 || + pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else { ret = -EINVAL ;(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.hindex b364c9e..db37df0 100644drivers/thermal/samsung/exynos_tmu.h +0
-0@@ -41,6 +41,7 @@ enum calibration_mode {
Quoted 9 lines
drivers/thermal/samsung/exynos_tmu.h enum calibration_mode { · line 47
Quoted 6 lines
drivers/thermal/samsung/exynos_tmu.h +1
-0enum soc_type {SOC_ARCH_EXYNOS4210 =1 , +SOC_ARCH_EXYNOS4412 ,SOC_ARCH_EXYNOS ,SOC_ARCH_EXYNOS5440 , };I believe the above enum needs some documentation.
SOC_ARCH_EXYNOSseams to be a bit confusing.
This is fixed at patch 4/6 of the series.
Quoted 66 lines
Quoted 45 lines
(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.cindex 9002499..bd08093 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.c+++b/drivers/thermal/samsung/exynos_tmu_data.cdrivers/thermal/samsung/exynos_tmu.h +0
-1@@ -90,8 +90,8 @@ struct exynos_tmu_init_data const exynos4210_default_tmu_data = { };#endif -#if defined(CONFIG_SOC_EXYNOS5250) ||
defined(CONFIG_SOC_EXYNOS4412)-static const structexynos_tmu_registersexynos5250_tmu_registers= { +#ifdefined(CONFIG_SOC_EXYNOS4412)||defined(CONFIG_SOC_EXYNOS5250)+static const structexynos_tmu_registersexynos4412_tmu_registers= { .triminfo_data =EXYNOS_TMU_REG_TRIMINFO, .triminfo_25_shift =EXYNOS_TRIMINFO_25_SHIFT, .triminfo_85_shift =EXYNOS_TRIMINFO_85_SHIFT, @@ -128,7 +128,7 @@ static const structexynos_tmu_registersexynos5250_tmu_registers= { .emul_time_mask =EXYNOS_EMUL_TIME_MASK, };drivers/thermal/samsung/exynos_tmu.h +2
-3-#define EXYNOS5250_TMU_DATA \ +#define EXYNOS4412_TMU_DATA \ .threshold_falling = 10, \ .trigger_levels[0] = 85, \ .trigger_levels[1] = 103, \@@ -162,15 +162,29 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .temp_level = 103, \ }, \ .freq_tab_count = 2, \ - .type = SOC_ARCH_EXYNOS, \ - .registers = &exynos5250_tmu_registers, \ + .registers = &exynos4412_tmu_registers, \ .features = (TMU_SUPPORT_EMULATION |
TMU_SUPPORT_TRIM_RELOAD| \TMU_SUPPORT_FALLING_TRIP|TMU_SUPPORT_READY_STATUS| \TMU_SUPPORT_EMUL_TIME)drivers/thermal/samsung/exynos_tmu.h +9
-0+#endif +#if defined(CONFIG_SOC_EXYNOS4412 ) +struct exynos_tmu_init_data const exynos4412_default_tmu_data = { + .tmu_data = { + {EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS4412 , + }, + }, + .tmu_count = 1,drivers/thermal/samsung/exynos_tmu.h
Quoted 10 lines
drivers/thermal/samsung/exynos_tmu.h +7
-1+}; +#endif + +#if defined(CONFIG_SOC_EXYNOS5250) struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { - {EXYNOS5250_TMU_DATA }, + { EXYNOS4412_TMU_DATA, + .type = SOC_ARCH_EXYNOS, + },Please add a comment on this initialization, specially because we start to mix macros with inline initialization. Starts to be hard to follow.
Besides, I believe
drivers/thermal/samsung/exynos_tmu_data.c +4
-0+ { + EXYNOS4412_TMU_DATA, + .type = SOC_ARCH_EXYNOS, + },
Quoted 1 line
is a much more common style.
Ok.
Quoted 28 lines
Quoted 26 lines
drivers/thermal/samsung/exynos_tmu.h +0
-0}, .tmu_count = 1, };(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.hindex dc7feb5..b130b1e 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.h+++b/drivers/thermal/samsung/exynos_tmu_data.h(quoted diff) +1
-1@@ -138,7 +138,14 @@ extern struct exynos_tmu_init_data const exynos4210_default_tmu_data; #define EXYNOS4210_TMU_DRV_DATA (NULL) #endif -#if (defined(CONFIG_SOC_EXYNOS5250) || defined(CONFIG_SOC_EXYNOS4412)) +#if defined(CONFIG_SOC_EXYNOS4412) +extern struct exynos_tmu_init_data const
exynos4412_default_tmu_data; +#defineEXYNOS4412_TMU_DRV_DATA(&exynos4412_default_tmu_data) +#elsedrivers/thermal/samsung/exynos_tmu_data.h +4
-0+#define EXYNOS4412_TMU_DRV_DATA (NULL) +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 ) extern struct exynos_tmu_init_data const
exynos5250_default_tmu_data; #defineEXYNOS5250_TMU_DRV_DATA(&exynos5250_default_tmu_data) #else
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
PATCH 3/6 thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412
In reply to Lukasz MajewskiThe commit d0a0ce3e77c795258d47f9163e92d5031d0c5221 ("thermal: exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.
This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
--- drivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 2 files changed, 7 insertions(+)
drivers/thermal/samsung/exynos_tmu.c +3 -0
@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl); +if (pdata->type ==SOC_ARCH_EXYNOS4412 ) + con |= (EXYNOS4412_MUX_ADDR_VALUE <<EXYNOS4412_MUX_ADDR_SHIFT ); +if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask << reg->buf_vref_sel_shift); con |= pdata->reference_voltage << reg->buf_vref_sel_shift;
drivers/thermal/samsung/exynos_tmu_data.h +4 -0
@@ -95,6 +95,10 @@#define EXYNOS_MAX_TRIGGER_PER_REG 4 +/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define EXYNOS5440_TMU_S0_7_CTRL 0x020
Signature · 1 line
1.7.10.4
Re: [PATCH 3/6] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412
Hi,
Quoted 7 lines · Lukasz Majewski
The commit
d0a0ce3e77c795258d47f9163e92d5031d0c5221("thermal: exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
Right In 5250 this field is not defined so didn't catch this. The changes looks fine but I have a minor comment that if this field is defined in 4412 in detail then you can add a field entry in exynos_tmu_registers with proper name and populate this field. The good thing is that in 5250 also this field is reserved and the default value is 0x6 so same TMU_DATA can be used for 5250 and 4412. The main idea of this suggestion is to reduce the soc checks in the driver.
Thanks,
Amit Daniel
Quoted 45 lines
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 2 files changed, 7 insertions(+)drivers/thermal/samsung/exynos_tmu.c +3
-0@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl); +if (pdata->type ==SOC_ARCH_EXYNOS4412 ) + con |= (EXYNOS4412_MUX_ADDR_VALUE <<EXYNOS4412_MUX_ADDR_SHIFT ); +if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask << reg->buf_vref_sel_shift); con |= pdata->reference_voltage << reg->buf_vref_sel_shift;drivers/thermal/samsung/exynos_tmu_data.h +4
-1@@ -95,6 +95,10 @@#define EXYNOS_MAX_TRIGGER_PER_REG 4 +/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define EXYNOS5440_TMU_S0_7_CTRL 0x020 --1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 52 lines · Lukasz Majewski
The commit
d0a0ce3e77c795258d47f9163e92d5031d0c5221("thermal: exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 2 files changed, 7 insertions(+)drivers/thermal/samsung/exynos_tmu.c +3
-0@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl); +if (pdata->type ==SOC_ARCH_EXYNOS4412 ) + con |= (EXYNOS4412_MUX_ADDR_VALUE <<EXYNOS4412_MUX_ADDR_SHIFT ); +if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask << reg->buf_vref_sel_shift); con |= pdata->reference_voltage << reg->buf_vref_sel_shift;drivers/thermal/samsung/exynos_tmu_data.h +4
-1@@ -95,6 +95,10 @@#define EXYNOS_MAX_TRIGGER_PER_REG 4 +/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define EXYNOS5440_TMU_S0_7_CTRL 0x020 --1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/6] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412
Hi Amit,
Quoted 8 lines
Hi,
Quoted 4 lines · Lukasz Majewski
The commit
d0a0ce3e77c795258d47f9163e92d5031d0c5221("thermal:
exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.
Quoted 8 lines
Quoted 4 lines
This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
Right In 5250 this field is not defined so didn't catch this. The changes looks fine but I have a minor comment that if this field is defined in 4412 in detail then you can add a field entry in
exynos_tmu_registerswith proper name and populate this field.
It seems, that only at Exynos4412 (and Exynos4212) this field is valid. When I extent exynos_tmu_registers structure, then all other Samsung SoCs will be aware of it.
Define with explicit EXYNOS4412 seems more readable.
Also at exynos_tmu_control() function we use constructs like:data->base + EXYNOS_TMU_REG_CONTROL, not data->base + regs->tmu_ctrl.
Quoted 3 lines
The
good thing is that in 5250 also this field is reserved and the default value is0x6so sameTMU_DATAcan be used for 5250 and 4412.
I'm not keen to this kind of hacks. This field is only valid on Exynos4x12. And for Exynos5250 is reserved, which means that we shall not touch it.
Quoted 2 lines
The main
idea of this suggestion is to reduce the soc checks in the driver.
Correct me if I'm wrong, but this MUX_ADDR initialization is performed at exynos_tmu_control() which is called at probe and thermal power management functions. Therefore, it seems that checking if SoC == Exynos4412 there is not an overkill.
If you don't mind I would leave those patches as they are and kindly ask thermal maintainers for pulling them to v3.12.
Quoted 106 lines
Thanks,
Amit DanielQuoted 46 lines
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 2 files changed, 7 insertions(+)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex a858cc4..21b89e4 100644drivers/thermal/samsung/exynos_tmu.c +2
-0@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl); +if (pdata->type ==SOC_ARCH_EXYNOS4412 ) + con |= (EXYNOS4412_MUX_ADDR_VALUE <<
EXYNOS4412_MUX_ADDR_SHIFT); +if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask <<
reg->buf_vref_sel_shift); con |=pdata->reference_voltage<<reg->buf_vref_sel_shift; diff --gita/drivers/thermal/samsung/exynos_tmu_data.hb/drivers/thermal/samsung/exynos_tmu_data.hindex b130b1e..a1ea19d 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.h+++b/drivers/thermal/samsung/exynos_tmu_data.h@@ -95,6 +95,10 @@#define
EXYNOS_MAX_TRIGGER_PER_REG4drivers/thermal/samsung/exynos_tmu.c +4
-1+/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define EXYNOS5440_TMU_S0_7_CTRL 0x020 --1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.htmlQuoted 54 lines · Lukasz Majewski
The commit
d0a0ce3e77c795258d47f9163e92d5031d0c5221("thermal:
exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 2 files changed, 7 insertions(+)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex a858cc4..21b89e4 100644drivers/thermal/samsung/exynos_tmu.c +2
-0@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl); +if (pdata->type ==SOC_ARCH_EXYNOS4412 ) + con |= (EXYNOS4412_MUX_ADDR_VALUE <<
EXYNOS4412_MUX_ADDR_SHIFT); +if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask <<
reg->buf_vref_sel_shift); con |=pdata->reference_voltage<<reg->buf_vref_sel_shift; diff --gita/drivers/thermal/samsung/exynos_tmu_data.hb/drivers/thermal/samsung/exynos_tmu_data.hindex b130b1e..a1ea19d 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.h+++b/drivers/thermal/samsung/exynos_tmu_data.h@@ -95,6 +95,10 @@#define
EXYNOS_MAX_TRIGGER_PER_REG4drivers/thermal/samsung/exynos_tmu.c +4
-1+/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define EXYNOS5440_TMU_S0_7_CTRL 0x020 --1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 9 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/6] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412
In reply to Lukasz MajewskiQuoted 21 lines · Lukasz Majewski
The commit
d0a0ce3e77c795258d47f9163e92d5031d0c5221("thermal: exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 2 files changed, 7 insertions(+)drivers/thermal/samsung/exynos_tmu.c +0
-0
drivers/thermal/samsung/exynos_tmu.c static void exynos_tmu_control(struct platform_device *pdev, bool on) · line 321
Quoted 5 lines
drivers/thermal/samsung/exynos_tmu.c +2
-0@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl); +if (pdata->type ==SOC_ARCH_EXYNOS4412 ) + con |= (EXYNOS4412_MUX_ADDR_VALUE <<EXYNOS4412_MUX_ADDR_SHIFT );
Amit has introduced a way to describe features instead of checking features per type. It would be interesting to have a reasoning why not to use it. Think what if new Exynos TMU versions come, are you guys going to steadily increase the above check for type?
Quoted 20 lines
drivers/thermal/samsung/exynos_tmu.c +1
-0+if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask << reg->buf_vref_sel_shift); con |= pdata->reference_voltage << reg->buf_vref_sel_shift;drivers/thermal/samsung/exynos_tmu_data.h +4
-0@@ -95,6 +95,10 @@#define EXYNOS_MAX_TRIGGER_PER_REG 4 +/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define EXYNOS5440_TMU_S0_7_CTRL 0x020
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Re: [PATCH 3/6] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412
Hi Eduardo,
Quoted 26 lines · Lukasz Majewski
Quoted 25 lines
The commit
d0a0ce3e77c795258d47f9163e92d5031d0c5221("thermal:
exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 2 files changed, 7 insertions(+)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex a858cc4..21b89e4 100644drivers/thermal/samsung/exynos_tmu.c +0
-0@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl);
Quoted 7 lines
drivers/thermal/samsung/exynos_tmu.c static void exynos_tmu_control(struct · line 322
Quoted 3 lines
drivers/thermal/samsung/exynos_tmu.c +2
-0+if (pdata->type ==SOC_ARCH_EXYNOS4412 ) + con |= (EXYNOS4412_MUX_ADDR_VALUE <<EXYNOS4412_MUX_ADDR_SHIFT );Amit has introduced a way to describe features instead of checking features per type. It would be interesting to have a reasoning why not to use it.
Problem with Exynos4412 and Exynos4212 is that _only_ those SoCs export this MUX_ADDR field at TMU_CONTROL register. Also I _must_ setup it correctly after reset (reset value causes board emergency shutdown).
The Exynos5250 defines it as a "reserved".
Quoted 2 lines
Think what if new Exynos TMU versions come, are you guys going to steadily increase the above check for type?
As the alternative I can define the TMU_SUPPORT_MUX_ADDR at .features field for EXYNOS4412_TMU_DATA.
Then I can test for this feature at exynos_tmu_control function. Proper shift and mask can be defined at struct exynos_tmu_registers.
Eduardo, Amit, will we manage to review/pull those patches with new approach before -rcX ends?
Quoted 23 lines
Quoted 21 lines
drivers/thermal/samsung/exynos_tmu.c +1
-0+if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask <<
reg->buf_vref_sel_shift); con |=pdata->reference_voltage<<reg->buf_vref_sel_shift; diff --gita/drivers/thermal/samsung/exynos_tmu_data.hb/drivers/thermal/samsung/exynos_tmu_data.hindex b130b1e..a1ea19d 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.h+++b/drivers/thermal/samsung/exynos_tmu_data.h@@ -95,6 +95,10 @@#define
EXYNOS_MAX_TRIGGER_PER_REG4drivers/thermal/samsung/exynos_tmu.c +4
-0+/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define EXYNOS5440_TMU_S0_7_CTRL 0x020
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
PATCH 4/6 thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
In reply to Lukasz MajewskiThe TMU data definition is now separated to Exynos4412 and Exynos5250.
Now SOC_ARCH_EXYNOS only refers to Exynos5250. Hence the name SOC_ARCH_EXYNOS has been changed to SOC_ARCH_EXYNOS5250.
--- drivers/thermal/samsung/exynos_tmu.c | 4 ++-- drivers/thermal/samsung/exynos_tmu.h | 2 +- drivers/thermal/samsung/exynos_tmu_data.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/thermal/samsung/exynos_tmu.c +2 -2
@@ -632,9 +632,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)if (ret)return ret; -if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || +if (pdata->type ==SOC_ARCH_EXYNOS4210 || pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5250 || pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else {
drivers/thermal/samsung/exynos_tmu.h +1 -1
@@ -42,7 +42,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 ,SOC_ARCH_EXYNOS4412 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };
drivers/thermal/samsung/exynos_tmu_data.c +1 -1
@@ -183,7 +183,7 @@ struct exynos_tmu_init_data const exynos4412_default_tmu_data = {struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { {EXYNOS4412_TMU_DATA , - .type =SOC_ARCH_EXYNOS , + .type =SOC_ARCH_EXYNOS5250 , }, }, .tmu_count =1 ,
Signature · 1 line
1.7.10.4
Re: [PATCH 4/6] thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
Quoted 6 lines · Lukasz Majewski
The TMU data definition is now separated to Exynos4412 and Exynos5250.
Now
SOC_ARCH_EXYNOSonly refers to Exynos5250. Hence the nameSOC_ARCH_EXYNOShas been changed toSOC_ARCH_EXYNOS5250.Signed-off-by Lukasz Majewski <[email protected]>
Changes looks fine.
Thanks,
Amit
Quoted 51 lines
--- drivers/thermal/samsung/exynos_tmu.c | 4 ++-- drivers/thermal/samsung/exynos_tmu.h | 2 +- drivers/thermal/samsung/exynos_tmu_data.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)drivers/thermal/samsung/exynos_tmu.c +2
-2@@ -632,9 +632,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)if (ret)return ret; -if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || +if (pdata->type ==SOC_ARCH_EXYNOS4210 || pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5250 || pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else {drivers/thermal/samsung/exynos_tmu.h +1
-1@@ -42,7 +42,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 ,SOC_ARCH_EXYNOS4412 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };drivers/thermal/samsung/exynos_tmu_data.c +1
-2@@ -183,7 +183,7 @@ struct exynos_tmu_init_data const exynos4412_default_tmu_data = {struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { {EXYNOS4412_TMU_DATA , - .type =SOC_ARCH_EXYNOS , + .type =SOC_ARCH_EXYNOS5250 , }, }, .tmu_count =1 , --1.7.10.4
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/6] thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
In reply to Lukasz MajewskiQuoted 5 lines · Lukasz Majewski
The TMU data definition is now separated to Exynos4412 and Exynos5250.
Now
SOC_ARCH_EXYNOSonly refers to Exynos5250. Hence the nameSOC_ARCH_EXYNOShas been changed toSOC_ARCH_EXYNOS5250.
How about merging this one with patch 02?
Quoted 50 lines
Signed-off-by Lukasz Majewski <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 4 ++-- drivers/thermal/samsung/exynos_tmu.h | 2 +- drivers/thermal/samsung/exynos_tmu_data.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)drivers/thermal/samsung/exynos_tmu.c +2
-2@@ -632,9 +632,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)if (ret)return ret; -if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || +if (pdata->type ==SOC_ARCH_EXYNOS4210 || pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5250 || pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else {drivers/thermal/samsung/exynos_tmu.h +1
-1@@ -42,7 +42,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 ,SOC_ARCH_EXYNOS4412 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };drivers/thermal/samsung/exynos_tmu_data.c +1
-1@@ -183,7 +183,7 @@ struct exynos_tmu_init_data const exynos4412_default_tmu_data = {struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { {EXYNOS4412_TMU_DATA , - .type =SOC_ARCH_EXYNOS , + .type =SOC_ARCH_EXYNOS5250 , }, }, .tmu_count =1 ,
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Re: [PATCH 4/6] thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
Hi,
Quoted 8 lines · Eduardo Valentin
Quoted 5 lines · Lukasz Majewski
The TMU data definition is now separated to Exynos4412 and Exynos5250.
Now
SOC_ARCH_EXYNOSonly refers to Exynos5250. Hence the nameSOC_ARCH_EXYNOShas been changed toSOC_ARCH_EXYNOS5250.How about merging this one with patch 02?
I would prefer that this is not done since patch #2 is a separate logical change and it should be kept as a minimal preparatory patch for patch #3 (which is an important bugfix) to make potential backporting of fixes into -stable etc. easier.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Quoted 49 lines
Quoted 49 lines
Signed-off-by Lukasz Majewski <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 4 ++-- drivers/thermal/samsung/exynos_tmu.h | 2 +- drivers/thermal/samsung/exynos_tmu_data.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)drivers/thermal/samsung/exynos_tmu.c +2
-2@@ -632,9 +632,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)if (ret)return ret; -if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || +if (pdata->type ==SOC_ARCH_EXYNOS4210 || pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5250 || pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else {drivers/thermal/samsung/exynos_tmu.h +1
-1@@ -42,7 +42,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 ,SOC_ARCH_EXYNOS4412 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };drivers/thermal/samsung/exynos_tmu_data.c +1
-1@@ -183,7 +183,7 @@ struct exynos_tmu_init_data const exynos4412_default_tmu_data = {struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { {EXYNOS4412_TMU_DATA , - .type =SOC_ARCH_EXYNOS , + .type =SOC_ARCH_EXYNOS5250 , }, }, .tmu_count =1 ,
Re: [PATCH 4/6] thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
In reply to Eduardo ValentinHi Eduardo,
Quoted 9 lines · Lukasz Majewski
Quoted 6 lines
The TMU data definition is now separated to Exynos4412 and Exynos5250.
Now
SOC_ARCH_EXYNOSonly refers to Exynos5250. Hence the nameSOC_ARCH_EXYNOShas been changed toSOC_ARCH_EXYNOS5250.How about merging this one with patch 02?
I wanted to show how the work was logically split - patch 02 extracts Exynos4412 from Exynos5250. Then this patch changes the name.
I will merge those two patches. No problem.
Quoted 53 lines
Quoted 51 lines
Signed-off-by Lukasz Majewski <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 4 ++-- drivers/thermal/samsung/exynos_tmu.h | 2 +- drivers/thermal/samsung/exynos_tmu_data.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex 21b89e4..037cd46 100644drivers/thermal/samsung/exynos_tmu.c +2
-2@@ -632,9 +632,9 @@ static int exynos_tmu_probe(struct platform_device *pdev) if (ret) return ret; - if (pdata->type == SOC_ARCH_EXYNOS || - pdata->type == SOC_ARCH_EXYNOS4210 || + if (pdata->type == SOC_ARCH_EXYNOS4210 || pdata->type == SOC_ARCH_EXYNOS4412 || + pdata->type == SOC_ARCH_EXYNOS5250 || pdata->type == SOC_ARCH_EXYNOS5440) data->soc = pdata->type; else {(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.hindex db37df0..b42ece4 100644drivers/thermal/samsung/exynos_tmu.h +1
-1@@ -42,7 +42,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 ,SOC_ARCH_EXYNOS4412 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.cindex bd08093..188223f 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.c+++b/drivers/thermal/samsung/exynos_tmu_data.c(quoted diff) +0
-0@@ -183,7 +183,7 @@ struct exynos_tmu_init_data const
exynos4412_default_tmu_data= { structexynos_tmu_init_dataconstexynos5250_default_tmu_data= { .tmu_data = {drivers/thermal/samsung/exynos_tmu_data.c +1
-1{ EXYNOS4412_TMU_DATA, - .type =SOC_ARCH_EXYNOS , + .type =SOC_ARCH_EXYNOS5250 , }, }, .tmu_count = 1,
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Re: [PATCH 4/6] thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
Quoted 10 lines · Lukasz Majewski
Hi Eduardo,
Quoted 8 lines · Lukasz Majewski
Quoted 6 lines
The TMU data definition is now separated to Exynos4412 and Exynos5250.
Now
SOC_ARCH_EXYNOSonly refers to Exynos5250. Hence the nameSOC_ARCH_EXYNOShas been changed toSOC_ARCH_EXYNOS5250.
Quoted 6 lines
Quoted 1 line
How about merging this one with patch 02?
I wanted to show how the work was logically split - patch 02 extracts Exynos4412 from Exynos5250. Then this patch changes the name.
I will merge those two patches. No problem.
Oh, well. Looking at the patch #2 again the merge can be done without sacrificing backportability.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Quoted 50 lines
Quoted 50 lines
Quoted 50 lines
Signed-off-by Lukasz Majewski <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 4 ++-- drivers/thermal/samsung/exynos_tmu.h | 2 +- drivers/thermal/samsung/exynos_tmu_data.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex 21b89e4..037cd46 100644drivers/thermal/samsung/exynos_tmu.c +2
-2@@ -632,9 +632,9 @@ static int exynos_tmu_probe(struct platform_device *pdev) if (ret) return ret; - if (pdata->type == SOC_ARCH_EXYNOS || - pdata->type == SOC_ARCH_EXYNOS4210 || + if (pdata->type == SOC_ARCH_EXYNOS4210 || pdata->type == SOC_ARCH_EXYNOS4412 || + pdata->type == SOC_ARCH_EXYNOS5250 || pdata->type == SOC_ARCH_EXYNOS5440) data->soc = pdata->type; else {(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.hindex db37df0..b42ece4 100644drivers/thermal/samsung/exynos_tmu.h +1
-1@@ -42,7 +42,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 ,SOC_ARCH_EXYNOS4412 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.cindex bd08093..188223f 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.c+++b/drivers/thermal/samsung/exynos_tmu_data.c(quoted diff) +0
-0@@ -183,7 +183,7 @@ struct exynos_tmu_init_data const
exynos4412_default_tmu_data= { structexynos_tmu_init_dataconstexynos5250_default_tmu_data= { .tmu_data = {drivers/thermal/samsung/exynos_tmu_data.c +1
-1{ EXYNOS4412_TMU_DATA, - .type =SOC_ARCH_EXYNOS , + .type =SOC_ARCH_EXYNOS5250 , }, }, .tmu_count = 1,
Re: [PATCH 4/6] thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
Quoted 13 lines · Bartlomiej Zolnierkiewicz
Quoted 12 lines · Lukasz Majewski
Hi Eduardo,
Quoted 9 lines · Lukasz Majewski
Quoted 6 lines
The TMU data definition is now separated to Exynos4412 and Exynos5250.
Now
SOC_ARCH_EXYNOSonly refers to Exynos5250. Hence the nameSOC_ARCH_EXYNOShas been changed toSOC_ARCH_EXYNOS5250.How about merging this one with patch 02?
Quoted 7 lines
Quoted 4 lines
I wanted to show how the work was logically split - patch 02 extracts Exynos4412 from Exynos5250. Then this patch changes the name.
I will merge those two patches. No problem.
Oh, well. Looking at the patch #2 again the merge can be done without sacrificing backportability.
Please, merge them and describe that you are reworking the type and the enum definition. Also add your reasonings, specially if you found bugs. The way the descriptions are being presented, the bugs you found do not get properly explained.
Quoted 64 lines
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung ElectronicsQuoted 37 lines
Quoted 37 lines
Quoted 37 lines
Signed-off-by Lukasz Majewski <[email protected]>--- drivers/thermal/samsung/exynos_tmu.c | 4 ++-- drivers/thermal/samsung/exynos_tmu.h | 2 +- drivers/thermal/samsung/exynos_tmu_data.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex 21b89e4..037cd46 100644drivers/thermal/samsung/exynos_tmu.c +2
-2@@ -632,9 +632,9 @@ static int exynos_tmu_probe(struct platform_device *pdev) if (ret) return ret; - if (pdata->type == SOC_ARCH_EXYNOS || - pdata->type == SOC_ARCH_EXYNOS4210 || + if (pdata->type == SOC_ARCH_EXYNOS4210 || pdata->type == SOC_ARCH_EXYNOS4412 || + pdata->type == SOC_ARCH_EXYNOS5250 || pdata->type == SOC_ARCH_EXYNOS5440) data->soc = pdata->type; else {(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.hindex db37df0..b42ece4 100644drivers/thermal/samsung/exynos_tmu.h +1
-1@@ -42,7 +42,7 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 ,SOC_ARCH_EXYNOS4412 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.cindex bd08093..188223f 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.c+++b/drivers/thermal/samsung/exynos_tmu_data.cdrivers/thermal/samsung/exynos_tmu.h +0
-0@@ -183,7 +183,7 @@ struct exynos_tmu_init_data constQuoted 8 lines
drivers/thermal/samsung/exynos_tmu.h
Quoted 8 lines
exynos4412_default_tmu_data= { structexynos_tmu_init_dataconstexynos5250_default_tmu_data= { .tmu_data = {drivers/thermal/samsung/exynos_tmu.h +1
-1{ EXYNOS4412_TMU_DATA, - .type =SOC_ARCH_EXYNOS , + .type =SOC_ARCH_EXYNOS5250 , }, }, .tmu_count = 1,--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
PATCH 5/6 ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
In reply to Lukasz MajewskiThe TMU device tree node definition for Exynos4x12 family of SoCs.
--- arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/exynos4x12.dtsi +10 -0
@@ -176,4 +176,14 @@ }; }; }; + + tmu@100C0000 { + compatible = "samsung,exynos4412-tmu"; + interrupt-parent = <&combiner>; + interrupts = <2 4>; + reg = <0x100C0000 0x100>; + clocks = <&clock 383>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; };
Signature · 1 line
1.7.10.4
PATCH 6/6 ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
In reply to Lukasz MajewskiThis patch enables support for TMU at Exynos4412 based Trats2 board.
--- arch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos4412-trats2.dts +5 -0
@@ -467,6 +467,11 @@ status = "okay"; }; + tmu@100C0000 { + vtmu-supply = <&ldo10_reg>; + status = "okay"; + }; + i2c_ak8975: i2c-gpio-0 { compatible = "i2c-gpio"; gpios = <&gpy2 4 0>, <&gpy2 5 0>;
Signature · 1 line
1.7.10.4
Hi Lukasz,
Quoted 20 lines · On Tuesday 24 of September 2013 10:08:16 Lukasz Majewski wrote:
This patch series is divided into two parts:
1. Device tree node definition and enabelement for TMU at Exynos4412 (Trats2)
2. Exynos thermal subsystem regressions for v3.12-rc1. Several commits were necessary to properly fix regression for TMU test MUX address setting after reset.Test HW:
- Exynos4412 - TRATS2 board (Linux v3.12-rc1)Lukasz Majewski (6):
thermal: exynos: fix: Return fromexynos_report_trigger()when
therm_devis NULL
thermal: exynos: Provide separate TMU data for Exynos4412
thermal: exynos: Provide initial setting for TMU's test MUX addressat Exynos4412 thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250 ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Quoted 9 lines
arch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ arch/arm/boot/dts/exynos4x12.dtsi | 10 +++++++++ drivers/thermal/samsung/exynos_thermal_common.c | 2 +- drivers/thermal/samsung/exynos_tmu.c | 12 +++++++---- drivers/thermal/samsung/exynos_tmu.h | 3 ++- drivers/thermal/samsung/exynos_tmu_data.c | 26 +++++++++++++++++------ drivers/thermal/samsung/exynos_tmu_data.h | 13 +++++++++++- 7 files changed, 58 insertions(+), 13 deletions(-)
For the whole series:
Best regards,
Tomasz
Dear All,
Quoted 5 lines
This patch series is divided into two parts:
1. Device tree node definition and enabelement for TMU at Exynos4412 (Trats2) 2. Exynos thermal subsystem regressions for v3.12-rc1. Several commits were necessary to properly fix regression for TMU test MUX address setting after reset.
Zhang or Eduardo - will you find time to review those changes? They have already been reviewed by Amit.
Now we have -rc3 and there is no feedback for regression/critical patches (posted for -rc1).
Quoted 25 lines
Test HW:
- Exynos4412 - TRATS2 board (Linux v3.12-rc1)Lukasz Majewski (6):
thermal: exynos: fix: Return fromexynos_report_trigger()when
therm_devis NULL
thermal: exynos: Provide separate TMU data for Exynos4412
thermal: exynos: Provide initial setting for TMU's test MUX addressat Exynos4412 thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250 ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
arch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ arch/arm/boot/dts/exynos4x12.dtsi | 10 +++++++++ drivers/thermal/samsung/exynos_thermal_common.c | 2 +- drivers/thermal/samsung/exynos_tmu.c | 12 +++++++---- drivers/thermal/samsung/exynos_tmu.h | 3 ++- drivers/thermal/samsung/exynos_tmu_data.c | 26+++++++++++++++++------
drivers/thermal/samsung/exynos_tmu_data.h| 13 +++++++++++- 7
files changed, 58 insertions(+), 13 deletions(-)
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
v2 cover thermal: exynos: Fixes for v3.12
In reply to Lukasz MajewskiThis patch series is divided into two parts:
1. Device tree node definition and enabelement for TMU at Exynos4412 (Trats2)
2. Exynos thermal subsystem regressions for v3.12-rc4. Several commits were necessary to properly fix regression for TMU test MUX address setting after reset.
Test HW:
- Exynos4412 - TRATS2 board (Linux v3.12-rc4)
SHA1: 8b5ede69d24db939f52b47effff2f6fe1e83e08b
Lukasz Majewski (5):
thermal: exynos: Remove check for thermal device pointer at
exynos_report_trigger()
thermal: exynos: Provide separate TMU data for Exynos4412
thermal: exynos: Provide initial setting for TMU's test MUX address
at Exynos4412
ARM: dts: exynos4x12: Device tree node definition for TMU on
Exynos4x12ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
arch/arm/boot/dts/exynos4412-trats2.dts | 5 ++++ arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++ drivers/thermal/samsung/exynos_thermal_common.c | 2 -- drivers/thermal/samsung/exynos_tmu.c | 12 ++++++--- drivers/thermal/samsung/exynos_tmu.h | 7 +++++- drivers/thermal/samsung/exynos_tmu_data.c | 30 ++++++++++++++++++----- drivers/thermal/samsung/exynos_tmu_data.h | 13 +++++++++- 7 files changed, 65 insertions(+), 14 deletions(-)
Signature · 1 line
1.7.10.4
PATCH v2 1/5 thermal: exynos: Remove check for thermal device pointer at exynos_report_trigger()
The commit 4de0bdaa9677d11406c9becb70c60887c957e1f0 ("thermal: exynos: Add support for instance based register/unregister") broke check for presence of therm_dev at global thermal zone in exynos_report_trigger().
The resulting wrong test prevents thermal_zone_device_update() call, which calls handlers for situation when trip points are passed.
Such behavior prevents thermal driver from proper reaction (when TMU interrupt is raised) in a situation when overheating is detected at TMU hardware.
It turns out, that after exynos thermal subsystem redesign (at v3.12) this check is not needed, since it is not possible to register thermal zone without valid thermal device.
---
Changes for v2:
- Remove check for th_zone->therm_dev at exynos_report_trigger()
drivers/thermal/samsung/exynos_thermal_common.c | 2 -- 1 file changed, 2 deletions(-)
drivers/thermal/samsung/exynos_thermal_common.c +0 -2
@@ -310,8 +310,6 @@ void exynos_report_trigger(struct thermal_sensor_conf *conf) } th_zone = conf->pzone_data; -if (th_zone->therm_dev) -return ;if (th_zone->bind == false) {for (i =0 ; i < th_zone->cool_dev_size; i++) {
Signature · 6 lines
1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v2 2/5 thermal: exynos: Provide separate TMU data for Exynos4412
In reply to Lukasz MajewskiUp till now Exynos5250 and Exynos4412 had the same definitions for TMU data. Following commit changes that, by introducing separate exynos4412_default_tmu_data structure.
Since Exynos4412 was chronologically first, the corresponding name for TMU registers and default data was renamed.
Additionally, new SOC_ARCH_EXYNOS4412 type has been defined.
Moreover, the SOC_ARCH_EXYNOS name has been changed to SOC_ARCH_EXYNOS5250.
---
Changes for v2:
- Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
- Fix coding style for tmu_data elements definition
drivers/thermal/samsung/exynos_tmu.c | 9 +++++---- drivers/thermal/samsung/exynos_tmu.h | 3 ++- drivers/thermal/samsung/exynos_tmu_data.c | 28 ++++++++++++++++++++++------ drivers/thermal/samsung/exynos_tmu_data.h | 9 ++++++++- 4 files changed, 37 insertions(+), 12 deletions(-)
drivers/thermal/samsung/exynos_tmu.c +5 -4
@@ -488,7 +488,7 @@ static const struct of_device_id exynos_tmu_match[] = { }, { .compatible = "samsung,exynos4412-tmu", - .data = (void *)EXYNOS5250_TMU_DRV_DATA, + .data = (void *)EXYNOS4412_TMU_DRV_DATA, }, { .compatible = "samsung,exynos5250-tmu",
@@ -629,9 +629,10 @@ static int exynos_tmu_probe(struct platform_device *pdev)if (ret)return ret; -if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || - pdata->type ==SOC_ARCH_EXYNOS5440 ) +if (pdata->type ==SOC_ARCH_EXYNOS4210 || + pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5250 || + pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else { ret = -EINVAL ;
drivers/thermal/samsung/exynos_tmu.h +2 -1
@@ -41,7 +41,8 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS4412 , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };
drivers/thermal/samsung/exynos_tmu_data.c +22 -6
@@ -90,8 +90,8 @@ struct exynos_tmu_init_data const exynos4210_default_tmu_data = { };#endif -#if defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 ) -static const struct exynos_tmu_registers exynos5250_tmu_registers = { +#if defined(CONFIG_SOC_EXYNOS4412 ) || defined(CONFIG_SOC_EXYNOS5250 ) +static const struct exynos_tmu_registers exynos4412_tmu_registers = { .triminfo_data =EXYNOS_TMU_REG_TRIMINFO , .triminfo_25_shift =EXYNOS_TRIMINFO_25_SHIFT , .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,
@@ -128,7 +128,7 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .emul_time_mask = EXYNOS_EMUL_TIME_MASK, }; -#define EXYNOS5250_TMU_DATA \ +#define EXYNOS4412_TMU_DATA \ .threshold_falling = 10, \ .trigger_levels[0] = 85, \ .trigger_levels[1] = 103, \
@@ -162,15 +162,31 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .temp_level = 103, \ }, \ .freq_tab_count = 2, \ - .type = SOC_ARCH_EXYNOS, \ - .registers = &exynos5250_tmu_registers, \ + .registers = &exynos4412_tmu_registers, \ .features = (TMU_SUPPORT_EMULATION |TMU_SUPPORT_TRIM_RELOAD | \TMU_SUPPORT_FALLING_TRIP |TMU_SUPPORT_READY_STATUS | \ TMU_SUPPORT_EMUL_TIME) +#endif +#if defined(CONFIG_SOC_EXYNOS4412 ) +struct exynos_tmu_init_data const exynos4412_default_tmu_data = { + .tmu_data = { + { +EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS4412 , + }, + }, + .tmu_count =1 , +}; +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { - {EXYNOS5250_TMU_DATA }, + { +EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS5250 , + }, }, .tmu_count =1 , };
drivers/thermal/samsung/exynos_tmu_data.h +8 -1
@@ -138,7 +138,14 @@ extern struct exynos_tmu_init_data const exynos4210_default_tmu_data;#define EXYNOS4210_TMU_DRV_DATA (NULL)#endif -#if (defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 )) +#if defined(CONFIG_SOC_EXYNOS4412 ) +extern struct exynos_tmu_init_data const exynos4412_default_tmu_data; +#define EXYNOS4412_TMU_DRV_DATA (&exynos4412_default_tmu_data) +#else +#define EXYNOS4412_TMU_DRV_DATA (NULL) +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )extern struct exynos_tmu_init_data const exynos5250_default_tmu_data;#define EXYNOS5250_TMU_DRV_DATA (&exynos5250_default_tmu_data)#else
Signature · 6 lines
1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/5] thermal: exynos: Provide separate TMU data for Exynos4412
Quoted 72 lines · Lukasz Majewski
Up till now Exynos5250 and Exynos4412 had the same definitions for TMU data. Following commit changes that, by introducing separate
exynos4412_default_tmu_datastructure.Since Exynos4412 was chronologically first, the corresponding name for TMU registers and default data was renamed.
Additionally, new
SOC_ARCH_EXYNOS4412type has been defined.Moreover, the
SOC_ARCH_EXYNOSname has been changed toSOC_ARCH_EXYNOS5250.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- ReplaceSOC_ARCH_EXYNOSwithSOC_ARCH_EXYNOS5250
- Fix coding style fortmu_dataelements definitiondrivers/thermal/samsung/exynos_tmu.c | 9 +++++---- drivers/thermal/samsung/exynos_tmu.h | 3 ++- drivers/thermal/samsung/exynos_tmu_data.c | 28 ++++++++++++++++++++++------ drivers/thermal/samsung/exynos_tmu_data.h | 9 ++++++++- 4 files changed, 37 insertions(+), 12 deletions(-)drivers/thermal/samsung/exynos_tmu.c +5
-4@@ -488,7 +488,7 @@ static const struct of_device_id exynos_tmu_match[] = { }, { .compatible = "samsung,exynos4412-tmu", - .data = (void *)EXYNOS5250_TMU_DRV_DATA, + .data = (void *)EXYNOS4412_TMU_DRV_DATA, }, { .compatible = "samsung,exynos5250-tmu",@@ -629,9 +629,10 @@ static int exynos_tmu_probe(struct platform_device *pdev)if (ret)return ret; -if (pdata->type ==SOC_ARCH_EXYNOS || - pdata->type ==SOC_ARCH_EXYNOS4210 || - pdata->type ==SOC_ARCH_EXYNOS5440 ) +if (pdata->type ==SOC_ARCH_EXYNOS4210 || + pdata->type ==SOC_ARCH_EXYNOS4412 || + pdata->type ==SOC_ARCH_EXYNOS5250 || + pdata->type ==SOC_ARCH_EXYNOS5440 ) data->soc = pdata->type;else { ret = -EINVAL ;drivers/thermal/samsung/exynos_tmu.h +2
-1@@ -41,7 +41,8 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS4412 , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };drivers/thermal/samsung/exynos_tmu_data.c +0
-0
drivers/thermal/samsung/exynos_tmu_data.c struct exynos_tmu_init_data const exynos4210_default_tmu_data = { · line 93
Quoted 6 lines
drivers/thermal/samsung/exynos_tmu_data.c +1
-2@@ -90,8 +90,8 @@ struct exynos_tmu_init_data const exynos4210_default_tmu_data = { };#endif -#if defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 ) -static const struct exynos_tmu_registers exynos5250_tmu_registers = { +#if defined(CONFIG_SOC_EXYNOS4412 ) || defined(CONFIG_SOC_EXYNOS5250 )
Below will be only 4412 definitions,right? Why should we test for 5250?
Quoted 69 lines
drivers/thermal/samsung/exynos_tmu_data.c +21
-4+static const struct exynos_tmu_registers exynos4412_tmu_registers = { .triminfo_data =EXYNOS_TMU_REG_TRIMINFO , .triminfo_25_shift =EXYNOS_TRIMINFO_25_SHIFT , .triminfo_85_shift =EXYNOS_TRIMINFO_85_SHIFT ,@@ -128,7 +128,7 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .emul_time_mask = EXYNOS_EMUL_TIME_MASK, }; -#define EXYNOS5250_TMU_DATA \ +#define EXYNOS4412_TMU_DATA \ .threshold_falling = 10, \ .trigger_levels[0] = 85, \ .trigger_levels[1] = 103, \@@ -162,15 +162,31 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .temp_level = 103, \ }, \ .freq_tab_count = 2, \ - .type = SOC_ARCH_EXYNOS, \ - .registers = &exynos5250_tmu_registers, \ + .registers = &exynos4412_tmu_registers, \ .features = (TMU_SUPPORT_EMULATION |TMU_SUPPORT_TRIM_RELOAD | \TMU_SUPPORT_FALLING_TRIP |TMU_SUPPORT_READY_STATUS | \ TMU_SUPPORT_EMUL_TIME) +#endif +#if defined(CONFIG_SOC_EXYNOS4412 ) +struct exynos_tmu_init_data const exynos4412_default_tmu_data = { + .tmu_data = { + { +EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS4412 , + }, + }, + .tmu_count =1 , +}; +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { - {EXYNOS5250_TMU_DATA }, + { +EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS5250 , + }, }, .tmu_count =1 , };drivers/thermal/samsung/exynos_tmu_data.h +8
-1@@ -138,7 +138,14 @@ extern struct exynos_tmu_init_data const exynos4210_default_tmu_data;#define EXYNOS4210_TMU_DRV_DATA (NULL)#endif -#if (defined(CONFIG_SOC_EXYNOS5250 ) || defined(CONFIG_SOC_EXYNOS4412 )) +#if defined(CONFIG_SOC_EXYNOS4412 ) +extern struct exynos_tmu_init_data const exynos4412_default_tmu_data; +#define EXYNOS4412_TMU_DRV_DATA (&exynos4412_default_tmu_data) +#else +#define EXYNOS4412_TMU_DRV_DATA (NULL) +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )extern struct exynos_tmu_init_data const exynos5250_default_tmu_data;#define EXYNOS5250_TMU_DRV_DATA (&exynos5250_default_tmu_data)#else
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Re: [PATCH v2 2/5] thermal: exynos: Provide separate TMU data for Exynos4412
Hi Eduardo,
Quoted 78 lines · Lukasz Majewski
Quoted 77 lines
Up till now Exynos5250 and Exynos4412 had the same definitions for TMU data. Following commit changes that, by introducing separate
exynos4412_default_tmu_datastructure.Since Exynos4412 was chronologically first, the corresponding name for TMU registers and default data was renamed.
Additionally, new
SOC_ARCH_EXYNOS4412type has been defined.Moreover, the
SOC_ARCH_EXYNOSname has been changed toSOC_ARCH_EXYNOS5250.Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- ReplaceSOC_ARCH_EXYNOSwithSOC_ARCH_EXYNOS5250
- Fix coding style fortmu_dataelements definitiondrivers/thermal/samsung/exynos_tmu.c | 9 +++++---- drivers/thermal/samsung/exynos_tmu.h | 3 ++- drivers/thermal/samsung/exynos_tmu_data.c | 28++++++++++++++++++++++------
drivers/thermal/samsung/exynos_tmu_data.h| 9 ++++++++- 4 files
changed, 37 insertions(+), 12 deletions(-)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex b43afda..1312b34 100644drivers/thermal/samsung/exynos_tmu.c +5
-4@@ -488,7 +488,7 @@ static const struct of_device_id exynos_tmu_match[] = { }, { .compatible = "samsung,exynos4412-tmu", - .data = (void *)EXYNOS5250_TMU_DRV_DATA, + .data = (void *)EXYNOS4412_TMU_DRV_DATA, }, { .compatible = "samsung,exynos5250-tmu",@@ -629,9 +629,10 @@ static int exynos_tmu_probe(struct platform_device *pdev) if (ret) return ret; - if (pdata->type == SOC_ARCH_EXYNOS || - pdata->type == SOC_ARCH_EXYNOS4210 || - pdata->type == SOC_ARCH_EXYNOS5440) + if (pdata->type == SOC_ARCH_EXYNOS4210 || + pdata->type == SOC_ARCH_EXYNOS4412 || + pdata->type == SOC_ARCH_EXYNOS5250 || + pdata->type == SOC_ARCH_EXYNOS5440) data->soc = pdata->type; else { ret = -EINVAL ;(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.hindex b364c9e..b42ece4 100644drivers/thermal/samsung/exynos_tmu.h +2
-1@@ -41,7 +41,8 @@ enum calibration_mode {enum soc_type {SOC_ARCH_EXYNOS4210 =1 , -SOC_ARCH_EXYNOS , +SOC_ARCH_EXYNOS4412 , +SOC_ARCH_EXYNOS5250 ,SOC_ARCH_EXYNOS5440 , };(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.cindex 9002499..d8de5c1 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.c+++b/drivers/thermal/samsung/exynos_tmu_data.c(quoted diff) +0
-0@@ -90,8 +90,8 @@ struct exynos_tmu_init_data const exynos4210_default_tmu_data = { }; #endif
Quoted 7 lines
Quoted 4 lines
(quoted diff) +0
-1-#if defined(CONFIG_SOC_EXYNOS5250) ||
defined(CONFIG_SOC_EXYNOS4412)-static const structexynos_tmu_registersexynos5250_tmu_registers= { +#ifdefined(CONFIG_SOC_EXYNOS4412)||defined(CONFIG_SOC_EXYNOS5250)Below will be only 4412 definitions,right? Why should we test for 5250?
^^^^^^^^ [1]
Below are registers definitions for Exynos4412, which appeared first.
However, the Exynos5250 is reusing those registers.
The exact separation between Exynos4412 and Exynos5250 is done when we assign value to .tmu_data at exynos4412_default_tmu_data and exynos5250_default_tmu_data.
The test [1] is correct here.
Quoted 72 lines
Quoted 70 lines
+static const struct
exynos_tmu_registersexynos4412_tmu_registers= { .triminfo_data =EXYNOS_TMU_REG_TRIMINFO,drivers/thermal/samsung/exynos_tmu_data.c +0
-0.triminfo_25_shift = EXYNOS_TRIMINFO_25_SHIFT, .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,@@ -128,7 +128,7 @@ static const struct exynos_tmu_registers
exynos5250_tmu_registers= { .emul_time_mask =EXYNOS_EMUL_TIME_MASK, };drivers/thermal/samsung/exynos_tmu_data.c +2
-3-#define EXYNOS5250_TMU_DATA \ +#define EXYNOS4412_TMU_DATA \ .threshold_falling = 10, \ .trigger_levels[0] = 85, \ .trigger_levels[1] = 103, \@@ -162,15 +162,31 @@ static const struct exynos_tmu_registers exynos5250_tmu_registers = { .temp_level = 103, \ }, \ .freq_tab_count = 2, \ - .type = SOC_ARCH_EXYNOS, \ - .registers = &exynos5250_tmu_registers, \ + .registers = &exynos4412_tmu_registers, \ .features = (TMU_SUPPORT_EMULATION |
TMU_SUPPORT_TRIM_RELOAD| \TMU_SUPPORT_FALLING_TRIP|TMU_SUPPORT_READY_STATUS| \TMU_SUPPORT_EMUL_TIME)drivers/thermal/samsung/exynos_tmu_data.c +18
-1+#endif +#if defined(CONFIG_SOC_EXYNOS4412 ) +struct exynos_tmu_init_data const exynos4412_default_tmu_data = { + .tmu_data = { + { +EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS4412 , + }, + }, + .tmu_count =1 , +}; +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 )struct exynos_tmu_init_data const exynos5250_default_tmu_data = { .tmu_data = { - {EXYNOS5250_TMU_DATA }, + { +EXYNOS4412_TMU_DATA , + .type =SOC_ARCH_EXYNOS5250 , + }, }, .tmu_count =1 , };(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.hindex dc7feb5..b130b1e 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.h+++b/drivers/thermal/samsung/exynos_tmu_data.h(quoted diff) +1
-1@@ -138,7 +138,14 @@ extern struct exynos_tmu_init_data const exynos4210_default_tmu_data; #define EXYNOS4210_TMU_DRV_DATA (NULL) #endif -#if (defined(CONFIG_SOC_EXYNOS5250) || defined(CONFIG_SOC_EXYNOS4412)) +#if defined(CONFIG_SOC_EXYNOS4412) +extern struct exynos_tmu_init_data const
exynos4412_default_tmu_data; +#defineEXYNOS4412_TMU_DRV_DATA(&exynos4412_default_tmu_data) +#elsedrivers/thermal/samsung/exynos_tmu_data.h +4
-0+#define EXYNOS4412_TMU_DRV_DATA (NULL) +#endif + +#if defined(CONFIG_SOC_EXYNOS5250 ) extern struct exynos_tmu_init_data const
exynos5250_default_tmu_data; #defineEXYNOS5250_TMU_DRV_DATA(&exynos5250_default_tmu_data) #else
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
PATCH v2 3/5 thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412
In reply to Lukasz MajewskiThe commit d0a0ce3e77c795258d47f9163e92d5031d0c5221 ("thermal: exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.
This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
---
Changes for v2:
- Define test_mux and test_mux_addr_shift to not use direct register access
- Remove pdata->type == SOC_ARCH_EXYNOS4412 check at exynos_tmu_control() and use only generic code
drivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu.h | 4 ++++ drivers/thermal/samsung/exynos_tmu_data.c | 2 ++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 4 files changed, 13 insertions(+)
drivers/thermal/samsung/exynos_tmu.c +3 -0
@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl); +if (pdata->test_mux) + con |= (pdata->test_mux << reg->test_mux_addr_shift); +if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask << reg->buf_vref_sel_shift); con |= pdata->reference_voltage << reg->buf_vref_sel_shift;
drivers/thermal/samsung/exynos_tmu.h +4 -0
@@ -85,6 +85,7 @@ enum soc_type { * @triminfo_reload_shift: shift of triminfo reload enable bit in triminfo_ctrl reg. * @tmu_ctrl: TMU main controller register. + * @test_mux_addr_shift: shift bits of test mux address. * @buf_vref_sel_shift: shift bits of reference voltage in tmu_ctrl register. * @buf_vref_sel_mask: mask bits of reference voltage in tmu_ctrl register. * @therm_trip_mode_shift: shift bits of tripping mode in tmu_ctrl register.
@@ -151,6 +152,7 @@ struct exynos_tmu_registers {u32 triminfo_reload_shift;u32 tmu_ctrl; +u32 test_mux_addr_shift;u32 buf_vref_sel_shift;u32 buf_vref_sel_mask;u32 therm_trip_mode_shift;
@@ -258,6 +260,7 @@ struct exynos_tmu_registers {* @first_point_trim: temp value of the first point trimming * @second_point_trim: temp value of the second point trimming * @default_temp_offset: default temperature offset in case of no trimming +* @test_mux; information if SoC supports test MUX * @cal_type: calibration type for temperature * @cal_mode: calibration mode for temperature * @freq_clip_table: Table representing frequency reduction percentage.
@@ -287,6 +290,7 @@ struct exynos_tmu_platform_data {u8 first_point_trim;u8 second_point_trim;u8 default_temp_offset; +u8 test_mux;enum calibration_type cal_type;enum calibration_mode cal_mode;
drivers/thermal/samsung/exynos_tmu_data.c +2 -0
@@ -98,6 +98,7 @@ static const struct exynos_tmu_registers exynos4412_tmu_registers = { .triminfo_ctrl = EXYNOS_TMU_TRIMINFO_CON, .triminfo_reload_shift = EXYNOS_TRIMINFO_RELOAD_SHIFT, .tmu_ctrl = EXYNOS_TMU_REG_CONTROL, + .test_mux_addr_shift = EXYNOS4412_MUX_ADDR_SHIFT, .buf_vref_sel_shift = EXYNOS_TMU_REF_VOLTAGE_SHIFT, .buf_vref_sel_mask = EXYNOS_TMU_REF_VOLTAGE_MASK, .therm_trip_mode_shift = EXYNOS_TMU_TRIP_MODE_SHIFT,
@@ -174,6 +175,7 @@ struct exynos_tmu_init_data const exynos4412_default_tmu_data = { { EXYNOS4412_TMU_DATA, .type = SOC_ARCH_EXYNOS4412, + .test_mux =EXYNOS4412_MUX_ADDR_VALUE , }, }, .tmu_count = 1,
drivers/thermal/samsung/exynos_tmu_data.h +4 -0
@@ -95,6 +95,10 @@#define EXYNOS_MAX_TRIGGER_PER_REG 4 +/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define EXYNOS5440_TMU_S0_7_CTRL 0x020
Signature · 1 line
1.7.10.4
Re: [PATCH v2 3/5] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412
Quoted 29 lines · Lukasz Majewski
The commit
d0a0ce3e77c795258d47f9163e92d5031d0c5221("thermal: exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- Definetest_muxandtest_mux_addr_shiftto not use direct register access
- Removepdata->type==SOC_ARCH_EXYNOS4412check atexynos_tmu_control()and use only generic codedrivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu.h | 4 ++++ drivers/thermal/samsung/exynos_tmu_data.c | 2 ++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 4 files changed, 13 insertions(+)drivers/thermal/samsung/exynos_tmu.c +0
-0
drivers/thermal/samsung/exynos_tmu.c static void exynos_tmu_control(struct platform_device *pdev, bool on) · line 320
Quoted 4 lines
drivers/thermal/samsung/exynos_tmu.c +1
-0@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl); +if (pdata->test_mux)
test_mux field is in fact an address, correct? Can 0 be a valid address?
Why not using the feature flags to test for capabilities, features and required configurations instead of assuming obscure domain and address ranges?
Quoted 78 lines
drivers/thermal/samsung/exynos_tmu.c +2
-0+ con |= (pdata->test_mux << reg->test_mux_addr_shift); +if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask << reg->buf_vref_sel_shift); con |= pdata->reference_voltage << reg->buf_vref_sel_shift;drivers/thermal/samsung/exynos_tmu.h +4
-0@@ -85,6 +85,7 @@ enum soc_type { * @triminfo_reload_shift: shift of triminfo reload enable bit in triminfo_ctrl reg. * @tmu_ctrl: TMU main controller register. + * @test_mux_addr_shift: shift bits of test mux address. * @buf_vref_sel_shift: shift bits of reference voltage in tmu_ctrl register. * @buf_vref_sel_mask: mask bits of reference voltage in tmu_ctrl register. * @therm_trip_mode_shift: shift bits of tripping mode in tmu_ctrl register.@@ -151,6 +152,7 @@ struct exynos_tmu_registers {u32 triminfo_reload_shift;u32 tmu_ctrl; +u32 test_mux_addr_shift;u32 buf_vref_sel_shift;u32 buf_vref_sel_mask;u32 therm_trip_mode_shift;@@ -258,6 +260,7 @@ struct exynos_tmu_registers {* @first_point_trim: temp value of the first point trimming * @second_point_trim: temp value of the second point trimming * @default_temp_offset: default temperature offset in case of no trimming +* @test_mux; information if SoC supports test MUX * @cal_type: calibration type for temperature * @cal_mode: calibration mode for temperature * @freq_clip_table: Table representing frequency reduction percentage. @@ -287,6 +290,7 @@ struct exynos_tmu_platform_data {u8 first_point_trim;u8 second_point_trim;u8 default_temp_offset; +u8 test_mux;enum calibration_type cal_type;enum calibration_mode cal_mode;drivers/thermal/samsung/exynos_tmu_data.c +2
-0@@ -98,6 +98,7 @@ static const struct exynos_tmu_registers exynos4412_tmu_registers = { .triminfo_ctrl = EXYNOS_TMU_TRIMINFO_CON, .triminfo_reload_shift = EXYNOS_TRIMINFO_RELOAD_SHIFT, .tmu_ctrl = EXYNOS_TMU_REG_CONTROL, + .test_mux_addr_shift = EXYNOS4412_MUX_ADDR_SHIFT, .buf_vref_sel_shift = EXYNOS_TMU_REF_VOLTAGE_SHIFT, .buf_vref_sel_mask = EXYNOS_TMU_REF_VOLTAGE_MASK, .therm_trip_mode_shift = EXYNOS_TMU_TRIP_MODE_SHIFT,@@ -174,6 +175,7 @@ struct exynos_tmu_init_data const exynos4412_default_tmu_data = { { EXYNOS4412_TMU_DATA, .type = SOC_ARCH_EXYNOS4412, + .test_mux =EXYNOS4412_MUX_ADDR_VALUE , }, }, .tmu_count = 1,drivers/thermal/samsung/exynos_tmu_data.h +4
-0@@ -95,6 +95,10 @@#define EXYNOS_MAX_TRIGGER_PER_REG 4 +/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define
EXYNOS5440_TMU_S0_7_CTRL0x020
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Re: [PATCH v2 3/5] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412
Hi Eduardo,
Quoted 35 lines · Lukasz Majewski
Quoted 34 lines
The commit
d0a0ce3e77c795258d47f9163e92d5031d0c5221("thermal:
exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- Definetest_muxandtest_mux_addr_shiftto not use direct register access
- Removepdata->type==SOC_ARCH_EXYNOS4412check atexynos_tmu_control()and use only generic codedrivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu.h | 4 ++++ drivers/thermal/samsung/exynos_tmu_data.c | 2 ++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 4 files changed, 13 insertions(+)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex 1312b34..32f38b9 100644drivers/thermal/samsung/exynos_tmu.c +0
-0@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl);
Quoted 5 lines
drivers/thermal/samsung/exynos_tmu.c static void exynos_tmu_control(struct platform_device *pdev, bool on) · line 320
Quoted 1 line
drivers/thermal/samsung/exynos_tmu.c +1
-0+if (pdata->test_mux)
test_muxfield is in fact an address, correct? Can 0 be a valid address?
No it isn't an address. It is the value which shall be written to test_mux field of TMU_CONTROL register.
Quoted 2 lines
Why not using the feature flags to test for capabilities,
It is easier to assign value to test_mux tmu_data struct, than write separate set of features for Exynos4412 and Exynos5250, which share the code.
Also .features seems to define SoC independent features of TMU IP (like TMU_SUPPORT_EMULATION).
The TEST_MUX setting is platform dependent (only Exynos4412 uses it), so this is the rationale to define it at tmu platform data.
Quoted 3 lines
features and
required configurations instead of assuming obscure domain and address ranges?
TMU_MUX only uses
(test_mux << test_mux_addr_shift) at tmu_ctrl register.
Quoted 86 lines
Quoted 84 lines
drivers/thermal/samsung/exynos_tmu.c +1
-0+ con |= (pdata->test_mux <<
reg->test_mux_addr_shift); +drivers/thermal/samsung/exynos_tmu.c +0
-0if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask <<
reg->buf_vref_sel_shift); con |=pdata->reference_voltage<<reg->buf_vref_sel_shift; diff --gita/drivers/thermal/samsung/exynos_tmu.hb/drivers/thermal/samsung/exynos_tmu.hindex b42ece4..3fb6554 100644 ---a/drivers/thermal/samsung/exynos_tmu.h+++b/drivers/thermal/samsung/exynos_tmu.h@@ -85,6 +85,7 @@ enumsoc_type{
* @triminfo_reload_shift: shift of triminfo reload enable bit intriminfo_ctrlreg.
* @tmu_ctrl: TMU main controller register.
+ * @test_mux_addr_shift: shift bits of test mux address.
* @buf_vref_sel_shift: shift bits of reference voltage intmu_ctrlregister.
* @buf_vref_sel_mask: mask bits of reference voltage intmu_ctrl
register.
* @therm_trip_mode_shift: shift bits of tripping mode intmu_ctrl
register. @@ -151,6 +152,7 @@ structexynos_tmu_registers{drivers/thermal/samsung/exynos_tmu.c +1
-0u32 triminfo_reload_shift;u32 tmu_ctrl; +u32 test_mux_addr_shift;u32 buf_vref_sel_shift;u32 buf_vref_sel_mask;u32 therm_trip_mode_shift;@@ -258,6 +260,7 @@ struct exynos_tmu_registers {* @first_point_trim: temp value of the first point trimming * @second_point_trim: temp value of the second point trimming * @default_temp_offset: default temperature offset in case of no trimming
+ * @test_mux; information if SoC supports test MUX
* @cal_type: calibration type for temperature
* @cal_mode: calibration mode for temperature
* @freq_clip_table: Table representing frequency reduction
percentage. @@ -287,6 +290,7 @@ structexynos_tmu_platform_data{drivers/thermal/samsung/exynos_tmu.c +1
-0u8 first_point_trim;u8 second_point_trim;u8 default_temp_offset; +u8 test_mux;enum calibration_type cal_type;enum calibration_mode cal_mode;(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.cindex d8de5c1..073c292 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.c+++b/drivers/thermal/samsung/exynos_tmu_data.c(quoted diff) +0
-0@@ -98,6 +98,7 @@ static const struct exynos_tmu_registers
exynos4412_tmu_registers= { .triminfo_ctrl =EXYNOS_TMU_TRIMINFO_CON, .triminfo_reload_shift =EXYNOS_TRIMINFO_RELOAD_SHIFT, .tmu_ctrl =EXYNOS_TMU_REG_CONTROL,drivers/thermal/samsung/exynos_tmu_data.c +2
-0+ .test_mux_addr_shift = EXYNOS4412_MUX_ADDR_SHIFT, .buf_vref_sel_shift = EXYNOS_TMU_REF_VOLTAGE_SHIFT, .buf_vref_sel_mask = EXYNOS_TMU_REF_VOLTAGE_MASK, .therm_trip_mode_shift = EXYNOS_TMU_TRIP_MODE_SHIFT,@@ -174,6 +175,7 @@ struct exynos_tmu_init_data const exynos4412_default_tmu_data = { { EXYNOS4412_TMU_DATA, .type = SOC_ARCH_EXYNOS4412, + .test_mux =EXYNOS4412_MUX_ADDR_VALUE , }, }, .tmu_count = 1,(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.hindex b130b1e..a1ea19d 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.h+++b/drivers/thermal/samsung/exynos_tmu_data.hdrivers/thermal/samsung/exynos_tmu_data.h +4
-0@@ -95,6 +95,10 @@#define EXYNOS_MAX_TRIGGER_PER_REG 4 +/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define
EXYNOS5440_TMU_S0_7_CTRL0x020
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Re: [PATCH v2 3/5] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412
Quoted 47 lines · Lukasz Majewski
Hi Eduardo,
Quoted 35 lines · Lukasz Majewski
Quoted 34 lines
The commit
d0a0ce3e77c795258d47f9163e92d5031d0c5221("thermal:
exynos: Add missing definations and code cleanup") has removed setting of test MUX address value at TMU configuration setting.This field is not present on Exynos4210 and Exynos5 SoCs. However on Exynos4412 SoC it is required to set this field after reset because without it TMU shows maximal available temperature, which causes immediate platform shutdown.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- Definetest_muxandtest_mux_addr_shiftto not use direct register access
- Removepdata->type==SOC_ARCH_EXYNOS4412check atexynos_tmu_control()and use only generic codedrivers/thermal/samsung/exynos_tmu.c | 3 +++ drivers/thermal/samsung/exynos_tmu.h | 4 ++++ drivers/thermal/samsung/exynos_tmu_data.c | 2 ++ drivers/thermal/samsung/exynos_tmu_data.h | 4 ++++ 4 files changed, 13 insertions(+)(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu.cindex 1312b34..32f38b9 100644drivers/thermal/samsung/exynos_tmu.c +0
-0@@ -317,6 +317,9 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) con =readl (data->base + reg->tmu_ctrl);Quoted 5 lines
drivers/thermal/samsung/exynos_tmu.c static void exynos_tmu_control(struct platform_device *pdev, bool on) · line 320
Quoted 1 line
drivers/thermal/samsung/exynos_tmu.c +1
-0+if (pdata->test_mux)
test_muxfield is in fact an address, correct? Can 0 be a valid address?No it isn't an address. It is the value which shall be written to
test_muxfield ofTMU_CONTROLregister.Quoted 1 line
Quoted 6 lines
Quoted 1 line
Why not using the feature flags to test for capabilities,
It is easier to assign value to
test_muxtmu_datastruct, than write separate set of features for Exynos4412 and Exynos5250, which share the code.
It is harder to write, yes, but things that are easy to write are usually harder to read. Besides, my concern is if 0x0 is a valid value to be written. And if yes, then makes the patch you sent might be incomplete.
Quoted 6 lines
Also .features seems to define SoC independent features of TMU IP (like
TMU_SUPPORT_EMULATION).The
TEST_MUXsetting is platform dependent (only Exynos4412 uses it), so this is the rationale to define it at tmu platform data.
Is test mux something pinctrl should be handling?
Quoted 98 lines
Quoted 3 lines
features and
required configurations instead of assuming obscure domain and address ranges?
TMU_MUXonly uses(
test_mux<<test_mux_addr_shift) attmu_ctrlregister.Quoted 86 lines
Quoted 84 lines
drivers/thermal/samsung/exynos_tmu.c +1
-0+ con |= (pdata->test_mux <<
reg->test_mux_addr_shift); +drivers/thermal/samsung/exynos_tmu.c +0
-0if (pdata->reference_voltage) { con &= ~(reg->buf_vref_sel_mask <<
reg->buf_vref_sel_shift); con |=pdata->reference_voltage<<reg->buf_vref_sel_shift; diff --gita/drivers/thermal/samsung/exynos_tmu.hb/drivers/thermal/samsung/exynos_tmu.hindex b42ece4..3fb6554 100644 ---a/drivers/thermal/samsung/exynos_tmu.h+++b/drivers/thermal/samsung/exynos_tmu.h@@ -85,6 +85,7 @@ enumsoc_type{
* @triminfo_reload_shift: shift of triminfo reload enable bit intriminfo_ctrlreg.
* @tmu_ctrl: TMU main controller register.
+ * @test_mux_addr_shift: shift bits of test mux address.
* @buf_vref_sel_shift: shift bits of reference voltage intmu_ctrlregister.
* @buf_vref_sel_mask: mask bits of reference voltage intmu_ctrl
register.
* @therm_trip_mode_shift: shift bits of tripping mode intmu_ctrl
register. @@ -151,6 +152,7 @@ structexynos_tmu_registers{drivers/thermal/samsung/exynos_tmu.c +1
-0u32 triminfo_reload_shift;u32 tmu_ctrl; +u32 test_mux_addr_shift;u32 buf_vref_sel_shift;u32 buf_vref_sel_mask;u32 therm_trip_mode_shift;@@ -258,6 +260,7 @@ struct exynos_tmu_registers {* @first_point_trim: temp value of the first point trimming * @second_point_trim: temp value of the second point trimming * @default_temp_offset: default temperature offset in case of no trimming
+ * @test_mux; information if SoC supports test MUX
* @cal_type: calibration type for temperature
* @cal_mode: calibration mode for temperature
* @freq_clip_table: Table representing frequency reduction
percentage. @@ -287,6 +290,7 @@ structexynos_tmu_platform_data{drivers/thermal/samsung/exynos_tmu.c +1
-0u8 first_point_trim;u8 second_point_trim;u8 default_temp_offset; +u8 test_mux;enum calibration_type cal_type;enum calibration_mode cal_mode;(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.cindex d8de5c1..073c292 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.c+++b/drivers/thermal/samsung/exynos_tmu_data.c(quoted diff) +0
-0@@ -98,6 +98,7 @@ static const struct exynos_tmu_registers
exynos4412_tmu_registers= { .triminfo_ctrl =EXYNOS_TMU_TRIMINFO_CON, .triminfo_reload_shift =EXYNOS_TRIMINFO_RELOAD_SHIFT, .tmu_ctrl =EXYNOS_TMU_REG_CONTROL,drivers/thermal/samsung/exynos_tmu_data.c +2
-0+ .test_mux_addr_shift = EXYNOS4412_MUX_ADDR_SHIFT, .buf_vref_sel_shift = EXYNOS_TMU_REF_VOLTAGE_SHIFT, .buf_vref_sel_mask = EXYNOS_TMU_REF_VOLTAGE_MASK, .therm_trip_mode_shift = EXYNOS_TMU_TRIP_MODE_SHIFT,@@ -174,6 +175,7 @@ struct exynos_tmu_init_data const exynos4412_default_tmu_data = { { EXYNOS4412_TMU_DATA, .type = SOC_ARCH_EXYNOS4412, + .test_mux =EXYNOS4412_MUX_ADDR_VALUE , }, }, .tmu_count = 1,(quoted diff) +0
-0
b/drivers/thermal/samsung/exynos_tmu_data.hindex b130b1e..a1ea19d 100644 ---a/drivers/thermal/samsung/exynos_tmu_data.h+++b/drivers/thermal/samsung/exynos_tmu_data.hdrivers/thermal/samsung/exynos_tmu_data.h +4
-0@@ -95,6 +95,10 @@#define EXYNOS_MAX_TRIGGER_PER_REG 4 +/* Exynos4412 specific */ +#define EXYNOS4412_MUX_ADDR_VALUE 6 +#define EXYNOS4412_MUX_ADDR_SHIFT 20 +/*exynos5440 specific registers*/ #define EXYNOS5440_TMU_S0_7_TRIM 0x000#define
EXYNOS5440_TMU_S0_7_CTRL0x020
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
PATCH v2 4/5 ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
In reply to Lukasz MajewskiThe TMU device tree node definition for Exynos4x12 family of SoCs.
---
Changes for v2:
- None
arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/exynos4x12.dtsi +10 -0
@@ -176,4 +176,14 @@ }; }; }; + + tmu@100C0000 { + compatible = "samsung,exynos4412-tmu"; + interrupt-parent = <&combiner>; + interrupts = <2 4>; + reg = <0x100C0000 0x100>; + clocks = <&clock 383>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; };
Signature · 1 line
1.7.10.4
Re: [PATCH v2 4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
Hi Kukjin,
Quoted 22 lines
The TMU device tree node definition for Exynos4x12 family of SoCs.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4x12.dtsiindex ad531fe..64c0ece 100644arch/arm/boot/dts/exynos4x12.dtsi +1
-0@@ -176,4 +176,14 @@ }; }; }; +
arch/arm/boot/dts/exynos4x12.dtsi line 189
Quoted 10 lines
arch/arm/boot/dts/exynos4x12.dtsi +9
-0+ tmu@100C0000 { + compatible = "samsung,exynos4412-tmu"; + interrupt-parent = <&combiner>; + interrupts = <2 4>; + reg = <0x100C0000 0x100>; + clocks = <&clock 383>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; };
Can you pull this DT node definition for TMU (as a fix to v3.12)?
It is crucial for Exynos4412.
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Eduardo Valentin
Reviewed-byRe: [PATCH v2 4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
Quoted 7 lines · Lukasz Majewski
Hi Kukjin,
Quoted 5 lines
The TMU device tree node definition for Exynos4x12 family of SoCs.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>
BTW, you can add my
on patch 4 and 5 of this series.
Quoted 32 lines
Quoted 17 lines
---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4x12.dtsiindex ad531fe..64c0ece 100644arch/arm/boot/dts/exynos4x12.dtsi +1
-0@@ -176,4 +176,14 @@ }; }; }; +arch/arm/boot/dts/exynos4x12.dtsi line 189
Quoted 10 lines
arch/arm/boot/dts/exynos4x12.dtsi +9
-0+ tmu@100C0000 { + compatible = "samsung,exynos4412-tmu"; + interrupt-parent = <&combiner>; + interrupts = <2 4>; + reg = <0x100C0000 0x100>; + clocks = <&clock 383>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; };Can you pull this DT node definition for TMU (as a fix to v3.12)?
It is crucial for Exynos4412.
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Re: [PATCH v2 4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
In reply to Lukasz MajewskiHi Kukjin,
Quoted 37 lines
Hi Kukjin,
Quoted 22 lines
The TMU device tree node definition for Exynos4x12 family of SoCs.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4x12.dtsiindex ad531fe..64c0ece 100644arch/arm/boot/dts/exynos4x12.dtsi +1
-0@@ -176,4 +176,14 @@ }; }; }; +arch/arm/boot/dts/exynos4x12.dtsi line 189
Quoted 10 lines
arch/arm/boot/dts/exynos4x12.dtsi +9
-0+ tmu@100C0000 { + compatible = "samsung,exynos4412-tmu"; + interrupt-parent = <&combiner>; + interrupts = <2 4>; + reg = <0x100C0000 0x100>; + clocks = <&clock 383>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; };Can you pull this DT node definition for TMU (as a fix to v3.12)?
Quoted 2 lines
It is crucial for Exynos4412.
Kukjin, could you pull this patch?
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
RE: [PATCH v2 4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
Quoted 3 lines · Lukasz Majewski
Hi Kukjin,
Hi,
Quoted 37 lines
Quoted 37 lines
Hi Kukjin,
Quoted 22 lines
The TMU device tree node definition for Exynos4x12 family of SoCs.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4x12.dtsiindex ad531fe..64c0ece 100644arch/arm/boot/dts/exynos4x12.dtsi +1
-0@@ -176,4 +176,14 @@ }; }; }; +arch/arm/boot/dts/exynos4x12.dtsi line 189
Quoted 10 lines
arch/arm/boot/dts/exynos4x12.dtsi +9
-0+ tmu@100C0000 { + compatible = "samsung,exynos4412-tmu"; + interrupt-parent = <&combiner>; + interrupts = <2 4>; + reg = <0x100C0000 0x100>; + clocks = <&clock 383>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; };Can you pull this DT node definition for TMU (as a fix to v3.12)?
Quoted 5 lines
Quoted 2 lines
It is crucial for Exynos4412.
Kukjin, could you pull this patch?
Yes, but I'm not sure this is _really_ critical bug fix so maybe this will be queued for 3.14.
If any problem, please kindly let me know.
Thanks,
Kukjin
Re: [PATCH v2 4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
Quoted 45 lines
Quoted 3 lines · Lukasz Majewski
Hi Kukjin,
Hi,
Quoted 39 lines
Quoted 39 lines
Hi Kukjin,
Quoted 24 lines
The TMU device tree node definition for Exynos4x12 family of SoCs.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz<[email protected]> Reviewed-by: Tomasz Figa <[email protected]>
---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4x12.dtsiindex ad531fe..64c0ece 100644 ---a/arch/arm/boot/dts/exynos4x12.dtsi+++b/arch/arm/boot/dts/exynos4x12.dtsiarch/arm/boot/dts/exynos4x12.dtsi +1
-0@@ -176,4 +176,14 @@ }; }; }; +arch/arm/boot/dts/exynos4x12.dtsi line 189
Quoted 10 lines
arch/arm/boot/dts/exynos4x12.dtsi +9
-0+ tmu@100C0000 { + compatible = "samsung,exynos4412-tmu"; + interrupt-parent = <&combiner>; + interrupts = <2 4>; + reg = <0x100C0000 0x100>; + clocks = <&clock 383>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; };Can you pull this DT node definition for TMU (as a fix to v3.12)?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
It is crucial for Exynos4412.
Kukjin, could you pull this patch?
Yes, but I'm not sure this is _really_ critical bug fix so maybe this will be queued for 3.14.
The thermal fixes were taken by Eduardo for 3.12-rcX cycle. Those were critical.
The code, which expects those definitions is already in ML, so we can try to upstream those ASAP.
Quoted 6 lines
If any problem, please kindly let me know.
Thanks,
Kukjin
Re: [PATCH v2 4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
In reply to [email protected]Hi Kukjin,
Quoted 45 lines
Quoted 3 lines · Lukasz Majewski
Hi Kukjin,
Hi,
Quoted 39 lines
Quoted 39 lines
Hi Kukjin,
Quoted 24 lines
The TMU device tree node definition for Exynos4x12 family of SoCs.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz<[email protected]> Reviewed-by: Tomasz Figa <[email protected]>
---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4x12.dtsiindex ad531fe..64c0ece 100644 ---a/arch/arm/boot/dts/exynos4x12.dtsi+++b/arch/arm/boot/dts/exynos4x12.dtsiarch/arm/boot/dts/exynos4x12.dtsi +1
-0@@ -176,4 +176,14 @@ }; }; }; +arch/arm/boot/dts/exynos4x12.dtsi line 189
Quoted 10 lines
arch/arm/boot/dts/exynos4x12.dtsi +9
-0+ tmu@100C0000 { + compatible = "samsung,exynos4412-tmu"; + interrupt-parent = <&combiner>; + interrupts = <2 4>; + reg = <0x100C0000 0x100>; + clocks = <&clock 383>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; };Can you pull this DT node definition for TMU (as a fix to v3.12)?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
It is crucial for Exynos4412.
Kukjin, could you pull this patch?
Yes, but I'm not sure this is _really_ critical bug fix so maybe this will be queued for 3.14.
Will you apply this patch to your Samsung tree?
Thanks in advance.
Quoted 6 lines
If any problem, please kindly let me know.
Thanks,
Kukjin
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
PATCH RESEND 1/2 ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
In reply to Lukasz MajewskiThe TMU device tree node definition for Exynos4x12 family of SoCs.
--- arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/exynos4x12.dtsi +10 -0
@@ -271,4 +271,14 @@ compatible = "samsung,exynos4x12-usb2-phy"; samsung,sysreg-phandle = <&sys_reg>; }; + + tmu at 100C0000 { + compatible = "samsung,exynos4412-tmu"; + interrupt-parent = <&combiner>; + interrupts = <2 4>; + reg = <0x100C0000 0x100>; + clocks = <&clock 383>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; };
Signature · 1 line
2.0.0.rc2
PATCH RESEND 2/2 ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
This patch enables support for TMU at Exynos4412 based Trats2 board.
--- arch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos4412-trats2.dts +5 -0
@@ -551,6 +551,11 @@ status = "okay"; }; + tmu at 100C0000 { + vtmu-supply = <&ldo10_reg>; + status = "okay"; + }; + i2c_ak8975: i2c-gpio-0 { compatible = "i2c-gpio"; gpios = <&gpy2 4 0>, <&gpy2 5 0>;
Signature · 1 line
2.0.0.rc2
PATCH v2 5/5 ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
In reply to Lukasz MajewskiThis patch enables support for TMU at Exynos4412 based Trats2 board.
---
Changes for v2:
- None
arch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos4412-trats2.dts +5 -0
@@ -467,6 +467,11 @@ status = "okay"; }; + tmu@100C0000 { + vtmu-supply = <&ldo10_reg>; + status = "okay"; + }; + i2c_ak8975: i2c-gpio-0 { compatible = "i2c-gpio"; gpios = <&gpy2 4 0>, <&gpy2 5 0>;
Signature · 1 line
1.7.10.4
Re: [PATCH v2 5/5] ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Hi Kukjin,
Quoted 19 lines
This patch enables support for TMU at Exynos4412 based Trats2 board.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ 1 file changed, 5 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4412-trats2.dtsindex fb7b9ae..57136f8 100644 ---a/arch/arm/boot/dts/exynos4412-trats2.dts+++b/arch/arm/boot/dts/exynos4412-trats2.dtsarch/arm/boot/dts/exynos4412-trats2.dts +0
-0@@ -467,6 +467,11 @@ status = "okay";
arch/arm/boot/dts/exynos4412-trats2.dts line 477
Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts +5
-0}; + tmu@100C0000 { + vtmu-supply = <&ldo10_reg>; + status = "okay"; + }; + i2c_ak8975: i2c-gpio-0 { compatible = "i2c-gpio"; gpios = <&gpy2 4 0>, <&gpy2 5 0>;
Can you pull this DT node definition for TMU (as a fix to v3.12)?
It is crucial for Exynos4412. Other patches from this patch set were already pulled as v3.12 fixes.
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Re: [PATCH v2 5/5] ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Hi Kukjin,
Quoted 34 lines
Hi Kukjin,
Quoted 19 lines
This patch enables support for TMU at Exynos4412 based Trats2 board.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ 1 file changed, 5 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4412-trats2.dtsindex fb7b9ae..57136f8 100644 ---a/arch/arm/boot/dts/exynos4412-trats2.dts+++b/arch/arm/boot/dts/exynos4412-trats2.dtsarch/arm/boot/dts/exynos4412-trats2.dts +0
-0@@ -467,6 +467,11 @@ status = "okay";arch/arm/boot/dts/exynos4412-trats2.dts line 477
Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts +5
-0}; + tmu@100C0000 { + vtmu-supply = <&ldo10_reg>; + status = "okay"; + }; + i2c_ak8975: i2c-gpio-0 { compatible = "i2c-gpio"; gpios = <&gpy2 4 0>, <&gpy2 5 0>;Can you pull this DT node definition for TMU (as a fix to v3.12)?
Quoted 3 lines
It is crucial for Exynos4412. Other patches from this patch set were already pulled as v3.12 fixes.
Kukjin, could you pull this patch?
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
[email protected]
AppliedRE: [PATCH v2 5/5] ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Quoted 37 lines · Lukasz Majewski
Hi Kukjin,
Quoted 34 lines
Hi Kukjin,
Quoted 19 lines
This patch enables support for TMU at Exynos4412 based Trats2 board.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>Reviewed-by Tomasz Figa <[email protected]>---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ 1 file changed, 5 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4412-trats2.dtsindex fb7b9ae..57136f8 100644 ---a/arch/arm/boot/dts/exynos4412-trats2.dts+++b/arch/arm/boot/dts/exynos4412-trats2.dtsarch/arm/boot/dts/exynos4412-trats2.dts +0
-0@@ -467,6 +467,11 @@ status = "okay";arch/arm/boot/dts/exynos4412-trats2.dts line 477
Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts +5
-0}; + tmu@100C0000 { + vtmu-supply = <&ldo10_reg>; + status = "okay"; + }; + i2c_ak8975: i2c-gpio-0 { compatible = "i2c-gpio"; gpios = <&gpy2 4 0>, <&gpy2 5 0>;Can you pull this DT node definition for TMU (as a fix to v3.12)?
Quoted 6 lines
Quoted 3 lines
It is crucial for Exynos4412. Other patches from this patch set were already pulled as v3.12 fixes.
Kukjin, could you pull this patch?
Applied, thanks.
Kukjin
Re: [PATCH v2 5/5] ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Hi Kukjin,
Quoted 40 lines
Quoted 39 lines · Lukasz Majewski
Hi Kukjin,
Quoted 36 lines
Hi Kukjin,
Quoted 21 lines
This patch enables support for TMU at Exynos4412 based Trats2 board.
Signed-off-by Lukasz Majewski <[email protected]>Reviewed-by Bartlomiej Zolnierkiewicz<[email protected]> Reviewed-by: Tomasz Figa <[email protected]>
---
Changes for v2:
- Nonearch/arm/boot/dts/exynos4412-trats2.dts | 5 +++++ 1 file changed, 5 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4412-trats2.dtsindex fb7b9ae..57136f8 100644 ---a/arch/arm/boot/dts/exynos4412-trats2.dts+++b/arch/arm/boot/dts/exynos4412-trats2.dtsarch/arm/boot/dts/exynos4412-trats2.dts +0
-0@@ -467,6 +467,11 @@ status = "okay";arch/arm/boot/dts/exynos4412-trats2.dts line 477
Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts +5
-0}; + tmu@100C0000 { + vtmu-supply = <&ldo10_reg>; + status = "okay"; + }; + i2c_ak8975: i2c-gpio-0 { compatible = "i2c-gpio"; gpios = <&gpy2 4 0>, <&gpy2 5 0>;Can you pull this DT node definition for TMU (as a fix to v3.12)?
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
It is crucial for Exynos4412. Other patches from this patch set were already pulled as v3.12 fixes.
Kukjin, could you pull this patch?
Applied, thanks.
It is strange, but it seems like this patch hasn't found its way to mainline (3.18-rc3).
This patch should be applied with the following one:
"[PATCH v2 4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12"
Anyway, I will resend them. If possible, please add them to your tree ASAP.
Quoted 7 lines
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Hi Zhang, Eduardo,
Quoted 16 lines
This patch series is divided into two parts:
1. Device tree node definition and enabelement for TMU at Exynos4412 (Trats2) 2. Exynos thermal subsystem regressions for v3.12-rc4. Several commits were necessary to properly fix regression for TMU test MUX address setting after reset.Test HW:
- Exynos4412 - TRATS2 board (Linux v3.12-rc4)
SHA1:8b5ede69d24db939f52b47effff2f6fe1e83e08bLukasz Majewski (5):
thermal: exynos: Remove check for thermal device pointer at
exynos_report_trigger()
thermal: exynos: Provide separate TMU data for Exynos4412
thermal: exynos: Provide initial setting for TMU's test MUX address
Quoted 5 lines
at Exynos4412 ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Zhang, Eduardo - any comments?
Would it be possible to add them to v3.12 since they do fix critical error and regression on Exynos4412.
Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts | 5 ++++ arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++ drivers/thermal/samsung/exynos_thermal_common.c | 2 -- drivers/thermal/samsung/exynos_tmu.c | 12 ++++++--- drivers/thermal/samsung/exynos_tmu.h | 7 +++++- drivers/thermal/samsung/exynos_tmu_data.c | 30++++++++++++++++++-----
drivers/thermal/samsung/exynos_tmu_data.h| 13 +++++++++- 7
files changed, 65 insertions(+), 14 deletions(-)
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Zhang, Rui
reviewerEduardo,
What's your opinion on this patch set?
BTW, please send me all the urgent fixes for thermal soc drivers that you think should go to 3.12.
Thanks,
rui
Quoted 60 lines
-----Original Message-----
From: Lukasz Majewski [mailto:[email protected]]
Sent: Monday, October 14, 2013 1:47 PM
To: Zhang, Rui; Eduardo Valentin; [email protected]
Cc: Lukasz Majewski; Linux PM list; Lukasz Majewski; linux-kernel; Bartlomiej Zolnierkiewicz; [email protected]; Amit Daniel Kachhap; [email protected]
Subject: Re: [PATCH v2 0/5] thermal: exynos: Fixes for v3.12
Importance: HighHi Zhang, Eduardo,
Quoted 4 lines
This patch series is divided into two parts:
1. Device tree node definition and enabelement for TMU at Exynos4412 (Trats2) 2. Exynos thermal subsystem regressions for v3.12-rc4. Several commits were necessary to properly fix regression for TMUtest
Quoted 12 lines
MUX address setting after reset.
Test HW:
- Exynos4412 - TRATS2 board (Linux v3.12-rc4)
SHA1:8b5ede69d24db939f52b47effff2f6fe1e83e08bLukasz Majewski (5):
thermal: exynos: Remove check for thermal device pointer at
exynos_report_trigger()
thermal: exynos: Provide separate TMU data for Exynos4412
thermal: exynos: Provide initial setting for TMU's test MUX addressQuoted 5 lines
at Exynos4412 ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Zhang, Eduardo - any comments?
Would it be possible to add them to v3.12 since they do fix critical error and regression on Exynos4412.
Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts | 5 ++++ arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++ drivers/thermal/samsung/exynos_thermal_common.c | 2 -- drivers/thermal/samsung/exynos_tmu.c | 12 ++++++--- drivers/thermal/samsung/exynos_tmu.h | 7 +++++- drivers/thermal/samsung/exynos_tmu_data.c | 30++++++++++++++++++-----
drivers/thermal/samsung/exynos_tmu_data.h| 13 +++++++++- 7
files changed, 65 insertions(+), 14 deletions(-)--
Best regards,Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Quoted 4 lines · Rui
Eduardo,
What's your opinion on this patch set?
BTW, please send me all the urgent fixes for thermal soc drivers that
you think should go to 3.12.
Quoted 1 line
I will be sending these + one fix on ti soc thermal for 3.12 soon.
The new chip support on exynos needs to be reworked and there are couple of new drivers that needs to be reworked too. But those I don't think are ready to go now.
Quoted 68 lines
Thanks,
ruiQuoted 54 lines
-----Original Message-----
From: Lukasz Majewski [mailto:[email protected]]
Sent: Monday, October 14, 2013 1:47 PM
To: Zhang, Rui; Eduardo Valentin; [email protected]
Cc: Lukasz Majewski; Linux PM list; Lukasz Majewski; linux-kernel; Bartlomiej Zolnierkiewicz; [email protected]; Amit Daniel Kachhap; [email protected]
Subject: Re: [PATCH v2 0/5] thermal: exynos: Fixes for v3.12
Importance: HighHi Zhang, Eduardo,
Quoted 4 lines
This patch series is divided into two parts:
1. Device tree node definition and enabelement for TMU at Exynos4412 (Trats2) 2. Exynos thermal subsystem regressions for v3.12-rc4. Several commits were necessary to properly fix regression for TMUtest
Quoted 12 lines
MUX address setting after reset.
Test HW:
- Exynos4412 - TRATS2 board (Linux v3.12-rc4)
SHA1:8b5ede69d24db939f52b47effff2f6fe1e83e08bLukasz Majewski (5):
thermal: exynos: Remove check for thermal device pointer at
exynos_report_trigger()
thermal: exynos: Provide separate TMU data for Exynos4412
thermal: exynos: Provide initial setting for TMU's test MUX addressQuoted 5 lines
at Exynos4412 ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Zhang, Eduardo - any comments?
Would it be possible to add them to v3.12 since they do fix critical error and regression on Exynos4412.
Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts | 5 ++++ arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++ drivers/thermal/samsung/exynos_thermal_common.c | 2 -- drivers/thermal/samsung/exynos_tmu.c | 12 ++++++--- drivers/thermal/samsung/exynos_tmu.h | 7 +++++- drivers/thermal/samsung/exynos_tmu_data.c | 30++++++++++++++++++-----
drivers/thermal/samsung/exynos_tmu_data.h| 13 +++++++++- 7
files changed, 65 insertions(+), 14 deletions(-)Quoted 6 lines
--
Best regards,Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Quoted 5 lines · Eduardo Valentin
Quoted 4 lines · Rui
Eduardo,
What's your opinion on this patch set?
BTW, please send me all the urgent fixes for thermal soc drivers that
Quoted 9 lines
you think should go to 3.12.
Quoted 1 line
I will be sending these + one fix on ti soc thermal for 3.12 soon.
The new chip support on exynos needs to be reworked and there are couple of new drivers that needs to be reworked too. But those I don't think are ready to go now.
Just to be clear, on this patch set obviously I wont be sending the DT changes. Those should go via the correct tree.
Quoted 70 lines
Quoted 68 lines
Thanks,
ruiQuoted 54 lines
-----Original Message-----
From: Lukasz Majewski [mailto:[email protected]]
Sent: Monday, October 14, 2013 1:47 PM
To: Zhang, Rui; Eduardo Valentin; [email protected]
Cc: Lukasz Majewski; Linux PM list; Lukasz Majewski; linux-kernel; Bartlomiej Zolnierkiewicz; [email protected]; Amit Daniel Kachhap; [email protected]
Subject: Re: [PATCH v2 0/5] thermal: exynos: Fixes for v3.12
Importance: HighHi Zhang, Eduardo,
Quoted 4 lines
This patch series is divided into two parts:
1. Device tree node definition and enabelement for TMU at Exynos4412 (Trats2) 2. Exynos thermal subsystem regressions for v3.12-rc4. Several commits were necessary to properly fix regression for TMUtest
Quoted 12 lines
MUX address setting after reset.
Test HW:
- Exynos4412 - TRATS2 board (Linux v3.12-rc4)
SHA1:8b5ede69d24db939f52b47effff2f6fe1e83e08bLukasz Majewski (5):
thermal: exynos: Remove check for thermal device pointer at
exynos_report_trigger()
thermal: exynos: Provide separate TMU data for Exynos4412
thermal: exynos: Provide initial setting for TMU's test MUX addressQuoted 5 lines
at Exynos4412 ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Zhang, Eduardo - any comments?
Would it be possible to add them to v3.12 since they do fix critical error and regression on Exynos4412.
Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts | 5 ++++ arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++ drivers/thermal/samsung/exynos_thermal_common.c | 2 -- drivers/thermal/samsung/exynos_tmu.c | 12 ++++++--- drivers/thermal/samsung/exynos_tmu.h | 7 +++++- drivers/thermal/samsung/exynos_tmu_data.c | 30++++++++++++++++++-----
drivers/thermal/samsung/exynos_tmu_data.h| 13 +++++++++- 7
files changed, 65 insertions(+), 14 deletions(-)Quoted 6 lines
--
Best regards,Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 3 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Hi Eduardo,
Quoted 12 lines · Eduardo Valentin
Quoted 11 lines · Rui
Quoted 5 lines
Eduardo,
What's your opinion on this patch set?
BTW, please send me all the urgent fixes for thermal soc drivers thatyou think should go to 3.12.
Quoted 1 line
I will be sending these + one fix on ti soc thermal for 3.12 soon.
Quoted 7 lines
Quoted 4 lines
The new chip support on exynos needs to be reworked and there are couple of new drivers that needs to be reworked too. But those I don't think are ready to go now.
Just to be clear, on this patch set obviously I wont be sending the DT changes. Those should go via the correct tree.
I understand. I will ask Mr. Kukjin Kim to take the DT changes.
Quoted 74 lines
Quoted 72 lines
Quoted 70 lines
Thanks,
ruiQuoted 55 lines
-----Original Message-----
From: Lukasz Majewski [mailto:[email protected]]
Sent: Monday, October 14, 2013 1:47 PM
To: Zhang, Rui; Eduardo Valentin; [email protected]
Cc: Lukasz Majewski; Linux PM list; Lukasz Majewski; linux-kernel; Bartlomiej Zolnierkiewicz; [email protected]; Amit Daniel Kachhap; [email protected]
Subject: Re: [PATCH v2 0/5] thermal: exynos: Fixes for v3.12
Importance: HighHi Zhang, Eduardo,
Quoted 5 lines
This patch series is divided into two parts:
1. Device tree node definition and enabelement for TMU at Exynos4412 (Trats2) 2. Exynos thermal subsystem regressions for v3.12-rc4. Several commits were necessary to properly fix regression for TMUtest
Quoted 14 lines
MUX address setting after reset.
Test HW:
- Exynos4412 - TRATS2 board (Linux v3.12-rc4)
SHA1:8b5ede69d24db939f52b47effff2f6fe1e83e08bLukasz Majewski (5):
thermal: exynos: Remove check for thermal device pointer at
exynos_report_trigger()
thermal: exynos: Provide separate TMU data for Exynos4412
thermal: exynos: Provide initial setting for TMU's test MUX
address at Exynos4412
ARM: dts: exynos4x12: Device tree node definition for TMU onQuoted 3 lines
Exynos4x12ARM: dts: exynos4412-trats2: Enable TMU support at Trats2
Zhang, Eduardo - any comments?
Would it be possible to add them to v3.12 since they do fix critical error and regression on Exynos4412.
Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts | 5 ++++ arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++ drivers/thermal/samsung/exynos_thermal_common.c | 2 -- drivers/thermal/samsung/exynos_tmu.c | 12 ++++++--- drivers/thermal/samsung/exynos_tmu.h | 7 +++++- drivers/thermal/samsung/exynos_tmu_data.c | 30++++++++++++++++++-----
drivers/thermal/samsung/exynos_tmu_data.h| 13
+++++++++- 7 files changed, 65 insertions(+), 14 deletions(-)Quoted 6 lines
--
Best regards,Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group