drm/i915: backlight combination mode bit is gen4 only
Subsystems (2)
PATCH 1/1 drm/i915: backlight combination mode bit is gen4 only
Not valid for later non-PCH split platforms such as VLV.
Signed-off-by Jani Nikula <[email protected]>
--- drivers/gpu/drm/i915/intel_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -1
@@ -329,7 +329,7 @@ static int is_backlight_combination_mode(struct drm_device *dev) {struct drm_i915_private *dev_priv = dev->dev_private; -if (INTEL_INFO (dev)->gen >=4 ) +if (IS_GEN4 (dev))return I915_READ (BLC_PWM_CTL2 ) &BLM_COMBINATION_MODE ;if (IS_GEN2 (dev))
Signature · 1 line
1.7.10.4
Quoted 3 lines · Jani Nikula
Not valid for later non-PCH split platforms such as VLV.
Signed-off-by Jani Nikula <[email protected]>
The bit is mbz on VLV, so I guess it should be 0, but better safe than sorry, and it gets rid of a useless register read.
Reviewed-by Ville Syrjälä <[email protected]>
Quoted 24 lines
--- drivers/gpu/drm/i915/intel_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_panel.c +1
-1@@ -329,7 +329,7 @@ static int is_backlight_combination_mode(struct drm_device *dev) {struct drm_i915_private *dev_priv = dev->dev_private; -if (INTEL_INFO (dev)->gen >=4 ) +if (IS_GEN4 (dev))return I915_READ (BLC_PWM_CTL2 ) &BLM_COMBINATION_MODE ;if (IS_GEN2 (dev))Signature · 6 lines
1.7.10.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 2 lines
Ville Syrjälä Intel OTC
Daniel Vetter
AppliedQuoted 9 lines · Ville Syrjälä
Quoted 3 lines · Jani Nikula
Not valid for later non-PCH split platforms such as VLV.
Signed-off-by Jani Nikula <[email protected]>The bit is mbz on VLV, so I guess it should be 0, but better safe than sorry, and it gets rid of a useless register read.
Reviewed-by Ville Syrjälä <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch