Skip to contentSkip to conversation

ARM: mxs: tools: Use mkimage for BootStream generation

PATCH New Marek Vasut 2 participants 9 messages Sep 24, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mxs: tools: Use mkimage for BootStream generation

Now that mkimage can generate an BootStream for i.MX23 and i.MX28, use the mkimage as a default tool to generate the BootStreams instead of the elftosb tool. This cuts out another obscure dependency.

Cc Fabio Estevam <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Stefano Babic <[email protected]>
---
 arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
 doc/README.mxs                               | 34 +++++++++++++++++++++++++---
 4 files changed, 41 insertions(+), 12 deletions(-)
arch/arm/cpu/arm926ejs/mxs/Makefile +6 -5
index 3d66892..3e9cbdb 100644
@@ -25,14 +25,15 @@ $(LIB):	$(OBJS)
 	$(call cmd_link_o_target, $(OBJS))
 
 # Specify the target for use in elftosb call
-ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
-ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
+ELFTOSB_TARGET-$(CONFIG_MX23) = mx23
+ELFTOSB_TARGET-$(CONFIG_MX28) = mx28
 
-$(OBJTREE)/u-boot.bd: $(SRCTREE)/$(CPUDIR)/$(SOC)/u-boot-$(ELFTOSB_TARGET-y).bd
+$(OBJTREE)/mxsimage.cfg: $(SRCTREE)/$(CPUDIR)/$(SOC)/mxsimage.$(ELFTOSB_TARGET-y).cfg
 	sed "s at OBJTREE@$(OBJTREE)@g" $^ > $@
 
-$(OBJTREE)/u-boot.sb: $(OBJTREE)/u-boot.bin $(OBJTREE)/spl/u-boot-spl.bin $(OBJTREE)/u-boot.bd
-		elftosb -zf $(ELFTOSB_TARGET-y) -c $(OBJTREE)/u-boot.bd -o $(OBJTREE)/u-boot.sb
+$(OBJTREE)/u-boot.sb: $(OBJTREE)/u-boot.bin $(OBJTREE)/spl/u-boot-spl.bin $(OBJTREE)/mxsimage.cfg
+	$(OBJTREE)/tools/mkimage -n $(OBJTREE)/mxsimage.cfg -T mxsimage $@
+
 
 #########################################################################
 
arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg +2 -2
index 8118767..c9cf4b3 100644
@@ -1,6 +1,6 @@
 SECTION 0x0 BOOTABLE
  TAG LAST
- LOAD     0x0        spl/u-boot-spl.bin
+ LOAD     0x0        OBJTREE/spl/u-boot-spl.bin
  CALL     0x14       0x0
- LOAD     0x40000100 u-boot.bin
+ LOAD     0x40000100 OBJTREE/u-boot.bin
  CALL     0x40000100 0x0
arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg +2 -2
index ea772f0..676f5c8 100644
@@ -1,8 +1,8 @@
 SECTION 0x0 BOOTABLE
  TAG LAST
- LOAD     0x0        spl/u-boot-spl.bin
+ LOAD     0x0        OBJTREE/spl/u-boot-spl.bin
  LOAD IVT 0x8000     0x14
  CALL HAB 0x8000     0x0
- LOAD     0x40000100 u-boot.bin
+ LOAD     0x40000100 OBJTREE/u-boot.bin
  LOAD IVT 0x8000     0x40000100
  CALL HAB 0x8000     0x0
doc/README.mxs +31 -3
index 5d9e72f..49eead4 100644
@@ -27,9 +27,25 @@ Contents
 1) Prerequisites
 ----------------
 
-To make a MXS based board bootable, some tools are necessary. The first one is
-the "elftosb" tool distributed by Freescale Semiconductor. The other one is the
-"mxsboot" tool found in U-Boot source tree.
+To make a MXS based board bootable, some tools are necessary. The only
+mandatory tool is the "mxsboot" tool found in U-Boot source tree. The
+tool is built automatically when compiling U-Boot for i.MX23 or i.MX28.
+
+The production of BootStream image is handled via "mkimage", which is
+also part of the U-Boot source tree. The "mkimage" requires OpenSSL
+development libraries to be installed. In case of Debian and derivates,
+this is installed by running:
+
+	$ sude apt-get install libssl-dev
+
+NOTE: The "elftosb" tool distributed by Freescale Semiconductor is no
+      longer necessary for general use of U-Boot on i.MX23 and i.MX28.
+      The mkimage supports generation of BootStream images encrypted
+      with a zero key, which is the vast majority of use-cases. In
+      case you do need to produce image encrypted with non-zero key
+      or other special features, please use the "elftosb" tool,
+      otherwise continue to section 2). The installation procedure of
+      the "elftosb" is outlined below:
 
 Firstly, obtain the elftosb archive from the following location:
 
@@ -107,6 +123,18 @@ The code produces "u-boot.sb" file. This file needs to be augmented with a
 proper header to allow successful boot from SD or NAND. Adding the header is
 discussed in the following chapters.
 
+NOTE: The process that produces u-boot.sb uses the mkimage to generate the
+      BootStream. The BootStream is encrypted with zero key. In case you need
+      some special features of the BootStream and plan on using the "elftosb"
+      tool instead, the invocation to produce a compatible BootStream with the
+      one produced by mkimage is outlined below. For further details, refer to
+      the documentation bundled with the "elftosb" package.
+
+	$ elftosb -zf imx23 -c arch/arm/cpu/arm926ejs/mxs/u-boot-imx23.bd \
+		-o u-boot.sb
+	$ elftosb -zf imx28 -c arch/arm/cpu/arm926ejs/mxs/u-boot-imx28.bd \
+		-o u-boot.sb
+
 3) Installation of U-Boot for a MXS based board to SD card
 ----------------------------------------------------------
 
Signature · 1 line
1.8.4.rc3
#1 lore raw

PATCH 1/1 ARM: mxs: tools: Use mkimage for BootStream generation

Hi,

Quoted 8 lines

Now that mkimage can generate an BootStream for i.MX23 and i.MX28, use the mkimage as a default tool to generate the BootStreams instead of the elftosb tool. This cuts out another obscure dependency.

Cc Fabio Estevam <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Stefano Babic <[email protected]>
Quoted 7 lines
---
 arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
 doc/README.mxs                               | 34

+++++++++++++++++++++++++--- 4 files changed, 41 insertions(+), 12 deletions(-)

Stefano, please schedule this for -next.

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 ARM: mxs: tools: Use mkimage for BootStream generation

In reply to Marek Vasut
Quoted 20 lines · Marek Vasut

Now that mkimage can generate an BootStream for i.MX23 and i.MX28, use the mkimage as a default tool to generate the BootStreams instead of the elftosb tool. This cuts out another obscure dependency.

Cc Fabio Estevam <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Stefano Babic <[email protected]>
---
 arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
 doc/README.mxs                               | 34 +++++++++++++++++++++++++---
 4 files changed, 41 insertions(+), 12 deletions(-)
arch/arm/cpu/arm926ejs/mxs/Makefile +0 -0
index 3d66892..3e9cbdb 100644

arch/arm/cpu/arm926ejs/mxs/Makefile $(LIB): $(OBJS) · line 29

Quoted 7 lines
arch/arm/cpu/arm926ejs/mxs/Makefile +2 -2
@@ -25,14 +25,15 @@ $(LIB):     $(OBJS)
        $(call cmd_link_o_target, $(OBJS))
 
 # Specify the target for use in elftosb call
-ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
-ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
+ELFTOSB_TARGET-$(CONFIG_MX23) = mx23
+ELFTOSB_TARGET-$(CONFIG_MX28) = mx28

Uh?! this seems wrong.

Quoted 95 lines
arch/arm/cpu/arm926ejs/mxs/Makefile +4 -3
-$(OBJTREE)/u-boot.bd: $(SRCTREE)/$(CPUDIR)/$(SOC)/u-boot-$(ELFTOSB_TARGET-y).bd
+$(OBJTREE)/mxsimage.cfg: $(SRCTREE)/$(CPUDIR)/$(SOC)/mxsimage.$(ELFTOSB_TARGET-y).cfg
        sed "s at OBJTREE@$(OBJTREE)@g" $^ > $@
 
-$(OBJTREE)/u-boot.sb: $(OBJTREE)/u-boot.bin $(OBJTREE)/spl/u-boot-spl.bin $(OBJTREE)/u-boot.bd
-               elftosb -zf $(ELFTOSB_TARGET-y) -c $(OBJTREE)/u-boot.bd -o $(OBJTREE)/u-boot.sb
+$(OBJTREE)/u-boot.sb: $(OBJTREE)/u-boot.bin $(OBJTREE)/spl/u-boot-spl.bin $(OBJTREE)/mxsimage.cfg
+       $(OBJTREE)/tools/mkimage -n $(OBJTREE)/mxsimage.cfg -T mxsimage $@
+
 
 #########################################################################
 
arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg +2 -2
index 8118767..c9cf4b3 100644
@@ -1,6 +1,6 @@
 SECTION 0x0 BOOTABLE
  TAG LAST
- LOAD     0x0        spl/u-boot-spl.bin
+ LOAD     0x0        OBJTREE/spl/u-boot-spl.bin
  CALL     0x14       0x0
- LOAD     0x40000100 u-boot.bin
+ LOAD     0x40000100 OBJTREE/u-boot.bin
  CALL     0x40000100 0x0
arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg +2 -2
index ea772f0..676f5c8 100644
@@ -1,8 +1,8 @@
 SECTION 0x0 BOOTABLE
  TAG LAST
- LOAD     0x0        spl/u-boot-spl.bin
+ LOAD     0x0        OBJTREE/spl/u-boot-spl.bin
  LOAD IVT 0x8000     0x14
  CALL HAB 0x8000     0x0
- LOAD     0x40000100 u-boot.bin
+ LOAD     0x40000100 OBJTREE/u-boot.bin
  LOAD IVT 0x8000     0x40000100
  CALL HAB 0x8000     0x0
doc/README.mxs +31 -4
index 5d9e72f..49eead4 100644
@@ -27,9 +27,25 @@ Contents
 1) Prerequisites
 ----------------
 
-To make a MXS based board bootable, some tools are necessary. The first one is
-the "elftosb" tool distributed by Freescale Semiconductor. The other one is the
-"mxsboot" tool found in U-Boot source tree.
+To make a MXS based board bootable, some tools are necessary. The only
+mandatory tool is the "mxsboot" tool found in U-Boot source tree. The
+tool is built automatically when compiling U-Boot for i.MX23 or i.MX28.
+
+The production of BootStream image is handled via "mkimage", which is
+also part of the U-Boot source tree. The "mkimage" requires OpenSSL
+development libraries to be installed. In case of Debian and derivates,
+this is installed by running:
+
+       $ sude apt-get install libssl-dev
+
+NOTE: The "elftosb" tool distributed by Freescale Semiconductor is no
+      longer necessary for general use of U-Boot on i.MX23 and i.MX28.
+      The mkimage supports generation of BootStream images encrypted
+      with a zero key, which is the vast majority of use-cases. In
+      case you do need to produce image encrypted with non-zero key
+      or other special features, please use the "elftosb" tool,
+      otherwise continue to section 2). The installation procedure of
+      the "elftosb" is outlined below:
 
 Firstly, obtain the elftosb archive from the following location:
 
@@ -107,6 +123,18 @@ The code produces "u-boot.sb" file. This file needs to be augmented with a
 proper header to allow successful boot from SD or NAND. Adding the header is
 discussed in the following chapters.
 
+NOTE: The process that produces u-boot.sb uses the mkimage to generate the
+      BootStream. The BootStream is encrypted with zero key. In case you need
+      some special features of the BootStream and plan on using the "elftosb"
+      tool instead, the invocation to produce a compatible BootStream with the
+      one produced by mkimage is outlined below. For further details, refer to
+      the documentation bundled with the "elftosb" package.
+
+       $ elftosb -zf imx23 -c arch/arm/cpu/arm926ejs/mxs/u-boot-imx23.bd \
+               -o u-boot.sb
+       $ elftosb -zf imx28 -c arch/arm/cpu/arm926ejs/mxs/u-boot-imx28.bd \
+               -o u-boot.sb
+
 3) Installation of U-Boot for a MXS based board to SD card
 ----------------------------------------------------------
 
--

1.8.4.rc3

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw

PATCH 1/1 ARM: mxs: tools: Use mkimage for BootStream generation

Dear Otavio Salvador,

Quoted 26 lines · Marek Vasut
Quoted 25 lines

Now that mkimage can generate an BootStream for i.MX23 and i.MX28, use the mkimage as a default tool to generate the BootStreams instead of the elftosb tool. This cuts out another obscure dependency.

Cc Fabio Estevam <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Stefano Babic <[email protected]>

---

 arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
 doc/README.mxs                               | 34

+++++++++++++++++++++++++--- 4 files changed, 41 insertions(+), 12 deletions(-)

(quoted diff) +0 -0

b/arch/arm/cpu/arm926ejs/mxs/Makefile index 3d66892..3e9cbdb 100644

arch/arm/cpu/arm926ejs/mxs/Makefile +0 -0
@@ -25,14 +25,15 @@ $(LIB):     $(OBJS)
 
        $(call cmd_link_o_target, $(OBJS))
 
Quoted 8 lines

arch/arm/cpu/arm926ejs/mxs/Makefile $(LIB): $(OBJS) · line 29

Quoted 6 lines
arch/arm/cpu/arm926ejs/mxs/Makefile +2 -2
 # Specify the target for use in elftosb call
 
-ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
-ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
+ELFTOSB_TARGET-$(CONFIG_MX23) = mx23
+ELFTOSB_TARGET-$(CONFIG_MX28) = mx28

Uh?! this seems wrong.

Why ?

Best regards,
Marek Vasut

#4 lore raw

PATCH 1/1 ARM: mxs: tools: Use mkimage for BootStream generation

Quoted 30 lines · Marek Vasut

Dear Otavio Salvador,

Quoted 28 lines · Marek Vasut
Quoted 27 lines

Now that mkimage can generate an BootStream for i.MX23 and i.MX28, use the mkimage as a default tool to generate the BootStreams instead of the elftosb tool. This cuts out another obscure dependency.

Cc Fabio Estevam <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Stefano Babic <[email protected]>

---

 arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
 doc/README.mxs                               | 34

+++++++++++++++++++++++++--- 4 files changed, 41 insertions(+), 12 deletions(-)

(quoted diff) +0 -0

b/arch/arm/cpu/arm926ejs/mxs/Makefile index 3d66892..3e9cbdb 100644

arch/arm/cpu/arm926ejs/mxs/Makefile +0 -0
@@ -25,14 +25,15 @@ $(LIB):     $(OBJS)
 
        $(call cmd_link_o_target, $(OBJS))
 
 # Specify the target for use in elftosb call
 
Quoted 8 lines
Quoted 6 lines

arch/arm/cpu/arm926ejs/mxs/Makefile $(LIB): $(OBJS) · line 29

Quoted 4 lines
arch/arm/cpu/arm926ejs/mxs/Makefile +2 -2
-ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
-ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
+ELFTOSB_TARGET-$(CONFIG_MX23) = mx23
+ELFTOSB_TARGET-$(CONFIG_MX28) = mx28

Uh?! this seems wrong.

Why ?

elftosb uses the former way; in case you might change the target var for:

MXSIMAGE_TARGET

So this does not cause confusion.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#5 lore raw

PATCH 1/1 ARM: mxs: tools: Use mkimage for BootStream generation

Dear Otavio Salvador,

Quoted 38 lines · Marek Vasut
Quoted 37 lines

Dear Otavio Salvador,

Quoted 34 lines · Marek Vasut
Quoted 22 lines

Now that mkimage can generate an BootStream for i.MX23 and i.MX28, use the mkimage as a default tool to generate the BootStreams instead of the elftosb tool. This cuts out another obscure dependency.

Cc Fabio Estevam <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Stefano Babic <[email protected]>

---

 arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
 doc/README.mxs                               | 34

+++++++++++++++++++++++++--- 4 files changed, 41 insertions(+), 12 deletions(-)

(quoted diff) +0 -0

b/arch/arm/cpu/arm926ejs/mxs/Makefile index 3d66892..3e9cbdb 100644

arch/arm/cpu/arm926ejs/mxs/Makefile $(LIB): $(OBJS) · line 31

Quoted 9 lines
arch/arm/cpu/arm926ejs/mxs/Makefile +2 -2
@@ -25,14 +25,15 @@ $(LIB):     $(OBJS)
 
        $(call cmd_link_o_target, $(OBJS))
 
 # Specify the target for use in elftosb call
 
-ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
-ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
+ELFTOSB_TARGET-$(CONFIG_MX23) = mx23
+ELFTOSB_TARGET-$(CONFIG_MX28) = mx28

Uh?! this seems wrong.

Quoted 7 lines
Quoted 1 line

Why ?

elftosb uses the former way; in case you might change the target var for:

MXSIMAGE_TARGET

So this does not cause confusion.

OK. Next time you could include such vital information in your first email.

Best regards,
Marek Vasut

#6 lore raw

PATCH 1/1 ARM: mxs: tools: Use mkimage for BootStream generation

Quoted 42 lines · Marek Vasut

Dear Otavio Salvador,

Quoted 40 lines · Marek Vasut
Quoted 38 lines

Dear Otavio Salvador,

Quoted 26 lines · Marek Vasut
Quoted 25 lines

Now that mkimage can generate an BootStream for i.MX23 and i.MX28, use the mkimage as a default tool to generate the BootStreams instead of the elftosb tool. This cuts out another obscure dependency.

Cc Fabio Estevam <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Stefano Babic <[email protected]>

---

 arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
 doc/README.mxs                               | 34

+++++++++++++++++++++++++--- 4 files changed, 41 insertions(+), 12 deletions(-)

(quoted diff) +0 -0

b/arch/arm/cpu/arm926ejs/mxs/Makefile index 3d66892..3e9cbdb 100644

arch/arm/cpu/arm926ejs/mxs/Makefile +0 -0
@@ -25,14 +25,15 @@ $(LIB):     $(OBJS)
 
        $(call cmd_link_o_target, $(OBJS))
 
Quoted 8 lines

arch/arm/cpu/arm926ejs/mxs/Makefile $(LIB): $(OBJS) · line 29

Quoted 6 lines
arch/arm/cpu/arm926ejs/mxs/Makefile +2 -2
 # Specify the target for use in elftosb call
 
-ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
-ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
+ELFTOSB_TARGET-$(CONFIG_MX23) = mx23
+ELFTOSB_TARGET-$(CONFIG_MX28) = mx28

Uh?! this seems wrong.

Why ?

Quoted 7 lines
Quoted 5 lines

elftosb uses the former way; in case you might change the target var for:

MXSIMAGE_TARGET

So this does not cause confusion.

OK. Next time you could include such vital information in your first email.

Next time you can say 'thank you'. Such politeness helps collaborative work ;-)

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#7 lore raw

PATCH 1/1 ARM: mxs: tools: Use mkimage for BootStream generation

Dear Otavio Salvador,

Quoted 49 lines · Marek Vasut
Quoted 48 lines

Dear Otavio Salvador,

Quoted 46 lines · Marek Vasut
Quoted 31 lines

Dear Otavio Salvador,

Quoted 29 lines · Marek Vasut
Quoted 28 lines

Now that mkimage can generate an BootStream for i.MX23 and i.MX28, use the mkimage as a default tool to generate the BootStreams instead of the elftosb tool. This cuts out another obscure dependency.

Cc Fabio Estevam <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Stefano Babic <[email protected]>

---

 arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
 doc/README.mxs                               | 34

+++++++++++++++++++++++++--- 4 files changed, 41 insertions(+), 12 deletions(-)

(quoted diff) +0 -0

b/arch/arm/cpu/arm926ejs/mxs/Makefile index 3d66892..3e9cbdb 100644

arch/arm/cpu/arm926ejs/mxs/Makefile +0 -0
@@ -25,14 +25,15 @@ $(LIB):     $(OBJS)
 
        $(call cmd_link_o_target, $(OBJS))
 
 # Specify the target for use in elftosb call
 
Quoted 8 lines
Quoted 6 lines

arch/arm/cpu/arm926ejs/mxs/Makefile $(LIB): $(OBJS) · line 29

Quoted 4 lines
arch/arm/cpu/arm926ejs/mxs/Makefile +2 -2
-ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
-ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
+ELFTOSB_TARGET-$(CONFIG_MX23) = mx23
+ELFTOSB_TARGET-$(CONFIG_MX28) = mx28

Uh?! this seems wrong.

Why ?

elftosb uses the former way; in case you might change the target var for:

MXSIMAGE_TARGET

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

So this does not cause confusion.

OK. Next time you could include such vital information in your first email.

Next time you can say 'thank you'. Such politeness helps collaborative work ;-)

Fixed (lol).

Best regards,
Marek Vasut

#8 lore raw

PATCH 1/1 ARM: mxs: tools: Use mkimage for BootStream generation

In reply to Otavio Salvador

Dear Otavio Salvador,

Quoted 26 lines · Marek Vasut
Quoted 25 lines

Now that mkimage can generate an BootStream for i.MX23 and i.MX28, use the mkimage as a default tool to generate the BootStreams instead of the elftosb tool. This cuts out another obscure dependency.

Cc Fabio Estevam <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Stefano Babic <[email protected]>

---

 arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
 arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
 doc/README.mxs                               | 34

+++++++++++++++++++++++++--- 4 files changed, 41 insertions(+), 12 deletions(-)

(quoted diff) +0 -0

b/arch/arm/cpu/arm926ejs/mxs/Makefile index 3d66892..3e9cbdb 100644

arch/arm/cpu/arm926ejs/mxs/Makefile +0 -0
@@ -25,14 +25,15 @@ $(LIB):     $(OBJS)
 
        $(call cmd_link_o_target, $(OBJS))
 
Quoted 8 lines

arch/arm/cpu/arm926ejs/mxs/Makefile $(LIB): $(OBJS) · line 29

Quoted 6 lines
arch/arm/cpu/arm926ejs/mxs/Makefile +2 -2
 # Specify the target for use in elftosb call
 
-ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
-ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
+ELFTOSB_TARGET-$(CONFIG_MX23) = mx23
+ELFTOSB_TARGET-$(CONFIG_MX28) = mx28

Uh?! this seems wrong.

Thank you for NOT explaining what you consider wrong by your comment ;-)

Best regards,
Marek Vasut