powerpc/c29xpcie: add DDR ECC on off config setting
PATCH 1/1 powerpc/c29xpcie: add DDR ECC on off config setting
c29xpcie REV_A board DDR ECC chip has bad impedance in hardware, force that kind of board to be DDR ECC off when booting. Other version board config ECC on/off by hwconfig=fsl_ddr:ecc=on in uboot enviroment.
---
Add this patch after the camelcase patch
http://patchwork.ozlabs.org/patch/271670/ was added.
board/freescale/c29xpcie/ddr.c | 8 ++++++++ include/configs/C29XPCIE.h | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)
board/freescale/c29xpcie/ddr.c +8 -0
@@ -9,6 +9,9 @@#include <asm/fsl_ddr_sdram.h> #include <asm/fsl_ddr_dimm_params.h> +#include "cpld.h" + +#define C29XPCIE_HARDWARE_REVA 0x40/* * Micron MT41J128M16HA-15E * */
@@ -61,7 +64,9 @@ void fsl_ddr_board_options(memctl_options_t *popts, dimm_params_t *pdimm, unsigned int ctrl_num) { +struct cpld_data *cpld_data = (void *)(CONFIG_SYS_CPLD_BASE );int i; + popts->clk_adjust =2 ; popts->cpo_override =0x1f ; popts->write_data_delay =4 ;
@@ -79,6 +84,9 @@ void fsl_ddr_board_options(memctl_options_t *popts, popts->trwt_override =1 ; popts->trwt =0 ; +if (in_8 (&cpld_data->hwver) ==C29XPCIE_HARDWARE_REVA ) + popts->ecc_mode =0 ; +for (i =0 ; i <CONFIG_CHIP_SELECTS_PER_CTRL ; i++) { popts->cs_local_opts[i].odt_rd_cfg =FSL_DDR_ODT_NEVER ; popts->cs_local_opts[i].odt_wr_cfg =FSL_DDR_ODT_CS ;
include/configs/C29XPCIE.h +1 -1
@@ -432,7 +432,7 @@#define CONFIG_BAUDRATE 115200#define CONFIG_EXTRA_ENV_SETTINGS \ - "hwconfig=" __stringify(CONFIG_DEF_HWCONFIG) "\0" \ + "hwconfig=fsl_ddr:ecc=off\0" \ "netdev=eth0\0" \ "uboot=" __stringify(CONFIG_UBOOTPATH) "\0" \ "loadaddr=1000000\0" \
Signature · 2 lines
1.8.0 camelcase patch
PATCH 1/1 powerpc/c29xpcie: add DDR ECC on off config setting
Quoted 4 lines · Po Liu
c29xpcie
REV_Aboard DDR ECC chip has bad impedance in hardware, force that kind of board to be DDR ECC off when booting. Other version board config ECC on/off by hwconfig=fsl_ddr:ecc=on in uboot enviroment.
Why does the Rev A workaround require setting the default ECC to off for other revisions? Why are you removing the use of CONFIG_DEF_HWCONFIG?
-Scott
A message that is not in the archive (sent off-list or not yet received): D473A0D087F4EA47A30C37E4637E25E609DEC5C5@039-SN2MPN1-023.039d.mgd.msft.net
PATCH 1/1 powerpc/c29xpcie: add DDR ECC on off config setting
Quoted 7 lines · On Tue, 2013-09-24 at 22:19 -0500, Liu Po-B43644 wrote:
Hi Wood Scott,
1. Do you mean it is better to set the hwconfig=fsl_ddr:ecc=on as default setting?
2. Do you mean keep theCONFIG_DEF_HWCONFIGdefine as below is better?#define
CONFIG_DEF_HWCONFIGfsl_ddr:ecc=on "hwconfig="__stringify(CONFIG_DEF_HWCONFIG)"\0"
Yes to both. There's no reason to change this just because one board revision can't do ECC (which is handled elsewhere).
-Scott
PATCH v2 1/1 powerpc/c29xpcie: add DDR ECC on off config setting
In reply to Po Liuc29xpcie REV_A board DDR ECC chip has bad impedance in hardware, force that kind of board to be DDR ECC off when booting. Other version board config ECC on/off by hwconfig=fsl_ddr:ecc=on in uboot enviroment.
---
Add this patch after the camelcase patch
http://patchwork.ozlabs.org/patch/271670/ was added. changes for v2:
- Default ecc on by hwconfig=fsl_ddr:ecc=on
- Keep the macro define CONFIG_DEF_HWCONFIG
board/freescale/c29xpcie/ddr.c | 8 ++++++++ include/configs/C29XPCIE.h | 2 ++ 2 files changed, 10 insertions(+)
board/freescale/c29xpcie/ddr.c +8 -0
@@ -9,6 +9,9 @@#include <asm/fsl_ddr_sdram.h> #include <asm/fsl_ddr_dimm_params.h> +#include "cpld.h" + +#define C29XPCIE_HARDWARE_REVA 0x40/* * Micron MT41J128M16HA-15E * */
@@ -61,7 +64,9 @@ void fsl_ddr_board_options(memctl_options_t *popts, dimm_params_t *pdimm, unsigned int ctrl_num) { +struct cpld_data *cpld_data = (void *)(CONFIG_SYS_CPLD_BASE );int i; + popts->clk_adjust =2 ; popts->cpo_override =0x1f ; popts->write_data_delay =4 ;
@@ -79,6 +84,9 @@ void fsl_ddr_board_options(memctl_options_t *popts, popts->trwt_override =1 ; popts->trwt =0 ; +if (in_8 (&cpld_data->hwver) ==C29XPCIE_HARDWARE_REVA ) + popts->ecc_mode =0 ; +for (i =0 ; i <CONFIG_CHIP_SELECTS_PER_CTRL ; i++) { popts->cs_local_opts[i].odt_rd_cfg =FSL_DDR_ODT_NEVER ; popts->cs_local_opts[i].odt_wr_cfg =FSL_DDR_ODT_CS ;
include/configs/C29XPCIE.h +2 -0
@@ -431,6 +431,8 @@#define CONFIG_BAUDRATE 115200 +#define CONFIG_DEF_HWCONFIG fsl_ddr:ecc=on +#define CONFIG_EXTRA_ENV_SETTINGS \ "hwconfig=" __stringify(CONFIG_DEF_HWCONFIG) "\0" \ "netdev=eth0\0" \
Signature · 1 line
1.8.0
York Sun
AppliedPATCH v2 1/1 powerpc/c29xpcie: add DDR ECC on off config setting
Quoted 13 lines · Po Liu
c29xpcie
REV_Aboard DDR ECC chip has bad impedance in hardware, force that kind of board to be DDR ECC off when booting. Other version board config ECC on/off by hwconfig=fsl_ddr:ecc=on in uboot enviroment.Signed-off-by Po Liu <[email protected]>---
Add this patch after the camelcase patch
http://patchwork.ozlabs.org/patch/271670/ was added. changes for v2:
- Default ecc on by hwconfig=fsl_ddr:ecc=on
- Keep the macro defineCONFIG_DEF_HWCONFIG
Quoted 4 lines
board/freescale/c29xpcie/ddr.c | 8 ++++++++ include/configs/C29XPCIE.h | 2 ++ 2 files changed, 10 insertions(+)
Applied to 85xx/next branch. Pending merging to master branch.
York