OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
PATCH 1/1 OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
From: Mark Brown <[email protected]>
The DSI-CM driver uses the backlight class so needs to build depend on it.
--- drivers/video/omap2/displays-new/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/video/omap2/displays-new/Kconfig +1 -0
@@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI config DISPLAY_PANEL_DSI_CM tristate "Generic DSI Command Mode Panel" + depends on BACKLIGHT_CLASS_DEVICE help Driver for generic DSI command mode panels.
Signature · 1 line
1.8.4.rc3
Quoted 6 lines · Mark Brown
From: Mark Brown <[email protected]>
The DSI-CM driver uses the backlight class so needs to build depend on it.
Signed-off-by Mark Brown <[email protected]>
I checked that the following build errors are removed. drivers/video/omap2/displays-new/panel-dsi-cm.c:1257: undefined reference to backlight_device_register' drivers/video/omap2/displays-new/panel-dsi-cm.c:1283: undefined reference to backlight_device_unregister' drivers/built-in.o: In function `dsicm_remove':drivers/video/omap2/displays-new/panel-dsi-cm.c:1309: undefined reference to `backlight_device_unregister'
Thank you.
Best regards,
Jingoo Han
Quoted 18 lines
--- drivers/video/omap2/displays-new/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/video/omap2/displays-new/Kconfig +1
-1@@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI config DISPLAY_PANEL_DSI_CM tristate "Generic DSI Command Mode Panel" + depends on BACKLIGHT_CLASS_DEVICE help Driver for generic DSI command mode panels. --1.8.4.rc3
Quoted 15 lines · Mark Brown
From: Mark Brown <[email protected]>
The DSI-CM driver uses the backlight class so needs to build depend on it.
Signed-off-by Mark Brown <[email protected]>--- drivers/video/omap2/displays-new/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/video/omap2/displays-new/Kconfig +0
-0
drivers/video/omap2/displays-new/Kconfig config DISPLAY_PANEL_DPI · line 41
Quoted 7 lines
drivers/video/omap2/displays-new/Kconfig +1
-0@@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI config DISPLAY_PANEL_DSI_CM tristate "Generic DSI Command Mode Panel" + depends on BACKLIGHT_CLASS_DEVICE help Driver for generic DSI command mode panels.
Thanks, I'll queue for 3.12 fixes.
I wish we could "select" instead of "depends on"...
Tomi
Quoted 1 line · Tomi Valkeinen
I wish we could "select" instead of "depends on"...
We probably could.
Quoted 5 lines · Mark Brown
Quoted 1 line · Tomi Valkeinen
I wish we could "select" instead of "depends on"...
We probably could.
I'm not so sure.
If we select BACKLIGHT_CLASS_DEVICE, we could end up compiling backlight.c without fbdev, and backlight.c uses fb's funcs.
The funny thing is, there is FB_BACKLIGHT, which seems to be designed to be selectable (and is selected). That one depends on FB, but if I'm not mistaken, that dependency does not do anything if FB_BACKLIGHT is selected.
FB_BACKLIGHT in turn selects both BACKLIGHT_LCD_SUPPORT and BACKLIGHT_CLASS_DEVICE, neither of which seem to be designed to be selectable.
I think that's a bit broken. Anyway, I guess it's better to "depend on" here, to be on the safe side.
Tomi