Skip to contentSkip to conversation

lib/oeqa/runtime: ping: wait for 5 echo replies

PATCH New Stefan Stanacar 1 participant 1 message Sep 25, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/oeqa/runtime: ping: wait for 5 echo replies

Instead of considering that ping test passed after 1 reply, wait for at least 5 consecutive replies in 60 seconds (which should be enough time for connman to reconfigure the interface in systemd images and help with the fake ssh/tests fails.)

---
 meta/lib/oeqa/runtime/ping.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
meta/lib/oeqa/runtime/ping.py +7 -4
index e163b96..0d028f9 100644
@@ -8,10 +8,13 @@ class PingTest(oeRuntimeTest):
 
     def test_ping(self):
         output = ''
-        status = None
+        count = 0
         endtime = time.time() + 60
-        while status != 0 and time.time() < endtime:
+        while count < 5 and time.time() < endtime:
             proc = subprocess.Popen("ping -c 1 %s" % oeRuntimeTest.tc.qemu.ip, shell=True, stdout=subprocess.PIPE)
             output += proc.communicate()[0]
-            status = proc.poll()
-        self.assertEqual(status, 0, msg = "No echo reply, ping output is:\n%s" % output)
+            if proc.poll() == 0:
+                count += 1
+            else:
+                count = 0
+        self.assertEqual(count, 5, msg = "Expected 5 consecutive replies, got %d.\nping output is:\n%s" % (count,output))
Signature · 1 line
1.8.3.1