Skip to contentSkip to conversation

oom: avoid selecting threads sharing mm with init

PATCH In review Ming Liu 2 participants 4 messages Sep 26, 2013 – Oct 2, 2013

Subsystems (2)
lore
Share & tools
lore

Ming Liu

author
#0 lore raw

PATCH 1/1 oom: avoid selecting threads sharing mm with init

It won't help free memory for killing tasks sharing mm with init, we should skip them in oom_unkillable_task(), or we may risk init process getting killed because after selecting a task to kill, the oom killer iterates all processes and kills all other user threads that share the same mm_struct in different thread groups.

In some extreme cases, the selected task happens to be a vfork child of init process sharing the same mm_struct with it, which causes kernel panic on init getting killed. This panic is observed in a busybox shell that busybox itself is init, with a kthread keeps consuming memories.

---
 mm/oom_kill.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
mm/oom_kill.c +11 -0
index 314e9d2..7e50a95 100644
@@ -113,11 +113,22 @@ struct task_struct *find_lock_task_mm(struct task_struct *p)
 static bool oom_unkillable_task(struct task_struct *p,
 		const struct mem_cgroup *memcg, const nodemask_t *nodemask)
 {
+	struct task_struct *init_tsk;
+
 	if (is_global_init(p))
 		return true;
 	if (p->flags & PF_KTHREAD)
 		return true;
 
+	/* It won't help free memory if p is sharing mm with init */
+	rcu_read_lock();
+	init_tsk = find_task_by_pid_ns(1, &init_pid_ns);
+	if(p->mm == init_tsk->mm) {
+		rcu_read_unlock();
+		return true;
+	}
+	rcu_read_unlock();
+
 	/* When mem_cgroup_out_of_memory() and p is not member of the group */
 	if (memcg && !task_in_mem_cgroup(p, memcg))
 		return true;
Signature · 7 lines
1.7.0.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#1 lore raw
Quoted 17 lines · Ming Liu
mm/oom_kill.c +4 -0
index 314e9d2..7e50a95 100644
@@ -113,11 +113,22 @@ struct task_struct *find_lock_task_mm(struct task_struct *p)
 static bool oom_unkillable_task(struct task_struct *p,
 		const struct mem_cgroup *memcg, const nodemask_t *nodemask)
 {
+	struct task_struct *init_tsk;
+
 	if (is_global_init(p))
 		return true;
 	if (p->flags & PF_KTHREAD)
 		return true;
 
+	/* It won't help free memory if p is sharing mm with init */
+	rcu_read_lock();

mm/oom_kill.c struct task_struct *find_lock_task_mm(struct task_struct *p) · line 134

Quoted 10 lines
mm/oom_kill.c +7 -0
+	init_tsk = find_task_by_pid_ns(1, &init_pid_ns);
+	if(p->mm == init_tsk->mm) {
+		rcu_read_unlock();
+		return true;
+	}
+	rcu_read_unlock();
+
 	/* When mem_cgroup_out_of_memory() and p is not member of the group */
 	if (memcg && !task_in_mem_cgroup(p, memcg))
 		return true;

You're aware of init_mm?

Can you post the kernel log when one of these "extreme cases" happens?

author
#2 lore raw
Quoted 17 lines · David Rientjes
Quoted 15 lines · Ming Liu
mm/oom_kill.c +2 -0
index 314e9d2..7e50a95 100644
@@ -113,11 +113,22 @@ struct task_struct *find_lock_task_mm(struct task_struct *p)
  static bool oom_unkillable_task(struct task_struct *p,
  		const struct mem_cgroup *memcg, const nodemask_t *nodemask)
  {
+	struct task_struct *init_tsk;
+
  	if (is_global_init(p))
  		return true;
  	if (p->flags & PF_KTHREAD)
  		return true;
 
Quoted 13 lines

mm/oom_kill.c struct task_struct *find_lock_task_mm(struct task_struct *p) · line 134

Quoted 12 lines
mm/oom_kill.c +9 -0
+	/* It won't help free memory if p is sharing mm with init */
+	rcu_read_lock();
+	init_tsk = find_task_by_pid_ns(1, &init_pid_ns);
+	if(p->mm == init_tsk->mm) {
+		rcu_read_unlock();
+		return true;
+	}
+	rcu_read_unlock();
+
  	/* When mem_cgroup_out_of_memory() and p is not member of the group */
  	if (memcg && !task_in_mem_cgroup(p, memcg))
  		return true;

You're aware of init_mm?

I might mislead you, when I talked about init, I meant the pid 1 process but not the idle, and isn't the idle a kthread and has not this risk getting killed by oom? This panic was observed in a busybox shell with a 2.6.27 kernel, MIPS board, but after some investigation, I think the upstream also has the problem, the kernel log is as following:

Out of memory: kill process 938 (crond) score 5 or a child
Killed process 938 (crond)
out_of_memory:tsk_rick info, name:init pid:1 mm:a8000001e0767700 task_struct:a8000001e0110000 //struct task_struct *tsk_rick = find_task_by_vpid(1);
out_of_memory:will close init process pid:1128 mm:a8000001e0767700 task_strct:a8000001f37e2800 Out of memory: kill process 1128 (init) score 4 or a child
oom_kill_process:will close init process pid:1128 mm:a8000001e0767700 task_struct:a8000001f37e2800 oom_kill_task:will close init process pid:1128 mm:a8000001e0767700 task_struct:a8000001f37e2800 Killed process 1128 (init)
do_exit: task_rick name:init , pid:1, mm:a8000001e0767700, &task_stuct:a8000001e0110000
do_exit: will kill process name:init , pid:1128, mm:a8000001e0767700, &task_stuct:a8000001f37e2800
do_exit: task_rick name:init , pid:1, mm:a8000001e0767700, &task_stuct:a8000001e0110000
find_new_reaper: will kill process name:init , pid:1128, mm:0000000000000000, &task_stuct:a8000001f37e2800
do_exit: will kill process name:init , pid:1, mm:a8000001e0767700, &task_stuct:a8000001e0110000

Call Trace:
[<ffffffff8143ab80>] dump_stack+0x8/0x34
[<ffffffff8116a0d4>] do_exit+0x94c/0x978
[<ffffffff8116a14c>] do_group_exit+0x4c/0xd0
[<ffffffff81177804>] get_signal_to_deliver+0x1ec/0x498
[<ffffffff81137088>] do_notify_resume+0x80/0x2b0
[<ffffffff81133184>] work_notifysig+0xc/0x14
find_new_reaper: will kill process name:init , pid:1, mm:0000000000000000, &tsk_stuct:a8000001e0110000
Kernel panic - not syncing: Attempted to kill init!

the best,
thank you

Quoted 9 lines

Can you post the kernel log when one of these "extreme cases" happens? --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#3 lore raw
Quoted 3 lines · Ming Liu

I might mislead you, when I talked about init, I meant the pid 1 process but not the idle, and isn't the idle a kthread and has not this risk getting killed by oom?

You can disqualify for p->mm == &init_mm, but the oom killer has been rewritten since 2.6.27 so please post a log from a recent kernel that exhibits the problem.